Fabien Potencier
6a5356290a
Revert "[HttpKernel] updated tests for shorter bundle names"
...
This reverts commit fb7e87da7d
.
2011-04-04 11:08:37 +02:00
Fabien Potencier
ad4a0bda1c
[Console] changed returned value of CommandTester to the command exit code
2011-04-03 22:30:40 +02:00
Fabien Potencier
53274512e2
Merge remote branch 'weaverryan/better_import_exception_and_bug_fix'
...
* weaverryan/better_import_exception_and_bug_fix:
[Config] Improving the exception when a resource cannot be imported
[DependencyInjection] Fixing a bug where "ignore_errors" doesn't work in YAML and XML
2011-04-02 18:37:51 +02:00
Bernhard Schussek
72a41f8c94
[Form] Fixed: Booleans can be used as choice keys now
2011-04-02 18:26:28 +02:00
Bernhard Schussek
a5d0b3aea6
[Form] Changed FormBuilder::set(Client|Norm)Transformer to FormBuilder::prepend(Client|Norm)Transformer and FormBuilder::append(Client|Norm)Transformer to facilitate extension of types
2011-04-02 16:39:19 +02:00
Bernhard Schussek
fc59936740
[Form] Fixed: ThemeRenderer::isChoiceSelected() works correctly for boolean choices
2011-04-02 16:00:46 +02:00
Bernhard Schussek
a4bbc40ac6
[Form] Cleaned up ChoiceListInterface
2011-04-02 15:41:43 +02:00
Pascal Borreli
8a82aee56f
[Locale][Windows] Fixing tests for old ICU version (default in php.net packages)
2011-04-02 13:19:30 +00:00
Bernhard Schussek
d3b7c4e8c1
[Form] Moved getLabel(), isChoiceSelected() and isChoiceGroup() from ChoiceListInterface to ThemeRenderer
2011-04-02 14:14:18 +02:00
Bernhard Schussek
94f2baa895
[Form] Fixed BooleanToStringTransformer::reverseTransform() to accept NULL values. Fixes ChoiceTypeTest
2011-04-02 13:00:19 +02:00
Bernhard Schussek
37e8e1270c
[Form][FrameworkBundle][TwigBundle] Renamed view variable 'disabled' to 'read_only' to match with the according FormInterface methods
2011-04-02 12:18:43 +02:00
Bernhard Schussek
39b0aafc00
Merge remote branch 'symfony/master' into experimental
...
Conflicts:
src/Symfony/Bundle/DoctrineBundle/Resources/config/orm.xml
2011-04-02 12:08:27 +02:00
Bernhard Schussek
35d9b7f800
[Form] Improved test coverage of Form. The emptyValue closure now receives the Form instance to use form data when constructing new objects
2011-04-02 12:00:19 +02:00
Bernhard Schussek
4f39234741
[Form] bind() is ignored if a form is read-only
2011-04-02 11:39:15 +02:00
Bernhard Schussek
ca20aef379
[Form] Improved test coverage of DelegatingValidator and fixed validation group inheritance
2011-04-02 11:35:58 +02:00
Bernhard Schussek
33b0011f86
[Form] Improved test coverage of Form
2011-04-02 11:22:29 +02:00
Ryan Weaver
65ac5ec7c0
[DependencyInjection] Fixing a bug where "ignore_errors" doesn't work in YAML and XML
...
Tests added, the arguments were simply mismatched.
2011-04-01 18:59:45 -05:00
Fabien Potencier
1a486492b8
[HttpKernel] fixed test
2011-04-01 18:07:22 +02:00
Kris Wallsmith
c51b716180
[Config] simplified DirectoryResource to only allow one regex
2011-04-01 04:56:50 -07:00
Fabien Potencier
a9160eee70
[Validator] made fields the default option for Collection constraint
2011-03-31 15:36:04 +02:00
Bernhard Schussek
c864d7fae1
[Form] Improved test coverage of Form class
2011-03-31 15:23:33 +02:00
Bernhard Schussek
1ef18360fa
[Form] Made name immutable in FormBuilder to avoid synchronization problems with name and property path
2011-03-31 13:48:06 +02:00
Bernhard Schussek
bbeddf7789
Merge remote branch 'symfony/master' into experimental
2011-03-31 12:32:20 +02:00
Fabien Potencier
59ef0c991c
[Form] fixed two unit tests
2011-03-31 07:36:52 +02:00
Fabien Potencier
c7ccb6643b
[Form] removed unused constructor argument from Type\FieldType (themeFactory and template)
2011-03-31 07:34:04 +02:00
Jeremy Mikola
e295bfc7a5
[Config] Alias used classes in NodeBuilderTest to avoid conflicts with fixture classes required in TreeBuilderTest
...
Depending on the order of execution of Config\Definition\Builder tests (due to filesystem ordering), namespace conflicts can occur between real classes and fixtures loaded by the TreeBuilderTest.
2011-03-30 19:52:00 -04:00
Fabien Potencier
f92055ce42
[Validator] renamed methods that do not follow CS
...
requiredOptions -> getRequiredOptions
targets -> getTargets
defaultOption -> getDefaultOption
2011-03-30 23:18:20 +02:00
Fabien Potencier
525702b5c6
[Validator] renamed method to follow CS
2011-03-30 23:10:30 +02:00
Fabien Potencier
f77b94074f
[HttpFoundation] replaced the option argument of Session by defaultLocale
2011-03-30 17:26:13 +02:00
Bernhard Schussek
55c14680d3
Merge remote branch 'symfony/master' into experimental
2011-03-30 10:31:21 +02:00
Pascal Borreli
33d887e154
[Finder][Windows] Fixed windows tests
2011-03-29 14:32:18 +00:00
Pascal Borreli
0199b5c70d
[HttpFoundation][Windows] Fixed guesser tests if Fileinfo extension is not loaded
...
Didn't test for presence of mime_content_type function since it's obsolete (deprecated) in PHP5
2011-03-29 14:32:17 +00:00
Bernhard Schussek
53838abf3f
Merge remote branch 'symfony/master' into experimental
...
Conflicts:
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/money_field.html.php
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/percent_field.html.php
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-28 22:52:15 +02:00
Kris Wallsmith
fb7e87da7d
[HttpKernel] updated tests for shorter bundle names
2011-03-28 11:37:19 -07:00
Fabien Potencier
49063a5314
Merge remote branch 'kriswallsmith/kernel/shorter-bundle-names'
...
* kriswallsmith/kernel/shorter-bundle-names:
updated codebase to use shorter bundle names
[HttpKernel] updated component to work with shorter bundle names
[HttpKernel] updated Bundle::getName() to validate bundle class name and rtrim "Bundle"
2011-03-28 18:06:41 +02:00
Fabien Potencier
786f165dae
Merge remote branch 'bschussek/validator'
...
* bschussek/validator:
removed Assert prefix from all constraints, renamed annotation namespace to assert
2011-03-28 17:05:22 +02:00
Fabien Potencier
faf9782e6f
renamed Twig TransExtension to TranslationExtension
2011-03-28 16:16:54 +02:00
Bernhard Schussek
1fa004ceb2
[Form] Simplified the interface names of the Renderer subnamespace
2011-03-27 23:39:01 +02:00
Bernhard Schussek
cfaa03eeec
[Form] Fixed: empty objects are only created upon binding forms with empty data
2011-03-27 23:07:30 +02:00
Bernhard Schussek
edfae73cd4
[Form] Moved PropertyPath, PropertyPathIterator and VirtualFormAwareIterator to subnamespace Util
2011-03-27 15:37:13 +02:00
Kris Wallsmith
ade83e2e80
updated codebase to use shorter bundle names
...
Controllers:
"BlogBundle:Post:show" is now "Blog:Post:show"
Templates:
"BlogBundle:Post:show.html.twig" is now "Blog:Post:show.html.twig"
Resources:
"@BlogBundle/Resources/config/blog.xml" is now "@Blog/Resources/config/blog.xml"
Doctrine:
"$em->find('BlogBundle:Post', $id)" is now "$em->find('Blog:Post', $id)"
2011-03-27 06:25:43 -07:00
Bernhard Schussek
b180319371
[Form] Moved creation of empty data to Form to clean up DataMapperInterface
2011-03-27 15:12:35 +02:00
Bernhard Schussek
6588a47ba7
[Form] Removed FormBuilder::setDataClass(). Use the FieldType option "data_class" instead.
...
The problem was that "data_class" was used in two places: FormBuilder::build() and PropertyPathMapper.
PropertyPathMapper was already constructed during FormType::buildForm(), so any data class changes made to the FormBuilder wouldn't affect the data class of the PropertyPathMapper anymore and so lead to an inconsistent state.
2011-03-27 14:34:48 +02:00
Kris Wallsmith
dd9ad97a0c
[HttpKernel] updated Bundle::getName() to validate bundle class name and rtrim "Bundle"
2011-03-27 05:31:57 -07:00
Bernhard Schussek
364b0f5208
[Form] Fixed: FormBuilder::add() accepts FormTypeInterface instances
2011-03-27 14:05:06 +02:00
Bernhard Schussek
dc38eeffe3
[Form] Changed the default value of the 'property_path' option to NULL. Explicitely set it to '' or false to disable mapping for a field/form
2011-03-27 14:02:24 +02:00
Bernhard Schussek
b21929423e
[Form] Completely removed the fields variable in the renderer. The renderer itself supports ArrayAccess and Traversable
2011-03-27 13:48:36 +02:00
Bernhard Schussek
eaff9c641e
[Form] Fixed: the default template is only set on the root renderer and reused by children
2011-03-26 19:39:31 +01:00
Bernhard Schussek
a58cfab37d
[Form] Removed form.type.loader tag and according compiler pass to simplify configuration. Custom types that are not in the DIC can be instantiated manually and passed wherever a type is desired.
2011-03-26 18:48:55 +01:00
Bernhard Schussek
9ff91dc997
Merge remote branch 'beberlei/FormsCollectionPrototype' into beberlei-merge
2011-03-26 18:39:20 +01:00
Bernhard Schussek
fae319e77a
[Form] Renderers are now created explicitely using FormFactory::createRenderer(). This improves performance on requests where a form does not need to be rendered
2011-03-26 16:03:34 +01:00
Bernhard Schussek
8c7a93c90c
[Form] Added FormTypeInterface::buildRendererBottomUp() which is called after children are initialized
2011-03-26 16:03:34 +01:00
Bernhard Schussek
c786fac303
[Form] Sample fix implementation of renderers
2011-03-26 16:03:34 +01:00
Bernhard Schussek
a396f8fdc8
Merge remote branch 'symfony/master' into experimental
2011-03-26 16:03:21 +01:00
Johannes M. Schmitt
7887f04dc2
removed Assert prefix from all constraints, renamed annotation namespace to assert
2011-03-26 15:26:05 +01:00
Benjamin Eberlei
d87651b6a2
[Form] Add option "prototype" defaulting to true.
2011-03-26 14:52:03 +01:00
Benjamin Eberlei
f882a511a0
[Form] Initialize on iterator access.
2011-03-26 12:28:46 +01:00
Benjamin Eberlei
cd1ce86aee
[Form] Iterator support for ThemeRenderer
2011-03-26 12:25:47 +01:00
Fabien Potencier
4594cd223b
[HttpKernel] fixed a test that randomly fails
2011-03-26 12:07:57 +01:00
Johannes Schmitt
db2089de0d
Merge branch 'acl-fix' of https://github.com/comfortablynumb/symfony into security
2011-03-26 01:11:11 +01:00
Bernhard Schussek
18b98353d5
Merge branch 'master' into experimental
...
Conflicts:
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 16:07:19 +01:00
Fabien Potencier
8d84fdfedc
[Finder] added Finder::append() method to be able to combine several Finder instances into one
2011-03-25 15:50:47 +01:00
Bernhard Schussek
7585dce8dd
[Form] Added options validation to field creation
2011-03-25 15:30:33 +01:00
Bernhard Schussek
6825ea2489
[Form] Improved test coverage of PropertyPathMapper
2011-03-25 11:27:20 +01:00
Bernhard Schussek
e3ac248617
[Form] Errors are mapped to subforms correctly and bubble up again if necessary
2011-03-25 10:53:36 +01:00
Bernhard Schussek
7b412cc762
[Form] Removed FormFactory::addGuessers() and moved guessers to constructor arg instead
2011-03-25 02:26:14 +01:00
Bernhard Schussek
9b1b8cbffa
[Form] Replaced various occurences of 'field' by 'form'
2011-03-25 02:12:01 +01:00
Bernhard Schussek
3c412ffba0
[Form] Moved Form::validateData() to DelegatingValidator::validateFormData()
2011-03-25 01:59:28 +01:00
Gustavo Adrian
bedbe51081
[Security] ACL: AclVoter::vote only gets an ObjectIdentity if $object is not an instance of ObjectIdentityInterface
2011-03-24 21:54:21 -03:00
Bernhard Schussek
729438fdea
Merge branch 'rename-execute' into experimental
...
Conflicts:
src/Symfony/Component/Form/FileField.php
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 01:38:49 +01:00
Bernhard Schussek
3e29348d21
[Validator] Added support for static callbacks to Callback constraint
2011-03-25 01:36:58 +01:00
Bernhard Schussek
9c6a6e13bf
[Validator] Renamed Execute constraint to Callback
2011-03-25 01:34:35 +01:00
Bernhard Schussek
770d403a52
[Form] Improved error mapping in DelegatingValidator
2011-03-25 00:57:35 +01:00
Bernhard Schussek
4372bd5dc8
[Form] Fixed: Bubbling errors are caught correctly
2011-03-25 00:18:58 +01:00
Bernhard Schussek
262bdcb21d
[Form] Fixed validation
2011-03-25 00:16:21 +01:00
Bernhard Schussek
ef334dbc4a
Merge remote branch 'beberlei/AttributeSupport' into beberlei-merge
2011-03-24 22:53:39 +01:00
Bernhard Schussek
3f390aa271
[Form] Removed EntityType from DefaultTypeLoader
2011-03-24 22:50:39 +01:00
Benjamin Eberlei
ee96ad0e81
[Form] [DoctrineBridge] Move EntityType and DoctrineTypeLoader into Doctrine Bridge
2011-03-24 22:43:00 +01:00
Benjamin Eberlei
8d6dd2b9af
[Form] Add Arbitrary Attribute Support to Form Rendering.
2011-03-24 22:08:08 +01:00
Benjamin Eberlei
6bcc04905c
[Form] Introduce ArrayTypeLoader, Remove EntityManager and FormFactory interface from DefaultTypeLoader
2011-03-24 20:00:17 +01:00
Bernhard Schussek
2faa47d03b
[Form] Added fallback templates to TwigThemeFactory
2011-03-24 15:11:43 +01:00
Bernhard Schussek
1211d77f49
[Form] Introduced renderer theme factories so that themes can be changed during runtime
2011-03-24 14:27:21 +01:00
Fabien Potencier
8cb400a5d8
[Console] fixed a test
2011-03-24 14:03:56 +01:00
Bernhard Schussek
5b41810b6d
Revert "[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'"
...
This reverts commit 1efd680b68
.
2011-03-24 10:55:12 +01:00
Bernhard Schussek
5078a63c74
Revert "[Form] Fixed more naming of themes and theme engines"
...
This reverts commit 1aa34b7240
.
2011-03-24 10:54:47 +01:00
Fabien Potencier
f5ab021386
Merge remote branch 'aurelijus/clear_name_for_goto'
...
* aurelijus/clear_name_for_goto:
removes unwanted characters from goto name
2011-03-24 10:00:31 +01:00
Fabien Potencier
ff3c66753f
[BrowserKit] tagged the guaranteed BC API
2011-03-24 09:25:46 +01:00
Aurelijus
38318f8f80
removes unwanted characters from goto name
2011-03-24 10:03:59 +02:00
Bernhard Schussek
1aa34b7240
[Form] Fixed more naming of themes and theme engines
2011-03-23 22:51:37 +01:00
Bernhard Schussek
1efd680b68
[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'
2011-03-23 22:34:58 +01:00
Fabien Potencier
06d00f36ba
Merge remote branch 'kriswallsmith/framework/protocol-relative-base-urls'
...
* kriswallsmith/framework/protocol-relative-base-urls:
[Templating] updated assets helper to leave protocol-relative URLs untouched
[FrameworkBundle] cleaned up test class
2011-03-23 22:03:48 +01:00
Fabien Potencier
a6e6cbbb27
[HttpFoundation] removed the hardcoded ^ and $ from the RequestMatcher
2011-03-23 21:27:04 +01:00
Bernhard Schussek
c01419d856
Merge remote branch 'johnwards/renderer_tests' into renderer-tests-merge
2011-03-23 21:13:36 +01:00
Kris Wallsmith
55671be888
[Templating] updated assets helper to leave protocol-relative URLs untouched
2011-03-23 13:02:49 -07:00
Fabien Potencier
76cf89b800
[Finder] fixed some tests that were failing on the CI server
2011-03-23 20:58:14 +01:00
Fabien Potencier
cb62fde8c9
[Serializer] fixed some tests that were failing on the CI server
2011-03-23 20:27:58 +01:00
Fabien Potencier
b5857528e0
[Routing] moved protected to private
2011-03-23 19:25:56 +01:00
Bernhard Schussek
9839aafb7d
Merge remote branch 'symfony/master' into experimental
2011-03-23 19:18:38 +01:00
Bernhard Schussek
08a09240f6
[Form] Fixed order of input and output timezone to a more natural one
2011-03-23 17:12:04 +01:00
Bernhard Schussek
a880f8d0d1
[Form] Fixed coding conventions
2011-03-23 16:14:53 +01:00