* 4.4:
Update .github/workflows/tests.yml
Don't call class_exists() on null
Added and improved Bulgarian translations
PHP 8.1 must not cause the build to fail (yet)
Add _run_tests bash function
Add a GitHub Action for tests against PHP 8.1
[HttpClient] fix adding query string to relative URLs with scoped clients
[Security] Added Ukrainian translations
This PR was merged into the 4.4 branch.
Discussion
----------
Add a GitHub Action for tests against PHP 8.1
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
I'd like to monitor our compatibility with the upcoming PHP 8.1 release. Because I failed miserably at convincing Travis to run our tests with PHP 8.1 (see #40532), I tried to do the same with GitHub Actions.
Commits
-------
6a328ae01e Update .github/workflows/tests.yml
6f1c4b8c58 PHP 8.1 must not cause the build to fail (yet)
b0b45105d7 Add _run_tests bash function
de4f0170e2 Add a GitHub Action for tests against PHP 8.1
This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection][ProxyManagerBridge] Don't call class_exists() on null
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
PHP 8.1 complains if we pass `null` to `class_exists()` or `interface_exists()`:
> class_exists(): Passing null to parameter `#1` ($class) of type string is deprecated
Commits
-------
88520e53b2 Don't call class_exists() on null
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Added Ukrainian translations
| Q | A
| ------------- | ---
| Branch? | 4.4 <!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#41088 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | <!-- required for new features -->
Added some missing Ukrainian translations.
Commits
-------
8f34572a65 [Security] Added Ukrainian translations
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Added and improved Bulgarian translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? |no
| Tickets | Fix#41035
| License | MIT
| Doc PR | n/a
Added missing translations for id 19 and 20.
Replaced the word "incorrect" with "unsuccessful"/"failed" for id 17.
Replaced the phonetic use of "cookie" with the word for "cookie" in Bulgarian for id 5 and 10.
Fixed grammatical error, now use the definite article ("the") instead of the indefinine for id 11, 13, 15 and 16.
Commits
-------
b79962b676 Added and improved Bulgarian translations
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
Introduce SYMFONY_FEATURE_BRANCH variable in Travis config
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | #40887
| License | MIT
| Doc PR | not needed
This PR proposes to introduce a `SYMFONY_FEATURE_BRANCH` variable that always points to the branch of Symfony's next feature release. This is a setting that we need to adjust twice a year. This way, the branch does not have to follow the `.x` suffix convention anymore.
~~I'm currently testing my changes against the 5.x branch. As soon as the PR is ready, I will target 4.4.~~
Update: `SYMFONY_FEATURE_BRANCH` is now populated via an API request.
Commits
-------
7de11c0e44 Introduce SYMFONY_FEATURE_BRANCH variable in Travis config
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Missing lt translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41054
| License | MIT
For minute/minutes translation I decided to use "min." abbreviation, because in lithuanian language the plural translation might not always match the word case.
For example:
1 minute -> 1 minutė
2 minutes -> 2 minutės
...
10 minutes -> 10 minučių
...
21 minutes -> 21 minutė
22 minutes -> 22 minutės
...
30 minutes -> 30 minučių
and so on...
Commits
-------
f2dedd8a53 Missing security lt translations added
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] Add missing charset to content-type for Slack notifier
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Symfony HttpClient doesn't set charset for the Content-Type header when used with `json` request option so with each response slack includes:
```
"response_metadata" => array:1 [
"warnings" => array:1 [
0 => "missing_charset"
]
]
```
Commits
-------
e642100ea5 Add missing charset to content-type for Slack notifier
* 4.4:
[Console] Fix Windows code page support
[CI][Psalm] Install stable/released PHPUnit
Bump Symfony version to 4.4.24
Update VERSION for 4.4.23
Update CONTRIBUTORS for 4.4.23
Update CHANGELOG for 4.4.23
This PR was merged into the 4.4 branch.
Discussion
----------
[Console] Fix Windows code page support
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#37385, Fix#35842, Fix#36324, Fix#37495, Fix#37278
| License | MIT
Corrects mojibake problem on Windows where an OEM code page was applied to an input string and then messed with PHP.internal_encoding setting used by the script. This caused strings with different encodings to be displayed on the console output.
Commits
-------
41452785c6 [Console] Fix Windows code page support
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[CI][Psalm] Install stable/released PHPUnit
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
PHPUnit 10 is soon released. We dont need to install it before it is actually released.
Currently, PHPUnit is updating dependencies and we get psalm failing with things like:
<img width="918" alt="Screenshot 2021-05-12 at 08 28 29" src="https://user-images.githubusercontent.com/1275206/117930440-468cc500-b2fe-11eb-8028-579478c001cf.png">
<img width="972" alt="Screenshot 2021-05-12 at 08 33 54" src="https://user-images.githubusercontent.com/1275206/117930443-47bdf200-b2fe-11eb-8cb7-79255532e899.png">
Commits
-------
2345614316 [CI][Psalm] Install stable/released PHPUnit
This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] fix dumping service-closure-arguments
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#39259
| License | MIT
| Doc PR | -
5.3 uses service closures a bit more, so that this is required to make the `lint:container` command work.
Commits
-------
1aa9a249fc [DependencyInjection] fix dumping service-closure-arguments
Alexander M. Turek
Nyholm
Jérémy Derussé
Nicolas Grekas
Ivo Valchev
Andrii Bodnar
Tomas
Marek Zajac
Fabien Potencier
Mikko Ala-Fossi
