This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17264).
Discussion
----------
Fix typo in Locale class annotations
Commits
-------
eab7e11 typo
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17183).
Discussion
----------
[FrameworkBundle] Set the kernel.name properly after a cache warmup
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16180
| License | MIT
| Doc PR | -
Commits
-------
1438b9a [FrameworkBundle] Set the kernel.name properly after a cache warmup
This PR was squashed before being merged into the 3.1-dev branch (closes#17191).
Discussion
----------
[Serializer] Move the normalization logic in an abstract class
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
As suggested by @xabbuh, move all the normalization logic for objects in an abstract class.
It will ease the maintenance as well as adding new features such as #17113 and #16143.
I've introduced a new abstract class to avoid BC breaks in `AbstractNormalizer`. As a (good) side effect, all normalizers now benefits from the caching system introduced in #16547.
Commits
-------
3bec813 [Serializer] Move the normalization logic in an abstract class
This PR was merged into the 2.8 branch.
Discussion
----------
[Yaml] cast arrays to objects after parsing has finished
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17190
| License | MIT
| Doc PR |
Casting arrays to objects must happen after the complete YAML string has
been parsed to avoid errors when parsing subsequent lines.
Commits
-------
8251d67 cast arrays to objects after parsing has finished
This PR was merged into the 2.8 branch.
Discussion
----------
Fix toolbar display when nvd3 is loaded on page
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | not applicable
Minor CSS fix for the toolbar, as nvd3 sets `svg { display: block }` so you end up with something like:
![image](https://cloud.githubusercontent.com/assets/183678/12079564/974aa694-b235-11e5-897e-ecb31ba20f26.png)
Commits
-------
d7010c0 Fix toolbar display when nvd3 is loaded on page
This PR was merged into the 2.8 branch.
Discussion
----------
[WebProfilerBundle] Remove duplicated HTML attributes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
7335dee [WebProfilerBundle] Removed duplicated HTML attributes
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17248).
Discussion
----------
[Form] fixed DateTimeType tests using "date_widget"="choice".
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | no
| License | MIT
| Doc PR | no
As said in the [documentation](http://symfony.com/doc/current/reference/forms/types/datetime.html#years), the default years available in the ``DateType`` go from five year before to five year after the current year. So now that it's 2016 all around, the tests which use the ``"date_widget"="choice"`` without defining a ``"years"`` option and tries to submit a date in 2010 are failing because 2010 is not in the default choice list.
This PR fixes the issue by setting the ``"years"`` option to ``"2010"`` for each test that need it. It also remove unnecessary (and confusing) dummy data from some tests which were suffering the same issue but silently.
Edit : The PHP 5.6 build on travis seems to fetch and run some old version of the tests. So it still fail on this build but not on the others anymore.
Commits
-------
be20e89 Fix Form's DateTimeType tests.
This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] recognize when a block scalar is left
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17116
| License | MIT
| Doc PR |
The parser did not recognize when the block scalar was completely parsed
and thus treated following comments as they need to be kept leading to
parse errors on the following lines.
Commits
-------
3a22165 [Yaml] recognize when a block scalar is left
The parser did not recognize when the block scalar was completely parsed
and thus treated following comments as they need to be kept leading to
parse errors on the following lines.
This PR was merged into the 2.3 branch.
Discussion
----------
Update copyright year
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
Happy new year! 🎉
Commits
-------
ce067e6 Update copyright year
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Clean tested process on tear down
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
As show on this failing test (https://travis-ci.org/symfony/symfony/jobs/99569782#L2690) and confirmed locally, some tested process objects remain in memory until the global destructor shutdown stage.
This PR forces processes to be cleaned right after their test case.
Commits
-------
80e1107 [Process] Clean tested process on tear down
* 2.8:
[travis] Use xargs instead of parallel to test --enable-sigchild
bug #14246 [Filesystem] dumpFile() non atomic
[Bridge/Doctrine] Fix test case
Conflicts:
src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php
src/Symfony/Component/Filesystem/Filesystem.php