This PR was merged into the 2.3 branch.
Discussion
----------
n/a
n/a
Commits
-------
f38536a [WebProfiler] replaced the import/export feature from the web interface to a CLI tool
This PR was merged into the 2.3 branch.
Discussion
----------
n/a
n/a
Commits
-------
9e1bc22 Add tests and more assertions
101a3b7 [FrameworkBundle][Translator] Validate locales.
This PR was merged into the 2.3 branch.
Discussion
----------
n/a
n/a
Commits
-------
3b4046e [HttpFoundation] added some missing tests
cefe237 fix parsing of Authorization header
This PR was merged into the 2.3 branch.
Discussion
----------
n/a
n/a
Commits
-------
1ee96a8 Test examples from Drupal SA-CORE-2014-003
5506ee8 Fix potential DoS when parsing HOST
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11825).
Discussion
----------
fixing yaml indentation
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
3bba329 fixing yaml indentation
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11812).
Discussion
----------
[HttpFoundation] Improve string values in test codes
I made the meanings of string literals more clear.
| Q | A
| ------------- | ---
| Bug fix? | no,
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
05f5860 [HttpFoundation] Improve string values in test codes
This PR was merged into the 2.3 branch.
Discussion
----------
[Security] fixing typo in a comment
| Q | A
| ------------- | ---
| Fixed tickets |
| License | MIT
As reported [here](https://github.com/symfony/symfony/pull/11574/files#r16934052).
Commits
-------
faefd66 fixing typo in a comment
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11811).
Discussion
----------
[HttpFoundation] fix comment: not fourth but sixth argument
$server is the **sixth** argument, not fourth.
| Q | A
| ------------- | ---
| Bug fix? | no,
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
42841e8 fix comment: not fourth but sixth argument
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10197).
Discussion
----------
[FrameworkBundle] PhpExtractor bugfix and improvements
PhpExtractor currently only handles simple strings which match an overly-specific token sequence.
This change adds support for
- heredoc / nowdoc
- inconsistent whitespace when parsing
- escaped sequences in strings
- `transChoice`
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
a8a40fc [FrameworkBundle] PhpExtractor bugfix and improvements
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11635).
Discussion
----------
[Finder] Fix findertest readability
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | part of #11631, #11588
| License | MIT
When running on Ubuntu it is hard to setup an account that allows the `chmod` to downgrade the rights on a directory but is not allow to read from the downgraded directory.
Commits
-------
8a47b62 [Finder] Fix findertest readability
This PR was merged into the 2.3 branch.
Discussion
----------
[Security] Made optimization on constant-time algorithm removing modulus operator
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This fix improves the constant-time algorithm used to compare strings, as it removes the `%` operator inside the loop.
Commits
-------
000bd0d Made optimization deprecating modulus operator
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11772).
Discussion
----------
[Filesystem] Add FTP stream wrapper context option to enable overwrite
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Without this change it's not possible to override a file on FTP by calling Filesystem::copy($originFile, $targetFile, true) as PHP/FTP server responds with error like:
fopen(ftp://...@ftp/file.txt): failed to open stream: Remote file already exists and overwrite context option not specified FTP server reports 213 166440 []
TODO: Write an integration tests? How? Use some real FTP server?
Commits
-------
c056a9c [Filesystem] Add FTP stream wrapper context option to enable overwrite (override)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11802).
Discussion
----------
[HttpKernel] add use statement for phpdoc
| Q | A
| ------------- | ---
| Fixed tickets | https://github.com/symfony/symfony/issues/11801
| License | MIT
Added use statement for the Phpdoc
Commits
-------
0010fba [HttpKernel] add use statement for phpdoc
When a line contains only a dash it cannot safely be assumed that
it contains a nested list or an embedded mapping. If the next line
starts with a dash at the same indentation, the current line's item
is to be treated as `null`.
This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] fixed mapping keys containing a quoted #
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11700, #11723
| License | MIT
| Doc PR | n/a
Commits
-------
110f999 [Yaml] fixed mapping keys containing a quoted #
8ba3b28 Added fixture to test parsing of hash keys ending with a space and #
This PR was merged into the 2.3 branch.
Discussion
----------
Disabled the PHPUnit self-update on Travis
The 4.2.2 release available on Travis currently ships with a broken self-update command. Given that it is new enough to contain the fixes for the other bugs affecting the build, it is fine to keep using the available phar without updating it.
This avoids making all builds except 5.3.3 fail before running tests.
FYI, the bug itself is already fixed in PHPUnit so 4.2.3 will have a working command.
Commits
-------
0fca352 Disabled the PHPUnit self-update on Travis
The 4.2.2 release available on Travis currently ships with a broken
self-update command. Given that it is new enough to contain the fixes for
the other bugs affecting the build, it is fine to keep using the available
phar without updating it.
This PR was merged into the 2.3 branch.
Discussion
----------
[DoctrineBridge] Abstract Doctrine Subscribers with tags
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | this one
| License | MIT
| Doc PR | N/A
I've hit a problem with some doctrine listeners, built by decorating an abstract definition.
I want the abstract definition to hold the tag, however because the RegisterEventListenersAndSubscribersPass runs before abstract definitions are removed, they get added as method calls to the EventManager definition, which once the abstract service is removed, we end up with a method call that breaks the container.
I don't know if this is the best approach, it might be better not to return abstract services when calling `findTaggedServiceIds` instead?
Commits
-------
cbcf513 Disallow abstract definitions from doctrine event listener registration
This PR was squashed before being merged into the 2.3 branch (closes#11768).
Discussion
----------
[ClassLoader] Add a __call() method to XcacheClassLoader
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11733
| License | MIT
| Doc PR |
Commits
-------
dd0d6af [ClassLoader] Add a __call() method to XcacheClassLoader
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] fix some minor typos in tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
24d2c9a fix some minor typos in tests
This PR was merged into the 2.3 branch.
Discussion
----------
[YAML] resolve variables in inlined YAML
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11665
| License | MIT
| Doc PR |
#11569 does not resolve variables in inline YAML.
Commits
-------
45a5863 [YAML] resolve variables in inlined YAML
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11639).
Discussion
----------
[DependencyInjection] Fixed factory service not within the ServiceReferenceGraph.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Fixed a problem where Factory services are not added to the ServiceReferenceGraph.
Commits
-------
e992f8e Fixed Factory services not within the ServiceReferenceGraph.
Fabien Potencier
Luis Cordova
Christophe Coevoet
Jérémy Derussé
Abdellatif Ait boudad
DQNEO
Christian Flothmann
Michael Tibben
1emming
Damian Sromek
Miliooo
Tobias Stöckler
Harm van Tilborg
Ka
Warnar Boekkooi