Commit Graph

14063 Commits

Author SHA1 Message Date
Fabien Potencier
604aaa2e1e merged branch fabpot/twig-url-escaping (PR #7850)
This PR was merged into the master branch.

Discussion
----------

[2.3] [TwigBridge] save auto-escaping of generated URLs when possible

| Q             | A
| ------------- | ---
| Bug fix?      | [no]
| New feature?  | [yes: optimization]
| BC breaks?    | [no]
| Deprecations? | [no]
| Tests pass?   | [yes]
| Fixed tickets | #7088
| License       | MIT
| Doc PR        | [-]

Determines at compile time whether the generated URL will be safe and thus
saving the unneeded automatic escaping for performance reasons.

The URL generation process percent encodes non-alphanumeric characters. So there is no risk
that malicious/invalid characters are part of the URL. The only character within an URL that
must be escaped in html is the ampersand ("&") which separates query params. So we cannot mark
the URL generation as always safe, but only when we are sure there won't be multiple query
params. This is the case when there are none or only one constant parameter given.
E.g. we know beforehand this will be safe:
- path('route')
- path('route', {'param': 'value'})

But the following may not:
- path('route', var)
- path('route', {'param': ['val1', 'val2'] }) // a sub-array
- path('route', {'param1': 'value1', 'param2': 'value2'})

If param1 and param2 reference placeholder in the route, it would still be safe. But we don't know.

Commits
-------

725568b [TwigBridge] added some unit test for the previous commit
0721ff8 save auto-escaping of generated URLs when possible for performance reasons
2013-04-25 18:30:34 +02:00
Fabien Potencier
ccc52a4e4b merged branch fabpot/bcrypt (PR #7853)
This PR was merged into the master branch.

Discussion
----------

[Security] Outsource all the BCrypt heavy lifting to a library

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

The [BCrypt bundle](https://github.com/elnur/ElnurBlowfishPasswordEncoderBundle) is already using the library.

This is a working implementation of #7247

Commits
-------

c83546d [Security] tweaked previous commit
b2e553a Outsource all the BCrypt heavy lifting to a library
2013-04-25 18:23:35 +02:00
Fabien Potencier
725568b66d [TwigBridge] added some unit test for the previous commit 2013-04-25 18:21:39 +02:00
Fabien Potencier
c83546d268 [Security] tweaked previous commit 2013-04-25 17:52:07 +02:00
Fabien Potencier
0b0872784c merged branch jakzal/patch-1 (PR #7851)
This PR was merged into the master branch.

Discussion
----------

Fixed typo

Commits
-------

0600d83 Fixed typo
2013-04-25 17:50:33 +02:00
Jakub Zalas
0600d833ac Fixed typo 2013-04-25 17:43:02 +02:00
Elnur Abdurrakhimov
b2e553ae1d Outsource all the BCrypt heavy lifting to a library 2013-04-25 17:38:27 +02:00
Tobias Schultze
0721ff8843 save auto-escaping of generated URLs when possible for performance reasons 2013-04-25 17:00:48 +02:00
Fabien Potencier
1099858678 merged branch bschussek/issue1341 (PR #7849)
This PR was merged into the master branch.

Discussion
----------

[Form] Added support for PATCH requests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #1341
| License       | MIT
| Doc PR        | not needed

Commits
-------

eabb7a1 [Form] Added support for PATCH requests
2013-04-25 16:47:21 +02:00
Fabien Potencier
5d12b2bf5d merged branch fabpot/dispatcher-compiler-pass (PR #7848)
This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle] make RegisterKernelListenersPass reusable

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6643
| License       | MIT
| Doc PR        | n/a

see #6643

Commits
-------

5047227 moved the kernel listener compiler pass to HttpKernel to make it reusable (refs #6643)
45f1a16 make RegisterKernelListenersPass reusable
2013-04-25 16:17:16 +02:00
Bernhard Schussek
eabb7a17ed [Form] Added support for PATCH requests 2013-04-25 16:09:14 +02:00
Fabien Potencier
5047227489 moved the kernel listener compiler pass to HttpKernel to make it reusable (refs #6643) 2013-04-25 16:01:08 +02:00
alexandresalome
45f1a16b93 make RegisterKernelListenersPass reusable 2013-04-25 15:40:01 +02:00
Fabien Potencier
e9b6c7c2a4 merged branch Seldaek/windows-tests (PR #7847)
This PR was merged into the master branch.

Discussion
----------

Windows test fixes

I checked all components/bundles/bridges.. Now everything is green except a few things still in Process that I wasn't sure what to do with yet.

Commits
-------

ae1624f [Process] Fix tests on windows
08e95db [Finder] Fix tests on windows
e8b07a0 [Filesystem] Fix tests on windows
7b83b72 [Console] Fix tests on windows
2013-04-25 15:33:44 +02:00
Fabien Potencier
1362b388df merged branch fabpot/json-response (PR #7846)
This PR was merged into the master branch.

Discussion
----------

[HttpFoundation] added a note about JSON responses as arrays (refs #6970)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6970
| License       | MIT
| Doc PR        | symfony/symfony-docs#2555

Commits
-------

abb32a1 [HttpFoundation] added a note about JSON responses as arrays (refs #6970)
2013-04-25 15:24:03 +02:00
Jordi Boggiano
ae1624fe02 [Process] Fix tests on windows 2013-04-25 15:23:11 +02:00
Fabien Potencier
e04ed3b9c2 merged branch fabpot/create-controller-names (PR #7843)
This PR was merged into the master branch.

Discussion
----------

Add a way to create a short controller name (a🅱️c) from a fully qualify one (controller::action)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #5865
| License       | MIT
| Doc PR        | n/a

Working implementation of #5865

Commits
-------

0795ea8 [FrameworkBundle] fixed implementation of previous merge (refs #5865)
91ebba4 new method to create shorthand name from full Controller name
2013-04-25 14:59:40 +02:00
Fabien Potencier
abb32a188e [HttpFoundation] added a note about JSON responses as arrays (refs #6970) 2013-04-25 14:33:17 +02:00
Jordi Boggiano
08e95dbbf4 [Finder] Fix tests on windows 2013-04-25 14:12:10 +02:00
Jordi Boggiano
e8b07a0787 [Filesystem] Fix tests on windows 2013-04-25 14:07:50 +02:00
Fabien Potencier
ad4021a38c merged branch Seldaek/multishortcuts (PR #7844)
This PR was merged into the master branch.

Discussion
----------

[Console] Allow arrays to be used for lists of shortcuts

Follow-up to #7839

Commits
-------

3bb971e [Console] Allow arrays to be used for lists of shortcuts
2013-04-25 14:06:07 +02:00
Jordi Boggiano
3bb971e57a [Console] Allow arrays to be used for lists of shortcuts 2013-04-25 14:00:12 +02:00
Jordi Boggiano
7b83b7221a [Console] Fix tests on windows 2013-04-25 13:56:40 +02:00
Fabien Potencier
7d0b30d579 merged branch Seldaek/verbosityflags (PR #7841)
This PR was merged into the master branch.

Discussion
----------

[Console] Add more verbosity levels

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6066
| License       | MIT
| Doc PR        | symfony/symfony-docs#2554

This adds new verbosity levels.

Replaces #7626 /cc @dlsniper

Commits
-------

02c2038 Fix tests
5327ec4 Add notes in UPGRADE and CHANGELOG
77c9791 [Console] Add tests and support for more types of inputs
54c1377 [Console] Handle new verbosity levels
e639686 Revert invalid changes
8f4d376 Removed unused options
5bb4163 Fixed tests
b62d35f Fix handling of --verbose=... and BC break
16cdb61 Added more verbosity levels
2013-04-25 13:51:06 +02:00
Fabien Potencier
0795ea8663 [FrameworkBundle] fixed implementation of previous merge (refs #5865) 2013-04-25 13:41:28 +02:00
Jordi Boggiano
02c20381c5 Fix tests 2013-04-25 13:40:04 +02:00
Bart van den Burg
91ebba420a new method to create shorthand name from full Controller name 2013-04-25 13:20:16 +02:00
Fabien Potencier
6a18bfc130 merged branch timaschew/patch-1 (PR #7842)
This PR was merged into the master branch.

Discussion
----------

add german translation for currency validator

| Q             | A
| ------------- | ---
| Fixed tickets | N/A
| License       | MIT

Commits
-------

e99b430 update german translation for validators
2013-04-25 13:16:11 +02:00
Jordi Boggiano
5327ec44e6 Add notes in UPGRADE and CHANGELOG 2013-04-25 12:51:56 +02:00
Jordi Boggiano
77c97913c8 [Console] Add tests and support for more types of inputs 2013-04-25 12:46:25 +02:00
Jordi Boggiano
54c1377a33 [Console] Handle new verbosity levels 2013-04-25 12:42:34 +02:00
Jordi Boggiano
e639686ad5 Revert invalid changes 2013-04-25 12:42:25 +02:00
Florin Patan
8f4d376bce Removed unused options 2013-04-25 12:42:10 +02:00
Florin Patan
5bb41636bc Fixed tests 2013-04-25 12:42:02 +02:00
Jordi Boggiano
b62d35feb9 Fix handling of --verbose=... and BC break 2013-04-25 12:41:54 +02:00
Florin Patan
16cdb6128e Added more verbosity levels 2013-04-25 12:41:44 +02:00
Fabien Potencier
5f9a24d0fa merged branch fabpot/browserkit-redirections (PR #7840)
This PR was merged into the master branch.

Discussion
----------

Browserkit redirections

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7811, #7731
| License       | MIT
| Doc PR        | n/a

Commits
-------

b60290a [BrowserKit] isolated the max redirect count to a given main request (refs #7811)
c8bc953 Add max redirections limit
2013-04-25 12:40:10 +02:00
Fabien Potencier
9a3f415de5 merged branch Seldaek/multishortcuts (PR #7839)
This PR was merged into the master branch.

Discussion
----------

[Console] Add support for multiple InputOption shortcuts

IDEs and others parsing the xml output of command helps should take note that there is a new shortcuts attribute listing all shortcuts, the shortcut one will only list the first for BC.

Commits
-------

a6421a0 [Console] Add support for multiple InputOption shortcuts
2013-04-25 12:39:22 +02:00
Fabien Potencier
b60290a7c8 [BrowserKit] isolated the max redirect count to a given main request (refs #7811) 2013-04-25 12:35:08 +02:00
Jordi Boggiano
a6421a0f23 [Console] Add support for multiple InputOption shortcuts 2013-04-25 12:32:10 +02:00
Joseph Bielawski
c8bc9533e5 Add max redirections limit 2013-04-25 12:21:41 +02:00
Fabien Potencier
6bbcb21fc9 merged branch ricoli/master (PR #7836)
This PR was merged into the master branch.

Discussion
----------

[Validator] Added Portuguese translation for the currency validator

| Q             | A
| ------------- | ---
| Fixed tickets | N/A
| License       | MIT

Commits
-------

a14eee3 [Validator] Added Portuguese translation for the currency validator
2013-04-25 11:58:38 +02:00
Ricardo Oliveira
a14eee3f81 [Validator] Added Portuguese translation for the currency validator 2013-04-25 10:35:53 +01:00
Fabien Potencier
e48e234c45 [PropertyAccess] removed an interface as discussion in the previous merge (refs #7263) 2013-04-25 10:58:14 +02:00
Fabien Potencier
d8ac478b19 merged branch jaugustin/property-access-add-magic-call (PR #7263)
This PR was merged into the master branch.

Discussion
----------

[PropertyAccess] add support for magic call

Hi,

I add support for magic call with the `PropertyAccess`

the is basic implementation, if no `getter`, `isser`, or `hasser` or `_get` is found and there is `__call` then the PropertyAccess call the getter

the same for setter.

This functionality is disable by default

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | seems OK (failure/errors are the same on master)
| Fixed tickets | #4683, #6413, #5309
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/2472

- [x] submit changes to the documentation

@bschussek is this ok ?

Commits
-------

a785baa [PropertyAccess] add support for magic call, related to #4683
2013-04-25 10:51:04 +02:00
timaschew
e99b430bd5 update german translation for validators 2013-04-25 10:58:30 +03:00
Fabien Potencier
7ceb6e5c99 merged branch fabpot/browserkit-client (PR #7835)
This PR was merged into the master branch.

Discussion
----------

fixed Client implementation to return the right Response (closes #4475)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #4475
| License       | MIT
| Doc PR        | symfony/symfony-docs#2549

This PR addresses #4475 by trying to minimize the BC break impact.

Commits
-------

31cefc6 made some small tweaks
84ca34b alternate fix where we had accessor for the BrowerKit request/response instances
1005fd1 fixed Client implementation to return the right Response (closes #4475)
2013-04-25 08:32:27 +02:00
Fabien Potencier
31cefc642b made some small tweaks 2013-04-25 08:21:47 +02:00
Fabien Potencier
84ca34b45e alternate fix where we had accessor for the BrowerKit request/response instances 2013-04-24 22:00:56 +02:00
Fabien Potencier
1005fd1f79 fixed Client implementation to return the right Response (closes #4475) 2013-04-24 20:50:59 +02:00