This PR was merged into the 2.3 branch.
Discussion
----------
do not ship with a custom rng implementation
Commits
-------
b91441c removed obsolete tests, fixed composer.json
fcd3160 do not ship with a custom rng implementation
This PR was squashed before being merged into the 2.3 branch (closes#17326).
Discussion
----------
[Console] Display console application name even when no version set
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
When displaying help of an Application with a name but no version, it show "Console Tool" instead of the application name.
Commits
-------
61e810e [Console] Display console application name even when no version set
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3] Remove empty statements.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Test run for new fixer to see if it would be suitable for SF.
For ref.: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1671
Commits
-------
4491c97 Remove empty statements.
This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] Fix tests on PHP 7.0.2
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #1234
| License | MIT
| Doc PR | -
Related to https://bugs.php.net/66179 that has been fixed in 7.0.2
Commits
-------
902f6dd [Yaml] Fix tests on PHP 7.0.2
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3] Workaround https://bugs.php.net/63206
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This bug has almost no chance to be hit in this code but still, cleaning any potential issue is worth.
Commits
-------
c5479dd [2.3] Workaround https://bugs.php.net/63206
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17338).
Discussion
----------
[Documentation] Typo fix
Commits
-------
12fd48c Typo fix
This PR was merged into the 2.3 branch.
Discussion
----------
[Serializer] Remove normalizer cache in Serializer class
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The serializer cache the normalizer/denormalizer to use based only on the class and format. But the supportsNormalization and supportDenormalization methods can decide based on the data passed leading to hard to find bugs when the serializer used a cached normalizer it shouldn't use.
Commits
-------
8566dc1 Remove normalizer cache in Serializer class
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] Fix paths with % in it (like urlencoded)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | Travis passed
| Fixed tickets | #17306
| License | MIT
| Doc PR | none
Commits
-------
de7b4d7Fix#17306 Paths with % in it are note allowed (like urlencoded)
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#17078).
Discussion
----------
[Bridge] [Doctrine] [Validator] Added support \IteratorAggregate for UniqueEntityValidator
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Expand the list of supported types of results returned from the repositories.
Added processing of type \IteratorAggregate (and as a consequence doctrine Collection)
Commits
-------
6ebd179 Added support \IteratorAggregate for UniqueEntityValidator
Expand the list of supported types of results returned from the repositories.
Added processing of type \IteratorAggregate (and as a consequence doctrine Collection)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17287).
Discussion
----------
[HttpKernel] Forcing string comparison on query parameters sort in UriSigner
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The signing of an url fails when using query parameters with integers as keys.
The ksort function in the ```UriSigner``` class changes the order of the query params and causes to generate a different hash which results in a failed check.
In this PR we force a string comparison for ksort which keeps the correct order of parameters.
Commits
-------
2040139 Added sort order SORT_STRING for params in UriSigner
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][FrameworkBundle] Add case in Kernel directory guess for PHPUnit
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
The current automatic guess of the Kernel directory in the context of PHPUnit does work properly using the following commands:
- `phpunit -c app`
- `phpunit --configuration app`
- `phpunit --configuration=app`
But it fails with the synthax `phpunit -capp`, even if PHPUnit supports it. This PR fixes this.
See https://github.com/symfony/symfony/pull/17272.
Commits
-------
758fc1d [FrameworkBundle] Add case in Kernel directory guess for PHPUnit
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17293).
Discussion
----------
[HttpFoundation] Add missing apostrophe in setSaveHandler phpdoc
| Q | A
| ------------- | ---
| Fixed tickets |
| License | MIT
I fixed php code in comment to one of functions as it couldn't be used with simple copy and paste.
Commits
-------
e32f5a2 Add missing apostrophe in setSaveHandler phpdoc
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix potential race condition
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
As seen at https://travis-ci.org/symfony/symfony/jobs/100448880#L2768, ProcessTest::testRunProcessWithTimeout can create an infinite blocking situation.
I found two potential code paths that could be subject to a race condition. This fixes them.
Commits
-------
b114a85 [Process] Fix potential race condition
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17264).
Discussion
----------
Fix typo in Locale class annotations
Commits
-------
eab7e11 typo
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17183).
Discussion
----------
[FrameworkBundle] Set the kernel.name properly after a cache warmup
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16180
| License | MIT
| Doc PR | -
Commits
-------
1438b9a [FrameworkBundle] Set the kernel.name properly after a cache warmup
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17248).
Discussion
----------
[Form] fixed DateTimeType tests using "date_widget"="choice".
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | no
| License | MIT
| Doc PR | no
As said in the [documentation](http://symfony.com/doc/current/reference/forms/types/datetime.html#years), the default years available in the ``DateType`` go from five year before to five year after the current year. So now that it's 2016 all around, the tests which use the ``"date_widget"="choice"`` without defining a ``"years"`` option and tries to submit a date in 2010 are failing because 2010 is not in the default choice list.
This PR fixes the issue by setting the ``"years"`` option to ``"2010"`` for each test that need it. It also remove unnecessary (and confusing) dummy data from some tests which were suffering the same issue but silently.
Edit : The PHP 5.6 build on travis seems to fetch and run some old version of the tests. So it still fail on this build but not on the others anymore.
Commits
-------
be20e89 Fix Form's DateTimeType tests.
This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] recognize when a block scalar is left
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17116
| License | MIT
| Doc PR |
The parser did not recognize when the block scalar was completely parsed
and thus treated following comments as they need to be kept leading to
parse errors on the following lines.
Commits
-------
3a22165 [Yaml] recognize when a block scalar is left
The parser did not recognize when the block scalar was completely parsed
and thus treated following comments as they need to be kept leading to
parse errors on the following lines.
This PR was merged into the 2.3 branch.
Discussion
----------
Update copyright year
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
Happy new year! 🎉
Commits
-------
ce067e6 Update copyright year
