22143 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Fabien Potencier	6393ec3169	Merge branch '2.7' into 2.8 ... * 2.7: [DomCrawler] Invalid uri created from forms if base tag present [Console] update param type phpdoc for StreamOutput [Console] fix typo in OutputInterface Use stderr by default when a specific output is not injected [Debug] Fix case mismatch detection [HttpKernel] fix broken multiline <esi:remove> [DoctrineBridge] Fixed #14840 [FrameworkBundle] add a suggest for the serializer component [Yaml] Fix the parsing of float keys [Console] Ensure the console output is only detected as decorated when both stderr and stdout support colors [HttpKernel] fix DumpDataCollector compat with Twig 2.0 Improve exception messages. Fix that two DirectoryResources with different patterns would be deduplicated Tests fix clockmock [WebProfilerBundle] Added tabindex="-1" to not interfer with normal UX missing "YAML" in the exception message. [Translator][warmup][fallback locales] fixed missing cache file generation. [framework-bundle] Add Test for TranslationUpdateCommand Use ObjectManager interface instead of EntityManager	2015-09-14 16:15:17 +02:00
Fabien Potencier	cafd4af7cd	Merge branch '2.3' into 2.7 ... * 2.3: [DomCrawler] Invalid uri created from forms if base tag present [Console] update param type phpdoc for StreamOutput [Console] fix typo in OutputInterface [HttpKernel] fix broken multiline <esi:remove> [DoctrineBridge] Fixed #14840 [FrameworkBundle] add a suggest for the serializer component [Yaml] Fix the parsing of float keys [Console] Ensure the console output is only detected as decorated when both stderr and stdout support colors Improve exception messages. Fix that two DirectoryResources with different patterns would be deduplicated Tests fix clockmock [WebProfilerBundle] Added tabindex="-1" to not interfer with normal UX missing "YAML" in the exception message. [framework-bundle] Add Test for TranslationUpdateCommand Use ObjectManager interface instead of EntityManager	2015-09-14 16:14:09 +02:00
Fabien Potencier	6d3f124854	bug #13794 [DomCrawler] Invalid uri created from forms if base tag present (danez) ... This PR was squashed before being merged into the 2.3 branch (closes #13794). Discussion ---------- [DomCrawler] Invalid uri created from forms if base tag present | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Since #13145 was merged the provided testcase does not work anymore and creates an invalid link This affects the latest versions of 2.3, 2.5, 2.6 and 2.7 Right now this PR only includes the failing test, as I could no easy find a fix. If someone immediately knows whats the problem, give me a hint please. Commits ------- dc57a7a [DomCrawler] Invalid uri created from forms if base tag present	2015-09-14 16:00:14 +02:00
Daniel Tschinder	dc57a7a5a7	[DomCrawler] Invalid uri created from forms if base tag present	2015-09-14 16:00:12 +02:00
Fabien Potencier	9e32be3af5	feature #15787 [VarDumper] Add caster for OuterIterator objects (nicolas-grekas) ... This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Add caster for OuterIterator objects | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- f64b72d [VarDumper] Add caster for OuterIterator objects	2015-09-14 15:29:52 +02:00
Fabien Potencier	eff9a26c76	bug #15728 Use stderr by default when a specific output is not injected (Seldaek) ... This PR was merged into the 2.7 branch. Discussion ---------- Use stderr by default when a specific output is not injected | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | stderr is really the best place to put logs by default, so unless someone explicitly passes something else we should use it, and especially not depend on the log level to decide where to output. Commits ------- c28796e Use stderr by default when a specific output is not injected	2015-09-14 15:18:21 +02:00
Fabien Potencier	3cf95ee08a	minor #15789 [Console] update param type phpdoc for StreamOutput (Tobion) ... This PR was merged into the 2.3 branch. Discussion ---------- [Console] update param type phpdoc for StreamOutput Makes it consistent with `getStream()` | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- c036352 [Console] update param type phpdoc for StreamOutput	2015-09-14 15:17:39 +02:00
Fabien Potencier	d87db39aa1	bug #15637 Use ObjectManager interface instead of EntityManager (gnat42) ... This PR was merged into the 2.3 branch. Discussion ---------- Use ObjectManager interface instead of EntityManager | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | If you use the EntityManager Decorator pattern that doctrine provides then simply specifying a query_builder closure where your decorated em is used fails as it isn't an instance of Doctrine\ORM\EntityManager. Testing against the ObjectManager interface fixes the issue. Commits ------- 1f3ea0f Use ObjectManager interface instead of EntityManager	2015-09-14 15:16:06 +02:00
Nicolas Grekas	f64b72ddf0	[VarDumper] Add caster for OuterIterator objects	2015-09-14 14:30:18 +02:00
Tobias Schultze	c0363524a9	[Console] update param type phpdoc for StreamOutput	2015-09-14 14:22:54 +02:00
Tobias Schultze	50afff1647	[Console] fix typo in OutputInterface	2015-09-14 14:10:47 +02:00
Jordi Boggiano	c28796ed74	Use stderr by default when a specific output is not injected	2015-09-14 11:58:30 +01:00
Fabien Potencier	7d343e6430	fixed bad merge	2015-09-14 12:33:37 +02:00
Fabien Potencier	2f31cbfc5f	bug #15783 [Debug] Fix case mismatch detection (nicolas-grekas) ... This PR was merged into the 2.7 branch. Discussion ---------- [Debug] Fix case mismatch detection | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15762 | License | MIT | Doc PR | - Commits ------- 18e9f45 [Debug] Fix case mismatch detection	2015-09-14 11:35:35 +02:00
Nicolas Grekas	18e9f45e8d	[Debug] Fix case mismatch detection	2015-09-14 10:41:38 +02:00
Fabien Potencier	95ccd3bb34	feature #13616 [HttpKernel] Add entry point to more easily create/configure the DI extension (egeloen) ... This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #13616). Discussion ---------- [HttpKernel] Add entry point to more easily create/configure the DI extension | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Hey! I would like to pass some dependencies to the DI extension through the bundle. In the current implementation, I need to duplicate the whole `getContainerExtension` in order to keep the extension alias check. This PR proposes to introduce an entry point for more easily do it. What do you think? Commits ------- 9bae1ae [HttpKernel] Add entry point to more easily create/configure the DI extension	2015-09-14 10:30:47 +02:00
Eric GELOEN	9bae1ae10c	[HttpKernel] Add entry point to more easily create/configure the DI extension	2015-09-14 10:28:58 +02:00
Fabien Potencier	74e408600e	feature #14378 [DX] Added a logout link in the security panel of the web debug toolbar (javiereguiluz) ... This PR was squashed before being merged into the 2.8 branch (closes #14378). Discussion ---------- [DX] Added a logout link in the security panel of the web debug toolbar | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While developing applications, it's common to login/logout users continuously to test security features. I usually type `/logout` in the URL, but this is boring and, depending on the application, not always works. This PR adds a small *Logout* link in the security panel when you are logged in the application:  Anonymous users won't see anything:  Commits ------- 192523a [DX] Added a logout link in the security panel of the web debug toolbar	2015-09-14 09:18:59 +02:00
Javier Eguiluz	192523aeab	[DX] Added a logout link in the security panel of the web debug toolbar	2015-09-14 09:18:57 +02:00
Fabien Potencier	b185056776	bug #14802 [HttpKernel] fix broken multiline <esi:remove> (sstok) ... This PR was squashed before being merged into the 2.3 branch (closes #14802). Discussion ---------- [HttpKernel] fix broken multiline <esi:remove> |Q |A | |--- |---| |Bug Fix? |yes| |New Feature? |n | |BC Breaks? |n | |Deprecations?|n | |Tests Pass? |yes| |Fixed Tickets| | |License |MIT| |Doc PR | | Originally found in https://github.com/symfony/symfony/pull/14800#discussion-diff-31388942 `<esi:remove>` blocks with multiline contents were not removed. `<esi:comment>` blocks with multiline contents were not removed. Note. According to http://www.w3.org/TR/esi-lang `comment is an empty element, and must not have an end tag.` so the support for multi line comments are not actually supported in the standard. Commits ------- 06f97bf [HttpKernel] fix broken multiline <esi:remove>	2015-09-14 09:14:59 +02:00
Sebastiaan Stok	06f97bfbd1	[HttpKernel] fix broken multiline <esi:remove>	2015-09-14 09:14:56 +02:00
Fabien Potencier	dcc6581206	bug #14841 [DoctrineBridge] Fixed #14840 (saksmt) ... This PR was squashed before being merged into the 2.3 branch (closes #14841). Discussion ---------- [DoctrineBridge] Fixed #14840 [DoctrineBridge] Fixed compatibility with entities packed in Phar | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14840 | License | MIT | Doc PR | none Commits ------- 92ad5df [DoctrineBridge] Fixed #14840	2015-09-14 09:11:55 +02:00
Kirill Saksin	92ad5df567	[DoctrineBridge] Fixed #14840	2015-09-14 09:11:51 +02:00
Fabien Potencier	f6bade0303	minor #15543 [FrameworkBundle] add a suggest for the serializer component (lsmith77) ... This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #15543). Discussion ---------- [FrameworkBundle] add a suggest for the serializer component | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | - | Fixed tickets | failing .. but due to unrelated issues in the 2.7 branch | License | MIT | Doc PR | - Commits ------- c7acde8 [FrameworkBundle] add a suggest for the serializer component	2015-09-14 08:48:18 +02:00
Lukas Kahwe Smith	c7acde8024	[FrameworkBundle] add a suggest for the serializer component	2015-09-14 08:48:11 +02:00
Fabien Potencier	f20e4e5ed8	fixed CS	2015-09-14 08:46:24 +02:00
Fabien Potencier	7b776e7ac5	removed non-working tests	2015-09-14 08:45:34 +02:00
Fabien Potencier	46eaafcd63	feature #15620 [WIP] #15502 Make template shortcuts be usable without Templating component (Koc) ... This PR was squashed before being merged into the 2.8 branch (closes #15620). Discussion ---------- [WIP] #15502 Make template shortcuts be usable without Templating component | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | ? | Fixed tickets | #15502 | License | MIT | Doc PR | - Commits ------- d547ec0 [WIP] #15502 Make template shortcuts be usable without Templating component	2015-09-14 08:44:24 +02:00
Konstantin.Myakshin	d547ec0084	[WIP] #15502 Make template shortcuts be usable without Templating component	2015-09-14 08:44:21 +02:00
Fabien Potencier	72111334b2	minor #15673 [framework-bundle] Add Test for TranslationUpdateCommand (zerustech) ... This PR was merged into the 2.3 branch. Discussion ---------- [framework-bundle] Add Test for TranslationUpdateCommand Added the test script as per the discussion in PR #15562 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 232f6fd [framework-bundle] Add Test for TranslationUpdateCommand	2015-09-14 08:41:36 +02:00
Fabien Potencier	71ef86e2f0	bug #15770 [Yaml] Fix the parsing of float keys (jmgq) ... This PR was merged into the 2.3 branch. Discussion ---------- [Yaml] Fix the parsing of float keys | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15667 | License | MIT | Doc PR | Before this fix, the parser was trying to set a float as an array key, and according to the [PHP documentation](http://php.net/manual/en/language.types.array.php) *"The key can either be an integer or a string"*. Therefore, PHP was internally casting the key to an integer. My first approach was to always cast to string, by changing this line: $key = Inline::parseScalar($values['key']); to $key = (string) Inline::parseScalar($values['key']); But that broke some tests, for instance, the parser is expected to transform the key `false` to `0`, but casting `false` to string results in an empty string, rather than `0`. Commits ------- 520bd26 [Yaml] Fix the parsing of float keys	2015-09-14 08:25:27 +02:00
Fabien Potencier	a2eebe8128	feature #15523 Redesigned the Symfony Profiler (javiereguiluz) ... This PR was squashed before being merged into the 2.8 branch (closes #15523). Discussion ---------- Redesigned the Symfony Profiler | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ### Context Recently, we redesigned the web debug toolbar ([read announcement](http://symfony.com/blog/new-in-symfony-2-8-redesigned-web-debug-toolbar)). We maintained "the spirit" of the original toolbar, but its visual appearance was completely changed. Now it's the turn of the Symfony Profiler. We want to update it to match the new toolbar design and to give it a more modern look and feel. ### The redesign Most of the redesign is focused on updating just the visual appearance, but we've seized this opportunity to make some minor functional changes as well. Testing this pull request in your own applications may be difficult, so we'll provide below a complete walkthrough of the redesign. (Click on the images to see them in full resolution) ### Overview This is the new general structure of the profiler pages:  ### Request panel * Renamed `Request` panel to `Request / Response` * Divided contents into tabs: Request, Response, Session, etc. (this prevents ultra long pages)  ### Timeline panel * Renamed `Timeline` panel to `Performance` * Highlighted the most important metrics * Added "Peak Memory Usage" to those metrics * The timeline graph is now easier to read (font size is slightly larger, updated the color palette, made the canvas wider, etc.) * If there is only one request, the page doesn't distract you with the "Master Request" heading. If there are several sub-requests, headings are now bigger and graphs are more separated.  ### Twig panel * Just a minor update to highlight the important metrics. The rest of the contents remain the same.  ### Exception panel * Just minor design tweaks.  ### Events panel When the `framework.ide` config option is set: * The listeners are now displayed as more evident clickable links. * Bellow the listener we show its full class namespace (if you don't need this information, it doesn't distract you much; if you need it, you don't have to wait for the `<abbr>` tooltip to show it)  When the `framework.ide` config option is NOT set: * In this case the developer cannot click on the listener name to go to that file and line. Therefore, we think it's important to display that information (full class namespace + full file path + line number). At first it may seem that it contains too much information ... but this panel should be more "useful" than "beautiful".  ### Logs panel * Logs are now grouped in: "Info. & Errors" (this is the panel that you need most of the times); "Deprecations" (separated from the normal logs because they are specific to the process of updating your Symfony version); and "Debug" (which are all those messages that you almost never need) * We now show the channel for the log messages (for built-in Symfony channels it may be redundant, but your application can define custom channels)  ### Routing panel * Just a minor redesign and highlighted some information.  ### Forms panel * Not redesigned yet. ### Translation panel * Highlighted the important metrics. * Replaced the old selector by the new tabbed navigation.  ### Security panel * Just a minor redesign and highlighted some information.  ### E-mails panel * Not redesigned yet. ### Doctrine panel * Queries are no longer displayed "shrinked". We display the full query without parameters by default. * The three old actions ("expand", "runnable" and "explain") have been reduced to two actions ("runnable" and "explain")  Here you can see what happens when you click on the "Show runnable query" and "Explain query" links:  ### Debug panel * Not redesigned yet. ### Config panel * This was probably the "ugliest" panel in the old profiler, because of the two first tables. * We now display the information of those tables highlighted in a different way.  ### Search results Results with response status different from 2xx now are highlighted:  ### Other design elements The page title now changes for each section: **Before**  **After**  Empty elements now display a dashed border. This allows to make design more consistent between different section. Besides, once you are used to the new design, your brain will immediately associate that design to an empty element, so you'll no longer need to read the inner text content.  Besides, when the entire panel doesn't have any content, its menu label looks disabled:  Long pages have been break down using a tabs-based navigation:  Below the page header we display a "summary section" which displays the profiled URL and some useful profiling information. The big URL is the natural way to "go back to application" from the profiler:  Besides, the summary background color changes according to the response HTTP status code:  Above the main menu we now display two shortcuts to common operations: "display the 10 most recent profiles" and "search profiles":  The search form in the sidebar has been collapsed and it's revealed when clicking on the "Search" shortcut button:  ----- And that's all! Please tell us what you think about this redesign. **Don't hesitate to criticize anything you don't like or think it's wrong or it's worse than in the previous profiler.** Let's work together to make the new profiler a reality! Thanks! Commits ------- 05773c2 Redesigned the Symfony Profiler	2015-09-14 08:10:06 +02:00
Javier Eguiluz	05773c263b	Redesigned the Symfony Profiler	2015-09-14 08:10:04 +02:00
Jose Gonzalez	520bd26642	[Yaml] Fix the parsing of float keys	2015-09-13 18:26:34 +01:00
Fabien Potencier	e2156d7c2c	bug #15771 [Console] Ensure the console output is only detected as decorated when both stderr and stdout support colors (Seldaek) ... This PR was merged into the 2.3 branch. Discussion ---------- [Console] Ensure the console output is only detected as decorated when both stderr and stdout support colors | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10592 #13449 | License | MIT | Doc PR | This is a simplified version of #13661 which does not create any issues with having two decorators but merely ensures that if either STDERR **or** STDOUT has colors disabled, then both will have decoration disabled. It's not a perfect solution but it's better than having both enabled as this breaks things. And I don't think we can come to a better solution without api changes. Commits ------- f3d8444 [Console] Ensure the console output is only detected as decorated when both stderr and stdout support colors	2015-09-13 13:30:23 +02:00
Fabien Potencier	fbba5d95cc	feature #15773 Make the exception output visible even in quiet mode, fixes #15680 (Seldaek) ... This PR was merged into the 2.8 branch. Discussion ---------- Make the exception output visible even in quiet mode, fixes #15680 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15680 | License | MIT | Doc PR | This builds upon #15772 and sets the exception output in Application::renderException to use VERBOSITY_QUIET so that exceptions are always visible. IMO it's a good change but I can see that it is potentially controversial. Commits ------- e9ee8f5 Make the exception output visible even in quiet mode, fixes #15680	2015-09-13 13:29:07 +02:00
Fabien Potencier	209f1fcc27	feature #15772 Convert Output::write's type to an options arg where verbosity can be passed in as well (Seldaek) ... This PR was merged into the 2.8 branch. Discussion ---------- Convert Output::write's type to an options arg where verbosity can be passed in as well | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15680 | License | MIT | Doc PR | Commits ------- 749fba5 Convert Output::write's type to an options arg where verbosity can be passed in as well	2015-09-13 13:27:52 +02:00
Jordi Boggiano	e9ee8f559d	Make the exception output visible even in quiet mode, fixes #15680	2015-09-12 23:39:36 +01:00
Jordi Boggiano	749fba54f9	Convert Output::write's type to an options arg where verbosity can be passed in as well	2015-09-12 23:35:49 +01:00
Jordi Boggiano	f3d844434b	[Console] Ensure the console output is only detected as decorated when both stderr and stdout support colors	2015-09-12 19:38:39 +01:00
Fabien Potencier	a9555fb98f	minor #15767 [Validator] mark test as legacy (TomasVotruba) ... This PR was merged into the 2.8 branch. Discussion ---------- [Validator] mark test as legacy | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Ref https://github.com/symfony/symfony/pull/15708#discussion_r39246000 Failing test are hhvm binaries: https://travis-ci.org/symfony/symfony/jobs/79951993#L530 Commits ------- cf18a99 [Validator] mark test as legacy	2015-09-12 12:03:37 +02:00
Tomas Votruba	cf18a997fb	[Validator] mark test as legacy	2015-09-12 10:46:41 +02:00
Fabien Potencier	238531fea1	bug #15750 Add tests to the recently added exceptions thrown from YamlFileLoaders (jakzal) ... This PR was merged into the 2.3 branch. Discussion ---------- Add tests to the recently added exceptions thrown from YamlFileLoaders | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15702 #15731 | License | MIT | Doc PR | - * use the `Symfony\Component\DependencyInjection\Exception\InvalidArgumentException` in the DI component * add tests Commits ------- 93e418f Improve exception messages.	2015-09-11 17:27:18 +02:00
Fabien Potencier	bee5c61093	bug #15763 [HttpKernel] fix DumpDataCollector compat with Twig 2.0 (nicolas-grekas) ... This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] fix DumpDataCollector compat with Twig 2.0 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15653 | License | MIT | Doc PR | - See https://github.com/twigphp/Twig/pull/1813 Commits ------- 92e50a3 [HttpKernel] fix DumpDataCollector compat with Twig 2.0	2015-09-11 15:10:24 +02:00
Nicolas Grekas	92e50a3b14	[HttpKernel] fix DumpDataCollector compat with Twig 2.0	2015-09-11 14:32:48 +02:00
Abdellatif Ait boudad	f29dd93d5c	feature #15756 [Translation] added option json_options to JsonFileDumper. (gepo) ... This PR was merged into the 2.8 branch. Discussion ---------- [Translation] added option json_options to JsonFileDumper. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | ~ | License | MIT | Doc PR | Replaces #14750 Commits ------- bfdc354 [Translation] added option flags to JsonFileDumper. It's passed to json_encode function second argument.	2015-09-11 11:34:42 +00:00
Gennady Telegin	bfdc35439b	[Translation] added option flags to JsonFileDumper. ... It's passed to json_encode function second argument.	2015-09-11 09:07:49 +00:00
Jakub Zalas	93e418f48e	Improve exception messages.	2015-09-11 08:57:18 +01:00
Nicolas Grekas	f8fa136652	Hot fix	2015-09-10 20:17:51 +02:00
Nicolas Grekas	8bc6df3731	minor #15754 [HttpKernel] Fix RequestStack argument position and deprecated behavior (nicolas-grekas) ... This PR was merged into the 2.8 branch. Discussion ---------- [HttpKernel] Fix RequestStack argument position and deprecated behavior | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 51b6d74 [HttpKernel] Fix RequestStack argument position and deprecated behavior	2015-09-10 19:22:54 +02:00