* 3.2:
[Workflow] Delete dead code
Rename StackOverflow to Stack Overflow
[travis] Test with hhvm 3.18
[Workflow] Fixed marking state on leave and enter events
This PR was merged into the 3.3-dev branch.
Discussion
----------
[FrameworkBundle] Fix autoloader in insulated clients
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Related to the deprecation of the class loader component:
the `Client` already uses this code in `HttpKernel`, but `FrameworkBundle` is missing the same update.
Spotted while debugging the hhvm 3.18 issue (the chain is: `ComposerResource` sees different vendors, thus says the kernel cache is not fresh, thus it is rebuild, thus we hit https://github.com/facebook/hhvm/issues/7722).
Commits
-------
414ac5d976 [FrameworkBundle] Fix autoloader in insulated clients
This PR was merged into the 2.7 branch.
Discussion
----------
[travis] Test with hhvm 3.18
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #21900
| License | MIT
| Doc PR | -
Needs #21922 on master to be green also.
Works around facebook/hhvm#7722.
Commits
-------
7f1f0cb630 [travis] Test with hhvm 3.18
This PR was merged into the 3.3-dev branch.
Discussion
----------
[Workflow] Added the workflow name to all events dispatched
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #21818
| License | MIT
| Doc PR | -
Commits
-------
b3400c7312 [Workflow] Added the workflow name to all events dispatched
This PR was merged into the 3.2 branch.
Discussion
----------
[Workflow] Delete dead code
| Q | A
| ------------- | ---
| Branch? | 3.2
| Bug fix? | "no"
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
---
Me (and all reviewers ;) ) totally miss this class. It has never been used and there are no reason to use it anyway. It's just a relic from the designing of the Component. Sorry.
I really don't think it deserves a deprecation as the component is quite new, and it is really some dead code.
Commits
-------
28e85cc32a [Workflow] Delete dead code
This PR was merged into the 3.2 branch.
Discussion
----------
[Workflow] Fixed marking state on leave and enter events
| Q | A
| ------------- | ---
| Branch? | 3.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | related to https://github.com/symfony/symfony-docs/pull/7528
It seems weird to me to dispatch an event while the marking is not yet marked by the new places.
The event is still "marked" by old places when leaving occurs, my guess is that the symmetry should be mirrored.
Do you agree? Should I add a test?
Commits
-------
175858a67e [Workflow] Fixed marking state on leave and enter events
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#21920).
Discussion
----------
Rename StackOverflow to Stack Overflow
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Renamed StackOverflow to Stack Overflow in README.md.
Commits
-------
e3ac705 Rename StackOverflow to Stack Overflow
This PR was merged into the 3.3-dev branch.
Discussion
----------
[DI] Add a check on the getReflectionClass call
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | ~
This prevents from doing a getter injection if the definition's idcannot be resolved to an existing class.
Commits
-------
a6590b3659 [DI] Add a check on the getReflectionClass call
This PR was merged into the 3.3-dev branch.
Discussion
----------
[travis] Master fixes for HHVM 3.18LTS
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #21900
| License | MIT
| Doc PR | -
For some reason, the current HHVM 3.15 consistently crashes in its shutdown sequence on master.
Time to move to 3.18?
https://github.com/symfony/symfony/pull/21914/files?w=1
Commits
-------
114d62c [travis] Master fixes for HHVM 3.18LTS
This PR was merged into the 2.7 branch.
Discussion
----------
[travis] Disable HHVM JIT - makes tests twice as fast
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
0691639 [travis] Disable HHVM JIT - makes tests twice as fast
This PR was merged into the 3.2 branch.
Discussion
----------
[Yaml] dump escape sequences when possible
| Q | A
| ------------- | ---
| Branch? | 3.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Tests for them have been introduced in #21903 (in 2.7 and 2.8 this does not need to be fixed as those versions didn't dump the `!!binary` tag).
Commits
-------
997103d [Yaml] dump escape sequences when possible
* 3.2:
[Cache] Fix Redis pipelining/multi-ops
[Yaml] Fix the tests
[github] Add a reminder about CHANGELOG.md files
respect the umask argument in dumpFile()
dumpFile(), preserve existing file permissions
[Form] Fixed overridden choices option in extended choice types
Add validate method to mockec validator in form TypeTestCase
bumped Symfony version to 2.8.19
updated VERSION for 2.8.18
updated CHANGELOG for 2.8.18
bumped Symfony version to 2.7.26
updated VERSION for 2.7.25
update CONTRIBUTORS for 2.7.25
updated CHANGELOG for 2.7.25
[HttpKernel] fixed Kernel name when stored in a directory starting with a number
context listener: hardening user provider handling
[Console] Do not squash input changes made from console.command event
[RFC 7231 §6.4.2](https://tools.ietf.org/html/rfc7231#section-6.4.2) states that 301 HTTP Code should forward POST requests to the Location URI.
But, it also states that:
> For historical reasons, a user agent MAY change the request method from POST to GET for the subsequent request.
This is the behavior implemented in almost all user agents.
However the `BrowserKit` did forward the method to the subsequent request.