Commit Graph

49242 Commits

Author SHA1 Message Date
Nicolas Grekas
63e42698d9 [WebLink] Sync type with parent interface 2021-06-22 09:44:52 +02:00
Nicolas Grekas
f0bb3caad1 minor #41763 [WebLink] fix types on Link::withAttribute() (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[WebLink] fix types on Link::withAttribute()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #40126
| License       | MIT
| Doc PR        | -

Related to 10e52348a2

Commits
-------

29903e2c35 [WebLink] fix types on Link::withAttribute()
2021-06-22 09:35:25 +02:00
Nicolas Grekas
29903e2c35 [WebLink] fix types on Link::withAttribute() 2021-06-22 09:33:19 +02:00
Alexander M. Turek
6a4dcde41f bug #41670 [HttpFoundation] allow savePath of NativeFileSessionHandler to be null (simon.chrzanowski)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] allow savePath of NativeFileSessionHandler to be null

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #41669
| License       | MIT

By introducing the great Symfony\Component\HttpFoundation\Session\Storage\Handler\SessionHandlerFactory it is possible to configure session handler via DSN. But if I want to use the NativeFileSessionHandler to use configured session.save_path of php.ini, it doesn't work as expected because the $savePath constructor param is an empty string (and not NULL) by using "file://" as DSN.

Commits
-------

f8a082daeb [HttpFoundation] allow savePath of NativeFileSessionHandler to be null
2021-06-21 23:37:53 +02:00
Pierrick Charron
9ed93df77a
[ErrorHandler][DebugClassLoader] Do not check Phake mocks classes 2021-06-21 16:27:34 -04:00
Nicolas Grekas
dffde22329 [Cache] Disable locking on Windows by default 2021-06-21 18:21:37 +02:00
Nicolas Grekas
8451a14cf6 [DependencyInjection] Fix binding "iterable $foo" when using the PHP-DSL 2021-06-21 17:20:28 +02:00
Nicolas Grekas
978747e6ea [Config] fix tracking default values that reference the parent class 2021-06-21 16:51:25 +02:00
Nicolas Grekas
67fae67a9a [DependencyInjection] fix accepted types on FactoryTrait::factory() 2021-06-21 14:31:30 +02:00
simon.chrzanowski
f8a082daeb [HttpFoundation] allow savePath of NativeFileSessionHandler to be null 2021-06-18 10:57:27 +02:00
Alexandre Daubois
f2b0822401 [VarDumper] Fix tests for PHP 8.1 2021-06-17 08:35:48 +02:00
Nyholm
ffb0d2d424
minor #41712 [Validator] Fix some typos in Greek language (simplegr)
This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] Fix some typos in Greek language

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

Fix some typos in Greek language

Commits
-------

8df2ea12d3 Fix some typos in Greek language
2021-06-16 16:15:28 +02:00
George Yiannoulopoulos
8df2ea12d3
Fix some typos in Greek language 2021-06-15 11:42:13 +03:00
Alexander M. Turek
0fa07c6d7c bug #41644 [Config] fix tracking attributes in ReflectionClassResource (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[Config] fix tracking attributes in ReflectionClassResource

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39988
| License       | MIT
| Doc PR        | -

Commits
-------

7ad8247422 [Config] fix tracking attributes in ReflectionClassResource
2021-06-10 17:19:12 +02:00
David Maicher
608a3e596a [Mailer] fix encoding of addresses using SmtpTransport 2021-06-10 15:25:38 +02:00
Nicolas Grekas
7ad8247422 [Config] fix tracking attributes in ReflectionClassResource 2021-06-09 17:56:09 +02:00
Nicolas Grekas
dd2e6059b5 bug #41621 [Process] Fix incorrect parameter type (bch36)
This PR was submitted for the 5.4 branch but it was squashed and merged into the 4.4 branch instead.

Discussion
----------

[Process] Fix incorrect parameter type

In the affected line of code, fclose() should ONLY be passed a parameter of type resource, but fopen() can return a value of type bool (if the fopen() fails). This results in a fatal error under PHP 8: Fatal error: Uncaught TypeError: fclose(): Argument #1 ($stream) must be of type resource, bool given.

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

d1579a2922 [Process] Fix incorrect parameter type
2021-06-09 16:59:17 +02:00
bch36
d1579a2922 [Process] Fix incorrect parameter type 2021-06-09 16:57:04 +02:00
Nicolas Grekas
c17ed9ee5d minor #41626 [HttpFoundation] Handle new tentative return types (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] Handle new tentative return types

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Part of #41552
| License       | MIT
| Doc PR        | N/A

Commits
-------

1d24bce18f [HttpFoundation] Handle tentative return types
2021-06-09 16:52:47 +02:00
Alexander M. Turek
1d24bce18f [HttpFoundation] Handle tentative return types
Signed-off-by: Alexander M. Turek <me@derrabus.de>
2021-06-09 13:23:53 +02:00
Alexander M. Turek
510be7aa1e minor #41630 [Config] Backport type declarations (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[Config] Backport type declarations

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

This PR backports type declarations from #41575 where it's safe to do so.

Commits
-------

46e18aff9b [Config] Backport type declarations
2021-06-09 12:55:15 +02:00
Nicolas Grekas
12f3e37a46 minor #41627 [VarExporter] Fix test on PHP 8.1 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[VarExporter] Fix test on PHP 8.1

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Part of #41552
| License       | MIT
| Doc PR        | N/A

On PHP 8.1, when dumping the properties of an object (either through serialization, `var_dump` or an array cast), those properties might appear in a different order than on PHP 8.0 and earlier.

Because of that, the test I'm fixing here fails. Since the order of the properties is not really important, I'm sorting the dumped array by key in order to get a stable order.

Commits
-------

56359cb999 [VarExporter] Fix test on PHP 8.1
2021-06-09 09:58:59 +02:00
Nicolas Grekas
7445c3eaab minor #41614 [Mime] Fix CSV file mime type guess test for PHP 8.1 (alexandre-daubois)
This PR was merged into the 4.4 branch.

Discussion
----------

[Mime] Fix CSV file mime type guess test for PHP 8.1

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Part of #41552 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

I had the same result as `@derrabus` on my computer: `application/csv`. The CI returns `text/csv`. These two seem possible, although `text/csv` is described in [RFC 7111](https://datatracker.ietf.org/doc/html/rfc7111#page-3).

(Oops little typo in title, thanks Alexander for the fix 🙏 )

Commits
-------

117cb8f085 [DependencyInjection] Fix CSV file mime type guess test for PHP 8.1
2021-06-09 09:49:03 +02:00
Alexander M. Turek
46e18aff9b [Config] Backport type declarations
Signed-off-by: Alexander M. Turek <me@derrabus.de>
2021-06-08 23:07:02 +02:00
Alexander M. Turek
56359cb999 [VarExporter] Fix test on PHP 8.1
Signed-off-by: Alexander M. Turek <me@derrabus.de>
2021-06-08 19:35:06 +02:00
Alexander M. Turek
7957b48855 bug #41624 [HttpClient] Revert bindto workaround for unaffected PHP versions (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Revert bindto workaround for unaffected PHP versions

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #41622
| License       | MIT
| Doc PR        | N/A

This PR reverts the changes of #38086 for PHP versions that don't need that workaround.

Commits
-------

e9afce3334 [HttpClient] Revert bindto workaround
2021-06-08 19:16:05 +02:00
Alexander M. Turek
e9afce3334 [HttpClient] Revert bindto workaround
… for unaffected PHP versions

Signed-off-by: Alexander M. Turek <me@derrabus.de>
2021-06-08 18:37:25 +02:00
Nicolas Grekas
7ca099579c minor #41603 [DependencyInjection] Fix testServiceSubscriber for PHP 8.1 (alexandre-daubois)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Fix testServiceSubscriber for PHP 8.1

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #41592 and part of #41552 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

a5be196827 [DependencyInjection] Fix testServiceSubscriber for PHP 8.1
2021-06-08 17:22:03 +02:00
Nicolas Grekas
a5816d11af minor #41609 Optimize travis file a bit (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

Optimize travis file a bit

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

fe51b80903 Optimize travis file a bit
2021-06-08 14:43:26 +02:00
Nicolas Grekas
fe51b80903 Optimize travis file a bit 2021-06-08 13:38:09 +02:00
Alexandre Daubois
117cb8f085 [DependencyInjection] Fix CSV file mime type guess test for PHP 8.1 2021-06-08 13:22:53 +02:00
Nicolas Grekas
2d699e3054 minor #41589 Add missing translations for Swedish (kiennguyen95)
This PR was merged into the 4.4 branch.

Discussion
----------

Add missing translations for Swedish

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #41483
| License       | MIT

Add missing Swedish translations to Security component.

Commits
-------

65e96dd13f Add missing translations for Swedish
2021-06-08 11:01:38 +02:00
Nicolas Grekas
b6d9c47df3 minor #41588 Add missing translations for Thai (kiennguyen95)
This PR was merged into the 4.4 branch.

Discussion
----------

Add missing translations for Thai

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #41086
| License       | MIT

Add missing Thai translations to Security component.

Commits
-------

d3249baa06 Add missing translations for Thai
2021-06-08 11:01:04 +02:00
Nicolas Grekas
e658d001e7 minor #41596 [FrameworkBundle] Remove duplicate catch block (OskarStark)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Remove duplicate catch block

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Spottet while reviewing https://github.com/symfony/symfony/pull/41576 by `@derrabus`

Commits
-------

32cac1c6f2 Remove duplicate catch block
2021-06-08 10:55:51 +02:00
Alexandre Daubois
a5be196827 [DependencyInjection] Fix testServiceSubscriber for PHP 8.1 2021-06-08 09:24:10 +02:00
Maxime Steinhausser
bc383215a3 [MonologBridge] Fix the server:log help --filter sample 2021-06-08 07:59:26 +02:00
Oskar Stark
32cac1c6f2 Remove duplicate catch block 2021-06-07 21:46:40 +02:00
Nicolas Grekas
a4dee4aaba minor #41594 fix tests (quinter) (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

fix tests (quinter)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

a70b537fbc fix tests (quinter)
2021-06-07 20:58:54 +02:00
Nicolas Grekas
a70b537fbc fix tests (quinter) 2021-06-07 20:50:09 +02:00
Nicolas Grekas
21619fe77f minor #41591 fix tests (quater) (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

fix tests (quater)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

e705a66a7f fix tests (quater)
2021-06-07 18:36:11 +02:00
Nicolas Grekas
e705a66a7f fix tests (quater) 2021-06-07 18:35:43 +02:00
Kien Nguyen
d3249baa06 Add missing translations for Thai 2021-06-07 22:19:59 +07:00
Nicolas Grekas
a1f376b276 bump ext-mongodb 2021-06-07 17:05:04 +02:00
Kien Nguyen
65e96dd13f Add missing translations for Swedish 2021-06-07 22:03:43 +07:00
Nicolas Grekas
bf30aa6f97 minor #41585 fix tests (ter) (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

fix tests (ter)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

a71fb4b8f2 fix tests (ter)
2021-06-07 16:42:00 +02:00
Nicolas Grekas
a71fb4b8f2 fix tests (ter) 2021-06-07 16:39:01 +02:00
Nicolas Grekas
ad5b25e390 minor #41581 Fix tests (bis) (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

 Fix tests (bis)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

7341e29f2f Fix tests (bis)
2021-06-07 13:02:58 +02:00
Nicolas Grekas
7341e29f2f Fix tests (bis) 2021-06-07 12:56:07 +02:00
Nicolas Grekas
fb79727653 minor #41565 [FrameworkBundle][WebProfilerBundle] Don't pass null to string parameters (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][WebProfilerBundle] Don't pass null to string parameters

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Part of #41552
| License       | MIT
| Doc PR        | N/A

This should fix the remaining issues from our bundle tests

Commits
-------

5af6edae62 [FrameworkBundle][WebProfilerBundle] Don't pass null to string parameters
2021-06-07 09:53:22 +02:00
Nicolas Grekas
301cc9877d minor #41570 [travis] fix travis hopefuly (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[travis] fix travis hopefuly

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

a245efb604 [travis] fix travis hopefuly
2021-06-07 09:45:19 +02:00