This PR was merged into the 2.3 branch.
Discussion
----------
[travis] use github token to fetch deps from ZIP files
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Is there any downside to doing so?
Commits
-------
6215437 [travis] use github token to fetch deps from ZIP files
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix potential race condition leading to transient tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #15617
| License | MIT
| Doc PR | -
Sibling of #17176 on 2.3
Commits
-------
99fc428 [Process] Fix potential race condition leading to transient tests
This PR was merged into the 2.3 branch.
Discussion
----------
CS: use nowdoc instead of heredoc
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | —
| License | MIT
| Doc PR | —
if this is accepted, we could add the fixer to symfony level of php-cs-fixer: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1580
Commits
-------
3dca549 use nowdoc instead of heredoc
This PR was merged into the 2.3 branch.
Discussion
----------
[travis] timeout the sigchild tests at 60s
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
[Sometimes](https://travis-ci.org/symfony/symfony/jobs/98790028#L2774), the tests of the process component with sigchild enabled are terminated by travis after 10 minutes of no activity.
In order to free the failing job faster and to get some output, let's kill the job ourselves after 60s (running the test suite usually takes ~8s on travis)
Commits
-------
f78e794 [travis] timeout the sigchild tests at 60s
This PR was merged into the 2.3 branch.
Discussion
----------
Do not use HttpKernel Extension when not needed
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
HttpKernel Extension only adds `addClassesToCompile`. So the class hierarchy should be slim if it's not used.
Commits
-------
4978e19 Do not use HttpKernel Extension when not needed
This PR was merged into the 2.3 branch.
Discussion
----------
CS: Single line comments should use double slashes (//) and not hash (#)
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | ?
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Just to be consistent ;)
Commits
-------
4f0f8a2 CS: Single line comments should use double slashes (//) and not hash (#).
This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] fix indented line handling in folded blocks
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9105
| License | MIT
| Doc PR |
Commits
-------
756834c [Yaml] fix indented line handling in folded blocks
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#17052).
Discussion
----------
[2.7] Fixed flatten exception recursion with errors
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Consider the following code:
```php
$error = new ParseError();
$exception = new RuntimeException($error->getMessage(), $error->getCode(), $error);
$flat = new Symfony\Component\Debug\Exception\FlattenException($exception);
```
Without this fix, that code is broken.
You'll end up with something like this:
```
FatalThrowableError in FlattenException.php line 76:
Type error: Argument 1 passed to Symfony\Component\Debug\Exception\FlattenException::create() must be an instance of Exception, instance of ParseError given
```
---
I came across this error issue in https://github.com/laravel/framework/issues/11329.
Commits
-------
2b0721d [2.7] Fixed flatten exception recursion with errors
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16826).
Discussion
----------
Embedded identifier support
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | n/a
If you define your entity identifier using an embeddable class the identifier name will contain period symbols in it such as `id.value` which will generate a syntax error in the DQL lexer because parameter names are not allowed to contain period symbols.
Example to reproduce described bug:
```php
/**
* @ORM\Embeddable
*/
class Identifier {
/**
* @ORM\Column(type="integer")
*/
protected $value;
}
/**
* @ORM\Entity
*/
class Entity {
/**
* @ORM\Id @ORM\Embedded(class="Identifier")
*/
protected $id;
}
```
Commits
-------
38fdda6 Embedded identifier support
This PR was merged into the 2.3 branch.
Discussion
----------
[Config] Fix array sort on normalization in edge case
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Commits
-------
eca41a8 [Config] Fix array sort on normalization in edge case
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes#17131).
Discussion
----------
[DependencyInjection] Change the ExtensionInterface load method definition
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/5988
This PR change the `Symfony\Component\DependencyInjection\Extension\ExtensionInterface` load method definition to be identical to the documentation :
`public function load(array $configs, ContainerBuilder $container);`
Commits
-------
85c271b Change the ExtensionInterface load method definition to bo identical to the documentation.
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#16945).
Discussion
----------
add and correct armenian translations
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Commits
-------
54e6fb4 add and correct armenian translations
This PR was merged into the 2.3 branch.
Discussion
----------
improve BrowserKit test coverage p1
Hi,
This PR improves BrowserKit test coverage.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
I rebased previous PR https://github.com/symfony/symfony/pull/16549 to 2.3
Commits
-------
0261b48 improve BrowserKit test coverage p1
This PR was merged into the 2.3 branch.
Discussion
----------
[appveyor] Exit with failing status code
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
[Sometimes](https://ci.appveyor.com/project/fabpot/symfony/build/1.0.4272#L1103), tests fail on appveyor and I'd like to see the exit code. This does it.
Commits
-------
a6cfff5 [appveyor] Exit with failing status code
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] More robustness and deterministic tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16988, #15617
| License | MIT
| Doc PR | -
Commits
-------
d1a178a [Process] More robustness and deterministic tests
This PR was merged into the 2.3 branch.
Discussion
----------
[PropertyAccess] Reorder elements array after PropertyPathBuilder::replace
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17102
| License | MIT
| Doc PR |
Commits
-------
d0c0294 [PropertyAccess] Reorder elements array after PropertyPathBuilder::replace
This PR was merged into the 2.3 branch.
Discussion
----------
[Security] skip bcrypt tests on incompatible platforms
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17055
| License | MIT
| Doc PR |
Not all PHP versions before 5.3.7 have backported fixes that make it
possible to use `password_hash()` function. Therefore, we have to skip
tests on not supported platforms.
Commits
-------
2a6fa7b use requires annotation
65eb188 skip bcrypt tests on incompatible platforms
This PR was merged into the 2.3 branch.
Discussion
----------
[Routing] Reduce memory usage of a high consuming test case
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Tests fail transiently on hhvm because of the high memory usage of this test case.
This patch cuts it by two.
See this blackfire comparison graph on the Memory dimension:
https://blackfire.io/profiles/compare/fd72ee66-e4d0-4ac2-92bf-16dd3849ef4c/graph?settings%5Bdimension%5D=pmu
Commits
-------
478a031 [Routing] Reduce memory usage of a high consuming test case
This PR was merged into the 2.3 branch.
Discussion
----------
[SecurityBundle] Removing test insulations for a huge perf win
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
b8fa471 [SecurityBundle] Removing test insulations for a huge perf win
