Commit Graph

18242 Commits

Author SHA1 Message Date
Nicolas Grekas 6a99db40dc minor #18099 [Filesystem] Fix transient tests (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Filesystem] Fix transient tests

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

time().mt_rand(0, 1000) is not enough...
also adds a missing skip

Commits
-------

a6edd78 [Filesystem] Fix transient tests
2016-03-10 15:52:33 +01:00
Nicolas Grekas a6edd78116 [Filesystem] Fix transient tests 2016-03-10 15:49:24 +01:00
Fabien Potencier be867ae968 bug #18080 [HttpFoundation] Set the Content-Range header if the requested Range is unsatisfied (jakzal)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] Set the Content-Range header if the requested Range is unsatisfied

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is a followup to https://github.com/symfony/symfony/pull/17150#issuecomment-174509954

[RFC2616](http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html) specifies the Content-Range header SHOULD be included with a *416 Requested Range Not Satisfiable* response:

>    When this status code is returned for a byte-range request, the response SHOULD include a Content-Range entity-header field specifying the current length of the selected resource (see section 14.16). This response MUST NOT use the multipart/byteranges content- type.

[RFC 7233](https://tools.ietf.org/html/rfc7233#section-4.2) specifies what should be the header's value. It's in the "Request for comments" state, but it's the best definition I could find. This value is valid according to rfc2616 as well.

Commits
-------

54329d8 [HttpFoundation] Set the Content-Range header if the requested Range is unsatisfied
2016-03-10 14:40:45 +01:00
Fabien Potencier 5340cbd4fc bug #18084 [HttpFoundation] Avoid warnings when checking malicious IPs (jakzal)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] Avoid warnings when checking malicious IPs

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17386
| License       | MIT
| Doc PR        | -

Commits
-------

3067bdb [HttpFoundation] Avoid warnings when checking malicious IPs
2016-03-10 14:30:02 +01:00
Jakub Zalas 3067bdb8d9 [HttpFoundation] Avoid warnings when checking malicious IPs 2016-03-10 08:48:57 +00:00
Jakub Zalas 54329d836c [HttpFoundation] Set the Content-Range header if the requested Range is unsatisfied 2016-03-09 16:57:57 +00:00
Fabien Potencier fd4edff329 bug #18048 [HttpKernel] Fix mem usage when stripping the prod container (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpKernel] Fix mem usage when stripping the prod container

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18007
| License       | MIT
| Doc PR        | -

I propose to just replace doc comments by regular comments, so that the parser removes them and opcache doesn't have to keep them in memory, which is the target.

Commits
-------

4fa5844 [HttpKernel] Fix mem usage when stripping the prod container
2016-03-09 14:11:45 +01:00
Fabien Potencier 15ccef7690 bug #18065 [Finder] Partially revert #17134 to fix a regression (jakzal)
This PR was merged into the 2.3 branch.

Discussion
----------

[Finder] Partially revert #17134 to fix a regression

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18013
| License       | MIT
| Doc PR        | -

Commits
-------

ead1824 [Finder] Partially revert #17134 to fix a regression
2016-03-09 14:08:09 +01:00
Jakub Zalas ead1824d3e [Finder] Partially revert #17134 to fix a regression 2016-03-09 12:50:31 +00:00
Fabien Potencier 5d8067f32d bug #18018 [HttpFoundation] exception when registering bags for started sessions (xabbuh)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] exception when registering bags for started sessions

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10707, #16136
| License       | MIT
| Doc PR        |

Commits
-------

c4a5b67 exception when registering bags for started sessions
2016-03-08 22:59:00 +01:00
Nicolas Grekas 4fa58440be [HttpKernel] Fix mem usage when stripping the prod container 2016-03-08 17:58:37 +01:00
Nicolas Grekas 1bbcff0ba0 bug #18054 [Filesystem] Fix false positive in ->remove() (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Filesystem] Fix false positive in ->remove()

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

3efd900 [Filesystem] Fix false positive in ->remove()
2016-03-08 14:39:20 +01:00
Nicolas Grekas 3efd900565 [Filesystem] Fix false positive in ->remove() 2016-03-08 14:32:44 +01:00
Fabien Potencier 35666f05f7 bug #18049 [Validator] Fix the locale validator so it treats a locale alias as a valid locale (jakzal)
This PR was merged into the 2.3 branch.

Discussion
----------

[Validator] Fix the locale validator so it treats a locale alias as a valid locale

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12583
| License       | MIT
| Doc PR        | -

Commits
-------

fbb12d8 [Validator] Fix the locale validator so it treats a locale alias as a valid locale
2016-03-08 09:19:01 +01:00
Jakub Zalas fbb12d89d1 [Validator] Fix the locale validator so it treats a locale alias as a valid locale 2016-03-07 19:18:54 +00:00
Nicolas Grekas 6d5dbf7a75 [HttpFoundation] Fix transient test 2016-03-07 14:26:56 +01:00
Nicolas Grekas 12c015398e minor #18030 [HttpFoundation] Add a dependency on the mbstring polyfill (jakzal)
This PR was squashed before being merged into the 2.3 branch (closes #18030).

Discussion
----------

[HttpFoundation] Add a dependency on the mbstring polyfill

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Alternative for #18029.

Commits
-------

59b9f15 [HttpFoundation] Add a dependency on the mbstring polyfill
2016-03-07 14:08:53 +01:00
Jakub Zalas 59b9f156a9 [HttpFoundation] Add a dependency on the mbstring polyfill 2016-03-07 14:08:49 +01:00
Nicolas Grekas 88ce9c18e3 minor #18046 Add README files where missing (xabbuh)
This PR was merged into the 2.3 branch.

Discussion
----------

Add README files where missing

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17997
| License       | MIT
| Doc PR        |

The bundles as well as the Swiftmailer bridge did not have readme files.

Commits
-------

a1997b9 add readme files where missing
2016-03-07 13:45:48 +01:00
Christian Flothmann a1997b92c6 add readme files where missing 2016-03-07 11:36:15 +01:00
Fabien Potencier 4f224ef4ab bug #18019 [Intl] Update ICU to version 55 (jakzal)
This PR was merged into the 2.3 branch.

Discussion
----------

[Intl] Update ICU to version 55

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14260
| License       | MIT
| Doc PR        | -

The update script needed to be fixed to work with latest data files from ICU as well.

The only change I needed to do in stubs and tests is related to the way negative numbers are formatted for currencies (a change from `(£100)` to `-£100`).

Form tests needed an update as well, as some date formats have changed.

Commits
-------

fac3de6 [Form] Update form tests after the ICU data update
6822147 [Intl] Update tests and the number formatter to match behaviour of the intl extension
37a9d8c [Intl] Update the ICU data to version 55
894ce3c [Intl] Fix the update-data.php script in preparation for ICU 5.5
2016-03-06 11:37:13 +01:00
Fabien Potencier 53033617f7 minor #18021 Don't use reflections when possible (Ener-Getick)
This PR was merged into the 2.3 branch.

Discussion
----------

Don't use reflections when possible

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Use php functions instead of reflection when possible (to improve a bit the performance).

Commits
-------

a46270a Don't use reflections when possible
2016-03-06 11:24:23 +01:00
Ener-Getick a46270a61a Don't use reflections when possible 2016-03-05 18:37:04 +01:00
Jakub Zalas fac3de628e [Form] Update form tests after the ICU data update 2016-03-05 13:21:13 +00:00
Jakub Zalas 6822147464 [Intl] Update tests and the number formatter to match behaviour of the intl extension 2016-03-05 13:11:12 +00:00
Jakub Zalas 37a9d8ca24 [Intl] Update the ICU data to version 55 2016-03-05 13:11:11 +00:00
Jakub Zalas 894ce3cbd8 [Intl] Fix the update-data.php script in preparation for ICU 5.5 2016-03-05 13:11:11 +00:00
Christian Flothmann c4a5b67a5a exception when registering bags for started sessions 2016-03-05 08:51:23 +01:00
Fabien Potencier d2e5c4c3ab minor #18009 Use constant instead of function call. (Koc)
This PR was merged into the 2.3 branch.

Discussion
----------

Use constant instead of function call.

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

c1edbc0 Use constant instead of function call.
2016-03-04 14:51:11 +01:00
Konstantin.Myakshin c1edbc08bb Use constant instead of function call. 2016-03-04 15:04:09 +02:00
Fabien Potencier 759f495594 fixed test name 2016-03-04 12:06:48 +01:00
Fabien Potencier 5bbe951cde bug #16656 [HttpFoundation] automatically generate safe fallback filename (xabbuh)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] automatically generate safe fallback filename

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16603
| License       | MIT
| Doc PR        |

Commits
-------

03721e3 automatically generate safe fallback filename
2016-03-04 10:42:52 +01:00
Christian Flothmann 03721e33a2 automatically generate safe fallback filename 2016-03-04 10:37:05 +01:00
Fabien Potencier ce60be5729 bug #15794 [Console] default to stderr in the console helpers (alcohol)
This PR was squashed before being merged into the 2.3 branch (closes #15794).

Discussion
----------

[Console] default to stderr in the console helpers

Interactive input/output and informational output such as progress should go to `stderr` if available.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

See #13730 also for previous discussion.

If someone explicitly wants to use `stdout`, they can simply pass `$output->getStream()` instead of `$output` in most use-cases.

Commits
-------

3d4e95e [Console] default to stderr in the console helpers
2016-03-04 10:20:54 +01:00
Rob Bast 3d4e95ef71 [Console] default to stderr in the console helpers 2016-03-04 10:20:49 +01:00
Fabien Potencier 9a5ea71c22 bug #17984 Allow to normalize \Traversable when serializing xml (Ener-Getick)
This PR was merged into the 2.3 branch.

Discussion
----------

Allow to normalize \Traversable when serializing xml

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets |
| License       | MIT

It's impossible to normalize an object implementing ``\Traversable`` when using the ``XMLEncoder``. For example we can't customize the serializer output when serializing a ``FormInterface`` instance.

So my proposition is to fix this by using the default XML encoder output only when the serializer can't normalize the data.

Commits
-------

97c5d27 Allow to normalize \Traversable
2016-03-04 08:19:22 +01:00
Fabien Potencier 8713c7efaf minor #17997 Updated all the README files (javiereguiluz)
This PR was squashed before being merged into the 2.3 branch (closes #17997).

Discussion
----------

Updated all the README files

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Related to #17995.

Commits
-------

2e81248 Updated all the README files
2016-03-04 08:12:08 +01:00
Javier Eguiluz 2e812481c9 Updated all the README files 2016-03-04 08:12:06 +01:00
Nicolas Grekas d791d78d34 minor #18002 [TwigBundle] Fix failing test on appveyor (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[TwigBundle] Fix failing test on appveyor

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #17434
| License       | MIT
| Doc PR        | -

Commits
-------

d5bbc3c [TwigBundle] Fix failing test on appveyor
2016-03-03 18:39:39 +01:00
Nicolas Grekas d5bbc3c6cb [TwigBundle] Fix failing test on appveyor 2016-03-03 18:24:01 +01:00
Fabien Potencier 37569be45f bug #17434 Improved the error message when a template is not found (rvanginneken, javiereguiluz)
This PR was merged into the 2.3 branch.

Discussion
----------

Improved the error message when a template is not found

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #14806
| License       | MIT
| Doc PR        | -

### Before

![template_error_before](https://cloud.githubusercontent.com/assets/73419/12414237/7db29212-be94-11e5-85b4-c6444aa853f8.png)

### After

![template_error_after](https://cloud.githubusercontent.com/assets/73419/12414242/80ed1eca-be94-11e5-992e-a0596a1e95ca.png)

This seems to work in the browser ... but I can't make tests pass. Could anybody please help me? Thanks!

Commits
-------

0134d76 Simplified everything
19bfa2e Added a test
88b913b Fixed the problem in an easier way
35f082f Fixed a syntax issue
968476b Improved the error message when a template is not found
e9d951a [CodingStandards] Conformed to coding standards
d3fe07b [TwigBundle] fixed Include file locations in "Template could not be found" exception
2016-03-03 15:31:15 +01:00
Fabien Potencier eee9bfbef6 bug #17894 [FrameworkBundle] Fix a regression in handling absolute template paths (jakzal)
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] Fix a regression in handling absolute template paths

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17777 #17683
| License       | MIT
| Doc PR        | -

Regression introduced by #15272.

Commits
-------

d8c493f [FrameworkBundle] Fix a regression in handling absolute and namespaced template paths
2016-03-03 13:59:03 +01:00
Fabien Potencier 154eac7733 bug #17595 [HttpKernel] Remove _path from query parameters when fragment is a subrequest (cmenning)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpKernel] Remove _path from query parameters when fragment is a subrequest

| Q             | A
| ------------- | ---
| Bug fix?      | Yes
| New feature?  | No
| BC breaks?    | No
| Deprecations? | No
| Tests pass?   | Yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Prior to 2.3.29, all requests to the ESI fragment path ("/_fragment" by default) would have the "_path" query parameter removed. This held true whether an external proxy (such as Varnish) handled the request as true ESI, or whether the Symfony kernel was mocking ESI behavior and inlining the subrequest.

Once the "_controller" check was added in 2.3.29, the "_path" query parameter was only removed on master requests (such as those coming from an external proxy) and not subrequests, leading to differing behavior in production and development settings.

Commits
-------

c374420 Remove _path from query parameters when fragment is a subrequest and request attributes are already set Added tests for _path removal in FragmentListener
2016-03-03 13:35:04 +01:00
Jakub Zalas d8c493f076 [FrameworkBundle] Fix a regression in handling absolute and namespaced template paths 2016-03-03 08:16:18 +00:00
Ener-Getick 97c5d27c59 Allow to normalize \Traversable 2016-03-02 21:42:54 +01:00
Fabien Potencier 5b577ddd19 bug #17986 [DomCrawler] Dont use LIBXML_PARSEHUGE by default (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[DomCrawler] Dont use LIBXML_PARSEHUGE by default

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #16873, #17956
| License       | MIT
| Doc PR        | -

Because of http://symfony.com/blog/security-release-symfony-2-0-17-released

Commits
-------

fda32f8 [DomCrawler] Dont use LIBXML_PARSEHUGE by default
2016-03-02 16:22:15 +01:00
Craig Menning c3744202f6 Remove _path from query parameters when fragment is a subrequest and request attributes are already set
Added tests for _path removal in FragmentListener
2016-03-02 08:58:36 -06:00
Nicolas Grekas fda32f8c43 [DomCrawler] Dont use LIBXML_PARSEHUGE by default 2016-03-02 15:53:47 +01:00
Fabien Potencier 9a4bf1e099 minor #17985 [Filesystem] Reduce complexity of ->remove() (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Filesystem] Reduce complexity of ->remove()

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

065acb7 [Filesystem] Reduce complexity of ->remove()
2016-03-02 15:50:41 +01:00
Nicolas Grekas 065acb7fa8 [Filesystem] Reduce complexity of ->remove() 2016-03-02 15:47:46 +01:00