Commit Graph

52874 Commits

Author SHA1 Message Date
Thomas Calvet
6b88e6f662 [Serializer][UidNormalizer] Add normalization formats 2021-01-06 09:25:33 +01:00
Fabien Potencier
9e47d90019 minor #39731 fix code style (xabbuh)
This PR was merged into the 5.3-dev branch.

Discussion
----------

fix code style

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

70ab0848ba fix code style
2021-01-06 06:25:03 +01:00
Christian Flothmann
70ab0848ba fix code style 2021-01-05 21:16:44 +01:00
Christian Flothmann
a7600370fa Merge branch '5.2' into 5.x
* 5.2:
  fix code style
  [Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
  [Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
  stop using void in test files
  parse cookie values containing the equal sign
  make some time dependent tests more resilient
  fix code style
  Remove full head content in HTML to text converter
  do not break when loading schemas from network paths on Windows
  apply the sort callback on the whole search result
2021-01-05 20:51:30 +01:00
Christian Flothmann
d3739d4482 Merge branch '5.1' into 5.2
* 5.1:
  parse cookie values containing the equal sign
  make some time dependent tests more resilient
  do not break when loading schemas from network paths on Windows
2021-01-05 20:50:41 +01:00
Christian Flothmann
cd1361b059 Merge branch '4.4' into 5.1
* 4.4:
  parse cookie values containing the equal sign
  make some time dependent tests more resilient
  do not break when loading schemas from network paths on Windows
2021-01-05 20:49:26 +01:00
Christian Flothmann
af13843668 minor #39727 fix code style (xabbuh)
This PR was merged into the 5.2 branch.

Discussion
----------

fix code style

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

0fdf59c26d fix code style
2021-01-05 20:48:34 +01:00
Christian Flothmann
0fdf59c26d fix code style 2021-01-05 20:37:17 +01:00
Christian Flothmann
bc20e633f3 Merge branch '5.1' into 5.2
* 5.1:
  [Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
  [Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
  stop using void in test files
2021-01-05 20:21:40 +01:00
Nicolas Grekas
80bde1e27c feature #39098 [PhpUnitBridge] Add log file option for deprecations (michaelKaefer)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[PhpUnitBridge] Add log file option for deprecations

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #37679
| License       | MIT
| Doc PR        | symfony/symfony-docs#14558

Commits
-------

3ed22bea69 [PhpUnitBridge] Add log file option for deprecations
2021-01-05 20:06:00 +01:00
Michael Käfer
3ed22bea69 [PhpUnitBridge] Add log file option for deprecations 2021-01-05 20:05:31 +01:00
Nicolas Grekas
9b719ab13d minor #39720 make some time dependent tests more resilient (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

make some time dependent tests more resilient

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

a33850e838 make some time dependent tests more resilient
2021-01-05 19:32:49 +01:00
Nicolas Grekas
b9c743c163 minor #39728 stop using void in test files (xabbuh)
This PR was merged into the 5.1 branch.

Discussion
----------

stop using void in test files

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

8f9f370f07 stop using void in test files
2021-01-05 19:31:25 +01:00
Nicolas Grekas
dcd3bad72a minor #39729 [Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version (fancyweb)
This PR was merged into the 5.1 branch.

Discussion
----------

[Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Ref https://github.com/symfony/polyfill/issues/323

In my scenario, I'm doing `Ulid::fromString('0164129e-c96f-eb1a-f011-57cf56e0c559')`. When we reach the modified line, we already know the provided `$ulid` string is an rfc-4122 valid uuid so we don't need to call `fromString` (I guess) + we don't care of the version, we just want the binary content. That fixes the referenced issue in my case because the missing constant is consequently not loaded.

Commits
-------

44392cbc30 [Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
2021-01-05 19:30:56 +01:00
Nicolas Grekas
6a953f4927 minor #39730 [Uid] Inline UuidV*::TYPE constants (fancyweb)
This PR was merged into the 5.1 branch.

Discussion
----------

[Uid] Inline UuidV*::TYPE constants

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Ref https://github.com/symfony/polyfill/issues/323

If we hardcode those values in the polyfill, we can surely hardcode them here? In my case, I have tested that `uuid_type` actually returns `3` even if the `\UUID_TYPE_MD5` constant is undefined 🤷‍♂️

Commits
-------

f0fafec019 [Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
2021-01-05 19:30:20 +01:00
Thomas Calvet
f0fafec019 [Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants 2021-01-05 18:34:45 +01:00
Thomas Calvet
44392cbc30 [Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version 2021-01-05 18:11:49 +01:00
Christian Flothmann
eb74e5e94d bug #39681 [HttpFoundation] parse cookie values containing the equal sign (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] parse cookie values containing the equal sign

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33667
| License       | MIT
| Doc PR        |

Commits
-------

29d2da572e parse cookie values containing the equal sign
2021-01-05 17:31:26 +01:00
Christian Flothmann
8f9f370f07 stop using void in test files 2021-01-05 16:52:51 +01:00
Christian Flothmann
c97d850224 minor #39721 [Lock] Fix CI (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Lock] Fix CI

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

e74a7f2004 Fix CI
2021-01-05 16:44:03 +01:00
Christian Flothmann
900cb0eece Merge branch '5.1' into 5.2
* 5.1:
  fix code style
  Remove full head content in HTML to text converter
  apply the sort callback on the whole search result
2021-01-05 16:30:03 +01:00
Christian Flothmann
d4620a7d51 minor #39714 fix code style (xabbuh)
This PR was merged into the 5.1 branch.

Discussion
----------

fix code style

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

08fb696dbc fix code style
2021-01-05 16:28:24 +01:00
Christian Flothmann
29d2da572e parse cookie values containing the equal sign 2021-01-05 15:30:54 +01:00
Christian Flothmann
d1664d71bf add missing upgrade entry 2021-01-05 15:21:37 +01:00
Christian Flothmann
d71aa52d73 fix typo 2021-01-05 15:08:22 +01:00
Jérémy Derussé
e74a7f2004
Fix CI 2021-01-05 14:11:35 +01:00
Fabien Potencier
eb3aa168f1 bug #39723 [Console] Handle duplicate negatable options (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Console] Handle duplicate negatable options

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Throws an LogicException when adding a "standard" option "--no-foo" along side a negatable "--foo"

Commits
-------

2954c9a238 Handle duplicate negatable options
2021-01-05 13:16:40 +01:00
Jérémy Derussé
2954c9a238
Handle duplicate negatable options 2021-01-05 12:54:42 +01:00
Christian Flothmann
a33850e838 make some time dependent tests more resilient 2021-01-05 10:09:27 +01:00
Fabien Potencier
a0bbf53ebb feature #39642 [Console] Support binary / negatable options (greg-1-anderson, jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Console] Support binary / negatable options

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #24314
| License       | MIT
| Doc PR        | TODO

This PR take over #26292 to introduce a new option mode `NEGATABLE` that ease creation of option and their negation (ie. `--foo`, `--no-foo`)

Negated options applies only to flag options (`VALUE_NONE`)
```
./cli.php --foo
var_dump(getOption('foo')); // true

./cli.php --no-foo
var_dump(getOption('foo')); // false
```

Commits
-------

1a9a3c34c9 Implement negatable option
8d455dbd0c [WIP] Implements #24314: Support binary / negatable options, e.g. --foo and --no-foo.
2021-01-05 08:59:18 +01:00
Christian Flothmann
08fb696dbc fix code style 2021-01-05 08:52:01 +01:00
Jérémy Derussé
1a9a3c34c9
Implement negatable option 2021-01-05 08:47:01 +01:00
Fabien Potencier
e1b81d513e bug #39716 [DependencyInjection] do not break when loading schemas from network paths on Windows (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] do not break when loading schemas from network paths on Windows

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #24090
| License       | MIT
| Doc PR        |

Commits
-------

acbafe889d do not break when loading schemas from network paths on Windows
2021-01-05 07:35:25 +01:00
Fabien Potencier
47e4b8e152 feature #39051 [WebProfilerBundle] Possibility to dynamically set mode (brusch)
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[WebProfilerBundle] Possibility to dynamically set mode

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| License       | MIT

Sometimes it is necessary to dynamically decide whether the debug toolbar should be injected or not.

Commits
-------

7c5cf579bb [WebProfilerBundle] Possibility to dynamically set mode
2021-01-05 07:30:58 +01:00
Bernhard Rusch
7c5cf579bb [WebProfilerBundle] Possibility to dynamically set mode 2021-01-05 07:30:52 +01:00
Fabien Potencier
b302ebc619 Merge branch '4.4' into 5.1
* 4.4:
  Remove full head content in HTML to text converter
  apply the sort callback on the whole search result
2021-01-05 07:22:18 +01:00
Fabien Potencier
70ed00325d feature #39701 [Lock] Create flock directory (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Lock] Create flock directory

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #35697
| License       | MIT
| Doc PR        | -

Automatically create the flock directory when does not exists

Commits
-------

be22c37ea1 Create flock directory
2021-01-05 07:21:05 +01:00
Fabien Potencier
1dead9a518 bug #39703 [Finder] apply the sort callback on the whole search result (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Finder] apply the sort callback on the whole search result

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34879
| License       | MIT
| Doc PR        |

Commits
-------

126105146f apply the sort callback on the whole search result
2021-01-05 07:04:52 +01:00
Fabien Potencier
ef11c2c6b4 bug #39717 [TwigBridge] Remove full head content in HTML to text converter (pupaxxo)
This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBridge] Remove full head content in HTML to text converter

When extracting text from HTML part all the content between opening and closing tag should be removed

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       |  <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
-->

Without the `s` flag the preg_replace match only head (or style) tags on a single line

Commits
-------

9e6baee9f3 Remove full head content in HTML to text converter
2021-01-05 07:02:58 +01:00
Andrea Ruggiero
9e6baee9f3
Remove full head content in HTML to text converter
When extracting text from HTML part all the content between opening and closing tag should be removed
2021-01-04 22:15:57 +01:00
Christian Flothmann
acbafe889d do not break when loading schemas from network paths on Windows 2021-01-04 20:26:31 +01:00
Christian Flothmann
8f0ba2a438 Merge branch '5.2' into 5.x
* 5.2:
  allow HttpKernel 5.x
2021-01-04 19:43:40 +01:00
Christian Flothmann
3e376a1d87 Merge branch '5.1' into 5.2
* 5.1:
  allow HttpKernel 5.x
2021-01-04 19:43:21 +01:00
Christian Flothmann
4468d6d19a minor #39715 [Cache] allow HttpKernel 5.x (xabbuh)
This PR was merged into the 5.1 branch.

Discussion
----------

[Cache] allow HttpKernel 5.x

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

47385a150f allow HttpKernel 5.x
2021-01-04 19:42:29 +01:00
Christian Flothmann
47385a150f allow HttpKernel 5.x 2021-01-04 19:39:57 +01:00
Nicolas Grekas
17eaad20d1 Merge branch '5.2' into 5.x
* 5.2:
  Cleanup CI scripts
  use the clock mock to make test more resilient
  fix code style
  fix code style
  take query and request parameters into account when matching routes
  mistake
  throw type error when incompatible types are passed
  fix tests to run assertions on returned Crawler instances
  [FrameworkBundle] Fix UidNormalizer priority
  propagate groups to nested constraints
2021-01-04 19:20:06 +01:00
Nicolas Grekas
85af7a2974 bug #39672 [FrameworkBundle] Fix UidNormalizer priority (fancyweb)
This PR was merged into the 5.2 branch.

Discussion
----------

[FrameworkBundle] Fix UidNormalizer priority

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`AbstractUid` implements `\JsonSerializable`. `JsonSerializableNormalizer` has a priority of `-900`, so it's actually this normalizer that is used instead of the good one. It does not change the result but it adds an extra layer.

Commits
-------

1c652a7649 [FrameworkBundle] Fix UidNormalizer priority
2021-01-04 19:02:28 +01:00
Nicolas Grekas
1e8fe94fff minor #39695 [PropertyAccess] throw type error when incompatible types are passed (xabbuh)
This PR was merged into the 5.2 branch.

Discussion
----------

[PropertyAccess] throw type error when incompatible types are passed

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

4c5cff6558 throw type error when incompatible types are passed
2021-01-04 19:01:42 +01:00
Nicolas Grekas
51d2da706e Merge branch '5.1' into 5.2
* 5.1:
  Cleanup CI scripts
  fix code style
  fix code style
  take query and request parameters into account when matching routes
  mistake
  fix tests to run assertions on returned Crawler instances
  propagate groups to nested constraints
2021-01-04 18:59:10 +01:00
Nicolas Grekas
929b4b5903 bug #39649 [Validator] propagate groups to nested constraints (xabbuh)
This PR was merged into the 5.1 branch.

Discussion
----------

[Validator] propagate groups to nested constraints

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39386
| License       | MIT
| Doc PR        |

Commits
-------

13a4610824 propagate groups to nested constraints
2021-01-04 18:36:57 +01:00