Fabien Potencier
74c24a5315
minor #15814 [WebProfilerBundle] fixed cursor as pointer when hovering over link. (aitboudad)
...
This PR was merged into the 2.8 branch.
Discussion
----------
[WebProfilerBundle] fixed cursor as pointer when hovering over link.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Fixed tickets | ~
| Tests pass? | yes
| License | MIT
Commits
-------
ac7591f
[WebProfilerBundle] added btn-link.
2015-09-22 14:44:41 +02:00
Abdellatif Ait boudad
ac7591f505
[WebProfilerBundle] added btn-link.
2015-09-16 12:52:37 +00:00
Nicky De Maeyer
534c5db3a3
bug #15811 use of twig deprecated sameas test
2015-09-16 11:31:47 +02:00
John Bafford
62dc0147bf
Remove minimum width for web profiler content view
2015-09-15 16:21:23 -04:00
Fabien Potencier
6393ec3169
Merge branch '2.7' into 2.8
...
* 2.7:
[DomCrawler] Invalid uri created from forms if base tag present
[Console] update param type phpdoc for StreamOutput
[Console] fix typo in OutputInterface
Use stderr by default when a specific output is not injected
[Debug] Fix case mismatch detection
[HttpKernel] fix broken multiline <esi:remove>
[DoctrineBridge] Fixed #14840
[FrameworkBundle] add a suggest for the serializer component
[Yaml] Fix the parsing of float keys
[Console] Ensure the console output is only detected as decorated when both stderr and stdout support colors
[HttpKernel] fix DumpDataCollector compat with Twig 2.0
Improve exception messages.
Fix that two DirectoryResources with different patterns would be deduplicated
Tests fix clockmock
[WebProfilerBundle] Added tabindex="-1" to not interfer with normal UX
missing "YAML" in the exception message.
[Translator][warmup][fallback locales] fixed missing cache file generation.
[framework-bundle] Add Test for TranslationUpdateCommand
Use ObjectManager interface instead of EntityManager
2015-09-14 16:15:17 +02:00
Fabien Potencier
cafd4af7cd
Merge branch '2.3' into 2.7
...
* 2.3:
[DomCrawler] Invalid uri created from forms if base tag present
[Console] update param type phpdoc for StreamOutput
[Console] fix typo in OutputInterface
[HttpKernel] fix broken multiline <esi:remove>
[DoctrineBridge] Fixed #14840
[FrameworkBundle] add a suggest for the serializer component
[Yaml] Fix the parsing of float keys
[Console] Ensure the console output is only detected as decorated when both stderr and stdout support colors
Improve exception messages.
Fix that two DirectoryResources with different patterns would be deduplicated
Tests fix clockmock
[WebProfilerBundle] Added tabindex="-1" to not interfer with normal UX
missing "YAML" in the exception message.
[framework-bundle] Add Test for TranslationUpdateCommand
Use ObjectManager interface instead of EntityManager
2015-09-14 16:14:09 +02:00
Fabien Potencier
a2eebe8128
feature #15523 Redesigned the Symfony Profiler (javiereguiluz)
...
This PR was squashed before being merged into the 2.8 branch (closes #15523 ).
Discussion
----------
Redesigned the Symfony Profiler
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
### Context
Recently, we redesigned the web debug toolbar ([read announcement](http://symfony.com/blog/new-in-symfony-2-8-redesigned-web-debug-toolbar )). We maintained "the spirit" of the original toolbar, but its visual appearance was completely changed.
Now it's the turn of the Symfony Profiler. We want to update it to match the new toolbar design and to give it a more modern look and feel.
### The redesign
Most of the redesign is focused on updating just the visual appearance, but we've seized this opportunity to make some minor functional changes as well. Testing this pull request in your own applications may be difficult, so we'll provide below a complete walkthrough of the redesign. (Click on the images to see them in full resolution)
### Overview
This is the new general structure of the profiler pages:
![profiler-structure](https://cloud.githubusercontent.com/assets/73419/9226162/c1bf71f0-410d-11e5-8a7b-5c690b7c8c8a.png )
### Request panel
* Renamed `Request` panel to `Request / Response`
* Divided contents into tabs: Request, Response, Session, etc. (this prevents ultra long pages)
![profiler-request](https://cloud.githubusercontent.com/assets/73419/9226172/cb7f7938-410d-11e5-8ffd-cea8264446dd.png )
### Timeline panel
* Renamed `Timeline` panel to `Performance`
* Highlighted the most important metrics
* Added "Peak Memory Usage" to those metrics
* The timeline graph is now easier to read (font size is slightly larger, updated the color palette, made the canvas wider, etc.)
* If there is only one request, the page doesn't distract you with the "Master Request" heading. If there are several sub-requests, headings are now bigger and graphs are more separated.
![profiler-performance](https://cloud.githubusercontent.com/assets/73419/9226178/d1335782-410d-11e5-9f9a-5ace45b0dfa0.png )
### Twig panel
* Just a minor update to highlight the important metrics. The rest of the contents remain the same.
![profiler-twig](https://cloud.githubusercontent.com/assets/73419/9226180/d5bd6ff4-410d-11e5-86c8-beba426516c1.png )
### Exception panel
* Just minor design tweaks.
![profiler-exception](https://cloud.githubusercontent.com/assets/73419/9226182/da0dfd9e-410d-11e5-965c-e980f7144541.png )
### Events panel
When the `framework.ide` config option is set:
* The listeners are now displayed as more evident clickable links.
* Bellow the listener we show its full class namespace (if you don't need this information, it doesn't distract you much; if you need it, you don't have to wait for the `<abbr>` tooltip to show it)
![profiler-events-links-enabled](https://cloud.githubusercontent.com/assets/73419/9226188/e403ae48-410d-11e5-8c86-5d28fed940e7.png )
When the `framework.ide` config option is NOT set:
* In this case the developer cannot click on the listener name to go to that file and line. Therefore, we think it's important to display that information (full class namespace + full file path + line number). At first it may seem that it contains too much information ... but this panel should be more "useful" than "beautiful".
![profiler-events-links-disabled](https://cloud.githubusercontent.com/assets/73419/9226198/eb9f3bae-410d-11e5-8bbe-95c148809387.png )
### Logs panel
* Logs are now grouped in: "Info. & Errors" (this is the panel that you need most of the times); "Deprecations" (separated from the normal logs because they are specific to the process of updating your Symfony version); and "Debug" (which are all those messages that you almost never need)
* We now show the channel for the log messages (for built-in Symfony channels it may be redundant, but your application can define custom channels)
![profiler-logger](https://cloud.githubusercontent.com/assets/73419/9226203/f345163a-410d-11e5-85e6-cf9fceb885fc.png )
### Routing panel
* Just a minor redesign and highlighted some information.
![profiler-routing](https://cloud.githubusercontent.com/assets/73419/9226213/00e99130-410e-11e5-90c0-dda9394dabd7.png )
### Forms panel
* Not redesigned yet.
### Translation panel
* Highlighted the important metrics.
* Replaced the old selector by the new tabbed navigation.
![profiler-translation](https://cloud.githubusercontent.com/assets/73419/9226215/06036c40-410e-11e5-90c9-fe3b43dd6156.png )
### Security panel
* Just a minor redesign and highlighted some information.
![profiler-security](https://cloud.githubusercontent.com/assets/73419/9226217/0a92fbcc-410e-11e5-9438-e9e230a7865b.png )
### E-mails panel
* Not redesigned yet.
### Doctrine panel
* Queries are no longer displayed "shrinked". We display the full query without parameters by default.
* The three old actions ("expand", "runnable" and "explain") have been reduced to two actions ("runnable" and "explain")
![profiler-doctrine](https://cloud.githubusercontent.com/assets/73419/9226225/13e0b5d4-410e-11e5-96ce-1eb67f99df49.png )
Here you can see what happens when you click on the "Show runnable query" and "Explain query" links:
![profiler-doctrine-detail](https://cloud.githubusercontent.com/assets/73419/9226247/33b47918-410e-11e5-9657-e1351787657a.png )
### Debug panel
* Not redesigned yet.
### Config panel
* This was probably the "ugliest" panel in the old profiler, because of the two first tables.
* We now display the information of those tables highlighted in a different way.
![profiler-config](https://cloud.githubusercontent.com/assets/73419/9226257/3d728850-410e-11e5-86d8-da807f6a1217.png )
### Search results
Results with response status different from 2xx now are highlighted:
![profiler-search-results](https://cloud.githubusercontent.com/assets/73419/9226279/44bacd8e-410e-11e5-8daf-e77d2be7e3c6.png )
### Other design elements
The page title now changes for each section:
**Before**
![page-title-before](https://cloud.githubusercontent.com/assets/73419/9226312/6301b9c4-410e-11e5-8ef7-001be222ac53.png )
**After**
![page-title-after](https://cloud.githubusercontent.com/assets/73419/9226316/693bce42-410e-11e5-897a-c5e4413bc638.png )
Empty elements now display a dashed border. This allows to make design more consistent between different section. Besides, once you are used to the new design, your brain will immediately associate that design to an empty element, so you'll no longer need to read the inner text content.
![profiler-empty-element](https://cloud.githubusercontent.com/assets/73419/9226400/c9ffe06a-410e-11e5-9859-f095e444d9af.png )
Besides, when the entire panel doesn't have any content, its menu label looks disabled:
![sidebar-menu](https://cloud.githubusercontent.com/assets/73419/9226405/cf4ee5e8-410e-11e5-9501-523cd6b3413e.png )
Long pages have been break down using a tabs-based navigation:
![tabbed-navigation](https://cloud.githubusercontent.com/assets/73419/9226409/d918dba6-410e-11e5-9cd4-516a082950de.gif )
Below the page header we display a "summary section" which displays the profiled URL and some useful profiling information. The big URL is the natural way to "go back to application" from the profiler:
![summary-back-to-application](https://cloud.githubusercontent.com/assets/73419/9226414/df1abb00-410e-11e5-88ff-59dbd35b584f.gif )
Besides, the summary background color changes according to the response HTTP status code:
![profiler-summary](https://cloud.githubusercontent.com/assets/73419/9226423/e5b03850-410e-11e5-9163-2f2153c5d1de.png )
Above the main menu we now display two shortcuts to common operations: "display the 10 most recent profiles" and "search profiles":
![sidebar-shortcuts](https://cloud.githubusercontent.com/assets/73419/9226427/eaea4586-410e-11e5-8ff4-f6141723996a.png )
The search form in the sidebar has been collapsed and it's revealed when clicking on the "Search" shortcut button:
![search-form-reveal](https://cloud.githubusercontent.com/assets/73419/9226435/ef907fec-410e-11e5-9627-37cb2a241f86.gif )
-----
And that's all! Please tell us what you think about this redesign. **Don't hesitate to criticize anything you don't like or think it's wrong or it's worse than in the previous profiler.** Let's work together to make the new profiler a reality! Thanks!
Commits
-------
05773c2
Redesigned the Symfony Profiler
2015-09-14 08:10:06 +02:00
Javier Eguiluz
05773c263b
Redesigned the Symfony Profiler
2015-09-14 08:10:04 +02:00
AlberT
53cdb1a420
[WebProfilerBundle] Added tabindex="-1" to not interfer with normal UX
2015-09-10 10:15:17 +02:00
Fabien Potencier
0383559f95
feature #15709 [WebProfilerBundle] deprecated import/export commands (fabpot)
...
This PR was merged into the 2.8 branch.
Discussion
----------
[WebProfilerBundle] deprecated import/export commands
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | part of #11742
| License | MIT
| Doc PR | n/a
Commits
-------
943fec9
[HtppKernel] deprecated Profiler::import/export
17e00b9
[WebProfilerBundle] deprecated import/export commands
2015-09-09 23:21:50 +02:00
Fabien Potencier
943fec97d3
[HtppKernel] deprecated Profiler::import/export
2015-09-09 22:55:09 +02:00
Omar Yepez
8497ad7ce9
[WebProfilerBundle ] Removes the ajax animation in | sf-toolbar-block-ajax
...
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | n/a
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
The change removes the animation in the "sf-toolbar-block-ajax" when the request state was "ok".
2015-09-09 15:09:41 -04:30
Fabien Potencier
17e00b9b8e
[WebProfilerBundle] deprecated import/export commands
2015-09-07 15:21:37 +02:00
Nicolas Grekas
922a534427
Merge branch '2.7' into 2.8
...
* 2.7:
Mark deprecated Twig functions as deprecated with the Twig feature
[appveyor] PHP 5.3.11 for Symfony 2.7
[HttpKernel] Group deprecation notices
Conflicts:
appveyor.yml
2015-09-01 09:33:03 +02:00
Nicolas Grekas
8d6e337602
[HttpKernel] Group deprecation notices
2015-08-31 14:42:37 +02:00
Fabien Potencier
aad7963ede
Merge branch '2.7' into 2.8
...
* 2.7:
fixes CS
2015-08-24 09:18:02 +02:00
Fabien Potencier
c25e054d9e
minor #15597 fixes CS (fabpot)
...
This PR was merged into the 2.7 branch.
Discussion
----------
fixes CS
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
c0e4495
fixes CS
2015-08-24 09:16:32 +02:00
Fabien Potencier
c0e4495b66
fixes CS
2015-08-24 09:13:45 +02:00
Fabien Potencier
472b374790
Merge branch '2.7' into 2.8
...
* 2.7:
fixed Twig deprecations
replaced deprecated Twig sameas test by same as
fixed a namespace in the upgrade file
2015-08-23 18:16:48 +02:00
Fabien Potencier
7b64354058
fixed Twig deprecations
2015-08-23 17:59:39 +02:00
Fabien Potencier
99a1fcc3e2
replaced deprecated Twig sameas test by same as
2015-08-23 09:32:15 +02:00
Fabien Potencier
1fc31243de
Merge branch '2.7' into 2.8
...
* 2.7:
[Form] fixed BC-break on grouped choice lists
[WebProfilerBundle] add import for Twig macro
made Symfony compatible with both Twig 1.x and 2.x
[Debug/VarDumper] minor cleanups
[Form] only use PropertyPath if not already callable
[Form] fix reworked choice list phpdoc
[DoctrineBridge][Form] Add old tests to legacy group
Fixed warning when command alias is longer than command name
removed _self usage when not needed
Implement the support of timezone objects in the stub IntlDateFormatter
typofix - https://github.com/vlajos/misspell_fixer
make doctrine mappings compiler pass exception message more understandable
fix debug-ext 003.phpt
[Yaml] Nested merge keys
[FrameworkBundle] [Command] removed unused variable.
[Debug] Enhance DebugClassLoader performance on MacOSX
Add support for variadic arguments in the GetSetNormalizer
[DoctrineBridge][Form] Fix IdReader when indexing by primary foreign key
[DoctrineBridge][Form] Fix EntityChoiceList when indexing by primary foreign key
2015-08-22 09:42:07 +02:00
Fabien Potencier
e25aca7072
Merge branch '2.3' into 2.7
...
* 2.3:
made Symfony compatible with both Twig 1.x and 2.x
2015-08-22 09:41:51 +02:00
Christian Flothmann
17950711a2
[WebProfilerBundle] add import for Twig macro
2015-08-22 09:00:15 +02:00
Fabien Potencier
a5c7a85b78
made Symfony compatible with both Twig 1.x and 2.x
2015-08-18 14:26:23 +02:00
Fabien Potencier
3d0577d1d2
removed _self usage when not needed
2015-08-11 17:34:43 +02:00
Christophe Coevoet
4fefd3d1e7
Remove the duplicated rendering of deprecation messages in the profiler
2015-08-02 01:52:06 +02:00
Javier Eguiluz
5a571b6eca
Reordered the toolbar elements via service priorities
2015-07-31 17:06:53 +02:00
Javier Eguiluz
f237ff1913
Increased the z-index of .sf-toolbar-info
2015-07-31 15:42:14 +02:00
Javier Eguiluz
b3ad83da01
Removed an unused media query
2015-07-31 15:37:44 +02:00
Javier Eguiluz
b438ee5482
Redesigned "abbr" elements
2015-07-31 15:19:54 +02:00
Javier Eguiluz
7d92cb8a02
Restored the old behavior for toolbars with lots of elements
...
If a toolbar includes lots of elements, some of them may
span to a new line, increasing the height of the toolbar
2015-07-31 15:08:06 +02:00
Javier Eguiluz
597637ecea
Tweaks and bug fixes
2015-07-31 13:11:01 +02:00
Javier Eguiluz
22f6bc5003
Removed an useless CSS class and added styles for <hr>
2015-07-30 15:15:53 +02:00
Javier Eguiluz
5070861326
Added a new profiler_markup_version to improve BC of the new toolbar
2015-07-30 13:21:10 +02:00
Javier Eguiluz
2fb33191fe
Removed an unused import
2015-07-30 09:30:53 +02:00
Javier Eguiluz
7ec1cd491d
Reverted the feature to display different toolbar versions
2015-07-30 09:29:46 +02:00
Javier Eguiluz
084cca644d
Minor JavaScript optimizations
2015-07-30 09:29:45 +02:00
Javier Eguiluz
972a92e778
Misc. tweaks and improvements
2015-07-30 09:29:45 +02:00
Javier Eguiluz
ebb44e4832
Added some styles to make old panels look better in the new design
2015-07-30 09:29:45 +02:00
Javier Eguiluz
1847285322
Pass the toolbar version number from the controller, to ease transition and keep BC
2015-07-30 09:29:45 +02:00
Javier Eguiluz
a0e03f6b2c
Minor tweaks
2015-07-30 09:29:45 +02:00
Javier Eguiluz
002dda5bd3
Fixed toolbar issues when displaying it inside the profiler
2015-07-30 09:29:45 +02:00
Javier Eguiluz
e94a6a02b1
Smaller font sizes for smartphones, fixed request status padding issue
...
and make too long panels always be displayed at the leftmost part of browser window
2015-07-30 09:29:45 +02:00
Javier Eguiluz
9b585b9808
Made the close icon a bit smaller
2015-07-30 09:29:44 +02:00
Javier Eguiluz
3ab2e20913
fixed all vertical aligning issues and tweaked icons
2015-07-30 09:29:44 +02:00
Javier Eguiluz
f087ac0bcd
More vertical aligning fixes
2015-07-30 09:29:44 +02:00
Javier Eguiluz
9e38a8aa96
Minor CSS tweaks and made font sizes bigger
2015-07-30 09:29:44 +02:00
Javier Eguiluz
0dfcb602ef
Fixed an issue with the Config panel in the Profiler view
2015-07-30 09:29:44 +02:00
Javier Eguiluz
cd53210161
Fixed another z-index issue
2015-07-30 09:29:44 +02:00