Commit Graph

31975 Commits

Author SHA1 Message Date
Michael Babker
76dc317e03 Removed ContextErrorException 2017-07-06 07:23:02 -05:00
Nicolas Grekas
1c1a86f897 Merge remote-tracking branch 'origin/master'
* origin/master:
  [Yaml] Support tagged scalars
2017-07-06 13:50:42 +03:00
Nicolas Grekas
a41600710f Merge branch '3.4'
* 3.4:
  Deprecate support for stacked errors
  fixed tests
  [HttpFoundation] Find the original request protocol version
  fixed CS
  Add support for microseconds in Stopwatch
  Preserve HttpOnly value when deserializing a header
  add minimum and maximum amount of pixels to Image validator
  fixed CHANGELOG
  [DX] [TwigBundle] Enhance the new exception page design
  [BrowserKit] Emulate back/forward browser navigation
  Fix deprecated message
  [Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer
  [Validator] improve the changelog
  [FrameworkBundle] Wire inner translator
  [FrameworkBundle][HttpKernel] Move addcachearmer, addcacheclearer compiler pass
  [FrameworkBundle][Translation] Move translation compiler pass
2017-07-06 13:49:06 +03:00
Fabien Potencier
c5cbc83a59 feature #22762 [Yaml] Support tagged scalars (GuilhemN)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Yaml] Support tagged scalars

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes, replacement of deprecations
| BC breaks?    | yes
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Add support of tagged scalars in 4.0.

Commits
-------

b1e8ebc6ac [Yaml] Support tagged scalars
2017-07-06 13:27:33 +03:00
Nicolas Grekas
47ee1d53c1 Merge branch '3.3' into 3.4
* 3.3: (33 commits)
  Preserve HttpOnly value when deserializing a header
  [DX] [TwigBundle] Enhance the new exception page design
  Fix deprecated message
  [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
  bumped Symfony version to 3.3.5
  updated VERSION for 3.3.4
  updated CHANGELOG for 3.3.4
  [VarDumper] Reduce size of serialized Data objects
  bumped Symfony version to 3.2.12
  updated VERSION for 3.2.11
  updated CHANGELOG for 3.2.11
  fixed bad merge
  Fix indent of methods
  [Cache] Handle APCu failures gracefully
  [DoctrineBridge] Use normalizedIds for resetting entity manager services
  [FrameworkBundle] Do not remove files from assets dir
  [FrameworkBundle] 3.3: Don't get() private services from debug:router
  bumped Symfony version to 3.3.4
  updated VERSION for 3.3.3
  updated CHANGELOG for 3.3.3
  ...
2017-07-06 13:23:40 +03:00
Nicolas Grekas
7ac2570d5c feature #22832 [Debug] Deprecate support for stacked errors (mbabker)
This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] Deprecate support for stacked errors

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #22804
| License       | MIT
| Doc PR        | n/a

Per discussion in #22804 this deprecates support for error stacking.  // @nicolas-grekas

Commits
-------

04b8b80 Deprecate support for stacked errors
2017-07-06 13:21:47 +03:00
Michael Babker
04b8b8027c Deprecate support for stacked errors 2017-07-06 13:08:05 +03:00
Fabien Potencier
26641bdf44 fixed tests 2017-07-06 12:58:45 +03:00
Fabien Potencier
4f187ced94 feature #21469 [HttpFoundation] Find the original request protocol version (thewilkybarkid)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #21469).

Discussion
----------

[HttpFoundation] Find the original request protocol version

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21415
| License       | MIT
| Doc PR        |

Adds a new method to `Request` to find the original protocol version from the `Via` header, if the request is from a trusted proxy.

Commits
-------

5a37f84713 [HttpFoundation] Find the original request protocol version
2017-07-06 12:57:48 +03:00
Chris Wilkinson
5a37f84713 [HttpFoundation] Find the original request protocol version 2017-07-06 12:57:36 +03:00
Fabien Potencier
a20426dded fixed CS 2017-07-06 12:41:12 +03:00
Fabien Potencier
984c1c724c minor #23427 [WebProfilerBundle] Remove deprecated TemplateManager::getTemplates() (maidmaid)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[WebProfilerBundle] Remove deprecated TemplateManager::getTemplates()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/20484
| License       | MIT
| Doc PR        | /

Commits
-------

f8be69da5f Remove TemplateManager::getTemplates()
2017-07-06 12:40:22 +03:00
Fabien Potencier
76858808ad fixed CS 2017-07-06 12:37:30 +03:00
Fabien Potencier
77963313ee feature #23431 [Validator] Add min/max amount of pixels to Image constraint (akeeman)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add min/max amount of pixels to Image constraint

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/7756

Useful for asserting image sizes/areas in pixels, for instance to estimate processing work load.

**This PR continues #22288**. I cleaned up my associated branch a while ago and found no way of restoring or re-linking.

@fabpot: "Could you rename to [TOO_FEW_PIXEL_ERROR](9ab5263d71/src/Symfony/Component/Validator/Constraints/Image.php (L28))? Same for the other constant?"
This is done.
@fabpot "Can you change the base to 3.4 instead of master and rebase on current 3.4? Thanks."
This is done too.

Commits
-------

9ab5263d71 add minimum and maximum amount of pixels to Image validator
2017-07-06 12:36:39 +03:00
Fabien Potencier
71c6f9962b bug #23426 Fixed HttpOnly flag when using Cookie::fromString() (Toflar)
This PR was merged into the 3.3 branch.

Discussion
----------

Fixed HttpOnly flag when using Cookie::fromString()

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23424
| License       | MIT
| Doc PR        | -

Using `Cookie::fromString()` should not set the `HttpOnly` flag to `true` by default. This is a factory method and it should create an instance of `Cookie` that represents exactly what the string contains.

Commits
-------

73187d0003 Preserve HttpOnly value when deserializing a header
2017-07-06 12:19:04 +03:00
Dany Maillard
f8be69da5f Remove TemplateManager::getTemplates() 2017-07-06 11:15:46 +02:00
Fabien Potencier
82036a388b feature #23223 Add support for microseconds in Stopwatch (javiereguiluz)
This PR was squashed before being merged into the 3.4 branch (closes #23223).

Discussion
----------

Add support for microseconds in Stopwatch

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no?
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18756
| License       | MIT
| Doc PR        | -

Stopwatch component already supports microseconds (and nanoseconds, etc.) ... but the problem is that it converts the millisecond times to integers, so anything smaller to 1 millisecond is lost. This PR changes that to fix issues like the one explained in #18756.

### Before
![before-stopwatch](https://user-images.githubusercontent.com/73419/27279393-c745db54-54e4-11e7-8f26-01e2063604ce.png)

### After

![after-stopwatch](https://user-images.githubusercontent.com/73419/27279396-c8894dac-54e4-11e7-9a3a-bff027377047.png)

Commits
-------

0db8d7fb6a Add support for microseconds in Stopwatch
2017-07-06 12:15:02 +03:00
Javier Eguiluz
0db8d7fb6a Add support for microseconds in Stopwatch 2017-07-06 12:14:58 +03:00
Yanick Witschi
73187d0003 Preserve HttpOnly value when deserializing a header
The specification states that the cookie should be considered http only if and
only if the flag is present.
See https://www.owasp.org/index.php/HttpOnly
2017-07-06 11:04:09 +02:00
Arjan Keeman
9ab5263d71 add minimum and maximum amount of pixels to Image validator 2017-07-06 11:02:57 +02:00
Fabien Potencier
fd01d7a1cf fixed CHANGELOG 2017-07-06 10:45:45 +03:00
Fabien Potencier
48bb1953b9 minor #23422 [Ldap] Fix deprecated message (maidmaid)
This PR was merged into the 3.3 branch.

Discussion
----------

[Ldap] Fix deprecated message

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/20390 https://github.com/symfony/symfony/pull/23402
| License       | MIT
| Doc PR        | /

``RenameEntryInterface`` is **deprecated** in 3.3 and **removed/merged** in 4.0.

Commits
-------

bbd0c7f69f Fix deprecated message
2017-07-06 10:41:24 +03:00
Fabien Potencier
626e9875a2 bug #22439 [DX] [TwigBundle] Enhance the new exception page design (sustmi)
This PR was squashed before being merged into the 3.3 branch (closes #22439).

Discussion
----------

[DX] [TwigBundle] Enhance the new exception page design

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

- [x] Fix the problem with wrapping wide lines (https://github.com/symfony/symfony/pull/20951#issuecomment-292201983)

I got motivated by recent PR https://github.com/symfony/symfony/pull/20951 and redesigned the exception page even more.

Compare before: ![before](https://cloud.githubusercontent.com/assets/885946/25052220/0756b74e-2151-11e7-98b6-c99fd9eaabec.png)
with after: ![after](https://cloud.githubusercontent.com/assets/885946/25052225/0c76581a-2151-11e7-96ff-eb502ee8e97b.png)
(Ignore the the "sf" toolbar icon in the middle of the page. This is how Firefox does full-page screenshots.)

The most noticeable changes:
- removed double line spacing (it just does not feel natural)
- file context increased from 3 to 10 lines (it helps me to better orientate in the code)
- added horizontal scrollbar for the cases when the code is wider
- the highlighted line color is more saturated in order to be noticed easily

Commits
-------

43212b9a90 [DX] [TwigBundle] Enhance the new exception page design
2017-07-06 10:10:35 +03:00
Miroslav Sustek
43212b9a90 [DX] [TwigBundle] Enhance the new exception page design 2017-07-06 10:10:33 +03:00
Fabien Potencier
0d06bbc3d3 feature #22341 [BrowserKit] Emulate back/forward browser navigation (e-moe)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #22341).

Discussion
----------

[BrowserKit] Emulate back/forward browser navigation

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22336
| License       | MIT
| Doc PR        | CHANGELOG.md updated

Hi all, please review this code for emulating back/forward browser navigation (skip redirects). If code is ok I will add tests and docs

Commits
-------

680da44789 [BrowserKit] Emulate back/forward browser navigation
2017-07-06 10:09:10 +03:00
Nikolay Labinskiy
680da44789 [BrowserKit] Emulate back/forward browser navigation 2017-07-06 10:09:09 +03:00
Dany Maillard
bbd0c7f69f Fix deprecated message 2017-07-06 09:08:20 +02:00
Fabien Potencier
bfaf8a0fdc feature #22619 [FrameworkBundle][Translation] Move translation compiler pass (lepiaf)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle][Translation] Move translation compiler pass

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | part of #21284
| License       | MIT
| Doc PR        | n/a

move TranslationDumperPass, TranslationExtractorPass, TranslatorPass to Translation component.

Commits
-------

74c951fa04 [FrameworkBundle][Translation] Move translation compiler pass
2017-07-06 09:49:25 +03:00
Fabien Potencier
3981f9ba89 feature #22620 [FrameworkBundle][HttpKernel] Move httpkernel pass (lepiaf)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle][HttpKernel] Move httpkernel pass

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | part of #21284
| License       | MIT
| Doc PR        | n/a

Move addcachearmer, addcacheclearer compiler pass to httpkernel

Commits
-------

83727c7e3d [FrameworkBundle][HttpKernel] Move addcachearmer, addcacheclearer compiler pass
2017-07-06 09:43:51 +03:00
Fabien Potencier
b9d93c8a2a feature #23402 [Ldap] Remove the RenameEntryInterface interface (maidmaid)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Ldap] Remove the RenameEntryInterface interface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/20390
| License       | MIT
| Doc PR        | /

Commits
-------

5d35184d7a Remove the RenameEntryInterface interface
2017-07-06 09:30:00 +03:00
Fabien Potencier
6aa66444bc added missing type hints 2017-07-06 09:26:26 +03:00
Fabien Potencier
6065ba68eb Merge branch '3.3'
* 3.3:
  [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
  bumped Symfony version to 3.3.5
  updated VERSION for 3.3.4
  updated CHANGELOG for 3.3.4
  [VarDumper] Reduce size of serialized Data objects
  bumped Symfony version to 3.2.12
  updated VERSION for 3.2.11
  updated CHANGELOG for 3.2.11
  [DoctrineBridge] Use normalizedIds for resetting entity manager services
2017-07-06 09:25:25 +03:00
Fabien Potencier
7e93ccad3f Merge branch '3.2' into 3.3
* 3.2:
  [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
  bumped Symfony version to 3.2.12
  updated VERSION for 3.2.11
  updated CHANGELOG for 3.2.11
2017-07-06 09:25:00 +03:00
Fabien Potencier
15938b4ffd bug #23417 [DI][Security] Prevent unwanted deprecation notices when using Expression Languages (dunglas)
This PR was merged into the 3.2 branch.

Discussion
----------

[DI][Security] Prevent unwanted deprecation notices when using Expression Languages

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

052b8c3a04 [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
2017-07-06 09:23:57 +03:00
Fabien Potencier
f7bca74cef feature #23337 [Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer (jordscream)
This PR was merged into the 3.4 branch.

Discussion
----------

[Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | ?
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23314
| License       | MIT
| Doc PR        | symfony/symfony-docs

Deal it with Has Method for the Normalizer/Denormalizer

Commits
-------

a15829d524 [Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer
2017-07-06 09:04:02 +03:00
Kévin Dunglas
052b8c3a04
[DI][Security] Prevent unwanted deprecation notices when using Expression Languages 2017-07-05 22:19:23 +02:00
Jordan Samouh
a15829d524 [Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer 2017-07-05 15:47:26 -04:00
Fabien Potencier
94b6ec3092 bumped Symfony version to 3.3.5 2017-07-05 16:59:31 +03:00
Fabien Potencier
82f7cba3c2 Merge pull request #23414 from fabpot/release-3.3.4
released v3.3.4
2017-07-05 16:28:34 +03:00
Fabien Potencier
e81d5d17d6 updated VERSION for 3.3.4 2017-07-05 16:28:15 +03:00
Fabien Potencier
a7c9d1aca0 updated CHANGELOG for 3.3.4 2017-07-05 16:28:05 +03:00
Fabien Potencier
3e84f7d91d bug #23413 [VarDumper] Reduce size of serialized Data objects (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[VarDumper] Reduce size of serialized Data objects

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #23233
| License       | MIT
| Doc PR        | -

By using `Stub` objects a lot, especially for arrays, `Data` objects generate heavy serialized strings.
By implemeting `Serializable` on `Data`, this PR removes most of the boilerplate.

This PR also removes duplicate data in `LoggerDataCollector`, and reduces the backtrace of silenced errors to their 3 last items - which should be enough - and is otherwise responsible for a significant portion of the serialized payloads.

This is not the last possible step towards shrinking serialized profiles, but the next one is more complex -and maybe this one is good enough? Please give feedback if you can.

Commits
-------

70bd2bc41b [VarDumper] Reduce size of serialized Data objects
2017-07-05 16:24:26 +03:00
Nicolas Grekas
70bd2bc41b [VarDumper] Reduce size of serialized Data objects 2017-07-05 16:02:37 +03:00
Fabien Potencier
692acb4d64 bumped Symfony version to 3.2.12 2017-07-05 13:46:19 +03:00
Fabien Potencier
697ece8d9a Merge pull request #23408 from fabpot/release-3.2.11
released v3.2.11
2017-07-05 13:25:23 +03:00
Fabien Potencier
99e70b8cc0 updated VERSION for 3.2.11 2017-07-05 12:51:47 +03:00
Fabien Potencier
0cd605bdea updated CHANGELOG for 3.2.11 2017-07-05 12:51:40 +03:00
Dany Maillard
5d35184d7a Remove the RenameEntryInterface interface 2017-07-05 11:08:46 +02:00
Fabien Potencier
bef2142071 bug #23385 [DoctrineBridge] Fix resetting entity managers with case sensitive id (chalasr)
This PR was merged into the 3.3 branch.

Discussion
----------

[DoctrineBridge] Fix resetting entity managers with case sensitive id

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

9737bcc024 [DoctrineBridge] Use normalizedIds for resetting entity manager services
2017-07-05 09:55:44 +03:00
Fabien Potencier
e9dc82a794 Merge branch '3.3'
* 3.3: (21 commits)
  fixed bad merge
  Fix indent of methods
  [Cache] Handle APCu failures gracefully
  [FrameworkBundle] Do not remove files from assets dir
  [FrameworkBundle] 3.3: Don't get() private services from debug:router
  bumped Symfony version to 3.3.4
  updated VERSION for 3.3.3
  updated CHANGELOG for 3.3.3
  bumped Symfony version to 3.2.11
  updated VERSION for 3.2.10
  updated CHANGELOG for 3.2.10
  bumped Symfony version to 2.8.24
  updated VERSION for 2.8.23
  updated CHANGELOG for 2.8.23
  Don't access private services from container aware commands (deprecated)
  bumped Symfony version to 2.7.31
  updated VERSION for 2.7.30
  update CONTRIBUTORS for 2.7.30
  updated CHANGELOG for 2.7.30
  call setContainer() for autowired controllers
  ...
2017-07-05 09:52:15 +03:00