This PR was merged into the 2.7 branch.
Discussion
----------
Do not use HttpKernel Extension when not needed for 2.7
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
#17145 for new stuff in 2.7
Commits
-------
cc64c54 Do not use HttpKernel Extension when not needed for 2.7
* 2.3:
[2.7] Fixed flatten exception recursion with errors
Embedded identifier support
Change the ExtensionInterface load method definition to bo identical to the documentation.
add and correct armenian translations
[Config] Fix array sort on normalization in edge case
[Yaml] fix indented line handling in folded blocks
improve BrowserKit test coverage p1
This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] fix indented line handling in folded blocks
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9105
| License | MIT
| Doc PR |
Commits
-------
756834c [Yaml] fix indented line handling in folded blocks
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#17052).
Discussion
----------
[2.7] Fixed flatten exception recursion with errors
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Consider the following code:
```php
$error = new ParseError();
$exception = new RuntimeException($error->getMessage(), $error->getCode(), $error);
$flat = new Symfony\Component\Debug\Exception\FlattenException($exception);
```
Without this fix, that code is broken.
You'll end up with something like this:
```
FatalThrowableError in FlattenException.php line 76:
Type error: Argument 1 passed to Symfony\Component\Debug\Exception\FlattenException::create() must be an instance of Exception, instance of ParseError given
```
---
I came across this error issue in https://github.com/laravel/framework/issues/11329.
Commits
-------
2b0721d [2.7] Fixed flatten exception recursion with errors
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16826).
Discussion
----------
Embedded identifier support
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | n/a
If you define your entity identifier using an embeddable class the identifier name will contain period symbols in it such as `id.value` which will generate a syntax error in the DQL lexer because parameter names are not allowed to contain period symbols.
Example to reproduce described bug:
```php
/**
* @ORM\Embeddable
*/
class Identifier {
/**
* @ORM\Column(type="integer")
*/
protected $value;
}
/**
* @ORM\Entity
*/
class Entity {
/**
* @ORM\Id @ORM\Embedded(class="Identifier")
*/
protected $id;
}
```
Commits
-------
38fdda6 Embedded identifier support
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#17079).
Discussion
----------
Also transform inline mappings to objects
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17075
| License | MIT
| Doc PR | -
`$objectForMapping` was only applied to inlined mappings. It should be applied for multi-line mappings as well.
Commits
-------
61b863b Also transform inline mappings to objects
This PR was merged into the 2.7 branch.
Discussion
----------
[Serializer] Make metadata interfaces internal
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/17113#discussion_r48291776
| License | MIT
| Doc PR | n/a
Introducing such interfaces was a (my) mistake. Serializer metadata are value objects. Nobody will (nor should) implement these interfaces. Composition is better for "extending" metadata.
They were not marked as `@api` and should now be marked as `@internal` (or even deprecated but it will cause some maintenance headaches).
Commits
-------
3f6cfcd [Serializer] Make metadata interfaces internal
This PR was merged into the 2.3 branch.
Discussion
----------
[Config] Fix array sort on normalization in edge case
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Commits
-------
eca41a8 [Config] Fix array sort on normalization in edge case
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes#17131).
Discussion
----------
[DependencyInjection] Change the ExtensionInterface load method definition
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/5988
This PR change the `Symfony\Component\DependencyInjection\Extension\ExtensionInterface` load method definition to be identical to the documentation :
`public function load(array $configs, ContainerBuilder $container);`
Commits
-------
85c271b Change the ExtensionInterface load method definition to bo identical to the documentation.
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#16945).
Discussion
----------
add and correct armenian translations
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Commits
-------
54e6fb4 add and correct armenian translations
This PR was merged into the 2.3 branch.
Discussion
----------
improve BrowserKit test coverage p1
Hi,
This PR improves BrowserKit test coverage.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
I rebased previous PR https://github.com/symfony/symfony/pull/16549 to 2.3
Commits
-------
0261b48 improve BrowserKit test coverage p1
This PR was merged into the 2.7 branch.
Discussion
----------
[Security] Run tests on all PHP versions
Symfony 2.7 supports PHP >= 5.3.9. Since #17073 was merged to 2.7 now, we need to remove the checks for 5.3.7 again.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
4bec980 [Security] Run tests on all PHP versions
This PR was merged into the 2.7 branch.
Discussion
----------
[Console][2.7] Fix merge #17040
| Q | A
| ------------- | ---
| Fixed tickets | 6a92f4e03f (commitcomment-15080872)
| License | MIT
This change should not be merged in upper branches.
Commits
-------
211d589 [Console][2.7] Fix merge #17040
This PR was merged into the 2.3 branch.
Discussion
----------
[appveyor] Exit with failing status code
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
[Sometimes](https://ci.appveyor.com/project/fabpot/symfony/build/1.0.4272#L1103), tests fail on appveyor and I'd like to see the exit code. This does it.
Commits
-------
a6cfff5 [appveyor] Exit with failing status code
This PR was merged into the 2.7 branch.
Discussion
----------
[Process] Make tests more deterministic
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16988
| License | MIT
| Doc PR | -
This makes running the Process tests faster and more deterministic.
Commits
-------
0dc9389 [Process] Make tests more deterministic
* 2.3:
[PropertyAccess] Reorder elements array after PropertyPathBuilder::replace
[Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM
[Process] More robustness and deterministic tests
Conflicts:
src/Symfony/Component/Process/Process.php
src/Symfony/Component/Process/Tests/ProcessTest.php
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] More robustness and deterministic tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16988, #15617
| License | MIT
| Doc PR | -
Commits
-------
d1a178a [Process] More robustness and deterministic tests
This PR was merged into the 2.3 branch.
Discussion
----------
[PropertyAccess] Reorder elements array after PropertyPathBuilder::replace
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17102
| License | MIT
| Doc PR |
Commits
-------
d0c0294 [PropertyAccess] Reorder elements array after PropertyPathBuilder::replace
* 2.3:
Clean EOL whitespace
[travis] Fix
[Routing] Reduce memory usage of a high consuming test case
use requires annotation
skip bcrypt tests on incompatible platforms
Conflicts:
.travis.yml
