This PR was merged into the 2.1 branch.
Discussion
----------
[HttpFoundation] Fixed copy pasted comment from FlashBag in AttributeBag
| Q | A
| ------------- | ---
| Bug fix? | [no]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes] I assume : only changed a comment word
| License | MIT
Commits
-------
815eb61 [HttpFoundation] Fixed copy pasted comment from FlashBag in AttributeBag
This PR was merged into the 2.1 branch.
Discussion
----------
[Form] [Doctrine] [EntityChoiceList] idAsIndex should be true with a smallint id field.
When the id of an entity is a smallint, $this->idAsIndex should also be true.
It was not the case.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: should
License of the code: MIT
Commits
-------
673fd9b idAsIndex should be true with a smallint or bigint id field.
This PR was merged into the 2.1 branch.
Discussion
----------
[2.1][SecurityBundle] Fixed configuration exemple
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
2c7a99b [SecurityBundle] Fixed configuration exemple
This PR was merged into the 2.1 branch.
Discussion
----------
[Validator] [translation] updated Japanese translation for Validator component
| Q | A
| ------------- | ---
| Fixed tickets | N/A
| License | MIT
I will also update translations for new messages available after 2.2 once this request is merged.
Commits
-------
987aded [Validator][translation][japanese]replaced period to japanese one [Validator][translation][japanese]fixed japanese translation to more practical one [Validator][translation][japanese]fixed message ordering to be consistent with other languages [Validator][translation][japanese]added new validation messages in japanese translation
[Validator][translation][japanese]fixed japanese translation to more practical one
[Validator][translation][japanese]fixed message ordering to be consistent with other languages
[Validator][translation][japanese]added new validation messages in japanese translation
Added the possibility to to use '@@' as an escaping strategy for
parameters that should be treated as strings but start with '@'
(i.e. safe mailer passwords).
This PR was merged into the 2.1 branch.
Discussion
----------
[Form] made DefaultCsrfProvider using session_status() when available
| Q | A
| ------------- | ---
| Bug fix? | [on PHP 5.4]
| Tests pass? | [yes]
| License | MIT
Commits
-------
5afea04 [Form] made DefaultCsrfProvider using session_status() when available
This PR was merged into the 2.1 branch.
Commits
-------
e6b7515 [DomCrawler] added support for query string with slash
Discussion
----------
[DomCrawler] added support for query string with slash
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Link\getUri() failed to return correct uri when current query string contains slash
Test pass on branch 2.1 but fails on master
This PR was merged into the 2.1 branch.
Commits
-------
54609b9 [HttpCache] added a test (cached content should be kept after purging)
Discussion
----------
[HttpCache] added a test (cached content should be kept after purging)
closes#6830
This PR was squashed before being merged into the 2.1 branch (closes#7378).
Commits
-------
17dc2ff [HttpRequest] fixes Request::getLanguages() bug
Discussion
----------
[HttpRequest] fixes Request::getLanguages() bug
This PR adds to suported languages the first segment of all compouds languages codes.
When receiving `Accept-Language: en-us` header, accepted languages will now be `en, en_US`.
This should not be a BC break as most browsers already send the long **and** short versions of language codes... but some dont.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6928
This PR was merged into the 2.1 branch.
Commits
-------
bd38483 [Security] fixed HttpUtils class tests
Discussion
----------
[Security] fixed HttpUtils class tests
This fixes tests broken in #7325.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7325
This PR was merged into the 2.1 branch.
Commits
-------
f2ef6bc [FrameworkBundle] removed BC break
cc3a40e [FrameworkBundle] changed temp kernel name in cache:clear
7d87ecd [FrameworkBundle] fixed cahe:clear command's warmup
Discussion
----------
[FrameworkBundle] fixes cahe:clear command's warmup
Solution taken is to replace the last char of the cache directory name to create a temporary cache directory, this way the temporary cache path has the same length than the real one. I tested this on several projects, in dev and prod environments.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6203
---------------------------------------------------------------------------
by jfsimon at 2013-03-13T12:32:25Z
@toloco @gergelypolonkai @ghost-x47 @stewe it would be great if you could test this patch on your projects and report result!
---------------------------------------------------------------------------
by toloco at 2013-03-13T12:41:47Z
Im sorry but have the same...
Notice: unserialize(): Error at offset 155 of 174227 bytes in /home/tolopalmer/Projects/shareandcoach/app/bootstrap.php.cache line 915
---------------------------------------------------------------------------
by jfsimon at 2013-03-13T12:45:04Z
@toloco could you paste the backtrace in a gist? and maybe the concerned file?
---------------------------------------------------------------------------
by stof at 2013-03-13T13:11:47Z
@jfsimon You probably have the same issue with the name of the temporary kernel class
---------------------------------------------------------------------------
by jfsimon at 2013-03-13T13:36:13Z
@stof if you're right, it's a nightmare. It must be possible to write a parser/fixer for serialized objects, don't you think?
---------------------------------------------------------------------------
by toloco at 2013-03-13T14:22:56Z
Here you are the gist with the stack and the bootstrap.php.cache file
https://gist.github.com/toloco/5152581
---------------------------------------------------------------------------
by mpdude at 2013-03-13T20:08:08Z
@jfsimon Writing such a parser is painting yourself in the corner.
Use a temp kernel class name of the same length as a quick fix.
#7230 could bring a solution because we might be able to inject a different ConfigCache factory during the command that intercepts and substitutes Resources before they get written into the meta file. Not sure if that PR has a chance of being picked though.
---------------------------------------------------------------------------
by toloco at 2013-03-14T08:19:58Z
So guys? we are blocked with this problem, can I help you? I can provide more stacks if it's needed
---------------------------------------------------------------------------
by mpdude at 2013-03-14T10:05:05Z
@toloco Could you please post the /home/tolopalmer/Projects/shareandcoach/app/cache/dev/appDevUrlMatcher.php.meta file? That's the one that is broken.
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T10:15:20Z
@mpdude you can find its content in the gist https://gist.github.com/toloco/5152581 (1st file, 6th line)
---------------------------------------------------------------------------
by mpdude at 2013-03-14T10:24:55Z
@toloco That file should contain a serialized set of Resources, it's not in the Gist.
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T10:33:12Z
@mpdude it's more visible in the raw file: ttps://gist.github.com/toloco/5152581/raw/48a1a823b5c8e6ba03936a52e8dc0d0ff1888f8a/Error+
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T10:33:27Z
sorry: 48a1a823b5/Error+
---------------------------------------------------------------------------
by toloco at 2013-03-14T10:37:09Z
https://gist.github.com/toloco/5160317 here you are the appDevUrlMatcher.php and meta
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T10:51:46Z
@toloco I applied @mpdude's solution (have a temp kernel class name of the same length than the real one).
Could you test it to see if it fixes your problem?
---------------------------------------------------------------------------
by mpdude at 2013-03-14T10:58:46Z
@jfsimon Thanks!
@toloco If Jean-François' fix does not work, please make sure that the .meta file you posted was the broken one? I was able to unserialize it without problems.
---------------------------------------------------------------------------
by toloco at 2013-03-14T11:02:09Z
Man!!!! you are the fucking boss it works!!
---------------------------------------------------------------------------
by mpdude at 2013-03-14T11:04:30Z
@jfsimon you just made someone happy.
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T11:12:39Z
@toloco @mpdude \o/
This PR was squashed before being merged into the 2.1 branch (closes#7297).
Commits
-------
ef53456 [DoctrineBridge] Avoids blob values to be logged by doctrine
Discussion
----------
[DoctrineBridge] Avoids blob values to be logged by doctrine
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7012
---------------------------------------------------------------------------
by pborreli at 2013-03-07T17:07:23Z
what about clob ?
---------------------------------------------------------------------------
by jfsimon at 2013-03-07T17:10:45Z
@pborreli do you think clob values shouldn't be logged?
---------------------------------------------------------------------------
by pborreli at 2013-03-07T17:26:27Z
well they can have same size than blob
---------------------------------------------------------------------------
by beberlei at 2013-03-07T18:07:15Z
I agree, skipping clobs as well would be WIN :-)
---------------------------------------------------------------------------
by francisbesset at 2013-03-08T08:44:08Z
Where are the tests?
---------------------------------------------------------------------------
by beberlei at 2013-03-08T09:25:20Z
Ah yes, the DbalLogger has a testsuite, can you extend it to show this behavior works?
---------------------------------------------------------------------------
by jfsimon at 2013-03-08T10:28:53Z
@francisbesset @beberlei tests written.
---------------------------------------------------------------------------
by staabm at 2013-03-10T16:00:55Z
May I also ask for text/char fields with a certain amount of chars?
This PR was squashed before being merged into the 2.1 branch (closes#7325).
Commits
-------
6575df6 [Security] use current request attributes to generate redirect url?
Discussion
----------
[Security] use current request attributes to generate redirect url?
Maybe we should consider to use current request attributes to generate the login/logout redirections URL?
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5080
---------------------------------------------------------------------------
by Seldaek at 2013-03-11T08:33:37Z
Can you explain why?
---------------------------------------------------------------------------
by jfsimon at 2013-03-11T09:30:07Z
@Seldaek let say I prefixed all my URLs with a `{domain}` var (`_locale` for instance), I'd like it to be passed to my redirected request. I guess it could lead to side effects, that's why I tagged this PR `RFC`.
---------------------------------------------------------------------------
by Seldaek at 2013-03-11T09:46:33Z
Fair enough. The main issue I see is that you end up with "garbage" query params in the URL. Any params that was needed by the previous page and not needed by the new one ends up as ?foo=bar in the URL. It's usually not harmful, but not very clean either. I'm not sure what it would take to grab all the params that a route can use, and only copy those over.
---------------------------------------------------------------------------
by jfsimon at 2013-03-11T10:12:49Z
@Seldaek indeed, I didn't think about those query parameters... I'll try to fix this in a simple way this afternoon.
---------------------------------------------------------------------------
by jfsimon at 2013-03-11T14:54:31Z
@Seldaek tell me if what you think of this, it may look like a hack (which wont be acceptable).
---------------------------------------------------------------------------
by Seldaek at 2013-03-11T14:59:39Z
Eh I see. I can't say it's the less hacky thing I ever saw, but it might be alright. I don't think I'm the best person to take this call though.. Let's see what @fabpot thinks.
This PR was merged into the 2.1 branch.
Commits
-------
7216cb0 [Validator] fix showing wrong max file size for upload errors
Discussion
----------
[Validator] fix showing wrong max file size for upload errors
this was because the maxSize option wasn't parsed correctly and simple string comparision could lead to wrong results, e.g. 200 > 1000M
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes|]
| Fixed tickets | [#6441,#5551]
| License | MIT
Will apply cleanly to 2.2
