This PR was merged into the master branch.
Commits
-------
6b54a51 moved the Stopwatch classes to their own component
Discussion
----------
moved the Stopwatch classes to their own component
see https://github.com/symfony/symfony/issues/5911
---------------------------------------------------------------------------
by stof at 2012-11-09T08:06:06Z
you should also add the ``.gitattributes`` in the new component
---------------------------------------------------------------------------
by fabpot at 2012-11-09T09:09:35Z
@stof: I've added the .gitattributes file, but also the phpunit and LICENSE ones.
---------------------------------------------------------------------------
by dlsniper at 2012-11-09T13:51:23Z
Also you should add this to the changelog/update files. I'll do it myself but only in about 8 hours or so as I'm not at home.
This PR was merged into the master branch.
Commits
-------
380cf4f [HttpKernel] added memory information in the Stopwatch
Discussion
----------
[HttpKernel] added memory information in the Stopwatch
This PR was merged into the master branch.
Commits
-------
d231b8f [ClassLoader] Make ApcClassLoader properly decorate ClassLoader.
Discussion
----------
[ClassLoader] Make ApcClassLoader properly decorate ClassLoader.
ApcClassLoader only implements the findFile() and loadClass() methods, but none of the other methods. That's an implementation detail, which isn't particularly trivial.
I can't see a reason for why ApcClassLoader cannot simply decorate ClassLoader in a proper way, passing forward all unknown method calls to ClassLoader.
---------------------------------------------------------------------------
by sun at 2012-11-09T03:00:51Z
mmm, the test failures seem to be irrelevant. It passed on the PHP 5.4 environment. The others failed on early pre-test infrastructure operations.
This PR was merged into the master branch.
Commits
-------
04e93d8 Update UPGRADE-2.1.md
Discussion
----------
Update UPGRADE-2.1.md
Change on selectedchoice part, because "choice.value" wont work, but just "value" does.
This PR was merged into the master branch.
Commits
-------
c16d6bf [Form] Fixed NumberToLocalizedStringTransformer to throw an exception if numbers contain illegal characters
Discussion
----------
[Form] Fixed NumberType to fail if numbers contain letters
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5707
Todo: -
License of the code: MIT
Documentation PR: -
This PR was merged into the 2.1 branch.
Commits
-------
208e134 [FrameworkBundle] Router skip defaults resolution for arrays
Discussion
----------
[FrameworkBundle] Router skip defaults resolution for arrays
The router should not resolve complex defaults/options parameters but it is not the case for arrays. So this small PR simply adds a check for arrays to prevent array-to-string fatal errors with deep array defaults.
```
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: ~
Todo: ~
License of the code: MIT
Documentation PR: ~
```
This PR was merged into the master branch.
Commits
-------
ded3a83 [HttpFoundation] Document MongoDbSessionHandler changes
Discussion
----------
[HttpFoundation] Document MongoDbSessionHandler changes
```
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
```
Documentation changes for #5916
---------------------------------------------------------------------------
by Baachi at 2012-11-06T20:41:11Z
👍
This PR was merged into the master branch.
Commits
-------
af87c2b changed the Firewall to be a proper subscriber
02bd359 changed the remember-me listener to be a proper subscriber
Discussion
----------
Changed some security classes to implement the EventSubscriberInterface interface
---------------------------------------------------------------------------
by fabpot at 2012-11-06T10:11:28Z
That could also be done in 2.1. What do you think?
This PR was merged into the master branch.
Commits
-------
55a0fef Float support added for transchoice in the Translation Component
Discussion
----------
Float support added for transchoice in the Translation Component
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
---------------------------------------------------------------------------
by pborreli at 2012-11-01T23:22:50Z
👍 nice PR
This PR was submitted for the 2.1 branch but it was merged into the master branch instead (closes#5916).
Commits
-------
917cc14 [HttpFoundation] Revise Mongo session storage
Discussion
----------
[HttpFoundation] Revise MongoDB session storage
```
Bug fix: yes
Feature addition: no
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
```
I decided to take a look at the MongoDB session driver after reading @pgodel's [blog post](http://blog.servergrove.com/2012/11/05/storing-sessions-in-mongodb-with-symfony2/) today. This PR contains some fixes to make this session handler integrate better with MongoDB, as well as make it more in line with the work I did in zendframework/zf2/#2031:
* Default to _id for storing session ID (BC break)
* Use MongoDate instead of MongoTimestamp (BC break)
* Rename default field names ("sess_" is redundant)
* "justOne" is redundant for session removal
* Assert true return values in method tests
* Add note about TTL collections for gc()
* Don't set identifier in upsert (invalid behavior)
In my opinion, the BC breaks are reasonable. `_id` is the logical field to store the session ID, as I'd expect many users may not even think to index the `sess_id` field to avoid inefficient queries otherwise. Also, MongoTimestamp should never have been used in the existing manner. Per the [documentation](http://php.net/manual/en/class.mongotimestamp.php):
> This class is not for measuring time, creating a timestamp on a document or automatically adding or updating a timestamp on a document. Unless you are writing something that interacts with the sharding internals, stop, go directly to MongoDate, do not pass go, do not collect 200 dollars. This is not the class you are looking for.
On a side note, I'm not sure why `sess_` prefixes exist for the PDO driver. It seems redundant in either case (the table/collection would logically have "session" in the name).
The fix to the update statement actually addresses a bug were `_id` to appear in the `$set` query.
I'm not sure how to document the BC breaks or changes, as the 2.1 branch's readme files look a lot sparser than those for 2.0. Let me know if there's something else to be done, though.
---------------------------------------------------------------------------
by jmikola at 2012-11-06T02:49:06Z
FYI: the Travis CI build failure looks unrelated to these changes (something to do with Form tests): https://travis-ci.org/#!/jmikola/symfony/jobs/3076587
---------------------------------------------------------------------------
by pgodel at 2012-11-06T04:27:24Z
I think the BC breaks are very mino, so there is no reason to not merge this.
---------------------------------------------------------------------------
by jmikola at 2012-11-06T07:32:44Z
Thanks, @stof. That looked like something @pborreli would have caught sooner or later :)
---------------------------------------------------------------------------
by fabpot at 2012-11-06T08:00:48Z
As there is a BC break, I'm going to merge it on master.
---------------------------------------------------------------------------
by pborreli at 2012-11-06T08:05:08Z
@jmikola merging with master you will have a little conflict as i already fixed the citeria => criteria typo :)
* Default to _id for storing session ID
* Use MongoDate instead of MongoTimestamp (BC break)
* Rename default field names ("sess_" is redundant)
* "justOne" is redundant for session removal
* Assert true return values in method tests
* Add note about TTL collections for gc()
* Don't set identifier in upsert (invalid behavior)
This PR was merged into the master branch.
Commits
-------
e193590 [Security] removed the 401 error custom status message
Discussion
----------
[Security] removed the 401 error custom status message
see fabpot/Silex#496
---------------------------------------------------------------------------
by pborreli at 2012-10-31T17:29:24Z
@fabpot please fix the test suite, if you don't know how to do it, read http://symfony.com/doc/current/contributing/code/tests.html, thx 😸
This PR was merged into the master branch.
Commits
-------
73bb47b [Console] Fix#5897 - Console component require Shell component
Discussion
----------
[Console] Fix#5897 - Console component require Shell component
When setting the process isolation of a shell to true:
`setProcessIsolation(true)` throw a `\RuntimeException` if the Process component isn't available.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5897
Todo: -
License of the code: MIT
Documentation PR: -
---------------------------------------------------------------------------
by alias-mac at 2012-11-04T17:07:59Z
I noticed that there is no Unit Testing for the Shell class. Shall I create one with the test for this fix/bug request?
---------------------------------------------------------------------------
by alias-mac at 2012-11-06T01:58:40Z
Updated based on @stof comments.
---------------------------------------------------------------------------
by alias-mac at 2012-11-06T02:11:20Z
The travis-ci build failure as nothing to do with the code. See:
https://travis-ci.org/#!/symfony/symfony/jobs/3076345
When setting the process isolation of a shell to true:
`setProcessIsolation(true)` throw a `\RuntimeException` if the Process component isn't available.
This PR was squashed before being merged into the master branch (closes#5841).
Commits
-------
6b601bd [http-foudation] Better accept header parsing
Discussion
----------
[http-foudation] Better accept header parsing
Bug fix: no
Feature addition: yes
Backwards compatibility break: yes
Symfony2 tests pass: yes
**Quality:**
The special `q` item attribute represents its quality. I had to make some choices:
* if I set `q` attribute, it's assigned to quality property, but not to attributes
* the `__toString()` method only render `q` attribute if quality is less than 1
**BC break:**
The return of `Request::splitHttpAcceptHeader()` has changed. It's result was an array of qualities indexed by an accept value, it now returns an array of `AcceptHeaderItem` indexed by its value.
---------------------------------------------------------------------------
by jfsimon at 2012-10-26T08:35:55Z
As dicussed in https://github.com/symfony/symfony/pull/5711.
---------------------------------------------------------------------------
by Seldaek at 2012-10-27T10:35:49Z
Maybe you can pull 5e8a5267f6 into your branch (for some reason I can't send a PR to your repo, it doesn't show up in github's repo selector.. looks like they don't like projects with too many forks). It allows you to use usort() which hopefully is faster than your merge sort, though I did not bench it. I also added tests to confirm the functionality.
---------------------------------------------------------------------------
by Seldaek at 2012-10-27T10:40:27Z
Sorry please check 376dd93c56 instead, I missed a few tests in the RequestTest class.
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T16:26:03Z
@fabpot do you think the introduced BC break is acceptable?
---------------------------------------------------------------------------
by fabpot at 2012-10-29T16:37:06Z
@jfsimon Are all getAccept*() method BC?
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T16:39:26Z
@fabpot nope, just `Request::splitHttpAcceptHeader()`
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T16:43:18Z
@fabpot I think missunderstood... only `Request::splitHttpAcceptHeader()` breaks BC.
---------------------------------------------------------------------------
by fabpot at 2012-10-29T16:53:22Z
So, a BC break on just splitHttpAcceptHeader is possible... but should be documented properly. Another option would be to deprecate the current method (and keep it as is), and just use the new version everywhere. Sounds better as it won"t introduce any BC breaks.
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T16:55:57Z
@fabpot Okay, I'll update this PR according to your second option.
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T20:14:46Z
@fabpot done.
As you can see here: https://github.com/symfony/symfony/pull/5841/files#L5L1029 value returned by `Request::splitHttpAcceptHeader()` is not **exactly** the same as before because all attributes are present (not only those before the `q` one).
---------------------------------------------------------------------------
by fabpot at 2012-10-30T06:16:23Z
The last thing missing before I can merge is a PR to update the documentation (should probably be just a note somewhere with the example you have in the UPGRADE file).
---------------------------------------------------------------------------
by jfsimon at 2012-10-30T07:07:08Z
@fabpot I could add this example here: http://symfony.com/doc/current/components/http_foundation/introduction.html#request after `Accessing the session`, what do you think?
---------------------------------------------------------------------------
by fabpot at 2012-10-30T07:14:10Z
Yes, looks good to me.
* 2.1:
removed unused use statements
[Form] Adapted HTML5 format in DateTimeType as response to a closed ICU ticket
[2.1][HttpFoundation] Fixed Php doc in Request::get
bumped Symfony version to 2.1.4-DEV
updated VERSION for 2.1.3
update CONTRIBUTORS for 2.1.3
updated CHANGELOG for 2.1.3
merged branch jakzal/yamlDoubleQuotesDumperFix (PR #4320)
Conflicts:
src/Symfony/Component/HttpKernel/Kernel.php
This PR was merged into the 2.1 branch.
Commits
-------
b9f6cac [2.1][HttpFoundation] Fixed Php doc in Request::get
Discussion
----------
[2.1][HttpFoundation] Fixed Php doc in Request::get
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
According to php code, `Request::get` method does not seek in cookies.
---------------------------------------------------------------------------
by pborreli at 2012-11-02T11:02:26Z
your PR is full of reSquest typo :)
---------------------------------------------------------------------------
by lyrixx at 2012-11-02T11:25:31Z
@pborreli Fixed
This PR was merged into the 2.1 branch.
Commits
-------
a0af8bf [Form] Adapted HTML5 format in DateTimeType as response to a closed ICU ticket
Discussion
----------
[Form] Adapted HTML5 format in DateTimeType as response to a closed ICU ticket
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
This PR was merged into the master branch.
Commits
-------
b550677 [Finder] Fix the BSD adapter
2401274 [Finder] Added bsd adapter (need tests).
Discussion
----------
[Finder] Adds bsd adapter.
OK on mac os x.
---------------------------------------------------------------------------
by fabpot at 2012-10-31T08:22:05Z
Here are the results for the Finder tests on my Mac:
```
............................................................... 63 / 181 ( 34%)
......................find: -regextype: unknown primary or operator
F..............find: -regextype: unknown primary or operator
find: -regextype: unknown primary or operator
.find: -regextype: unknown primary or operator
find: -regextype: unknown primary or operator
......................... 126 / 181 ( 69%)
.......................................................
Time: 1 second, Memory: 10.75Mb
There was 1 failure:
1) Symfony\Component\Finder\Tests\FinderTest::testIgnoreDotFiles with data set #1 (Symfony\Component\Finder\Adapter\PhpAdapter)
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => '/var/folders/h7/55h7wcsx4g1cl...r/.bar'
- 1 => '/var/folders/h7/55h7wcsx4g1cl...r/.foo'
- 2 => '/var/folders/h7/55h7wcsx4g1cl...o/.bar'
- 3 => '/var/folders/h7/55h7wcsx4g1cl...r/.git'
- 4 => '/var/folders/h7/55h7wcsx4g1cl...er/foo'
- 5 => '/var/folders/h7/55h7wcsx4g1cl...oo bar'
- 6 => '/var/folders/h7/55h7wcsx4g1cl...ar.tmp'
- 7 => '/var/folders/h7/55h7wcsx4g1cl...st.php'
- 8 => '/var/folders/h7/55h7wcsx4g1cl...est.py'
- 9 => '/var/folders/h7/55h7wcsx4g1cl...r/toto'
)
.../src/Symfony/Component/Finder/Tests/Iterator/IteratorTestCase.php:25
.../src/Symfony/Component/Finder/Tests/FinderTest.php:207
phpunit:46
```
---------------------------------------------------------------------------
by jfsimon at 2012-10-31T08:46:22Z
@fabpot thank you! It seems I need to experiment a little more...
---------------------------------------------------------------------------
by jfsimon at 2012-11-01T14:38:31Z
@fabpot BSD adapter is OK on mac os x.
This PR was merged into the master branch.
Commits
-------
4e21bf2 [Finder] Added path & notPath support to gnu find adapter.
6258d12 [Finder] Fixed expression classes.
5c6dbeb [Finder] Fixed tests.
c36dfc1 [Component][Finder] ->path(), ->notPath() methods (with basic tests)
Discussion
----------
[2.2][Finder] ->pathContains(), ->pathNotContains() methods (with basic tests)
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: [](http://travis-ci.org/gajdaw/symfony)
Fixes the following tickets: #4581
Todo: -
License of the code: MIT
Documentation PR: -
Two additional methods: `Finder->path()` and `Finder->notPath()`.
They allow filtering with paths, e.g. `->path('some/special/dir')`.
---------------------------------------------------------------------------
by fabpot at 2012-09-21T05:52:01Z
Can you submit a PR on symfony/symfony-docs to update the documentation and reference it here before I merge? Thanks.
---------------------------------------------------------------------------
by gajdaw at 2012-09-21T10:54:50Z
I've already done it in PR1527.
https://github.com/symfony/symfony-docs/pull/1527
---------------------------------------------------------------------------
by stof at 2012-09-21T22:15:46Z
Actually, to be BC in PHPUnit when switching to Finder (this feature is the reason why the switch was reverted in 3.7), they will need the support of the glob syntax. Should it be supported directly in the Finder or should we consider that PHPUnit will have to put the code converting globs to regexes themselves before calling the finder ?
---------------------------------------------------------------------------
by fabpot at 2012-09-23T13:15:08Z
@stof what about supporting globs/patterns for the `in()` method?
---------------------------------------------------------------------------
by stof at 2012-09-23T13:38:00Z
yeah, this could be a good idea too
---------------------------------------------------------------------------
by gajdaw at 2012-09-26T06:11:56Z
Supporting globs in `path(), notPath()` methods is trivial: we have `Glob::toRegex()`. The only thing to do is to convert (when necessary) parameter sent to `path(), notPath()`.
---------------------------------------------------------------------------
by stof at 2012-10-13T17:19:08Z
@gajdaw can you update this PR with the glob support and rebase it ?
---------------------------------------------------------------------------
by fabpot at 2012-10-29T11:20:55Z
@gajdaw You also need to rebase and update the new adapters accordingly. Maybe @jfsimon can help.
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T16:22:25Z
With pleasure! @gajdaw let me know if I can do anything.
---------------------------------------------------------------------------
by gajdaw at 2012-10-29T16:48:10Z
I have moved `->path()` and `->notPath()` methods to `PhpAdapter`.
This implementation passes all the tests on Windows, but Travis reports failures.
I think that similar methods should be implemented for `GnuFindAdapter`.
@jfsimon What do you think?
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T17:03:36Z
@gajdaw Travis says class 'Symfony\Component\HttpKernel\Exception\InternalServerErrorHttpException' not found in /home/travis/builds/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Exception/FlattenExceptionTest.php on line 83. This is weird.
And yes, `AdapterInterface` and `GnuFindAdapter` should be updated too. I can work on it if you like.
---------------------------------------------------------------------------
by fabpot at 2012-10-29T17:07:46Z
I've just fixed the unit tests
---------------------------------------------------------------------------
by gajdaw at 2012-10-29T17:25:43Z
@jfsimon Can implement `path(), notPath()` for `GnuFindAdapter`? I have no time to analyse Gnu's `find` command at the moment. Thanks!
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T17:30:13Z
@gajdaw okay.
---------------------------------------------------------------------------
by jfsimon at 2012-10-29T19:05:26Z
@gajdaw work complete! I cant make a PR on your repos :-/ Could you merge my repos https://github.com/jfsimon/symfony/tree/component_finder_path_notPath please? Or maybe could I post a new PR on symfony/master.
---------------------------------------------------------------------------
by gajdaw at 2012-10-30T05:34:17Z
@jfsimon I have pulled your changes. I don't know wheather you should post a new PR.
