Commit Graph

27682 Commits

Author SHA1 Message Date
Fabien Potencier
7fc8041bcb updated CHANGELOG for 2.8.36 2018-03-05 11:06:21 -08:00
Fabien Potencier
a03ae7c194 Merge branch '2.7' into 2.8
* 2.7:
  Improve the documentation of `Finder::exclude()`
2018-03-05 10:27:59 -08:00
Fabien Potencier
3379310dd6 minor #26396 Improve the documentation of Finder::exclude() (mnapoli)
This PR was merged into the 2.7 branch.

Discussion
----------

Improve the documentation of `Finder::exclude()`

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Tried to do this and this didn't work:

```php
$iterator->in($sourcePath)
    ->exclude($sourcePath.'/foo');
```

I read on http://symfony.com/doc/current/components/finder.html that excluded directories need to be relative:

![capture d ecran 2018-03-04 a 16 10 31](https://user-images.githubusercontent.com/720328/36947055-28e47eda-1fc7-11e8-9475-399a3d853169.png)

Commits
-------

cc3084ed65 Improve the documentation of `Finder::exclude()`
2018-03-04 08:34:45 -08:00
Matthieu Napoli
cc3084ed65
Improve the documentation of Finder::exclude() 2018-03-04 16:13:29 +01:00
Nicolas Grekas
710a189e83 Merge branch '2.7' into 2.8
* 2.7:
  [WebProfilerBundle] fix wrong variable for profiler counting ajax requests
2018-03-02 16:25:13 +01:00
Nicolas Grekas
79e8545f86 minor #26373 [WebProfilerBundle] fix wrong variable for profiler counting ajax requests (Marin Nicolae)
This PR was squashed before being merged into the 2.7 branch (closes #26373).

Discussion
----------

[WebProfilerBundle] fix wrong variable for profiler counting ajax requests

| Q             | A
| ------------- | ---
| Branch?       |  2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26364
| License       | MIT
| Doc PR        | symfony/symfony-docs#...

Symfony WebProfiler base js change variable tbodies to tbody for counting Ajax Requests.

Commits
-------

0fb83af [WebProfilerBundle] fix wrong variable for profiler counting ajax requests
2018-03-02 16:24:45 +01:00
Marin Nicolae
0fb83af015 [WebProfilerBundle] fix wrong variable for profiler counting ajax requests 2018-03-02 16:24:40 +01:00
Nicolas Grekas
aa8254ce2f Merge branch '2.7' into 2.8
* 2.7:
  [WebProfilerBundle] Fix Debug toolbar breaks app
  bumped Symfony version to 2.7.43
  updated VERSION for 2.7.42
  update CONTRIBUTORS for 2.7.42
  updated CHANGELOG for 2.7.42
2018-03-02 09:25:37 +01:00
Nicolas Grekas
0c5f8391f9 bug #26368 [WebProfilerBundle] Fix Debug toolbar breaks app (xkobal)
This PR was squashed before being merged into the 2.7 branch (closes #26368).

Discussion
----------

[WebProfilerBundle] Fix Debug toolbar breaks app

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26364
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Wrong method is used to count `tbody.rows`

Commits
-------

52f187e [WebProfilerBundle] Fix Debug toolbar breaks app
2018-03-02 09:20:34 +01:00
Xavier HAUSHERR
52f187e86a [WebProfilerBundle] Fix Debug toolbar breaks app 2018-03-02 09:20:32 +01:00
Fabien Potencier
3ff74ada0d bumped Symfony version to 2.8.36 2018-03-01 11:16:54 -08:00
Fabien Potencier
7339c93c82
Merge pull request #26361 from fabpot/release-2.8.35
released v2.8.35
2018-03-01 08:45:46 -08:00
Fabien Potencier
fbf0d0cce1 updated VERSION for 2.8.35 2018-03-01 08:45:28 -08:00
Fabien Potencier
586f697610 updated CHANGELOG for 2.8.35 2018-03-01 08:45:24 -08:00
Fabien Potencier
31c69ec90d bumped Symfony version to 2.7.43 2018-03-01 06:32:34 -08:00
Fabien Potencier
1cb920ef3b
Merge pull request #26346 from fabpot/release-2.7.42
released v2.7.42
2018-02-28 14:57:23 -08:00
Fabien Potencier
751196e8f0 updated VERSION for 2.7.42 2018-02-28 14:53:23 -08:00
Fabien Potencier
621d440217 update CONTRIBUTORS for 2.7.42 2018-02-28 14:53:19 -08:00
Fabien Potencier
3000270452 updated CHANGELOG for 2.7.42 2018-02-28 14:53:13 -08:00
Fabien Potencier
3dd843ba7e Merge branch '2.7' into 2.8
* 2.7:
  Pass on previous exception in FatalThrowableError
  [Routing] remove dead code
  [Routing] fix typo
2018-02-28 13:47:46 -08:00
Fabien Potencier
40639589bf bug #26338 [Debug] Keep previous errors of Error instances (Philipp91)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #26338).

Discussion
----------

[Debug] Keep previous errors of Error instances

| Q             | A
| ------------- | ---
| Branch?       | 2.7 (I have tested against 4.0, but I guess it applies to all the older versions too)
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | ?
| Fixed tickets | --
| License       | MIT

Passing on the previous exception gives developers better debugging information. In particular, if you throw an uncaught `new \Error("Something", 0, new \Exception("Inner exception"))` or sth. like that today, you will not see the "Inner exception" text (which may be more helpful than the outer error) in the HTTP debug response. Converting exceptions into errors this way is a common pattern when an exception raised in a sub-routine cannot reasonably occur for a specific caller situation, so there it becomes an `AssertionError` instead.

Commits
-------

b1b6093f3d Pass on previous exception in FatalThrowableError
2018-02-28 13:02:44 -08:00
Philipp Keck
b1b6093f3d Pass on previous exception in FatalThrowableError 2018-02-28 13:02:44 -08:00
Nicolas Grekas
2f4b867b50 [Routing] remove dead code 2018-02-28 10:36:59 +01:00
Nicolas Grekas
c794fa821b [Routing] fix typo 2018-02-28 10:29:53 +01:00
Nicolas Grekas
64e538e730 Merge branch '2.7' into 2.8
* 2.7:
  [Routing] remove useless failing mocks
2018-02-26 16:48:27 +01:00
Nicolas Grekas
87bbe5ef5f [Routing] remove useless failing mocks 2018-02-26 16:48:14 +01:00
Nicolas Grekas
19d6b592f4 Merge branch '2.7' into 2.8
* 2.7:
  [appveyor] Workaround GitHub disabling of low versions of TLS
  [Routing] Don't throw 405 when scheme requirement doesn't match
  [Routing] Revert throwing 405 on missed slash/scheme redirections
  Fix ArrayInput::toString() for InputArgument::IS_ARRAY args
  [Routing] fix CS
2018-02-26 16:33:21 +01:00
Nicolas Grekas
4f14fff13b bug #26312 [Routing] Don't throw 405 when scheme requirement doesn't match (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Routing] Don't throw 405 when scheme requirement doesn't match

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22739
| License       | MIT
| Doc PR        | -

Commits
-------

9d70ef0 [Routing] Don't throw 405 when scheme requirement doesn't match
2018-02-26 16:07:55 +01:00
Nicolas Grekas
0acbf2b68c minor #26320 [appveyor] Workaround GitHub disabling of low versions of TLS (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[appveyor] Workaround GitHub disabling of low versions of TLS

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

04b56d6 [appveyor] Workaround GitHub disabling of low versions of TLS
2018-02-26 16:07:09 +01:00
Nicolas Grekas
04b56d6ddf [appveyor] Workaround GitHub disabling of low versions of TLS 2018-02-26 16:04:10 +01:00
Nicolas Grekas
9d70ef0915 [Routing] Don't throw 405 when scheme requirement doesn't match 2018-02-25 22:38:00 +01:00
Tobias Schultze
d8395f5035 minor #26307 [Routing] Revert throwing 405 on missed slash/scheme redirections (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Routing] Revert throwing 405 on missed slash/scheme redirections

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | ye
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This partially reverts an unreleased behavior: throwing a 405 when a non-safe verb prevents a slash/scheme redirection.
While this was correct, we are removing it from master to remove some complexity from the implementation of dumped router.
Better not make anyone rely on such nitpicking details that have little to no use in practice.

Commits
-------

391b01393d [Routing] Revert throwing 405 on missed slash/scheme redirections
2018-02-25 16:23:11 +01:00
Nicolas Grekas
391b01393d [Routing] Revert throwing 405 on missed slash/scheme redirections 2018-02-25 09:34:03 +01:00
Robin Chalas
25f3eb5cdd bug #26298 Fix ArrayInput::toString() for InputArgument::IS_ARRAY args (maximium)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix ArrayInput::toString() for InputArgument::IS_ARRAY args

| Q             | A
| ------------- | ---
| Branch?       | 2.7 up to 4.0
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Fix ArrayInput::toString() method to eliminate 'Array to string conversion' notice and get right string representation of InputArgument::IS_ARRAY argument. It need to be fixed in all branches up to master.

Commits
-------

f371fd8 Fix ArrayInput::toString() for InputArgument::IS_ARRAY args
2018-02-24 21:25:11 +01:00
Maxim Lovchikov
f371fd8ced Fix ArrayInput::toString() for InputArgument::IS_ARRAY args 2018-02-24 16:59:02 +00:00
Nicolas Grekas
9587d04520 [Routing] fix CS 2018-02-23 15:02:47 +01:00
Nicolas Grekas
613697c47a Merge branch '2.7' into 2.8
* 2.7:
  [travis] cache in ~/php-ext/
2018-02-22 14:00:21 +01:00
Nicolas Grekas
0f1cae864b [travis] cache in ~/php-ext/ 2018-02-22 13:59:51 +01:00
Nicolas Grekas
5627b48b3a Merge branch '2.7' into 2.8
* 2.7:
  [travis] fix passing $INI to tpecl()
2018-02-22 13:51:14 +01:00
Nicolas Grekas
30b691c57d [travis] fix passing $INI to tpecl() 2018-02-22 13:51:03 +01:00
Nicolas Grekas
3a42da3c5f Sync UPGRADE-3.0.md with 3.4 2018-02-22 13:34:56 +01:00
Nicolas Grekas
a1a2a0ad69 Merge branch '2.7' into 2.8
* 2.7:
  [travis] fix php-ext/ location
2018-02-22 13:25:27 +01:00
Nicolas Grekas
ef8222c1e5 [travis] fix php-ext/ location 2018-02-22 13:24:14 +01:00
Nicolas Grekas
124d338446 Merge branch '2.7' into 2.8
* 2.7:
  Another PR template tweak
  [WebProfilerBundle] limit ajax request to 100 and remove the last one
2018-02-22 11:35:54 +01:00
Fabien Potencier
4758f4c932 minor #26240 Another PR template tweak (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

Another PR template tweak

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

c338d85514 Another PR template tweak
2018-02-20 21:39:22 +01:00
Nicolas Grekas
c338d85514 Another PR template tweak 2018-02-20 16:46:06 +01:00
Fabien Potencier
ddc32e37b8 bug #26236 [PropertyInfo] ReflectionExtractor: give a chance to other extractors if no properties (dunglas)
This PR was merged into the 2.8 branch.

Discussion
----------

[PropertyInfo] ReflectionExtractor: give a chance to other extractors if no properties

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #25803 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

For instance when using `__call()`, see #25803.
<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

270147b04f [PropertyInfo] ReflectionExtractor: give a chance to other extractors if no properties
2018-02-19 21:28:07 +01:00
Fabien Potencier
cb53f4ccd5 bug #25557 [WebProfilerBundle] add a way to limit ajax request (Simperfit)
This PR was merged into the 2.7 branch.

Discussion
----------

[WebProfilerBundle] add a way to limit ajax request

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #22688
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

I need to add the doc entry and the reproducer to test that everything is ok.

Commits
-------

9ff86d6181 [WebProfilerBundle] limit ajax request to 100 and remove the last one
2018-02-19 21:11:32 +01:00
Nicolas Grekas
9cbb2569b9 Merge branch '2.7' into 2.8
* 2.7:
  Clean calls to http_build_query()
  [HttpFoundation] Fix missing "throw" in JsonResponse
  Improve the documentation of
  Suppress warning from sapi_windows_vt100_support on stream other than STDIO
  removed extra-verbose comments
  Fixes #26136: Avoid emitting warning in hasParameterOption()
  Added a README entry to the PR template
  [HttpFoundation] Add x-zip-compressed to MimeTypeExtensionGuesser.
  [DI] Add null check for removeChild
2018-02-19 17:23:47 +01:00
Nicolas Grekas
862e347623 minor #26233 Clean calls to http_build_query() (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

Clean calls to http_build_query()

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

4055224 Clean calls to http_build_query()
2018-02-19 17:21:10 +01:00