This PR was merged into the 3.4 branch.
Discussion
----------
[WebProfilerBundle] Set NullLogger for functional tests
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | https://github.com/symfony/symfony/issues/36962
| License | MIT
| Doc PR | -
Commits
-------
0b9519975d [WebProfilerBundle] Set NullLogger for functional tests
This PR was merged into the 3.4 branch.
Discussion
----------
[PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed
…nnot be parsed
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#37086
| License | MIT
| Doc PR | -
Commits
-------
d3f9b7f833 [PhpUnitBridge] Fix undefined index when output of "composer show" cannot be parsed
This PR was merged into the 3.4 branch.
Discussion
----------
[PhpUnitBridge] fix undefined var on version 3.4
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
bd6a06a8b3 [PhpUnitBridge] fix undefined var on version 3.4
This PR was merged into the 3.4 branch.
Discussion
----------
Fix abstract method name in PHP doc block
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
d6966c3147 Fix abstract method name in PHP doc block
This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] never directly validate Existence (Required/Optional) constraints
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#36637#36723
| License | MIT
| Doc PR |
Using `Optional` or `Required` like "regular" constraints does not make any sense, but doing so didn't break before #36365. I suggest to ignore them for now and deprecate using them outside the `Collection` constraint in 5.2.
Commits
-------
d333aae187 never directly validate Existence (Required/Optional) constraints
This PR was merged into the 3.4 branch.
Discussion
----------
[Console] Fix QuestionHelper::disableStty()
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no>
| Tickets | -
| License | MIT
| Doc PR | -
We broke it when adding `Terminal::hasSttyAvailable()`.
Let's fix it on 3.4 and move it to terminal on master, as suggested in #36977
Commits
-------
5d93b61278 [Console] Fix QuestionHelper::disableStty()
This PR was merged into the 3.4 branch.
Discussion
----------
[PropertyAccess] Fix TypeError parsing again
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | #36872
| License | MIT
| Doc PR | N/A
Apparently, the format of `TypeError`s has changed again in php8. While investigating, I noticed our error message parsing is not handling anonymous classes well, so I've added some test cases for them.
I chose a fuzzier regular expression to parse the expected return type from the error message. Additionally, I'm checking the stack trace if the caught `TypeError` is really caused by the accessor call.
Commits
-------
03b4e98630 [PropertyAccess] Fix TypeError parsing again.
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] validate subforms in all validation groups
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#36852
| License | MIT
| Doc PR |
Commits
-------
b819d94d14 validate subforms in all validation groups
This PR was merged into the 3.4 branch.
Discussion
----------
Fixes sprintf(): Too few arguments in form transformer
Similar to: #29482
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | none
| License | MIT
| Doc PR | none
Fixes the form reverse transformation when the method viewToNorm is called within a value with the character %:
Before : "sprintf(): Too few arguments"
After : Form reverse transformation works.
Reference : http://php.net/manual/function.sprintf.php
Commits
-------
ff7d3f4f01 Fixes sprintf(): Too few arguments in form transformer
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] Update Hungarian translations
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | -
| License | MIT
| Doc PR | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch master.
-->
Commits
-------
1614595424 Update Hungarian translations
This PR was submitted for the master branch but it was merged into the 3.4 branch instead.
Discussion
----------
Add meaningful message when using ProcessHelper and Process is not installed
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
When using the process helper without the `Process` component, a php fatal error is triggered (`PHP Fatal error: Uncaught Error: Class 'Symfony\Component\Process\Process' not found`). This PR adds a meaningful exception; allowing to display a console error message instead of a raw php fatal error.
Commits
-------
3ab76e40ff Add meaningful message when Process is not installed (ProcessHelper)
This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] Add missing translations for cs locale (Czech)
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License | MIT
Is it enough to submit this only against 3.4 to have it included also in 5.1 version?
Commits
-------
3d18c1c185 [Validator] add missing Czech translations
This PR was merged into the 3.4 branch.
Discussion
----------
Handle fetch mode deprecation of DBAL 2.11.
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | no
| License | MIT
| Doc PR | N/A
See doctrine/dbal#4019
DBAL has deprecated PDO-style fetch modes in favor of more explicit methods.
Commits
-------
ed518551e1 Handle fetch mode deprecation of DBAL 2.11.
This PR was merged into the 3.4 branch.
Discussion
----------
[Security] Fixed handling of CSRF logout error
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#36814
| License | MIT
| Doc PR | -
8 years ago, a typo was made while refactoring the `ExceptionListener`, loosing this logic (46071f3238). I think we should fix it.
The `LogoutException` is a very generic name for something only used when the CSRF token is invalid. Should we match the exception message to make sure only this CSRF error is transformed into 403? I didn't yet do it because any usage of `LogoutException` would have resulted in 500, which always is worse than 403.
Commits
-------
50348f2eb7 Fixed handling of CSRF logout error
This PR was merged into the 3.4 branch.
Discussion
----------
[FrameworkBundle] Removed detection of Serializer < 3.2
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
The test that is changed here contains detection logic for Serializer versions prior 3.2. However, accoring to FrameworkBundle's composer.json, we need at least Serializer 3.3, so that logic is obsolete.
I came across this piece of code because on the 5.1 branch, this test is actually skipped because the `use` statement for `CacheClassMetadataFactory` is missing there.
Commits
-------
9badd71687 [FrameworkBundle] Removed detection of Serializer < 3.2
This PR was merged into the 3.4 branch.
Discussion
----------
[travis] display deprecations in nightly jobs
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
83a34a84ab [travis] display deprecations in nightly jobs
This PR was merged into the 3.4 branch.
Discussion
----------
Enable APCu for the php 8 build
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | #36872
| License | MIT
| Doc PR | N/A
This PR enables APCu for the php 8 build on Travis.
Since the latest version release on PECL produces a lot of runtime warnings, I'm pulling the latest master commit from github.
Commits
-------
e3e1558a0b Enable APCu for the php 8 build.
This PR was merged into the 3.4 branch.
Discussion
----------
Make PHP 8 green on Travis
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | #36872
| License | MIT
| Doc PR | -
See #36872 for preparatory work and remaining steps.
Commits
-------
571d46cf01 Make PHP 8 green on Travis