This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9557).
Discussion
----------
[DoctrineBridge] Fix for cache-key conflict when having a \Traversable as choices
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9556
| License | MIT
| Doc PR | ~
Commits
-------
1119684 Fix for cache-key conflict when having a \Traversable as choices
This PR was merged into the 2.3 branch.
Discussion
----------
[Security] Fix ExceptionListener to catch correctly AccessDeniedException if is not first exception
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9544, #8467?, #9823
| License | MIT
| Doc PR |
Same as #9823 but with some refactoring of the code and with some unit tests.
When merging to 2.4, the unit tests can be simplified a bit.
Commits
-------
172fd63 [Security] made code easier to understand, added some missing unit tests
616b6c5 [Security] fixed error 500 instead of 403 if previous exception is provided to AccessDeniedException
This PR was merged into the 2.3 branch.
Discussion
----------
[Dependencyinjection] Fixed handling of inlined references in the AnalyzeServiceReferencesPass
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8299, #9829
| License | MIT
| Doc PR | n/a
Hopefully a better fix for #9829 (ping @jakzal). Unit tests coming soon.
In some cases `InlineServiceDefinitionsPass` replaces a Reference with a service Definition. In such scenarios `AnalyzeServiceReferencesPass` was falling into an infinite loop.
Commits
-------
d650295 [DependencyInjection] fixed InlineServiceDefinitionsPass to not inline a service if it's part of the current definition (to avoid an infinite loop)
This PR was merged into the 2.3 branch.
Discussion
----------
[DomCrawler] Fixed creating form objects from named form nodes
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9619
| License | MIT
| Doc PR | -
Commits
-------
72d6322 [DomCrawler] Fixed creating form objects from form nodes.
This PR was merged into the 2.3 branch.
Discussion
----------
disabled php.ini changes when using HHVM in .travis.yml
Commits
-------
78bfd3a disabled php.ini changes when using HHVM in .travis.yml
This PR was merged into the 2.3 branch.
Discussion
----------
Add support for HHVM in the getting of the PHP executable
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Same as #9583 but with CS fixed, on 2.3, and with an added safeguard to only change the current behavior for HHVM.
Check for a PHP_BINARY environment variable before using the pre-defined PHP_BINARY constant.
HHVM has an explicit hhvm binary and a wrapper to mimic php functionality. We were running into issues with tests that ran in their own process where using the hhvm binary does not handle php code sent to it via stdin very well. We get "Nothing to do...pass file" exceptions. Unfortunately, the PHP_BINARY is always set to the explicit binary (the php wrapper is basically a symlink to the explicit binary). So, we thought about adding a check for a PHP_BINARY environment variable as the first choice when getting the PHP binary.
Commits
-------
876482f [Process] fixed HHVM support
539de17 Add support for HHVM in the getting of the PHP executable
This PR was merged into the 2.3 branch.
Discussion
----------
fixed typos
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Hope @pborreli is not going to be too jealous about all those typo fixes ;)
Commits
-------
5ff5615 fixed typos
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Fixed IBAN validator with 0750447346 value
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
cf88ba5 [Validator] Fixed IBAN validator with 0750447346 value
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9761).
Discussion
----------
Add testing against HHVM at Travis-CI
Commits
-------
a4d1095 Add testing against HHVM at Travis-CI
This PR was squashed before being merged into the 2.3 branch (closes#9875).
Discussion
----------
Fixed typo
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Commits
-------
660ab38 Fixed typo
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9873).
Discussion
----------
Fixed typo
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Commits
-------
025ae7a Fixed typo
This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] fixed some license headers
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Fixes lambdas once and for all.
Commits
-------
a2a6bd4 fixed a typo
35b407f fixed CS for lambdas
93edf44 [Yaml] fixed some license headers
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9865).
Discussion
----------
[Validator] Fixes message value for objects
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
7b69e9b [Validator] Fixes message value for objects
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9441).
Discussion
----------
[Form][DateTimeToArrayTransformer] Check for hour, minute & second validity
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9440
| License | MIT
| Doc PR | -
This PR checks if hour, minute & second values are valid in the datetime to array transformer (values must be integer if they exist).
Commits
-------
1543653 [Form][DateTimeToArrayTransformer] Check for hour, minute & second validity
This PR was merged into the 2.3 branch.
Discussion
----------
fixed various typos
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
2f15ac7 fixed various typos
This PR was merged into the 2.3 branch.
Discussion
----------
#9866 [Filesystem] Fixed mirror for symlinks
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | [#9866]
| License | MIT
| Doc PR | [NA]
Check the original ticket for the full description and how to reproduce.
The initial PR #9213 was closed.
Commits
-------
d136555 [Filesystem] Fixed mirror for symlinks
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Removed duplicated test for IBAN in data provider
Working on #9850, I spotted a duplicated value on `getValidIbans` data provider and I just removed the duplicated value.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
35610d0 [Validator] Removed duplicated test for IBAN in data provider
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9806).
Discussion
----------
[Security] Fix parent serialization of user object
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
`parent::serialize()` and `parent::unserialize()`, which are used in the `AbstractToken` are [problematic](https://bugs.php.net/bug.php?id=62836) in PHP >= 5.4. [Cloning the object](https://gist.github.com/aurelijus/4713758) before serialization seems to fix this.
Commits
-------
e0bb891 [Security] Fix parent serialization of user object
This PR was merged into the 2.3 branch.
Discussion
----------
[DependencyInjection] fixed typo
Commits
-------
408d992 [DependencyInjection] fixed typo
This PR was merged into the 2.3 branch.
Discussion
----------
[Tests|WCM] add memcache, memcached, and mongodb extensions to run skipped tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | na
| License | MIT
| Doc PR | na
- [x] go over all skipped tests, take note and check they are reasonable
- [x] reenable memcache, mongodb, and memcached
We are keeping the icu intl related tests skipped because setting up icu 51.2 is totally time consuming in travis and it would require a custom distro box on travis because there are no ppa's available for the ubuntu version. I tried hard but it does not seem worth it. Same for plugging beta of memcached with pecl, it is just not reasonable to be running beta versions on travis. This then does not address #9797 but at least now we are aware.
This PR now can be merged as is as it improves tests that before were not ran. Not all but more than before. 👶
Commits
-------
47a822d add memcache, memcached, and mongodb extensions to run skipped tests
This PR was merged into the 2.3 branch.
Discussion
----------
[DependencyInjection] Fixed support for backslashes in service ids.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9801
| License | MIT
| Doc PR |
This change is needed for consistency with `camelize()` which is used in [`ProxyDumper`](https://github.com/symfony/symfony/blob/2.3/src/Symfony/Bridge/ProxyManager/LazyProxy/PhpDumper/ProxyDumper.php#L69) and [`PhpDumper`](https://github.com/symfony/DependencyInjection/blob/2.3/Dumper/PhpDumper.php#L1275).
Either this PR needs to be merged for consistency or #9610 rolled back (if we don't want to support backslashes in service ids).
Anyone could tell me why we're not using the `camelize()` method internally in the `Container`?
Commits
-------
c6f210b [DependencyInjection] Fixed support for backslashes in service ids.
