This PR was squashed before being merged into the 2.3 branch (closes#9718).
Discussion
----------
[validator] throw an exception if isn't an instance of ConstraintValidatorInterface.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9264
| License | MIT
Commits
-------
fc232a5 [validator] throw an exception if isn't an instance of ConstraintValidatorInterface.
This PR was merged into the 2.3 branch.
Discussion
----------
Reset the box model to content-box in the web debug toolbar
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This makes the styles compatible with CSS frameworks changing the box model to box-sizing using a universal selector (Bootstrap 3 for instance).
Commits
-------
ae95a71 Reset the box model to content-box in the web debug toolbar
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] Allowed "0" as a checkbox value in php templates
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8251
| License | MIT
| Doc PR |
Commits
-------
955e8cf [FrameworkBundle] Allowed "0" as a checkbox value in the php template.
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9678).
Discussion
----------
[HttpKernel] use static late binding when dumping out container
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no?
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9649
| License | MIT
| Doc PR |
This PR gives the ability to override the stripComments method in descendants (and to disable the memory-eater container whitespace stripping)
Commits
-------
2e241cc [HttpKernel] use static late binding when dumping out container
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#9698).
Discussion
----------
[Stopwatch] raising delta on stopwatch as travis really breaks with less than 35
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | well many failing so far because of travis
| License | MIT
| Doc PR | no way
Commits
-------
3348c6a raising delta on stopwatch as travis really breaks with less than 35
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9686).
Discussion
----------
[Form] Switched to correct gender of "Token"
The neutral gender "das Token" is used in science to describe an array of bits or chars, where as the masculin "der Token" is commenly used for keys in communications and authentication in the network.
I guess the a CSRF-Token is more a key for authentication then a bit array.
Cheers,
Christian
| Q | A
| ------------- | ---
| Bug fix? | yes/kinda
| New feature? | not really
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| Doc PR | none
Commits
-------
c2bc9ae Switched to correct gender of "Token"
The neutral gender "das Token" is used in science to describe an array of bits or chars, where as the masculin "der Token" is commenly used for keys in communications and authentication in the network.
I guess the a CSRF-Token is more a key for authentication then a bit array.
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3] fix typos in several translations
| Q | A
| ------------- | ---
| Fixed tickets | --
| License | MIT
Similar to #9681, but for 2.3, with one additional change.
Commits
-------
8209a7f fixed typos in several translations
* 2.2:
updated VERSION for 2.2.11
update CONTRIBUTORS for 2.2.11
updated CHANGELOG for 2.2.11
[HttpKernel] made a small optimization to Bundle initialization
minor optimalization at bundle initialization
[EventDispatcher] tweaked README
removed observer pattern, in favour of mediator
[DoctrineBridge] normalized class names in the ORM type guesser
Fix `extract` method to avoid recalculating count() for each iteration.
use the correct class name to retrieve mapped class' metadata and repository
[WebProfilerBundle] Fixed js escaping in time.html.twig
Conflicts:
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
src/Symfony/Component/HttpKernel/Kernel.php
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#9675).
Discussion
----------
Fixed typo in phpdoc
Commits
-------
350d5ea Fixed typo in phpdoc
This PR was merged into the 2.3 branch.
Discussion
----------
[Bridge/Doctrine] ORMQueryBuilderLoader - handled the scenario when no entity manager is passed with closure query builder
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
a534b55 Handled the scenario when no entity manager is passed with closure query builder.
This PR was merged into the 2.2 branch.
Discussion
----------
[HttpKernel] minor optimalization at bundle initialization
fast check to avoid six array method calls
| Q | A
| ------------- | ---
| Bug fix? | [no]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [|no]
| Tests pass? | [yes]
| Fixed tickets | #9657
| License | MIT
| Doc PR |
That's a rebased version of #9657 on 2.2 + another optimization suggested by @GromNaN
Commits
-------
3330c40 [HttpKernel] made a small optimization to Bundle initialization
4ba6c0b minor optimalization at bundle initialization
This PR was merged into the 2.2 branch.
Discussion
----------
Removed observer pattern, in favour of mediator
| Q | A
| ------------- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | *
| Fixed tickets | #9344
I don't think this is the best tool to implement the observer pattern.
I just have copied the sentence from:
https://github.com/symfony/symfony-docs/edit/2.3/components/event_dispatcher/introduction.rst
but maybe could be improved with something like:
"Symfony Event Dispatcher is a tool that allows to make your projects truly extensible, facilitating the implementation of Mediator pattern and Publish subscribe pattern"
[edit-1]
I think this could be modified also here:
https://github.com/symfony/symfony-marketing/edit/master/views/en/get_started/components.html.twig
Commits
-------
ab3e231 [EventDispatcher] tweaked README
b9ad62e removed observer pattern, in favour of mediator
This PR was merged into the 2.2 branch.
Discussion
----------
[DoctrineBridge] normalized class names in the ORM type guesser
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5837
| License | MIT
| Doc PR | n/a
Commits
-------
a1b9c2e [DoctrineBridge] normalized class names in the ORM type guesser
This PR was merged into the 2.2 branch.
Discussion
----------
use the correct class name to retrieve mapped class' metadata and reposi...
...tory
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9646
| License | MIT
| Doc PR |
The validation context isn't necessarily the entity being validated. In case that you added the Unique Entity constraint inside your custom type via the ``constraints`` option the validation context will be the ``Form`` class itself. Thus, not the validation context should be used to get the class metadata and the repository of the validated entity, but the entity itself should be used.
Commits
-------
cd4df11 use the correct class name to retrieve mapped class' metadata and repository
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9651).
Discussion
----------
Fix `extract` method to avoid recalculating count() for each iteration.
This PR was submitted on the symfony/DomCrawler read-only repository and moved automatically to the main Symfony repository (closessymfony/DomCrawler#16).
Cache the value of `count($attributes)` to avoid recalculating it for each iteration of the loop.
Since this count will never change during the method execution, this change make the code a bit more efficient.
Commits
-------
9ababf4 Fix `extract` method to avoid recalculating count() for each iteration.
Cache the value of `count($attributes)` to avoid recalculating it for each iteration of the loop.
Since this count will never change during the method execution, this change make the code a bit more efficient.
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] ensured that a fatal PHP error is actually fatal after being handled by our error handler
This is a follow-up for #9641 where I try to restore the previous code behavior as much as possible.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
d7a4cfb [Debug] ensured that a fatal PHP error is actually fatal after being handled by our error handler
This PR was merged into the 2.2 branch.
Discussion
----------
[WebProfilerBundle] Fixed js escaping in time.html.twig
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
For some event names I received the JavaScript error: ```Uncaught SyntaxError: Unexpected token ILLEGAL```
Commits
-------
4828350 [WebProfilerBundle] Fixed js escaping in time.html.twig
* 2.2:
Teardown used wrong property
Modified guessDefaultEscapingStrategy to not escape txt templates
Fix DateType for 32bits computers.
Fixed the registration of validation.xml file when the form is disabled
When getting the session's id, check if the session is not closed
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] Avoid notice from being "eaten" by fatal error.
Workaround for https://bugs.php.net/bug.php?id=54275. Follow-up to PR #9428 and #9449.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8703
| License | MIT
| Doc PR | n/a
Commits
-------
872d584 [Debug] fixed unit tests
2d6c2aa Avoid notice from being *eaten* by fatal error.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9640).
Discussion
----------
Fixed wrong property in test teardown
This PR was submitted on the symfony/EventDispatcher read-only repository and moved automatically to the main Symfony repository (closessymfony/EventDispatcher#2).
Commits
-------
5330603 Teardown used wrong property
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9639).
Discussion
----------
Modified guessDefaultEscapingStrategy to not escape txt templates
This PR was submitted on the symfony/TwigBundle read-only repository and moved automatically to the main Symfony repository (closessymfony/TwigBundle#2).
Useful for plaintext emails.
Commits
-------
6affe94 Modified guessDefaultEscapingStrategy to not escape txt templates
This PR was squashed before being merged into the 2.2 branch (closes#9314).
Discussion
----------
[Form] Fix DateType for 32bits computers.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5227,#5554
| License | MIT
| Doc PR | -
Fix an issue due to 32bits machines, date can be only between 1902-2037.
Simply not add date if false. Can be good to add this to 2.3 and master too.
Commits
-------
b80fb43 [Form] Fix DateType for 32bits computers.
This PR was submitted for the 2.1 branch but it was merged into the 2.2 branch instead (closes#9443).
Discussion
----------
[FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
cfa5aa5 [FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled
