This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][WebProfilerBundle] fix debug toolbar rendering by removing inadvertently added links
| Q | A
| ------------- | ---
| Branch | 2.3+
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The debug toolbar was broken by #17527...
**before**
**and after**
**explanation**
If `false` is explicitly passed for `link` then `link | default(true)` would evaluate to `true`, which is not what we want. The correct expression `link is not defined or link` was suggested originally in #16653.
Commits
-------
a0ddfc4 fix debug toolbar rendering by removing inadvertently added links
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17925).
Discussion
----------
[Bridge] The WebProcessor now forwards the client IP
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | yes
| BC breaks? | yes
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | #17905
| License | MIT
Commits
-------
e740852 The WebProcessor now forwards the client IP
This PR was merged into the 2.3 branch.
Discussion
----------
Fix - #17676 (backport #17919 to 2.3)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17676
| License | MIT
| Doc PR |
This is a backport of #17919
Commits
-------
0c6400a#17676 - making the proxy instantiation compatible with ProxyManager 2.x by detecting proxy features
This PR was squashed before being merged into the 2.3 branch (closes#17942).
Discussion
----------
Fix bug when using an private aliased factory service
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17910, #17915
| License | MIT
| Doc PR | -
/cc @xabbuh
Commits
-------
de406c0 Fix bug when using an private aliased factory service
This PR was merged into the 2.3 branch.
Discussion
----------
Update contributing docs
| Q | A
| ------------- | ---
| Branch | 2.3
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
I propose adding the branch to the pull request template so that submitters have some hint about the branch selection workflow, and so that we can edit it for mergers.
I'd also like to add a link to the "running tests" doc, which made me rewrite the full contributing file, with links to the sections of the contributing documentation.
Commits
-------
852f999 Update contributing docs
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17542).
Discussion
----------
ChoiceFormField of type "select" could be "disabled"
Hi,
New PR to add tests from the closed PR #15952
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
576c4b9 ChoiceFormField of type "select" could be "disabled"
This PR was merged into the 2.3 branch.
Discussion
----------
[ci] clone with depth=1 to kill push-forced PRs
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | -
| License | MIT
| Doc PR | -
As documented in https://github.com/travis-ci/travis-ci/issues/4575#issuecomment-125200308, setting a clone depth of 1 will make push-forced PRs to fail quickly so that our CI won't spend too much time on them.
Commits
-------
562d4d6 [ci] clone with depth=1 to kill push-forced PRs
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17074).
Discussion
----------
Fix constraint validator alias being required
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16805
| License | MIT
| Doc PR | symfony/symfony-docs#6055
This is my first contribution, so everything might not be in perfect order.
Follow-up of #16841 on the right branch.
Commits
-------
5136c30 Fix constraint validator alias being required
This PR was merged into the 2.3 branch.
Discussion
----------
[DependencyInjection] replace alias in factory services
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17864
| License | MIT
| Doc PR |
Commits
-------
56f8798 replace alias in factory services
This PR was squashed before being merged into the 2.3 branch (closes#17903).
Discussion
----------
Validate XLIFF translation files
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
In #17902 @stof proposed to add a simple test to validate `.xlf` files (to avoid issues like #17893).
This is a proposal for that test. My questions:
**1)** Do you agree displaying detailed error messages when the XML is not valid. Example output for the #17893 error:
Or is it enough displaying just the PHPUnit error message and let the user figure out the details?
**2)** How do I validate the translation files of the Security and Form components? Do I just copy+paste this test in those components?
Commits
-------
db03055 Validate XLIFF translation files
This PR was merged into the 2.3 branch.
Discussion
----------
Fixed a minor XML issue in a translation file
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17893
| License | MIT
| Doc PR | -
Commits
-------
3135742 Fixed a minor XML issue in a translation file
This PR was merged into the 2.3 branch.
Discussion
----------
[CS] PHPUnit dedicate assert fixer acceptance test
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| License | MIT
The goal of this PR is _not_ to have it merge, but to check with SF community if a new Fixer (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1792) should be added to the set of Symfony fixers (at PHP-CS-Fixer).
Commits
-------
7aff7f4 PhpUnitNoDedicateAssertFixer results
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#17862).
Discussion
----------
Improve Norwegian translations
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | N/A
| License | MIT
This PR (1) fixes multiple grammatical errors in the Norwegian translations and (2) adds missing translations.
Commits
-------
73a5d6c Improve Norwegian translations
This PR was merged into the 2.3 branch.
Discussion
----------
Simplify markdown for PR template
I know it's all about rendering in the issue, but actually putting `[` in markdown can create some issues.
Here, having raw informations looks better IMO and does not cause any rendering issue when not used. And double-click-selection does not force to remove the brackets manually.
What do you think?
Commits
-------
a278035 Simplify markdown for PR template
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] read commands from bundles when accessing list
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This allows access to the list of commands registered by the kernel (bundle and later service ids) programmatically when you do not `run` the application.
Commits
-------
0fe3088 register commands from kernel when accessing list
This PR was merged into the 2.3 branch.
Discussion
----------
[FileSystem] Windows fix
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/16783
| License | MIT
| Doc PR |
* Fixes edge case on windows where PHP does not generate a PHP Warning but instead returns a wrong result https://bugs.php.net/bug.php?id=71103
* Improved error reporting on `unlink` used in `remove()`
Commits
-------
0d5f7e2 Update FileSystem
This PR was squashed before being merged into the 2.3 branch (closes#17831).
Discussion
----------
Create PULL_REQUEST_TEMPLATE.md
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | n/a
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Github has support for issue and template files (`issue_template.md` and `pull_request_template.md`). The contents of these files will auto-populate new issues/PRs.
This PR creates a `PULL_REQUEST_TEMPLATE.md` file using the [Symfony Pull Request Template](https://symfony.com/doc/current/contributing/code/patches.html#make-a-pull-request).
See https://github.com/blog/2111-issue-and-pull-request-templates
Commits
-------
ac8f8f8 Create PULL_REQUEST_TEMPLATE.md
