Vasilij Dusko | CREATION
a197deeed1
* LightSmsTransport.php - better to remove if we do not have it?
2021-04-01 13:58:54 +03:00
Vasilij Dusko | CREATION
83d259832b
* Coding Standard patch
2021-04-01 13:35:26 +03:00
Vasilij Dusko | CREATION
1ff97e410a
* LightSmsTransport.php - build signature and use http_build_query, timestamp int
2021-04-01 13:33:34 +03:00
Vasilij Dusko | CREATION
1c993b7224
* ERROR_CODES -> int
...
* www. - bug
* isset validate ['error']
2021-04-01 13:12:34 +03:00
Vasilij Dusko | CREATION
1b59a7d47e
* LightSmsTransport.php - string param
2021-04-01 08:41:55 +03:00
Vasilij Dusko | CREATION
58ac708d0f
* LightSmsTransport.php - return back www (without will not work). Now fail tests
2021-03-30 13:18:00 +03:00
Vasilij Dusko | CREATION
b9f9ff8c94
* LightSmsTransport.php - tests fail
2021-03-30 09:17:45 +03:00
Vasilij Dusko | CREATION
265f776394
* LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest
2021-03-30 09:15:57 +03:00
Vasilij Dusko | CREATION
23a446a2e1
* LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest
2021-03-30 09:14:59 +03:00
Vasilij Dusko | CREATION
08235e5a3c
* LightSmsTransport.php - bug fix
2021-03-30 08:09:56 +03:00
Vasilij Dusko | CREATION
80ef5ba565
* LightSmsTransport.php - Unable to send the SMS: Closing direction to the user
2021-03-30 08:07:02 +03:00
Vasilij Duško
08b0729751
Update LightSmsTransport.php
2021-03-29 19:37:44 +03:00
Vasilij Duško
7180c1f400
Update LightSmsTransport.php
2021-03-29 19:26:20 +03:00
Vasilij Dusko | CREATION
f16b4d2aa2
* phone changed to from
2021-03-29 17:52:20 +03:00
Vasilij Dusko | CREATION
7f13dbf711
* sender changed to from
2021-03-29 17:49:52 +03:00
Vasilij Dusko | CREATION
e20ef1ed35
* LightSmsTransport.php - change + to 00
2021-03-29 14:16:34 +03:00
Vasilij Dusko | CREATION
b0e64b9250
* LightSmsTransport.php - not ok throw exception
2021-03-29 13:51:17 +03:00
Vasilij Dusko | CREATION
fc13bb27e2
* LightSmsTransport.php - changed login for validation (the same like we have all places)
2021-03-29 13:34:15 +03:00
Vasilij Dusko | CREATION
5d2e6928f3
* LightSmsTransport.php - escape phone number
2021-03-29 13:29:53 +03:00
Vasilij Dusko | CREATION
8620e828a7
* LightSmsTransport.php - move timestamp
2021-03-29 13:14:06 +03:00
Vasilij Duško
66c34baf03
Update README.md
2021-03-29 08:45:01 +03:00
Vasilij Duško
2e0e1d733d
Update README.md
2021-03-29 08:45:01 +03:00
Vasilij Duško
7b51e0dd7f
Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
...
Co-authored-by: Thibault RICHARD <thibault@widop.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
079406ed3d
Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
...
Co-authored-by: Thibault RICHARD <thibault@widop.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
0e41bc9186
Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php
...
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
3d0d79cfe2
Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php
...
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
e0a68bd0ac
Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
...
Co-authored-by: Thibault RICHARD <thibault@widop.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
1b073c2366
Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
...
Co-authored-by: Thibault RICHARD <thibault@widop.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
b0891be0b2
Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
...
Co-authored-by: Thibault RICHARD <thibault@widop.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
49b4780f40
Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
...
Co-authored-by: Thibault RICHARD <thibault@widop.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
b2e46387b7
Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
...
Co-authored-by: Thibault RICHARD <thibault@widop.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
c02dbbd963
Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md
...
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
2021-03-29 08:45:01 +03:00
Vasilij Duško
9f89014d94
Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md
...
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
2021-03-29 08:45:01 +03:00
Vasilij Dusko
5e54dfe475
* LightSmsTransport.php - quick fix for private constant.
2021-03-29 08:45:01 +03:00
Vasilij Dusko
3cbbc85e43
* HOST split into two parts
2021-03-29 08:45:01 +03:00
Vasilij Dusko
9e1809e6ae
* small changes
2021-03-29 08:45:01 +03:00
Vasilij Duško
febff4613d
Update src/Symfony/Component/Notifier/Bridge/LightSms/LICENSE
...
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
2021-03-29 08:45:01 +03:00
Vasilij Dusko
4a11b945a3
* github account author
2021-03-29 08:45:01 +03:00
Vasilij Dusko
728a3e2450
* Transport.php - missing use
2021-03-29 08:45:01 +03:00
Vasilij Dusko
ce41756a6c
* notifier_transports.php - Coding Standard
2021-03-29 08:45:01 +03:00
Vasilij Dusko
d1ccd46e75
* Attached file changes which are required to run the lightsms notifier
2021-03-29 08:45:01 +03:00
Vasilij Dusko
a0fae7dc4a
* tests
2021-03-29 08:45:01 +03:00
Vasilij Dusko
15686c0851
* LightSmsTransport.php - Coding Standard
2021-03-29 08:45:01 +03:00
Vasilij Dusko
2f65b92cba
* LightSmsTransport.php - Coding Standard
2021-03-29 08:45:00 +03:00
Vasilij Dusko
6792535a52
* composer.json - requirements bug fix
2021-03-29 08:45:00 +03:00
Vasilij Dusko
167f325f40
* LightSmsTransport.php - logic error
2021-03-29 08:45:00 +03:00
Vasilij Dusko
be8f994fca
* LightSmsTransport.php - return type
2021-03-29 08:45:00 +03:00
Vasilij Dusko
f2ba226b46
* LightSmsTransport.php - bug fix
2021-03-29 08:45:00 +03:00
Vasilij Dusko
b075c0eae2
* LightSms notifier
2021-03-29 08:45:00 +03:00
Robin Chalas
40a2c19ae7
feature #40403 [Security] Rename UserInterface::getUsername() to getUserIdentifier() (wouterj)
...
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[Security] Rename UserInterface::getUsername() to getUserIdentifier()
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes
| Deprecations? | yes
| Tickets | Fix part of #39308
| License | MIT
| Doc PR | tbd
This continues the great work by @chalasr in #40267 and rounds up the `UserInterface` cleanup.
The `getUsername()` has been a point of confusion for many years. In today's applications, many domains no longer have a username, but instead rely on a user's email address or the like. Even more, this username has to be unique for all Security functionality to work correctly - so it's more confusing in complex applications relying on e.g. "username+company" to be unique.
**This PR proposes to rename the method to `getUserIdentifier()`**, to more clearly indicate the goal of the method (note: I'm open for any other suggestion).
For BC, the `getUsername()` method is deprecated in 5.3 and `getUserIdentifier()` will be added to the `UserInterface` in 6.0. PHPdocs are used to improve type-hinting for 5.3 & 5.4. Both authentication managers (the legacy and experimental one) check the authenticated user object and trigger a deprecation if `getUserIdentifier()` is not implemented.
* [x] **judge whether we need to have better deprecations for calling `getUsername()` in the application code.**
Consistent with these changes, I've also done the same BC change for `TokenInterface::getUsername()`.
* [x] **do the same for remember me's `PersistentTokenInterface::getUsername()`**
* [x] **also rename `UserProviderInterface::loadUserByUsername()` & `UsernameNotFoundException`**
* [x] **also rename `UserLoaderInterface::loadUserByUsername()`**
I'm very much looking forward for feedback and help for this important, but BC-heavy, rename. 😃
Commits
-------
8afd7a3765
[Security] Rename UserInterface::getUsername() to getUserIdentifier()
2021-03-28 22:25:04 +02:00