This PR was merged into the 2.4 branch.
Discussion
----------
[Validator] Backported constraint validator tests from 2.5
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This PR backports the constraint validator tests from 2.5 to 2.4 to facilitate maintenance. When we adapt a test in 2.4, we can now easily merge the change forward to 2.5.
Commits
-------
845c33c [Validator] Backported constraint validator tests from 2.5
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Backported constraint validator tests from 2.5
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This PR backports the constraint validator tests from 2.5 to 2.3 to facilitate maintenance. When we adapt a test in 2.3, we can now easily merge the change forward to 2.5.
Commits
-------
87a47ea [Validator] Backported constraint validator tests from 2.5
This PR was squashed before being merged into the 2.5 branch (closes#11666).
Discussion
----------
[DIC] Fixed: anonymous services are always private
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR |
This PR fix a regression introduce by 33c91f9be8 (diff-c68f5120ea7d664e07e96cc40bdf6295L268)
* First commit is just about CS
* Second commit really fix the regression (see only this diff to easily understand)
ping @sandermarechal @romainneutron
Commits
-------
7f4f9ab [DIC] Fixed: anonymous services are always private
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11641).
Discussion
----------
[WebProfilerBundle ] Fix toolbar vertical alignment
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Fix the vertical alignment of texts in the toolbar.
This issue appears when a reset css contain ```vertical-align: top/bottom/middle;```
Commits
-------
65220e7 Fix toolbar vertical alignment.
This PR was merged into the 2.5 branch.
Discussion
----------
fix dependencies on HttpFoundation component
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11636
| License | MIT
| Doc PR |
The ``closeOutputBuffers()`` method was added to the ``Response`` class of the HttpFoundation in Symfony 2.5. Therefore, parts that are calling this method must depend on ``symfony/http-foundation`` 2.5 or higher.
Commits
-------
fe2f007 fix dependencies on HttpFoundation component
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Convert objects to string in comparison validators
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
In the [latest merge from 2.3 into 2.4](/symfony/symfony/commit/3bed1b7988e94a897a64c6a2ad3bf70bde9005c1), the changes from 6cf5e0812e in 2.4 got lost. This PR brings back these changes and backports them to 2.3.
The change is BC, because the former value `true` of the `$prettyDateTime` will be cast to `1`, which corresponds to the `PRETTY_DATE` format constant.
Commits
-------
273671e [Validator] Convert objects to string in comparison validators. Reapplies 6cf5e0812e
This PR was squashed before being merged into the 2.3 branch (closes#11510).
Discussion
----------
[HttpFoundation] MongoDbSessionHandler supports auto expiry via configurable expiry_field
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11508
| License | MIT
| Doc PR | no
ToDo
* [x] Fix Tests
Looking for feedback on this early PR.
This adds a config option that disables the PHP GC method call from doing anything,
It also means that the write method sets up the auto expiring index.
Ref: #11508
Commits
-------
b56b740 [HttpFoundation] MongoDbSessionHandler supports auto expiry via configurable expiry_field
This PR was merged into the 2.5 branch.
Discussion
----------
[Validator] Fix little typo in ExecutionContextInterface::buildViolation() method comments
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
b8c0a12 [Validator] Fix little typo in ExecutionContextInterface::buildViolation() method comments
This PR was merged into the 2.5 branch.
Discussion
----------
[FrameworkBundle] resolve parameters before the configs are processed in the config:debug command
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11622
| License | MIT
| Doc PR |
If the raw values are passed to the processor, config values don't necessarily have the expected data type. For example, the value of the kernel.debug parameter is a boolean type. But when passed as the raw parameter name, it is a string.
@lyrixx Do you have any objections?
Commits
-------
19f3b47 resolve parameters before the configs are processed
The closeOutputBuffers() method was added to the Response class of
the HttpFoundation in Symfony 2.5. Therefore, parts that are calling
this method must depend on symfony/http-foundation 2.5 or higher.
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] add missing attribute to XSD
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The ``hinclude_default_template`` configuration option couldn't have been set in XML configurations since it wasn't defined in the XML schema definition.
Commits
-------
8a2b423 [FrameworkBundle] add missing attribute to XSD
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11601).
Discussion
----------
[Validator] Allow basic auth in url when using UrlValidator.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Now an url with basic auth like ```http://username:password@symfony.com``` can be valid.
Commits
-------
f1ea987 Allow basic auth in url. Improve regex. Add tests.
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] fixed style creation when providing an unknown tag option
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
When formatting a string, the console ignore style it cannot parse. But if a string looks like an option (`<setting=value>`) for instance, instead of displaying the text as is, it currently throws an exception.
Commits
-------
8814920 [Console] fixed style creation when providing an unknown tag option
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11605).
Discussion
----------
[WebProfilerBundle] Fix typos and syntax in Profiler controller method comments
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
be03b75 fix typos and syntax in Profiler controller method comments
If the raw values are passed to the processor, config values don't
necessarily have the expected data type. For example, the value of
the kernel.debug parameter is a boolean type. But when passed as the
raw parameter name, it is a string.
The config:debug and yaml:lint commands use classes from the Yaml
component. Therefore, the installation of these packages should be
suggested to the user.
* 2.4:
[HttpKernel] added an analyze of environment parameters for built-in server.
change command to which available under most unix systems
add way to test command under windows
fix shell command injection
[Form] allowed CallbackTransformer to use callable
[Process] Added process synchronization to the incremental output tests
* 2.3:
[HttpKernel] added an analyze of environment parameters for built-in server.
change command to which available under most unix systems
add way to test command under windows
fix shell command injection
[Form] allowed CallbackTransformer to use callable
[Process] Added process synchronization to the incremental output tests
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10914).
Discussion
----------
[HttpKernel] added an analyze of environment parameters for built-in server
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | #10208
| License | MIT
| Doc PR | -
With the built-in server, it is not possible to use the external parameters: environment variables are only in `$_ENV`.
Commits
-------
696b978 [HttpKernel] added an analyze of environment parameters for built-in server.
This PR was merged into the 2.5 branch.
Discussion
----------
[Validator] Removed legacy validator classes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This PR removes the legacy validator classes again and adds the API checks inside the constraint validators instead.
Commits
-------
e844ed0 [Validator] Removed legacy validator classes
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Added process synchronization to the incremental output tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
The tests currently fail from time to time if the executing machine is under
heavy load. This leads to false negatives on Travis CI.
A side effect of the change is that the tests are much faster now.
Commits
-------
6dd3946 [Process] Added process synchronization to the incremental output tests
This PR was merged into the 2.3 branch.
Discussion
----------
[Finder] Shell escape and windows support
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Add escaping of command passed to Shell::testCommand().
Fix todo add support for windows.
Commits
-------
c70a226 change command to which available under most unix systems
85e77b1 add way to test command under windows
4fa9288 fix shell command injection
This PR was merged into the 2.5 branch.
Discussion
----------
[DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validation API
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11578
| License | MIT
| Doc PR | -
Commits
-------
f45f1ab [DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validation API
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11576).
Discussion
----------
[Form] allowed CallbackTransformer to use callable
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
I want to use the callable(i.e. inner class methods) in CallbackTransformer, but its current constructor is defined argument type hinting for \Closure so i can't.
Commits
-------
e77022b [Form] allowed CallbackTransformer to use callable
The tests currently fail from time to time if the executing machine is under
heavy load. This leads to false negatives on Travis CI.
A side effect of the change is that the tests are much faster now.
This PR was merged into the 2.5 branch.
Discussion
----------
[SecurityBundle] Added UserPasswordValidator tests for the different Validation APIs
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
0653426 [SecurityBundle] Added UserPasswordValidator tests for the different Validation APIs
