Commit Graph

16244 Commits

Author SHA1 Message Date
cmfcmf
81a1fbec42 Coding standards
static MUST be declared after the visibility (PSR-2)
2014-01-13 21:21:10 +01:00
Fabien Potencier
ac45678cb3 bug #10010 [Twig Bridge] Fixed bug in ExpressionExtension (ricbra)
This PR was squashed before being merged into the 2.4 branch (closes #10010).

Discussion
----------

[Twig Bridge] Fixed bug in ExpressionExtension

Currently it's impossible to use the expression extension in Twig as the <code> ExpressionExtension ::createExpression</code> method is defined as private which will throw an exception: <code>Fatal error: Call to private method Symfony\Bridge\Twig\Extension\ExpressionExtension::createExpression() from context '__TwigTemplate_83f94baa63f1faa30cdacee32980572936c887ef25baa389ebddd7a666db3a9b'</code>

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

521eee4 [Twig Bridge] Fixed bug in ExpressionExtension
2014-01-13 21:19:24 +01:00
Richard van den Brand
521eee42d8 [Twig Bridge] Fixed bug in ExpressionExtension 2014-01-13 21:19:24 +01:00
Fabien Potencier
0d500edc50 bug #10000 [Console] Fixed the compatibility with HHVM (stof)
This PR was squashed before being merged into the 2.3 branch (closes #10000).

Discussion
----------

[Console] Fixed the compatibility with HHVM

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | -

The only failures in the Console testsuite were due to facebook/hhvm#1327, and a workaround for this issue is easy.

This PR currently includes #9999 in it, to have a working HHVM build on Travis.

Commits
-------

ac1ba81 [Console] Fixed the compatibility with HHVM
2014-01-11 08:44:43 +01:00
Christophe Coevoet
ac1ba81834 [Console] Fixed the compatibility with HHVM 2014-01-11 08:44:43 +01:00
Fabien Potencier
13064f59ee minor #9999 Fixed the Travis setup for HHVM (stof)
This PR was squashed before being merged into the 2.3 branch (closes #9999).

Discussion
----------

Fixed the Travis setup for HHVM

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | -

this replaces #9997 with a proper fix: fixing the cause of the issue instead of adding workarounds for it

"php -r" does not seem to behave properly in HHVM, so the check to detect HHVM has been switch to a check on the environment variable set by Travis.

Commits
-------

67d4959 Fixed the Travis setup for HHVM
2014-01-11 08:42:48 +01:00
Christophe Coevoet
67d49598b9 Fixed the Travis setup for HHVM 2014-01-11 08:42:47 +01:00
Fabien Potencier
7a995ce5bc minor #9991 Fix for a couple of undefined classes in docblocks (dave1010)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #9991).

Discussion
----------

Fix for a couple of undefined classes in docblocks

These are the 2 that I've come across, but there may be some more.

Commits
-------

3918d6d Fix for a couple of undefined classes in docblocks
2014-01-10 15:42:38 +01:00
Dave Hulbert
d4e32c62f5 Fix for a couple of undefined classes in docblocks 2014-01-10 15:42:33 +01:00
Fabien Potencier
228ef22f32 bug #9979 [Doctrine Bridge][Validator] Fix for null values in assosiated properties when using UniqueEntityValidator (vpetrovych)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #9979).

Discussion
----------

[Doctrine Bridge][Validator] Fix for null values in assosiated properties when using UniqueEntityValidator

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7382
| License       | MIT
| Doc PR        |

This fixes issue with UniqueEntityValidator when ignoreNull = false and associated property contains null value:
```
Warning: ReflectionProperty::getValue() expects parameter 1 to be object, null given in [...]/symfony2/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php line 670
```

Here's what docs say about ignoreNull:

> If this option is set to true, then the constraint will allow multiple entities to have a null value for a field without failing validation. If set to false, only one null value is allowed - if a second entity also has a null value, validation would fail.

Commits
-------

bf368bc [Doctrine Bridge][Validator] Fix for null values in assosiated properties when using UniqueEntityValidator
2014-01-09 21:30:14 +01:00
Vladyslav Petrovych
8ddb74adaa Fix for null values in assosiated properties when using UniqueEntityValidator 2014-01-09 21:30:13 +01:00
Miha Vrhovnik
4791351d78 Prevent WDT from creating a session 2014-01-09 13:15:03 +01:00
Fabien Potencier
dea0a7bba4 bug #9983 [TwigBridge] Update min. version of Twig (stloyd)
This PR was merged into the 2.3 branch.

Discussion
----------

[TwigBridge] Update min. version of Twig

| Q             | A
| ------------- | ---
| Bug fix?      | kinda
| New feature?  | no
| BC breaks?    | no
| Tests pass?   | yes
| License       | MIT

The minimal version of Twig must be 1.12 because of usage the method `Twig_SimpleFunction` that was added in that version.

Commits
-------

c003291 [TwigBridge] Update min. version of Twig
2014-01-09 12:05:21 +01:00
Joseph Bielawski
c003291235 [TwigBridge] Update min. version of Twig
The minimal version of Twig must be 1.12 because of usage the method `Twig_SimpleFunction` that was added in that version.
2014-01-09 11:59:13 +01:00
Fabien Potencier
a5b4aad45b bug #9970 [CssSelector] fixed numeric attribute issue (jfsimon)
This PR was merged into the 2.3 branch.

Discussion
----------

[CssSelector] fixed numeric attribute issue

This PR adds a cast from number to string when parsing a numeric attribute value.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9968

Commits
-------

613535a [CssSelector] fixed numeric attribute issue
2014-01-07 21:11:44 +01:00
Jean-François Simon
613535a4d0 [CssSelector] fixed numeric attribute issue 2014-01-07 20:32:21 +01:00
Fabien Potencier
0ebf99bc07 bug #9747 [DoctrineBridge] Fix: Add type detection. Needed by pdo_dblib (iamluc)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #9747).

Discussion
----------

[DoctrineBridge] Fix: Add type detection. Needed by pdo_dblib

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

75f5cc3 Add type detection. Needed by pdo_dblib
2014-01-07 17:16:08 +01:00
iamluc
bd78fbd1c3 Add type detection. Needed by pdo_dblib 2014-01-07 17:16:07 +01:00
Fabien Potencier
795599911e udpated LICENSE year 2014-01-07 14:29:32 +01:00
Fabien Potencier
30e66fa773 Merge branch '2.3' into 2.4
* 2.3:
  update year on licenses
  rundown and typo fix
  [Process] Fix #9861 : Revert TTY mode
  [Form] Update minimal requirement in composer.json
  Fix Empty translations with Qt files
  Update UPGRADE-2.3.md to account for #9388

Conflicts:
	src/Symfony/Component/Validator/Tests/Constraints/LessThanValidatorTest.php
2014-01-07 14:28:54 +01:00
Fabien Potencier
2cc6bdaad1 minor #9965 [All] update license year to 2014 (cordoval)
This PR was merged into the 2.3 branch.

Discussion
----------

[All] update license year to 2014

| Q             | A   |
| ---           | --- |
| Bug fix?      | n   |
| New feature?  | n   |
| BC breaks?    | n   |
| Deprecations? | n   |
| Tests pass?   | y   |
| Fixed tickets | na  |
| License       | MIT |
| Doc PR        | na  |

 Sent using [Gush](https://github.com/cordoval/gush)

sorry about the previous PR now closed, forgot Gush had branched off of master and not 2.3

Commits
-------

8ace5f9 update year on licenses
2014-01-07 14:28:10 +01:00
Fabien Potencier
c0dcb7809b minor #9964 [Validator] rundown with some typo fixes and consistency (cordoval)
This PR was merged into the 2.3 branch.

Discussion
----------

[Validator] rundown with some typo fixes and consistency

| Q             | A   |
| ---           | --- |
| Bug fix?      | no  |
| New feature?  | no  |
| BC breaks?    | no  |
| Deprecations? | no  |
| Tests pass?   | yes |
| Fixed tickets | na  |
| License       | MIT |
| Doc PR        | na  |

 Sent using [Gush](https://github.com/cordoval/gush)

Commits
-------

dcd23df rundown and typo fix
2014-01-07 14:26:01 +01:00
Luis Cordova
8ace5f9f0d update year on licenses 2014-01-07 08:19:25 -05:00
Luis Cordova
dcd23df424 rundown and typo fix 2014-01-07 07:58:55 -05:00
Fabien Potencier
a0c5c6bcd3 bug #9962 [Process] Fix #9861 : Revert TTY mode (romainneutron)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fix #9861 : Revert TTY mode

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9861
| License       | MIT

This revert the TTY mode support for the process component

Commits
-------

160b1cf [Process] Fix #9861 : Revert TTY mode
2014-01-07 10:32:57 +01:00
Romain Neutron
160b1cfae8 [Process] Fix #9861 : Revert TTY mode 2014-01-07 10:16:01 +01:00
Fabien Potencier
b208dcebb9 bug #9960 [Form] Update minimal requirement in composer.json (stloyd)
This PR was merged into the 2.3 branch.

Discussion
----------

[Form] Update minimal requirement in composer.json

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Tests pass?   | yes
| Fixed tickets | #9959
| License       | MIT

Minimal requirement for PropertyAccess component needs to be `~2.3` as Form component depends on new method `PropertyAccess::createPropertyAccessor()`.

Commits
-------

88153b3 [Form] Update minimal requirement in composer.json
2014-01-07 09:49:58 +01:00
Joseph Bielawski
88153b3aa5 [Form] Update minimal requirement in composer.json
Minimal requirement for PropertyAccess component needs to be `~2.3` as Form component depends on new method `PropertyAccess::createPropertyAccessor()`
2014-01-07 09:39:31 +01:00
Fabien Potencier
b2d594daa0 bug #9952 [Translator] Fix Empty translations with Qt files (vlefort)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #9952).

Discussion
----------

[Translator] Fix Empty translations with Qt files

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | n/a
| Fixed tickets | no
| License       | MIT
| Doc PR        |

When you use ts files, QtLinguist, generate empty string for all translations, even if there are not translated yet.

It could be a good idea to generate an entry in the MessageCatalogue only if translation value is not empty.

Commits
-------

1c220be [Translator] Fix Empty translations with Qt files
2014-01-07 09:33:09 +01:00
Vincent LEFORT
7eacc5adf5 Fix Empty translations with Qt files 2014-01-07 09:33:09 +01:00
Fabien Potencier
9b5017c8b6 bug #9957 [Console] Fixed command name guessing if an alternative is an alias (jakzal)
This PR was merged into the 2.4 branch.

Discussion
----------

[Console] Fixed command name guessing if an alternative is an alias

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9953
| License       | MIT
| Doc PR        | -

Commits
-------

ade448c [Console] Fixed command name guessing if an alternative is an alias.
2014-01-07 09:25:44 +01:00
Jakub Zalas
ade448cf10 [Console] Fixed command name guessing if an alternative is an alias. 2014-01-06 22:33:02 +00:00
Fabien Potencier
3ae496ee4d minor #9804 [Form] Update UPGRADE-2.3.md to account for #9388 (ureimers)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #9804).

Discussion
----------

[Form] Update UPGRADE-2.3.md to account for #9388

Added documentation for how to correctly pre-fill a form using the form's `data` option.
The "old" and also wrong way of doing it broke with Symfony 2.3.7 (with https://github.com/symfony/symfony/pull/9388 to be precise) and this short documentation should help others to fix the problem and do it right.

Commits
-------

5e06535 [Form] Update UPGRADE-2.3.md to account for #9388
2014-01-06 17:31:17 +01:00
ureimers
8a7397425a Update UPGRADE-2.3.md to account for #9388 2014-01-06 17:31:17 +01:00
Fabien Potencier
73edae9a79 Merge branch '2.3' into 2.4
* 2.3:
  [WebProfilerBundle] Fixed profiler toolbar icons for XHTML.
  [BrowserKit] Throw exception on invalid cookie expiration timestamp
  [Propel1Bridge][ModelChoiceList] add exception message for invalid classes
2014-01-06 17:19:55 +01:00
Fabien Potencier
6e0848dce2 bug #9948 [WebProfilerBundle] Fixed profiler toolbar icons for XHTML. (rafalwrzeszcz)
This PR was squashed before being merged into the 2.3 branch (closes #9948).

Discussion
----------

[WebProfilerBundle] Fixed profiler toolbar icons for XHTML.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | n/a
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Profiler page itself is entirely autonomic, but toolbar is not - unfortunately currently it doesn't work in XHTML documents :(.

#9877 backported to `2.3` branch.

Commits
-------

296c4d1 [WebProfilerBundle] Fixed profiler toolbar icons for XHTML.
2014-01-06 17:19:21 +01:00
Rafał Wrzeszcz
296c4d1def [WebProfilerBundle] Fixed profiler toolbar icons for XHTML. 2014-01-06 17:19:20 +01:00
Fabien Potencier
956fa58227 bug #9933 Propel1 exception message (jaugustin)
This PR was merged into the 2.3 branch.

Discussion
----------

Propel1 exception message

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9932
| License       | MIT
| Doc PR        | none

This add exception message for `ModelChoiceList` and `ModelType` when `class` parameter is not provided or invalid

Commits
-------

047492f [Propel1Bridge][ModelChoiceList] add exception message for invalid classes
2014-01-06 17:10:21 +01:00
Fabien Potencier
34c0f1bb0f bug #9949 [BrowserKit] Throw exception on invalid cookie expiration timestamp (anlutro)
This PR was squashed before being merged into the 2.3 branch (closes #9949).

Discussion
----------

[BrowserKit] Throw exception on invalid cookie expiration timestamp

Currently, if an invalid timestamp is provided, a fatal error with no stack trace will occur, making it difficult to trace the problem.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

8df535d [BrowserKit] Throw exception on invalid cookie expiration timestamp
2014-01-06 17:03:23 +01:00
Andreas
8df535dbf9 [BrowserKit] Throw exception on invalid cookie expiration timestamp 2014-01-06 17:03:23 +01:00
Fabien Potencier
def4d7cb93 Merge branch '2.3' into 2.4
* 2.3:
  Revert "bug #9601 [Routing] Remove usage of deprecated _scheme requirement (Danez)"
2014-01-06 08:27:58 +01:00
Fabien Potencier
146e6663ef Revert "bug #9601 [Routing] Remove usage of deprecated _scheme requirement (Danez)"
This reverts commit 0af3d19c38, reversing
changes made to d56cc4b2cb.
2014-01-06 08:27:41 +01:00
Fabien Potencier
439664dabd bumped Symfony version to 2.4.2 2014-01-05 11:33:23 +01:00
Fabien Potencier
377a5fb23b updated VERSION for 2.4.1 2014-01-05 03:12:11 +01:00
Fabien Potencier
ae962797df updated CHANGELOG for 2.4.1 2014-01-05 03:12:05 +01:00
Fabien Potencier
8cc2414c96 Merge branch '2.3' into 2.4
* 2.3:
  bumped Symfony version to 2.3.10
  updated VERSION for 2.3.9
  update CONTRIBUTORS for 2.3.9
  updated CHANGELOG for 2.3.9
  Add support SAPI cli-server
  Fix hardcoded listenerTag name in error message
  [HttpFoundation] Documented public properties.
  [Routing] add missing unit tests for Route and RouteCollection classes

Conflicts:
	src/Symfony/Component/HttpKernel/Kernel.php
	src/Symfony/Component/Routing/Tests/RouteCollectionTest.php
2014-01-05 03:10:50 +01:00
Fabien Potencier
e7df0cfecd bumped Symfony version to 2.3.10 2014-01-05 03:02:33 +01:00
Fabien Potencier
ee1e0f2ef8 updated VERSION for 2.3.9 2014-01-05 02:24:54 +01:00
Fabien Potencier
e9356832fd update CONTRIBUTORS for 2.3.9 2014-01-05 02:24:39 +01:00
Fabien Potencier
08bd497e7d updated CHANGELOG for 2.3.9 2014-01-05 02:24:22 +01:00