Commit Graph

52714 Commits

Author SHA1 Message Date
Christian Flothmann
126105146f apply the sort callback on the whole search result 2021-01-04 15:07:41 +01:00
Christian Flothmann
28b6051f53 take query and request parameters into account when matching routes 2021-01-04 14:59:34 +01:00
Gerard Berengué
caa59fae81
mistake 2021-01-04 14:29:17 +01:00
Christian Flothmann
4c5cff6558 throw type error when incompatible types are passed 2021-01-04 13:51:17 +01:00
Christian Flothmann
5b9e187631 Merge branch '5.1' into 5.2
* 5.1:
  harden test to not depend on the actual time
  [ProxyManager] fix tests
  actually compare the order of entries when any sorting is applied
  Dump abstract arguments
2021-01-04 13:41:39 +01:00
Christian Flothmann
74d8fb897a Merge branch '4.4' into 5.1
* 4.4:
  harden test to not depend on the actual time
  [ProxyManager] fix tests
  actually compare the order of entries when any sorting is applied
2021-01-04 13:34:36 +01:00
Fabien Potencier
0304f754b3 minor #39705 [ProxyManager] fix tests (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[ProxyManager] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

5ec2a252ee [ProxyManager] fix tests
2021-01-04 13:05:33 +01:00
Fabien Potencier
135a9b20af minor #39704 [Finder] actually compare the order of entries when any sorting is applied (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Finder] actually compare the order of entries when any sorting is applied

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Without this change the tests where still passing if the sorting didn't work as expected. There are three more tests that sort by file times. I do not really know how to make them more stable though.

Commits
-------

f1ed653eee actually compare the order of entries when any sorting is applied
2021-01-04 13:04:05 +01:00
Fabien Potencier
b9bdb8e5ed minor #39706 [HttpKernel] harden test to not depend on the actual time (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] harden test to not depend on the actual time

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

From time to time this test fails (e.g. https://travis-ci.com/github/symfony/symfony/jobs/468014427#L7092). We can fix that by not depending on the system clock which is actually not needed in this test.

Commits
-------

28a956baa9 harden test to not depend on the actual time
2021-01-04 13:01:41 +01:00
Christian Flothmann
28a956baa9 harden test to not depend on the actual time 2021-01-04 12:47:44 +01:00
Nicolas Grekas
5ec2a252ee [ProxyManager] fix tests 2021-01-04 12:30:20 +01:00
Christian Flothmann
f1ed653eee actually compare the order of entries when any sorting is applied 2021-01-04 12:28:59 +01:00
Fabien Potencier
b76d5608cf bug #39692 [FrameworkBundle] Dump abstract arguments (jderusse)
This PR was merged into the 5.1 branch.

Discussion
----------

[FrameworkBundle] Dump abstract arguments

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #24138
| License       | MIT
| Doc PR        | -

This PR fixes n exception thrown when dumping abstract arguments (ie. `./bin/console  debug:containter session.abstract_handler --show-arguments`)

Commits
-------

df769ec84c Dump abstract arguments
2021-01-04 08:57:52 +01:00
Alexander M. Turek
a378537a8e Merge branch '5.1' into 5.2
* 5.1:
  remove unneeded sprintf() call
  Fix CS
  Fix config merging in lock
  keep trailing newlines when dumping multi-line strings
  disable error bubbling by default when inherit_data is configured
2021-01-03 23:09:37 +01:00
Alexander M. Turek
3fca96d9de Merge branch '4.4' into 5.1
* 4.4:
  remove unneeded sprintf() call
  Fix CS
  Fix config merging in lock
  keep trailing newlines when dumping multi-line strings
  disable error bubbling by default when inherit_data is configured
2021-01-03 23:00:02 +01:00
Alexander M. Turek
04671ee726 minor #39694 [PropertyAccess] remove unneeded sprintf() call (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[PropertyAccess] remove unneeded sprintf() call

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

a8252a43b8 remove unneeded sprintf() call
2021-01-03 13:23:32 +01:00
Christian Flothmann
a8252a43b8 remove unneeded sprintf() call 2021-01-03 12:55:43 +01:00
Jérémy Derussé
df769ec84c
Dump abstract arguments 2021-01-03 12:32:13 +01:00
Christian Flothmann
1d0c91629a fix tests to run assertions on returned Crawler instances 2021-01-03 11:13:13 +01:00
Fabien Potencier
a902dd8a1b bug #39683 [Yaml] keep trailing newlines when dumping multi-line strings (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] keep trailing newlines when dumping multi-line strings

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix https://github.com/symfony/symfony/pull/39668#issuecomment-753484545
| License       | MIT
| Doc PR        |

Commits
-------

4c513c24c7 keep trailing newlines when dumping multi-line strings
2021-01-03 09:28:04 +01:00
Fabien Potencier
da07550827 bug #39670 [Form] disable error bubbling by default when inherit_data is configured (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] disable error bubbling by default when inherit_data is configured

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #14441
| License       | MIT
| Doc PR        |

Commits
-------

8679c2ac05 disable error bubbling by default when inherit_data is configured
2021-01-03 09:24:31 +01:00
Fabien Potencier
4bced61887 Fix CS 2021-01-03 09:19:04 +01:00
Fabien Potencier
a0d66d2ecd bug #39686 [Lock] Fix config merging in lock (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

[Lock] Fix config merging in lock

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35920
| License       | MIT
| Doc PR        | -

Commits
-------

6bb2d67cf1 Fix config merging in lock
2021-01-03 09:18:23 +01:00
Jérémy Derussé
6bb2d67cf1
Fix config merging in lock 2021-01-02 23:18:12 +01:00
Christian Flothmann
4c513c24c7 keep trailing newlines when dumping multi-line strings 2021-01-02 17:02:59 +01:00
Alexander M. Turek
0633f96941 Merge branch '5.1' into 5.2
* 5.1:
  fix postgres transport when the retry table is the same
  do not dump extra trailing newlines for multiline blocks
2021-01-01 23:54:04 +01:00
Alexander M. Turek
5c2ef6b5cf Merge branch '4.4' into 5.1
* 4.4:
  do not dump extra trailing newlines for multiline blocks
2021-01-01 21:51:20 +01:00
Fabien Potencier
04c67e61e2 bug #39668 [Yaml] do not dump extra trailing newlines for multiline blocks (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] do not dump extra trailing newlines for multiline blocks

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38310
| License       | MIT
| Doc PR        |

Commits
-------

5fa9592d5e do not dump extra trailing newlines for multiline blocks
2021-01-01 10:44:44 +01:00
Fabien Potencier
e6ba3a5e4b bug #39674 [Messenger] fix postgres transport when the retry table is the same (lyrixx)
This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger] fix postgres transport when the retry table is the same

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

---

I noticed messenger do not consume all messages when there is a retry
and when I'm using only one table for everything.

To reproduce, use the following configuration + use PG + throw an
exception in the handler

```yaml
framework:
    messenger:
        failure_transport: failed

        transports:
            async: '%env(MESSENGER_TRANSPORT_DSN)%'
            failed: 'doctrine://default?queue_name=failed'

        routing:
            'App\Message\Foobar': async
```

The real issue is PG does not notify messenger when we `UPDATE` the message.

---

ping @dunglas

Commits
-------

2b4d47163f fix postgres transport when the retry table is the same
2021-01-01 10:40:53 +01:00
Fabien Potencier
a459b44829 Bump license year 2021-01-01 10:27:05 +01:00
Fabien Potencier
2a1a4e7067 Merge branch '5.1' into 5.2
* 5.1:
  Bump license year
  Bump license year
  [Form] fix passing null $pattern to IntlDateFormatter
  Add reference link
  Update README.md
2021-01-01 10:26:45 +01:00
Fabien Potencier
46ea62297b Bump license year 2021-01-01 10:26:30 +01:00
Fabien Potencier
f4ca745086 Merge branch '4.4' into 5.1
* 4.4:
  Bump license year
  [Form] fix passing null $pattern to IntlDateFormatter
  Update README.md
2021-01-01 10:25:51 +01:00
Fabien Potencier
2c4337ae5b Bump license year 2021-01-01 10:24:35 +01:00
Grégoire Pineau
2b4d47163f fix postgres transport when the retry table is the same 2020-12-31 17:54:38 +01:00
Thomas Calvet
1c652a7649 [FrameworkBundle] Fix UidNormalizer priority 2020-12-31 17:30:56 +01:00
Christian Flothmann
8679c2ac05 disable error bubbling by default when inherit_data is configured 2020-12-31 15:25:34 +01:00
Christian Flothmann
5fa9592d5e do not dump extra trailing newlines for multiline blocks 2020-12-31 11:51:02 +01:00
Nicolas Grekas
841ec99831 bug #39653 [Form] fix passing null $pattern to IntlDateFormatter (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] fix passing null $pattern to IntlDateFormatter

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

52360c1e4e [Form] fix passing null $pattern to IntlDateFormatter
2020-12-29 14:57:58 +01:00
Nicolas Grekas
52360c1e4e [Form] fix passing null $pattern to IntlDateFormatter 2020-12-29 14:49:19 +01:00
Christian Flothmann
13a4610824 propagate groups to nested constraints 2020-12-29 11:10:22 +01:00
Nicolas Grekas
b604fd7dd8 minor #39648 [Notifier] Add missing LICENSE file (OskarStark)
This PR was merged into the 5.2 branch.

Discussion
----------

[Notifier] Add missing LICENSE file

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Commits
-------

fbd1fe0fd6 [Notifier] Add missing LICENSE file
2020-12-29 09:43:11 +01:00
Oskar Stark
fbd1fe0fd6 [Notifier] Add missing LICENSE file 2020-12-29 09:21:34 +01:00
Fabien Potencier
b42dd0bb4e Add reference link 2020-12-29 08:39:30 +01:00
Fabien Potencier
37aba3db51 bug #39637 [Security] Fix event propagation for AuthenticationTokenCreatedEvent when globally registered (scheb)
This PR was merged into the 5.2 branch.

Discussion
----------

[Security] Fix event propagation for AuthenticationTokenCreatedEvent when globally registered

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

As promised, here's the follow-up to #39621, fixing `AuthenticationTokenCreatedEvent` to be propated from the global event dispatcher to firewall-specific event dispatchers.

The event was added in Symfony 5.2, therefore the separate PR targeting the 5.2 branch.

Commits
-------

68aaf4f916 Add AuthenticationTokenCreatedEvent to be propagated
2020-12-29 08:25:13 +01:00
Fabien Potencier
e7071bdcd4 bug #39647 [Validator] Update Isin message to match the translation files (derrabus)
This PR was merged into the 5.2 branch.

Discussion
----------

[Validator] Update Isin message to match the translation files

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39645
| License       | MIT
| Doc PR        | N/A

Commits
-------

add3cdd623 [Validator] Update Isin message to match the translation files.
2020-12-29 08:18:41 +01:00
Alexander M. Turek
40677a014e minor #39646 Update README.md (abdounikarim)
This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.

Discussion
----------

Update README.md

update readme semver link to use https

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | no

I just update semver link to use https instead of http. 😉

Commits
-------

9ee2dc6d66 Update README.md
2020-12-29 01:30:08 +01:00
Alexander M. Turek
add3cdd623 [Validator] Update Isin message to match the translation files. 2020-12-29 01:25:50 +01:00
Abdouni Abdelkarim
9ee2dc6d66
Update README.md
update semver link to use https
2020-12-29 01:17:49 +01:00
Nicolas Grekas
c0d12ed98f Merge branch '5.1' into 5.2
* 5.1:
  [ProxyManagerBridge] Fix tests
  [Messenger] Fix stopwach usage if it has been reset
2020-12-28 22:49:17 +01:00