This PR was merged into the 2.3 branch.
Discussion
----------
[Form] Update minimal requirement in composer.json
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Tests pass? | yes
| Fixed tickets | #9959
| License | MIT
Minimal requirement for PropertyAccess component needs to be `~2.3` as Form component depends on new method `PropertyAccess::createPropertyAccessor()`.
Commits
-------
88153b3 [Form] Update minimal requirement in composer.json
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9952).
Discussion
----------
[Translator] Fix Empty translations with Qt files
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | n/a
| Fixed tickets | no
| License | MIT
| Doc PR |
When you use ts files, QtLinguist, generate empty string for all translations, even if there are not translated yet.
It could be a good idea to generate an entry in the MessageCatalogue only if translation value is not empty.
Commits
-------
1c220be [Translator] Fix Empty translations with Qt files
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9804).
Discussion
----------
[Form] Update UPGRADE-2.3.md to account for #9388
Added documentation for how to correctly pre-fill a form using the form's `data` option.
The "old" and also wrong way of doing it broke with Symfony 2.3.7 (with https://github.com/symfony/symfony/pull/9388 to be precise) and this short documentation should help others to fix the problem and do it right.
Commits
-------
5e06535 [Form] Update UPGRADE-2.3.md to account for #9388
This PR was squashed before being merged into the 2.3 branch (closes#9948).
Discussion
----------
[WebProfilerBundle] Fixed profiler toolbar icons for XHTML.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | n/a
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Profiler page itself is entirely autonomic, but toolbar is not - unfortunately currently it doesn't work in XHTML documents :(.
#9877 backported to `2.3` branch.
Commits
-------
296c4d1 [WebProfilerBundle] Fixed profiler toolbar icons for XHTML.
This PR was merged into the 2.3 branch.
Discussion
----------
Propel1 exception message
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9932
| License | MIT
| Doc PR | none
This add exception message for `ModelChoiceList` and `ModelType` when `class` parameter is not provided or invalid
Commits
-------
047492f [Propel1Bridge][ModelChoiceList] add exception message for invalid classes
This PR was squashed before being merged into the 2.3 branch (closes#9949).
Discussion
----------
[BrowserKit] Throw exception on invalid cookie expiration timestamp
Currently, if an invalid timestamp is provided, a fatal error with no stack trace will occur, making it difficult to trace the problem.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
8df535d [BrowserKit] Throw exception on invalid cookie expiration timestamp
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9938).
Discussion
----------
[Process] Add support SAPI cli-server
As of PHP 5.4.0, the CLI SAPI provides a built-in web server.
```php
PHP_SAPI == 'cli-server'
```
PHP can be used portable without installation on PC. For example, the [assembly](http://windows.php.net/download/) does not require installation in the system on Windows. In this case `PHP_BINARY` contains the path to the PHP executor, and all the other search methods will not return result.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
92d8323 Add support SAPI cli-server
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9940).
Discussion
----------
[EventDispatcher] Fix hardcoded listenerTag name in error message
| Q | A
| ------------- | ---
| Fixed tickets | N/A
| License | MIT
Just as the title say, there was a kernel.event_listener string hardcoded in an error message although everywhere else in this class it is stored in the `$listenerTag` property.
Commits
-------
8c91537 [EventDispatcher] Fix hardcoded listenerTag name in error message
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Documented public properties
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9670
| License | MIT
| Doc PR | -
`$request` and `$query` parameter bags could be hard to get for a newcommer, who's used to `$_POST` and `$_GET` variables. Some people claim naming makes no sense (see #9671).
For consistency I documented all public properties.
Commits
-------
1b79831 [HttpFoundation] Documented public properties.
This PR was squashed before being merged into the 2.3 branch (closes#9925).
Discussion
----------
[Routing] add missing unit tests for Route and RouteCollection classes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Just add few unit tests in Route and RouteCollection classes to have a full coverage.
Commits
-------
7bbd568 [Routing] add missing unit tests for Route and RouteCollection classes
This PR was merged into the 2.3 branch.
Discussion
----------
removed unneeded use statements
| Q | A
| ------------- | ---
| License | MIT
Commits
-------
7f9a366 removed unneeded use statements
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9112).
Discussion
----------
Prepend Child Bundle paths before the parent
This fixes#9085
Say you have AcmeDemoBundle and AppDemoBundle. AcmeDemoBundle is the parent of AppDemoBundle.
If you load templates using @AcmeDemoBundle/ControllerDir/template.html.twig it means that you cannot override the template in AppDemoBundle. The patch below prepends the AppDemoBundle Resources directory to the AcmeDemo namespace.
The namespace directories would not result in:
```
[AcmeDemo] => Array(
[0] => [absolute-dir-here]/src/App/DemoBundle/Resources/views
[1] => [absolute-dir-here]/app/Resources/AcmeDemoBundle/views
[2] => [absolute-dir-here]/src/Acme/DemoBundle/Resources/views
)
```
Commits
-------
19fad88 Prepend Child Bundle paths before the parent
This PR was merged into the 2.3 branch.
Discussion
----------
[Routing] add unit tests for Symfony\Component\Routing\RequestContext class
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
ATM, this class don't have its own unit tests. This PR fill this gap with a full coverage.
Commits
-------
c4aaa38 [Routing] add unit tests for Symfony\Component\Routing\RequestContext class
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Throw proper exception when invalid data is passed to JsonResponse class
| Q | A
| ------------- | ---
| Bug fix? | yes
| BC breaks? | no*
| Tests pass? | yes
| Fixed tickets | #9903
| License | MIT
\* as described in mentioned issue, before this PR there was thrown exception `UnexpectedValueException`, which was not correct, but I guess some people trying to hide the bug could use `try {} catch` on it.
Commits
-------
38287e7 [HttpFoundation] Throw proper exception when invalid data is passed to JsonResponse class
This PR was merged into the 2.3 branch.
Discussion
----------
[Security] fixed pre/post authentication checks
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8510, #9622
| License | MIT
| Doc PR | N/A
After further investigation of #8510, I found that all checks in the `checkPreAuth` actually belongs to `checkPostAuth` and the same goes for checks in `CheckPostAuth` (I checked the original source from Spring and indeed, that's how it is implemented there: see https://github.com/spring-projects/spring-security/blob/master/core/src/main/java/org/springframework/security/authentication/dao/AbstractUserDetailsAuthenticationProvider.java#L305
).
So, this PR fixes that issue. I think that we can do this change safely in 2.3 as the error message is the same for all causes by default (`$hideUserNotFoundExceptions` is `true` by default in `UserAuthenticationProvider`).
The only "real" change is whether the authentication is checked or not.
Commits
-------
ada82a2 [Security] fixed pre/post authentication checks
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9909).
Discussion
----------
[Validator] Updated lithuanian validator translation.
Updated lithuanian validator translation: changed 'vartotojas' to 'naudotojas' as it is more proper term.
| Q | A
| ------------- | ---
| Bug fix? | no
| License | MIT
Commits
-------
53a8621 Updated lithuanian validator translation: changed vartotojas to naudotojas as it is more proper term.
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9478).
Discussion
----------
Fixed CSS
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9474
| License | MIT
| Doc PR | -
Commits
-------
95cc5b8 Fixed CSS
This PR was merged into the 2.3 branch.
Discussion
----------
fixed some PSR-0 class names
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
a38e2c0 fixes PSR-0 issues in tests
This PR was merged into the 2.3 branch.
Discussion
----------
[Filesystem | WCM] 9339 fix stat on url for filesystem copy
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9339
| License | MIT
| Doc PR | na
supersedes https://github.com/symfony/symfony/pull/9863
Commits
-------
4fba412 adjusted behavior to always copy override on url files
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9589).
Discussion
----------
[DependencyInjection] Fixed#9020 - Added support for collections in service#parameters
Disclaimer: I made sure that tests are passing, but I am not sure how to test if it really works. By looking at the code, it should.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9020
| License | MIT
| Doc PR | needed
Commits
-------
462532e [DependencyInjection] Fixed#9020 - Added support for collections in service#parameters
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9896).
Discussion
----------
[Intl] Skip tests that need full lib-intl when there's no lib-intl
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
`NumberFormatter::formatCurrency` executes indirectly `Symfony\Component\Intl\ResourceBundle\Reader::read()`, which has `$bundle = new \ResourceBundle($locale, $path)` - there's Fatal Error if `\ResourceBundle` isn't found. Added availability to run unit tests if `lib-intl` isn't installed.
Commits
-------
6614b66 Skips test that need full lib-intl.
