This PR was merged into the 2.5-dev branch.
Discussion
----------
[Routing] Added an extension point for globals in AnnotationClassLoader
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
We need to add a new extension point for global to be able to support
`@Method` on class:
``` php
/**
* @Route("/api")
* @Method("GET")
*/
class FooBarController
{
/**
* @Route("/")
*/
public function listAction()
{
}
/**
* @Route("/new")
* @Method("POST")
*/
public function newAction()
{
}
}
```
Commits
-------
8f7524e [Routing] Added an extension point for globals in AnnotationClassLoader
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Component/Security] Fixed some phpdocs in Security/Core
| Q | A
| ------------- | ---
| Bug fix? | kinda*
| New feature? | no
| License | MIT
\* - those missing phpdocs lead to problems when debugging with IDE, as well as some were wrong (i.e. `SecurityContextInterface::isGranted()`) as parameters differ in interface & class implementing it
Commits
-------
80fae1d [Component/Security] Fixed some phpdocs in Security/Core
This PR was squashed before being merged into the 2.5-dev branch (closes#9405).
Discussion
----------
[FrameworkBundle] Added a helper method to create AccessDeniedException
Just a small helper method that has been missing, since the addition of createNotFoundException().
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
183d0ec [FrameworkBundle] Added a helper method to create AccessDeniedException
This PR was merged into the 2.3 branch.
Discussion
----------
Fixed validators.nl.xlf
Source of trans-unit id 72 was incorrect.
Made two minor grammar updates.
Commits
-------
6c05b1d Fixed validators.nl.xlf
This PR was submitted for the 2.4-dev branch but it was merged into the 2.4 branch instead (closes#10042).
Discussion
----------
[Expression Language] fix foo[index]
| Q | A |
|----|-----|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR | |
This patch fixes the usage of variables as key in GetAttrNode.
```php
$language = new \Symfony\Component\ExpressionLanguage\ExpressionLanguage();
$language->evaluate('foo[i]', ['foo' => ['a', 'b', 'c'], 'i' => 1]); // 'b'
```
Commits
-------
f657d03 [Expression Language] fix foo[index]
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Completed Luxembourgish translation
Commits
-------
d7a41f3 Completed Luxembourgish translation
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#10033).
Discussion
----------
[HttpKernel] Bugfix - Logger Deprecation Notice
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This PR fixes the Logger deprecation notices to match the correct method name it should be informing of.
Commits
-------
c55cc46 Fixing the Logger deprecation notices to match the correct method name it should be informing of
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] Thrown an HttpException instead returning a Response in RedirectController::redirectAction()
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9243
| License | MIT
| Doc PR | -
I'm considering this to be a bug fix, since before, a missing path or route name would result in rendering a blank page.
Commits
-------
3097ec6 [FrameworkBundle] Thrown an HttpException instead returning a Response in order to show an error page when path is not defined.
This PR was squashed before being merged into the 2.5-dev branch (closes#9967).
Discussion
----------
Form debugger storage
This PR continues #9857
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9123
| License | MIT
| Doc PR | -
Commits
-------
744da7f Form debugger storage
This PR was squashed before being merged into the 2.5-dev branch (closes#9980).
Discussion
----------
[Routing][FrameworkBundle] Deprecated the apache dumper
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | #9652
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/3446
Commits
-------
6258cfa [Routing][FrameworkBundle] Deprecated the apache dumper
This PR was merged into the 2.3 branch.
Discussion
----------
Prevent WDT from creating a session
The wdt should not create a session.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: N/A
Todo: -
License of the code: MIT
Documentation PR: N/A
Commits
-------
4791351 Prevent WDT from creating a session
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10006).
Discussion
----------
Fixed coding standards (PSR-2)
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | ---
| Fixed tickets | ---
| License | MIT
| Doc PR | ---
> static MUST be declared after the visibility
-- (PSR-2)
Commits
-------
2fbc833 Coding standards
This PR was squashed before being merged into the 2.4 branch (closes#10010).
Discussion
----------
[Twig Bridge] Fixed bug in ExpressionExtension
Currently it's impossible to use the expression extension in Twig as the <code> ExpressionExtension ::createExpression</code> method is defined as private which will throw an exception: <code>Fatal error: Call to private method Symfony\Bridge\Twig\Extension\ExpressionExtension::createExpression() from context '__TwigTemplate_83f94baa63f1faa30cdacee32980572936c887ef25baa389ebddd7a666db3a9b'</code>
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
521eee4 [Twig Bridge] Fixed bug in ExpressionExtension
This PR was squashed before being merged into the 2.3 branch (closes#10000).
Discussion
----------
[Console] Fixed the compatibility with HHVM
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
The only failures in the Console testsuite were due to facebook/hhvm#1327, and a workaround for this issue is easy.
This PR currently includes #9999 in it, to have a working HHVM build on Travis.
Commits
-------
ac1ba81 [Console] Fixed the compatibility with HHVM
This PR was squashed before being merged into the 2.3 branch (closes#9999).
Discussion
----------
Fixed the Travis setup for HHVM
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
this replaces #9997 with a proper fix: fixing the cause of the issue instead of adding workarounds for it
"php -r" does not seem to behave properly in HHVM, so the check to detect HHVM has been switch to a check on the environment variable set by Travis.
Commits
-------
67d4959 Fixed the Travis setup for HHVM
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Form] Errors now reference the field they were added to and the violation/exception that caused them
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9472, #9582
| License | MIT
| Doc PR | -
Commits
-------
c8a0ee6 [Form] Errors now reference the field they were added to and the violation/exception that caused them
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9991).
Discussion
----------
Fix for a couple of undefined classes in docblocks
These are the 2 that I've come across, but there may be some more.
Commits
-------
3918d6d Fix for a couple of undefined classes in docblocks
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9979).
Discussion
----------
[Doctrine Bridge][Validator] Fix for null values in assosiated properties when using UniqueEntityValidator
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7382
| License | MIT
| Doc PR |
This fixes issue with UniqueEntityValidator when ignoreNull = false and associated property contains null value:
```
Warning: ReflectionProperty::getValue() expects parameter 1 to be object, null given in [...]/symfony2/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php line 670
```
Here's what docs say about ignoreNull:
> If this option is set to true, then the constraint will allow multiple entities to have a null value for a field without failing validation. If set to false, only one null value is allowed - if a second entity also has a null value, validation would fail.
Commits
-------
bf368bc [Doctrine Bridge][Validator] Fix for null values in assosiated properties when using UniqueEntityValidator
This PR was merged into the 2.3 branch.
Discussion
----------
[TwigBridge] Update min. version of Twig
| Q | A
| ------------- | ---
| Bug fix? | kinda
| New feature? | no
| BC breaks? | no
| Tests pass? | yes
| License | MIT
The minimal version of Twig must be 1.12 because of usage the method `Twig_SimpleFunction` that was added in that version.
Commits
-------
c003291 [TwigBridge] Update min. version of Twig
This PR was merged into the 2.5-dev branch.
Discussion
----------
Upgrade File for 2.5
Added upgrade info for #9601, as this pr might break code which overwrites this method and also to respect symfony/symfony-docs#3439.
Commits
-------
fefcf41 Added upgrade info for #9601
This PR was merged into the 2.3 branch.
Discussion
----------
[CssSelector] fixed numeric attribute issue
This PR adds a cast from number to string when parsing a numeric attribute value.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9968
Commits
-------
613535a [CssSelector] fixed numeric attribute issue
