This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#8432).
Discussion
----------
[BrowserKit] CookieJar remove unneeded var, Client remove unneeded else
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
10c6799 [BrowserKit] CookieJar remove unneeded var, Client remove unneeded else
This PR was squashed before being merged into the 2.3 branch (closes#8435).
Discussion
----------
[DI] Fixed bug requesting non existing service from dumped frozen container
When dumping a frozen container without aliases, the method `Container::has()` will throw a *"Warning: array_key_exists() expects parameter 2 to be array, null given"* warning. It's because `PhpDumper::addAliases` returns `''` if no aliases are given. This will work for a normal constructor, because it calls the `Container::__construct` method, but the frozen constructor doesn't do that. So it requires a `$this->aliases = array();` in the constructor.
This PR fixes this bug (and adds the test). Bug is introduced in #8252 and 63367a3d5615ff65251ccee4f73223107275f65f
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
8bb4e4d [DI] Fixed bug requesting non existing service from dumped frozen container
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#8411).
Discussion
----------
Update validators.sk.xlf
updatet pluralization translations for lenght validators
Commits
-------
00c2e5c Update validators.sk.xlf
This PR was merged into the master branch.
Discussion
----------
[Filesystem] create FilesystemTestCase from FilesystemTest
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
FilesystemTest methods are useful for testing any class are working with file system
Commits
-------
266df16 [Filesystem] create FilesystemTestCase from FilesystemTest
This PR was merged into the 2.2 branch.
Discussion
----------
Passed the config when building the Configuration in ConfigurableExtension
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This passes the config to ``getConfiguration`` instead of passing an empty array in ConfigurableExtension. This makes the class usable for bundle overwriting the ``getConfiguration`` method to use the config instead of using the default logic (which does not need the config).
Commits
-------
a830001 Passed the config when building the Configuration in ConfigurableExtension
This PR was merged into the master branch.
Discussion
----------
Bumping max version of ProxyManager, supporting 0.4.0
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
18352fc Bumping max version of ProxyManager, supporting 0.4.0
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8400).
Discussion
----------
Replace romaji period characters with Japanese style zenkaku period char...
...acters
Found 4 of the Japanese translations inconsistently used romaji style periods. Replaced with zenkaku periods.
Commits
-------
1b3b1a7 Replace romaji period characters with Japanese style zenkaku period characters
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] Avoided an unnecessary check if a stream is an interactive terminal
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
It only makes sense to do the second check, if the first one evaluates to false (so the `--no-interaction` option was not passed).
Running `posix_isatty()` raises a warning with some stream types (like in-memory stream). With this patch, warning could be avoided by passing the `--no-interaction option` (which is what we want with an in-memory stream).
The warning I'm getting is:
```
PHP Warning: posix_isatty(): could not use stream of type 'MEMORY' in vendor/symfony/console/Symfony/Component/Console/Application.php on line 866
```
Commits
-------
e46fd4e [Console] Avoided an unnecessary check.
It only makes sense to do the second check if the --no-interaction
option was not passed.
Running posix_isatty() raises a warning with some stream types (like MEMORY).
With this patch, warning could be avoided by passing the --no-interaction option.
This PR was merged into the 2.3 branch.
Discussion
----------
Added missing French validator translations
Commits
-------
0cc8872 Added missing French validator translations
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8363).
Discussion
----------
typo first->second
Commits
-------
2d9a84b typo first->second
This PR was submitted for the 2.3 branch but it was merged into the master branch instead (closes#8339).
Discussion
----------
[Routing] Add an extension-point for DI into the Matcher/Generator Dumpers
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
The Routing's MatcherDumper and GeneratorDumper classes are instantiated very deeply into the `Router::getGenerator()` and `Router::getMatcher()` methods.
This pull requests aims to :
1. separate the instances creation
2. ease overriding (lesser risks of changes at framework updates)
3. ease dependencies injection for these classes (as we can't inject dependencies in another way, be it service definition, compiler pass or whatever I'm aware of).
An example of usage would be the following : https://gist.github.com/gnutix/5844630
It's a real case I'm having in my company's current project.
Commits
-------
5a03a7f [Routing] Add an extension-point for DI into the Matcher/Generator Dumpers
This PR was submitted for the 2.3 branch but it was merged into the 2.2 branch instead (closes#8310).
Discussion
----------
[FrameworkBundle] Fixed variable name used in translation cache
This simply fixes the `$catalogueXXX` variable name used in the translation cache files in case the user use locales such as `en-US`, the generated variable's name was `$catalogueEn-Us`, with this fix it will be `$catalogueEnUs`.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7824
| License | MIT
| Doc PR | -
Commits
-------
e50399c [FrameworkBundle] Fixed variable name used in translation cache
* 2.3: (33 commits)
[Form] fixed INF usage which does not work on Solaris (closes#8246)
Fix grammar
Removed PHP 5.5 from the allowed failures.
[Intl] Fixed tests failing on PHP 5.5
bumped Symfony version to 2.2.4
updated VERSION for 2.2.3
update CONTRIBUTORS for 2.2.3
updated CHANGELOG for 2.2.3
[DependencyInjection] Replaced try/catch block with an @expectedException annotation in a test.
[CssSelector] tweaked README file (closes#8287)
added a node about HTML extension in readme
[Console] Fixed the table rendering with multi-byte strings.
Feature/fix unit tests
[Process] Disable exception on stream_select timeout
[HttpFoundation] fixed issue with session_regenerate_id (closes#7380)
[DomCrawler] added a note about the default charset
Throw exception if value is passed to VALUE_NONE input, long syntax
fixed date type format pattern regex
[Security] fixed usage of the salt for the bcrypt encoder (refs #8210)
[FrameworkBundle] tweaked previous merge (refs #8242)
...
Conflicts:
src/Symfony/Component/HttpKernel/Kernel.php
* 2.2:
[Form] fixed INF usage which does not work on Solaris (closes#8246)
Fix grammar
bumped Symfony version to 2.2.4
updated VERSION for 2.2.3
update CONTRIBUTORS for 2.2.3
updated CHANGELOG for 2.2.3
[Process] Disable exception on stream_select timeout
[HttpFoundation] fixed issue with session_regenerate_id (closes#7380)
[DomCrawler] added a note about the default charset
[Console] fixed regression when calling a command foo:bar if there is another one like foo:bar:baz (closes#8245)
force the Content-Type to html in the web profiler controllers
Conflicts:
src/Symfony/Component/HttpKernel/Kernel.php
This PR was merged into the 2.3 branch.
Discussion
----------
[Intl] Fixed tests failing on PHP 5.5 and removed this version from the allowed failures
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
69ec7c8 Removed PHP 5.5 from the allowed failures.
3492186 [Intl] Fixed tests failing on PHP 5.5
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8337).
Discussion
----------
Fix grammar
Commits
-------
4163f71 Fix grammar
This PR was submitted for the 2.3 branch but it was merged into the master branch instead (closes#8302).
Discussion
----------
[Config] Allow to get parent of BaseNode
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no (improvement)
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Like an ArrayNode have method `getChildren`, I might to be good idea for having method `getParent` of all nodes.
Commits
-------
a9a7ecc [Config] Allow to get parent of BaseNode
