This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] Add the missing translations for the Portuguese ("pt") locale
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #30181
| License | MIT
This PR addresses the issue https://github.com/symfony/symfony/issues/30181, adding the missing translations.
Commits
-------
95795dc8cd add_missing_translations_for_portuguese : [Validator] Add the missing translations for the Portuguese ("pt") locale
This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] Add the missing translations for the French (fr) locale
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #30164
| License | MIT
| Doc PR | -
To simplify things, translated files contains all the keys of the French file in `master` branch. That's why our translations in 3.4 branch contain the keys `id = 84` and `id = 85` even if that is not used in 3.4 branch.
I propose to also include that unused key in the French file to make it easier to keep things in sync.
Commits
-------
9a86504fc1 [Validator] Add the missing translations for the French (fr) locale
This PR was merged into the 4.3-dev branch.
Discussion
----------
[FrameworkBundle] consolidate the mime types service definition
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
I wonder if we couldn't simplify things by just initializing the default `MimeTypes` instance once the first one is going to be created.
Commits
-------
ce546f5e5b consolidate the mime types service definition
This PR was squashed before being merged into the 4.3-dev branch (closes#30111).
Discussion
----------
[SecurityBundle] Deprecate the normalization of the cookie names
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This is an alternative solution to #24018 providing a BC layer until Symfony 5.0.
Commits
-------
36c5df4589 [SecurityBundle] Deprecate the normalization of the cookie names
This PR was merged into the 3.4 branch.
Discussion
----------
[Security] fix switch user without having current token
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #22729
| License | MIT
Attempting to switch a user cause an error when not having any token in the storage
Commits
-------
15db914984 [Security] fix switch user without having current token
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] add back test after fixing it
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/29934#discussion_r250501108
| License | MIT
| Doc PR |
Commits
-------
0daeba8e8a add back test after fixing it
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes#30136).
Discussion
----------
use PropertyAccessorInterface instead of PropertyAccessor
[Validator] [Constraints] use PropertyAccessorInterface instead of PropertyAccessor
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #30133 (partially)
| License | MIT
| Doc PR | none
Commits
-------
3e3ca9d467 use PropertyAccessorInterface instead of PropertyAccessor
This PR was merged into the 3.4 branch.
Discussion
----------
[PhpunitBridge] dropping ext-zip suggestion as its no longer needed
| Q | A
| ------------- | ---
| Branch? | 3.4 <!-- see below -->
| Bug fix? | yes
| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| License | MIT
The zip requirement was dropped after this pull request: https://github.com/symfony/symfony/pull/29265
Commits
-------
bb4b53bc45 Update composer.json
This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] Added a missing translation
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
34698372e4 [Validator] Added a missing translation
This PR was squashed before being merged into the 3.4 branch (closes#30124).
Discussion
----------
Fix KernelTestCase compatibility for PhpUnit 8 (bis)
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Follow up of #30084 and @Tobion's comment there.
Fabbot failure is a false-positive.
Commits
-------
1077df60ab Fix KernelTestCase compatibility for PhpUnit 8 (bis)
This PR was merged into the 3.4 branch.
Discussion
----------
add xabbuh as code owner of the Form component
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
d0ae383517 add xabbuh as code owner of the Form component
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] add missing null return type
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This reflects how all our implementations of this interface actually behave.
Commits
-------
03abfc09bd add missing null return type
This PR was merged into the 4.3-dev branch.
Discussion
----------
[WebProfilerBundle] Add ajax request number
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #30121
| License | MIT
Add request number foreach ajax call in profiler.
![screenshot_2019-02-10_18-54-02](https://user-images.githubusercontent.com/9253091/52537598-c830c980-2d68-11e9-815e-90345b6bbd88.png)
Commits
-------
70a38cfdfd [WebProfilerBundle] Add ajax request number
This PR was merged into the 4.2 branch.
Discussion
----------
[Form] replace mocks with real objects in tests
| Q | A
| ------------- | ---
| Branch? | 4.2
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
reapplies parts of #30108 on the `4.2` branch
Commits
-------
cee3ccd70f replace mocks with real objects in tests
* 4.2:
New extensions were released supporting PHP 7.3
Remove "internal" annotation from datacollector serialization methods
replace mocks with real objects in tests
[DependencyInjection] fix#29930 add $lazyLoad flag to the generated factory code for lazy non-shared services
escape function does not always take a string
Fix phpunit 8 compatibility
render integer types with grouping as text input
ignore _method forms in NativeRequestHandler
don't lose int precision with not needed type casts
* 3.4:
Remove "internal" annotation from datacollector serialization methods
replace mocks with real objects in tests
Fix phpunit 8 compatibility
render integer types with grouping as text input
ignore _method forms in NativeRequestHandler
don't lose int precision with not needed type casts
This PR was merged into the 3.4 branch.
Discussion
----------
Remove "internal" annotation from datacollector serialization methods
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
I've been a bit too aggressively adding `@internal` in #30035.
Commits
-------
3c8fd2072f Remove "internal" annotation from datacollector serialization methods
This PR was merged into the 4.2 branch.
Discussion
----------
New extensions were released supporting PHP 7.3
| Q | A
| ------------- | ---
| Branch? | 4.2
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | see travis
| License | MIT
Requested in #30030
Commits
-------
31de71d216 New extensions were released supporting PHP 7.3
This PR was merged into the 4.3-dev branch.
Discussion
----------
[FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configuration
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #29830
| License | MIT
| Doc PR | n/a
this a fix for the issue #29830
After deliberation, we estimate that only `sid_length` and` sid_bits_per_character` session options should be exposed. These options à optional.
For others, we recommend changing your php.ini file
We can now configure the session like this :
```yaml
framwork:
session:
sid_length: 64 //optional, recommended value is 32
sid_bits_per_character: 6 //optional, recommended value is 5
```
Commits
-------
0403e4ad67 [FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in configuration
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #29830
| License | MIT
| Doc PR | n/a
this a fix for the issue #29830
After deliberation, we estimate that only `sid_length` and` sid_bits_per_character` session options should be exposed. These options à optional.
For others, we recommend changing your php.ini file
We can now configure the session like this :
```yaml
framwork:
session:
sid_length: 64 //optional, recommended value is 32
sid_bits_per_character: 6 //optional, recommended value is 5
```
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] render integer types with grouping as text input
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #29422
| License | MIT
| Doc PR |
Commits
-------
d6a5fde521 render integer types with grouping as text input
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] don't lose int precision with not needed type casts
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #26795
| License | MIT
| Doc PR |
Commits
-------
72136f1c04 don't lose int precision with not needed type casts
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] ignore _method forms in NativeRequestHandler
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #19017
| License | MIT
| Doc PR |
Commits
-------
bc4b0913b4 ignore _method forms in NativeRequestHandler
This PR was merged into the 3.4 branch.
Discussion
----------
Fix KernelTestCase compatibility for PhpUnit 8
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? |no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #30071
| License | MIT
| Doc PR |
As the PhpUnit 8 Testcase has different return types as PhpUnit 7 there need to be 2 different classes to support both PhpUnit 8 and PhpUnit 7. With a class alias we can then change which version is used based on the PhpUnit Version constant. The fix is a little bit hacky but to support different major versions I see no other way.
Not sure as we can't upgrade symfony/symfony to PhpUnit 8 how we can create a TestCase for this change.
Commits
-------
83a56a0cbe Fix phpunit 8 compatibility
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] replace mocks with real objects in tests
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
6ac2550dc8 replace mocks with real objects in tests
This PR was merged into the 4.2 branch.
Discussion
----------
[DependencyInjection] add $lazyLoad context to the generated code for lazy non-shared service by PhpDumper
| Q | A
| ------------- | ---
| Branch? | 4.1
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #29930
| License | MIT
| Doc PR | n/a
Fix#29930 by adding $lazyLoad context to the generated code for lazy non-shared service by PhpDumper
Commits
-------
98d4dfdadb [DependencyInjection] fix#29930 add $lazyLoad flag to the generated factory code for lazy non-shared services
This PR was merged into the 4.3-dev branch.
Discussion
----------
[DependencyInjection] Added information about deprecated aliases in debug:autowiring
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | n/a
Fix and improves a bit PR #29968 and #29995
![Screenshot](https://i.imgur.com/GDj2NIY.png)
Commits
-------
3d2378dab5 [DependencyInjection] Added information about deprecated aliases in debug:autowiring