Commit Graph

49047 Commits

Author SHA1 Message Date
Nicolas Grekas
bf43fa3b34 minor #36941 [HttpFoundation] Avoid TypeError when calling \SessionHandlerInterface::gc() (derrabus)
This PR was merged into the 5.1 branch.

Discussion
----------

[HttpFoundation] Avoid TypeError when calling \SessionHandlerInterface::gc()

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This should fix the remaining red php 8 test of the HttpFoundation suite.

Commits
-------

12f734d8b3 [HttpFoundation] Avoid TypeError when calling \SessionHandlerInterface::gc().
2020-05-24 20:56:05 +02:00
Nicolas Grekas
595ca2ec8b minor #36945 [DependencyInjection] Fixed tests for wither with static return type (derrabus)
This PR was merged into the 5.1 branch.

Discussion
----------

[DependencyInjection] Fixed tests for wither with static return type

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This PR fixes the remaining failing test on php 8 for the DependencyInjection suite.

Commits
-------

b27b535126 [DependencyInjection] Fixed tests for wither with static return type.
2020-05-24 20:45:32 +02:00
Alexander M. Turek
b27b535126 [DependencyInjection] Fixed tests for wither with static return type. 2020-05-24 17:04:36 +02:00
Alexander M. Turek
12f734d8b3 [HttpFoundation] Avoid TypeError when calling \SessionHandlerInterface::gc(). 2020-05-24 14:18:07 +02:00
Nicolas Grekas
5233cb96f4 bug #36938 Don't call method_exists() with non-objects. (derrabus)
This PR was merged into the 5.1 branch.

Discussion
----------

Don't call method_exists() with non-objects.

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

Followup to #36901.

Commits
-------

9efb442ce5 Don't call method_exists() with non-objects.
2020-05-24 12:54:01 +02:00
Alexander M. Turek
9efb442ce5 Don't call method_exists() with non-objects. 2020-05-24 12:15:36 +02:00
Nicolas Grekas
2fd78c6a89 minor #36937 [Lock] skip tests when ext-mongo is not installed (nicolas-grekas)
This PR was merged into the 5.1 branch.

Discussion
----------

[Lock] skip tests when ext-mongo is not installed

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

c0d4617820 [Lock] skip tests when ext-mongo is not installed
2020-05-24 12:11:47 +02:00
Nicolas Grekas
c0d4617820 [Lock] skip tests when ext-mongo is not installed 2020-05-24 12:09:11 +02:00
Nicolas Grekas
e3069df98f bug #36936 [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8 (nicolas-grekas)
This PR was merged into the 5.1 branch.

Discussion
----------

[FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

In PHP 8, abstract methods on traits are now enforcing that their using classes match the signature.

But this is not the semantics we need in this trait: we want to allow ppl to use a different type of configurators, to provide extensibility of the DSL each provide.

This makes nightly job fail with fatal error currently.

There is no other options here.

/cc @nikic FYI

Commits
-------

4473f454ca [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8
2020-05-24 11:40:24 +02:00
Nicolas Grekas
4488c30990 bug #36935 [HttpClient] Adjust AmpResponse to the stricter trait handling in php 8 (derrabus)
This PR was merged into the 5.1 branch.

Discussion
----------

[HttpClient] Adjust AmpResponse to the stricter trait handling in php 8

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

Follows #36908.

Commits
-------

e3aa78fd51 [HttpClient] Adjust AmpResponse to the stricter trait handling in php 8.
2020-05-24 11:29:49 +02:00
Alexander M. Turek
e3aa78fd51 [HttpClient] Adjust AmpResponse to the stricter trait handling in php 8. 2020-05-24 11:25:47 +02:00
Nicolas Grekas
4473f454ca [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8 2020-05-24 11:24:07 +02:00
Nicolas Grekas
6868f6cd1a Merge branch '5.0' into 5.1
* 5.0:
  [travis] display deprecations in nightly jobs
2020-05-24 10:59:54 +02:00
Nicolas Grekas
466b70d655 Merge branch '4.4' into 5.0
* 4.4:
  [travis] display deprecations in nightly jobs
2020-05-24 10:58:00 +02:00
Nicolas Grekas
6e7658baff Merge branch '3.4' into 4.4
* 3.4:
  [travis] display deprecations in nightly jobs
2020-05-24 10:57:28 +02:00
Nicolas Grekas
c08d8d116c minor #36934 [travis] display deprecations in nightly jobs (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[travis] display deprecations in nightly jobs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

83a34a84ab [travis] display deprecations in nightly jobs
2020-05-24 10:57:17 +02:00
Nicolas Grekas
83a34a84ab [travis] display deprecations in nightly jobs 2020-05-24 10:55:27 +02:00
Nicolas Grekas
2ed4e0efce Merge branch '5.0' into 5.1
* 5.0:
  Parse and render anonymous classes correctly on php 8
  Enable APCu for the php 8 build.
  [Process] Fix failing test on php 8.
  [HttpKernel] fix test
  Make PHP 8 green on Travis
  Revert "[Cache] allow DBAL v3"
  [PropertyAccessor] Added missing property path on php 8.
  Don't execute tests with DBAL 2.x on php 8.
2020-05-24 10:49:09 +02:00
Nicolas Grekas
49eb5c9c1f Merge branch '4.4' into 5.0
* 4.4:
  Parse and render anonymous classes correctly on php 8
  Enable APCu for the php 8 build.
  [Process] Fix failing test on php 8.
  [HttpKernel] fix test
  Make PHP 8 green on Travis
  Revert "[Cache] allow DBAL v3"
  [PropertyAccessor] Added missing property path on php 8.
  Don't execute tests with DBAL 2.x on php 8.
2020-05-24 10:40:42 +02:00
Nicolas Grekas
6d02565ea7 bug #36914 Parse and render anonymous classes correctly on php 8 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

Parse and render anonymous classes correctly on php 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

The format of the value that `get_class()` returns for anonymous classes has changed in php 8. This PR attempts to detect both formats, with the help of the PHP80 polyfill where possible.

Commits
-------

9d702fd94b Parse and render anonymous classes correctly on php 8
2020-05-24 10:35:29 +02:00
Alexander M. Turek
9d702fd94b Parse and render anonymous classes correctly on php 8 2020-05-24 10:33:35 +02:00
Nicolas Grekas
7224c1d6b9 Merge branch '3.4' into 4.4
* 3.4:
  Enable APCu for the php 8 build.
2020-05-23 23:42:41 +02:00
Nicolas Grekas
acbaf0020f minor #36932 Enable APCu for the php 8 build (derrabus)
This PR was merged into the 3.4 branch.

Discussion
----------

Enable APCu for the php 8 build

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This PR enables APCu for the php 8 build on Travis.

Since the latest version release on PECL produces a lot of runtime warnings, I'm pulling the latest master commit from github.

Commits
-------

e3e1558a0b Enable APCu for the php 8 build.
2020-05-23 23:40:17 +02:00
Nicolas Grekas
3588a53270 minor #36933 [Process] Fix failing test on php 8 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[Process] Fix failing test on php 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

Commits
-------

98e5105bd3 [Process] Fix failing test on php 8.
2020-05-23 23:38:59 +02:00
Alexander M. Turek
e3e1558a0b Enable APCu for the php 8 build. 2020-05-23 23:26:28 +02:00
Alexander M. Turek
98e5105bd3 [Process] Fix failing test on php 8. 2020-05-23 21:47:49 +02:00
Nicolas Grekas
d8bb5b2df5 Merge branch '3.4' into 4.4
* 3.4:
  [HttpKernel] fix test
2020-05-23 19:38:31 +02:00
Nicolas Grekas
5ebcd26f06 [HttpKernel] fix test 2020-05-23 19:37:50 +02:00
Nicolas Grekas
7b871133e9 Merge branch '3.4' into 4.4
* 3.4:
  Make PHP 8 green on Travis
2020-05-23 19:20:05 +02:00
Nicolas Grekas
d6902039c4 minor #36930 Make PHP 8 green on Travis (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

Make PHP 8 green on Travis

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | -

See #36872 for preparatory work and remaining steps.

Commits
-------

571d46cf01 Make PHP 8 green on Travis
2020-05-23 19:17:25 +02:00
Nicolas Grekas
571d46cf01 Make PHP 8 green on Travis 2020-05-23 19:05:51 +02:00
Nicolas Grekas
9de714c3d4 minor #36928 [PropertyAccessor] Added missing property path on php 8 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[PropertyAccessor] Added missing property path on php 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This PR adds the property path to the exception message to fix failing tests on php 8.

Commits
-------

6a73bcdb8e [PropertyAccessor] Added missing property path on php 8.
2020-05-23 18:30:14 +02:00
Nicolas Grekas
098d84afd7 minor #36927 [Cache][Lock][Messenger] Don't execute tests with DBAL 2.x on php 8 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[Cache][Lock][Messenger] Don't execute tests with DBAL 2.x on php 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

Follow-up to #36895: If we autoload the `PDOConnection` from DBAL 2.x during a test on php8, our test suite goes 💥

What this PR does:
* Some more Cache tests are skipped if DBAL 2 is installed on php 8.
* The Lock and Messenger components are tested against DBAL 3.

Commits
-------

7dc3f9cb42 Don't execute tests with DBAL 2.x on php 8.
2020-05-23 18:27:24 +02:00
Nicolas Grekas
6e0593f210 Merge branch '3.4' into 4.4
* 3.4:
  Revert "[Cache] allow DBAL v3"
2020-05-23 18:26:58 +02:00
Nicolas Grekas
896b69c907 Revert "[Cache] allow DBAL v3"
This reverts commit d12b3b6a72.
2020-05-23 18:25:19 +02:00
Alexander M. Turek
6a73bcdb8e [PropertyAccessor] Added missing property path on php 8. 2020-05-23 17:44:24 +02:00
Alexander M. Turek
7dc3f9cb42 Don't execute tests with DBAL 2.x on php 8. 2020-05-23 17:32:20 +02:00
Nicolas Grekas
4e6967e2f5 Merge branch '5.0' into 5.1
* 5.0:
  [travis] skip extensions that dont compile on nightly
2020-05-23 15:57:19 +02:00
Nicolas Grekas
fdedbb7ff0 Merge branch '4.4' into 5.0
* 4.4:
  [travis] skip extensions that dont compile on nightly
2020-05-23 15:57:11 +02:00
Nicolas Grekas
a14d8f9da4 minor #36924 [travis] skip extensions that dont compile on nightly (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[travis] skip extensions that dont compile on nightly

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | -

Commits
-------

c26044b0b1 [travis] skip extensions that dont compile on nightly
2020-05-23 15:53:53 +02:00
Nicolas Grekas
c26044b0b1 [travis] skip extensions that dont compile on nightly 2020-05-23 15:47:19 +02:00
Nicolas Grekas
8dfac5c3b9 Merge branch '5.0' into 5.1
* 5.0:
  [BrowserKit] fix bad merge
2020-05-23 15:13:03 +02:00
Nicolas Grekas
fceea7ce01 [BrowserKit] fix bad merge 2020-05-23 15:12:54 +02:00
Nicolas Grekas
56faca9c38 Merge branch '5.0' into 5.1
* 5.0: (28 commits)
  [Cache] $lifetime cannot be null
  [Serializer] minor cleanup
  fix merge
  Run PHP 8 as 7.4.99
  Remove calls to deprecated ReflectionParameter::getClass().
  [VarDumper] fix PHP 8 support
  Add php 8 to travis.
  [Cache] Accessing undefined constants raises an Error in php8
  [Cache] allow DBAL v3
  Skip Doctrine DBAL on php 8 until we have a compatible version.
  [DomCrawler] Catch expected ValueError.
  Made method signatures compatible with their corresponding traits.
  [ErrorHandler] Apply php8 fixes from Debug component.
  [DomCrawler] Catch expected ValueError.
  [Validator] Catch expected ValueError.
  [VarDumper] ReflectionFunction::isDisabled() is deprecated.
  [BrowserKit] Raw body with custom Content-Type header
  [PropertyAccess] Parse php 8 TypeErrors correctly.
  [Intl] Fix call to ReflectionProperty::getValue() for static properties.
  [HttpKernel] Prevent calling method_exists() with non-string values.
  ...
2020-05-23 15:08:13 +02:00
Nicolas Grekas
a17e72e0b5 Merge branch '4.4' into 5.0
* 4.4:
  [Cache] $lifetime cannot be null
2020-05-23 15:02:37 +02:00
Nicolas Grekas
c8c7d4c458 [Cache] $lifetime cannot be null 2020-05-23 15:02:18 +02:00
Nicolas Grekas
08afeed555 Merge branch '4.4' into 5.0
* 4.4: (27 commits)
  [Serializer] minor cleanup
  fix merge
  Run PHP 8 as 7.4.99
  Remove calls to deprecated ReflectionParameter::getClass().
  [VarDumper] fix PHP 8 support
  Add php 8 to travis.
  [Cache] Accessing undefined constants raises an Error in php8
  [Cache] allow DBAL v3
  Skip Doctrine DBAL on php 8 until we have a compatible version.
  [DomCrawler] Catch expected ValueError.
  Made method signatures compatible with their corresponding traits.
  [ErrorHandler] Apply php8 fixes from Debug component.
  [DomCrawler] Catch expected ValueError.
  [Validator] Catch expected ValueError.
  [VarDumper] ReflectionFunction::isDisabled() is deprecated.
  [BrowserKit] Raw body with custom Content-Type header
  [PropertyAccess] Parse php 8 TypeErrors correctly.
  [Intl] Fix call to ReflectionProperty::getValue() for static properties.
  [HttpKernel] Prevent calling method_exists() with non-string values.
  Fix wrong roles comparison
  ...
2020-05-23 14:58:59 +02:00
Nicolas Grekas
236a2145fc Merge branch '3.4' into 4.4
* 3.4:
  [Serializer] minor cleanup
2020-05-23 14:50:36 +02:00
Nicolas Grekas
1a21a7582e bug #36921 [OptionsResolver][Serializer] Remove calls to deprecated ReflectionParameter::getClass() (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[OptionsResolver][Serializer] Remove calls to deprecated ReflectionParameter::getClass()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

Following #36891, this PR removes the remaining calls to `ReflectionParameter::getClass()` from the 4.4 branch.

Commits
-------

1575d853f1 Remove calls to deprecated ReflectionParameter::getClass().
2020-05-23 14:48:29 +02:00
Nicolas Grekas
ca695e55e8 [Serializer] minor cleanup 2020-05-23 14:46:57 +02:00