Commit Graph

37058 Commits

Author SHA1 Message Date
Nicolas Grekas
c250fbdda0 [Cache] Remove TaggableCacheInterface, alias cache.app.taggable to CacheInterface 2018-05-28 21:56:05 +02:00
Fabien Potencier
f557f943ba feature #26981 No more support for custom anon/remember tokens based on FQCN (Iltar van der Berg)
This PR was squashed before being merged into the 4.2-dev branch (closes #26981).

Discussion
----------

No more support for custom anon/remember tokens based on FQCN

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #26940
| License       | MIT
| Doc PR        | ~

This PR deprecates the ability to configure a custom anonymous and remember me token class, via the AuthenticationTrustResolver. The only change required _if_ you have changed the token classes like this, is to extend the Anonymous/RememberMe token classes.

Commits
-------

860d4549c2 No more support for custom anon/remember tokens based on FQCN
2018-05-27 09:21:43 +02:00
Iltar van der Berg
860d4549c2 No more support for custom anon/remember tokens based on FQCN 2018-05-27 09:19:43 +02:00
Nicolas Grekas
e077c798f0 Merge branch '4.1'
* 4.1:
  [Routing] Account for greediness when merging route patterns
2018-05-25 23:27:57 +02:00
Nicolas Grekas
9e6fbe8fdb bug #27388 [Routing] Account for greediness when merging route patterns (nicolas-grekas)
This PR was merged into the 4.1 branch.

Discussion
----------

[Routing] Account for greediness when merging route patterns

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27385
| License       | MIT
| Doc PR        | -

Sub-patterns of variable length should not be considered as common prefixes because their greediness would break in-order matching.

Commits
-------

d5a8237b1c [Routing] Account for greediness when merging route patterns
2018-05-25 23:27:30 +02:00
Nicolas Grekas
d5a8237b1c [Routing] Account for greediness when merging route patterns 2018-05-25 23:14:53 +02:00
Nicolas Grekas
ee22169caa Merge branch '4.1'
* 4.1:
  [HttpKernel] fix test
2018-05-25 17:22:45 +02:00
Nicolas Grekas
2ed650332f Merge branch '4.0' into 4.1
* 4.0:
  [HttpKernel] fix test
2018-05-25 17:22:41 +02:00
Nicolas Grekas
a453bdf921 Merge branch '3.4' into 4.0
* 3.4:
  [HttpKernel] fix test
2018-05-25 17:22:18 +02:00
Nicolas Grekas
6fc7fdb182 [HttpKernel] fix test 2018-05-25 17:22:00 +02:00
Nicolas Grekas
b1a41a4812 Merge branch '4.1'
* 4.1:
  [HttpKernel] Dont reset start time when not needed
2018-05-25 17:07:57 +02:00
Nicolas Grekas
84748d6420 Merge branch '4.0' into 4.1
* 4.0:
  [HttpKernel] Dont reset start time when not needed
2018-05-25 17:07:41 +02:00
Nicolas Grekas
3a2f37f15d Merge branch '3.4' into 4.0
* 3.4:
  [HttpKernel] Dont reset start time when not needed
2018-05-25 17:07:09 +02:00
Nicolas Grekas
9de5014b27 [HttpKernel] Dont reset start time when not needed 2018-05-25 17:06:28 +02:00
Nicolas Grekas
201b472009 Merge branch '4.1'
* 4.1: (26 commits)
  Revert "bug #27312 Supress deprecation notices thrown when getting private servies from container in tests (arderyp)"
  [HttpKernel] reset kernel start time on reboot
  Add code of Conduct links in our README
  bumped Symfony version to 4.0.12
  [FrameworkBundle] Fix using test.service_container when Client is rebooted
  [DI] never inline lazy services
  updated VERSION for 4.0.11
  updated CHANGELOG for 4.0.11
  bumped Symfony version to 3.4.12
  updated VERSION for 3.4.11
  updated CHANGELOG for 3.4.11
  Default testsuite to latest PHPUnit 6.*
  [Github] Update the pull-request template
  bumped Symfony version to 2.8.42
  updated VERSION for 2.8.41
  updated CHANGELOG for 2.8.41
  Tweak Argon2 test config
  [HttpFoundation] Fix cookie test with xdebug
  [FrameworkBundle] cleanup generated test container
  [Serializer] Check the value of enable_max_depth if defined
  ...
2018-05-25 16:55:42 +02:00
Nicolas Grekas
d4d137de53 Merge branch '4.0' into 4.1
* 4.0:
  [HttpKernel] reset kernel start time on reboot
  Add code of Conduct links in our README
  bumped Symfony version to 4.0.12
  [DI] never inline lazy services
  updated VERSION for 4.0.11
  updated CHANGELOG for 4.0.11
  bumped Symfony version to 3.4.12
  updated VERSION for 3.4.11
  updated CHANGELOG for 3.4.11
  Default testsuite to latest PHPUnit 6.*
  [Github] Update the pull-request template
  bumped Symfony version to 2.8.42
  updated VERSION for 2.8.41
  updated CHANGELOG for 2.8.41
  [HttpFoundation] Fix cookie test with xdebug
  [Serializer] Check the value of enable_max_depth if defined
  [DI] remove dead code
  [PhpUnitBridge] silence some stderr outputs
  [Validator] Update sl translation
2018-05-25 16:55:38 +02:00
Nicolas Grekas
101ff69e1a Merge branch '3.4' into 4.0
* 3.4:
  [HttpKernel] reset kernel start time on reboot
  Add code of Conduct links in our README
  [DI] never inline lazy services
  bumped Symfony version to 3.4.12
  updated VERSION for 3.4.11
  updated CHANGELOG for 3.4.11
  Default testsuite to latest PHPUnit 6.*
  [Github] Update the pull-request template
  bumped Symfony version to 2.8.42
  updated VERSION for 2.8.41
  updated CHANGELOG for 2.8.41
  [HttpFoundation] Fix cookie test with xdebug
  [Serializer] Check the value of enable_max_depth if defined
  [DI] remove dead code
  [PhpUnitBridge] silence some stderr outputs
  [Validator] Update sl translation
2018-05-25 16:54:15 +02:00
Nicolas Grekas
bf20260025 Merge branch '2.8' into 3.4
* 2.8:
  Add code of Conduct links in our README
  [DI] never inline lazy services
  Default testsuite to latest PHPUnit 6.*
  [Github] Update the pull-request template
  bumped Symfony version to 2.8.42
  updated VERSION for 2.8.41
  updated CHANGELOG for 2.8.41
2018-05-25 16:50:57 +02:00
Nicolas Grekas
ab09fcc249 Revert "bug #27312 Supress deprecation notices thrown when getting private servies from container in tests (arderyp)"
This reverts commit 70c70e2d9f, reversing
changes made to 7497ad4a68.
2018-05-25 16:46:53 +02:00
Nicolas Grekas
d314735919 feature #27336 [Security][SecurityBundle] FirewallMap/FirewallContext deprecations (chalasr)
This PR was merged into the 4.2-dev branch.

Discussion
----------

[Security][SecurityBundle] FirewallMap/FirewallContext deprecations

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Next to #24805.

Commits
-------

a71ba78478 [Security][SecurityBundle] FirewallMap/FirewallContext deprecations
2018-05-25 16:45:07 +02:00
Nicolas Grekas
79bd461d59 bug #27344 [HttpKernel] reset kernel start time on reboot (kiler129)
This PR was squashed before being merged into the 3.4 branch (closes #27344).

Discussion
----------

[HttpKernel] reset kernel start time on reboot

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27319
| License       | MIT
| Doc PR        | n/a

I created branch from 3.4, since the furthest thing I could find for the reboot feature was a4fc49294e and it originated during stabilization phase of 3.4.

ping @nicolas-grekas

Commits
-------

b7feef00ae [HttpKernel] reset kernel start time on reboot
2018-05-25 16:43:55 +02:00
kiler129
b7feef00ae [HttpKernel] reset kernel start time on reboot 2018-05-25 16:43:44 +02:00
Nicolas Grekas
7064a77e87 minor #27347 [Validator] Update sl translation (petk)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Update sl translation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

This patch updates Slovenian sl_SI translation for the 3.4 branches and up to master.

Commits
-------

a7a1325eab [Validator] Update sl translation
2018-05-25 16:42:15 +02:00
Nicolas Grekas
cb106fa2ff bug #27365 [Serializer] Check the value of enable_max_depth if defined (dunglas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Check the value of enable_max_depth if defined

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

Because it confuses some users that `['enable_max_depth' => false]` actually triggers the check.

Commits
-------

e88e0f30f1 [Serializer] Check the value of enable_max_depth if defined
2018-05-25 16:39:07 +02:00
Nicolas Grekas
f8e21fd67b bug #27358 [PhpUnitBridge] silence some stderr outputs (ostrolucky)
This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] silence some stderr outputs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Solves following issues

![obrazok](https://user-images.githubusercontent.com/496233/40449464-cc02bda2-5ed8-11e8-8a79-65c996ffc59d.png)

and

![obrazok](https://user-images.githubusercontent.com/496233/40452080-eb57381a-5ee0-11e8-82b5-99e13b357f74.png)

Commits
-------

87b3ad91d2 [PhpUnitBridge] silence some stderr outputs
2018-05-25 16:38:26 +02:00
Nicolas Grekas
3d310ab2ef minor #27363 [DI] remove dead code (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] remove dead code

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

1314a952cd [DI] remove dead code
2018-05-25 16:37:08 +02:00
Nicolas Grekas
4279f53e34 bug #27366 [DI] never inline lazy services (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[DI] never inline lazy services

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Should apply also:
- to deprecated services since 2.8
- to errored services since 3.4

Commits
-------

3b4d7ab56c [DI] never inline lazy services
2018-05-25 16:36:25 +02:00
Nicolas Grekas
e2ba3af1ec minor #27369 [HttpFoundation] Fix cookie test with xdebug (ostrolucky)
This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Fix cookie test with xdebug

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Here's the failure without this patch:

```
Testing Symfony\Component\HttpFoundation\Tests\ResponseFunctionalTest
F.....                                                              6 / 6 (100%)

Time: 1.07 seconds, Memory: 4.00MB

There was 1 failure:

1) Symfony\Component\HttpFoundation\Tests\ResponseFunctionalTest::testCookie with data set #0 ('cookie_max_age')
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@

 Warning: Expiry date cannot have a year greater than 9999 in /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_max_age.php on line 10

+Call Stack:
+    0.0004     390392   1. {main}() /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_max_age.php:0
+    0.0178     500960   2. setcookie() /home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_max_age.php:10
+
+
 Array
 (
     [0] => Content-Type: text/plain; charset=utf-8
     [1] => Cache-Control: no-cache, private
     [2] => Date: Sat, 12 Nov 1955 20:04:00 GMT
-    [3] => Set-Cookie: foo=bar; expires=Sat, 01-Jan-10000 02:46:40 GMT; Max-Age=%d; path=/
+    [3] => Set-Cookie: foo=bar; expires=Sat, 01-Jan-10000 02:46:40 GMT; Max-Age=251875115405; path=/
 )
 shutdown

/home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php:49
```

Commits
-------

47f0e732d9 [HttpFoundation] Fix cookie test with xdebug
2018-05-25 16:35:31 +02:00
Nicolas Grekas
9c089b3f09 minor #27355 Add code of Conduct links in our README (javiereguiluz)
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #27355).

Discussion
----------

Add code of Conduct links in our README

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

Commits
-------

40e59a6415 Add code of Conduct links in our README
2018-05-25 16:34:13 +02:00
Javier Eguiluz
40e59a6415 Add code of Conduct links in our README 2018-05-25 16:34:01 +02:00
Nicolas Grekas
3e65a1c326 bug #27352 Remove reference to the test container after kernel shutdown (stof)
This PR was merged into the 4.1 branch.

Discussion
----------

Remove reference to the test container after kernel shutdown

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This reference is not working anymore, as the main container was reset and cleaned. Keeping a reference to the test container will prevent collecting the object graph.

Commits
-------

d8fb1b97c9 Remove reference to the test container after kernel shutdown
2018-05-25 16:32:25 +02:00
Nicolas Grekas
0f06410315 minor #27349 [Security] Fix missing use in UserInterface (jvasseur)
This PR was merged into the 4.1 branch.

Discussion
----------

[Security] Fix missing use in UserInterface

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Fix missing `Role` use used in the `getRoles` return type.

Commits
-------

3e0a0f4cb5 Fix missing use in UserInterface
2018-05-25 16:31:27 +02:00
Nicolas Grekas
7d23ac529f bug #27350 [HttpKernel] fix deprecation in AbstractTestSessionListener (alekitto)
This PR was merged into the 4.1 branch.

Discussion
----------

[HttpKernel] fix deprecation in AbstractTestSessionListener

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

After #26564 functional tests began to emit a deprecation warning because of `getSession()` being called without verifying the existence of a session.

Commits
-------

0ecaefe179 [HttpKernel] fix deprecation in AbstractTestSessionListener
2018-05-25 16:30:50 +02:00
Nicolas Grekas
af62eac5c2 bug #27367 [FrameworkBundle] cleanup generated test container (nicolas-grekas)
This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] cleanup generated test container

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Cleans up removed and hidden services, fixes an issue when the private container locator is inlined.

Commits
-------

d8cbec00ad [FrameworkBundle] cleanup generated test container
2018-05-25 16:30:13 +02:00
Nicolas Grekas
2fd30a6159 bug #27379 [FrameworkBundle] Fix using test.service_container when Client is rebooted (nicolas-grekas)
This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] Fix using test.service_container when Client is rebooted

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

169a3b1688 [FrameworkBundle] Fix using test.service_container when Client is rebooted
2018-05-25 16:29:22 +02:00
Nicolas Grekas
402fc23f3f minor #27371 Tweak Argon2 test config (ostrolucky)
This PR was merged into the 4.1 branch.

Discussion
----------

Tweak Argon2 test config

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Memory cost 8 seems to be lowest value accepted on my machine

```
Testing Symfony\Component\Security\Core\Tests\Encoder\Argon2iPasswordEncoderTest
E....                                                               5 / 5 (100%)

Time: 114 ms, Memory: 4.00MB

There was 1 error:

1) Symfony\Component\Security\Core\Tests\Encoder\Argon2iPasswordEncoderTest::testValidationWithConfig
password_hash(): Memory cost is outside of allowed memory range

/home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Encoder/Argon2iPasswordEncoder.php:105
/home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Encoder/Argon2iPasswordEncoder.php:67
/home/gadelat/PhpstormProjects/symfony/src/Symfony/Component/Security/Core/Tests/Encoder/Argon2iPasswordEncoderTest.php:34
```

Commits
-------

0e74f73af5 Tweak Argon2 test config
2018-05-25 16:28:36 +02:00
Fabien Potencier
3de52144af bumped Symfony version to 4.0.12 2018-05-25 16:06:48 +02:00
Fabien Potencier
a54fa08210
Merge pull request #27383 from fabpot/release-4.0.11
released v4.0.11
2018-05-25 16:03:56 +02:00
Nicolas Grekas
169a3b1688 [FrameworkBundle] Fix using test.service_container when Client is rebooted 2018-05-25 15:53:35 +02:00
Nicolas Grekas
3b4d7ab56c [DI] never inline lazy services 2018-05-25 15:50:34 +02:00
Fabien Potencier
a981742931 updated VERSION for 4.0.11 2018-05-25 15:32:52 +02:00
Fabien Potencier
905f917e18 updated CHANGELOG for 4.0.11 2018-05-25 15:32:46 +02:00
Fabien Potencier
f918da9819 bumped Symfony version to 3.4.12 2018-05-25 15:32:08 +02:00
Fabien Potencier
8eb567d839
Merge pull request #27380 from fabpot/release-3.4.11
released v3.4.11
2018-05-25 15:16:49 +02:00
Fabien Potencier
136824a749 updated VERSION for 3.4.11 2018-05-25 15:16:28 +02:00
Fabien Potencier
0a4a0c0bc9 updated CHANGELOG for 3.4.11 2018-05-25 15:16:19 +02:00
Nicolas Grekas
586b1231f8 minor #27370 Default testsuite to latest PHPUnit 6.* (ostrolucky)
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #27370).

Discussion
----------

Default testsuite to latest PHPUnit 6.*

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Necessary to fix each() function deprecation calls introduced in PHP 7.2

![obrazok](https://user-images.githubusercontent.com/496233/40514525-b6099d64-5fa9-11e8-906b-ccd8c358b5a5.png)

Commits
-------

37e543329a Default testsuite to latest PHPUnit 6.*
2018-05-25 15:04:14 +02:00
Gabriel Ostrolucký
37e543329a Default testsuite to latest PHPUnit 6.*
Necessary to fix each() function deprecation calls introduced in PHP 7.2
2018-05-25 15:04:04 +02:00
Nicolas Grekas
2fd6ab9b02 minor #27376 [Github] Update the pull-request template (sroze)
This PR was squashed before being merged into the 2.8 branch (closes #27376).

Discussion
----------

[Github] Update the pull-request template

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ø
| License       | MIT
| Doc PR        | ø

2.7 is end of life.

Commits
-------

99327a6153 [Github] Update the pull-request template
2018-05-25 15:02:56 +02:00
Samuel ROZE
99327a6153 [Github] Update the pull-request template 2018-05-25 15:02:46 +02:00