This PR was merged into the 2.3 branch.
Discussion
----------
[Serializer] Remove normalizer cache in Serializer class
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The serializer cache the normalizer/denormalizer to use based only on the class and format. But the supportsNormalization and supportDenormalization methods can decide based on the data passed leading to hard to find bugs when the serializer used a cached normalizer it shouldn't use.
Commits
-------
8566dc1 Remove normalizer cache in Serializer class
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] Fix paths with % in it (like urlencoded)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | Travis passed
| Fixed tickets | #17306
| License | MIT
| Doc PR | none
Commits
-------
de7b4d7Fix#17306 Paths with % in it are note allowed (like urlencoded)
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#17078).
Discussion
----------
[Bridge] [Doctrine] [Validator] Added support \IteratorAggregate for UniqueEntityValidator
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Expand the list of supported types of results returned from the repositories.
Added processing of type \IteratorAggregate (and as a consequence doctrine Collection)
Commits
-------
6ebd179 Added support \IteratorAggregate for UniqueEntityValidator
Expand the list of supported types of results returned from the repositories.
Added processing of type \IteratorAggregate (and as a consequence doctrine Collection)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#17319).
Discussion
----------
[Form] fixed phpdoc in tests
| Q | A
| ------------- | ---
| Fixed tickets |
| License | MIT
fixed phpdoc
Commits
-------
0f8da34 Update AbstractChoiceListTest.php
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#17298).
Discussion
----------
[FrameworkBundle] Use proper class to fetch $versionStrategy property
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17259
| License | MIT
This is a replacement of #17260
Commits
-------
e38fa13 Use proper class to fetch $versionStrategy property
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17287).
Discussion
----------
[HttpKernel] Forcing string comparison on query parameters sort in UriSigner
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The signing of an url fails when using query parameters with integers as keys.
The ksort function in the ```UriSigner``` class changes the order of the query params and causes to generate a different hash which results in a failed check.
In this PR we force a string comparison for ksort which keeps the correct order of parameters.
Commits
-------
2040139 Added sort order SORT_STRING for params in UriSigner
* 2.7:
Add missing apostrophe in setSaveHandler phpdoc
[VarDumper] Fix typo
[FrameworkBundle] Add case in Kernel directory guess for PHPUnit
[FrameworkBundle] Add case in Kernel directory guess for PHPUnit
This PR was merged into the 2.7 branch.
Discussion
----------
[2.7][FrameworkBundle] Add case in Kernel directory guess for PHPUnit
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
The current automatic guess of the Kernel directory in the context of PHPUnit does work properly using the following commands:
- `phpunit -c app`
- `phpunit --configuration app`
- `phpunit --configuration=app`
But it fails with the synthax `phpunit -capp`, even if PHPUnit supports it. This PR fixes this.
See https://github.com/symfony/symfony/pull/17272.
Commits
-------
a7b7766 [FrameworkBundle] Add case in Kernel directory guess for PHPUnit
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][FrameworkBundle] Add case in Kernel directory guess for PHPUnit
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
The current automatic guess of the Kernel directory in the context of PHPUnit does work properly using the following commands:
- `phpunit -c app`
- `phpunit --configuration app`
- `phpunit --configuration=app`
But it fails with the synthax `phpunit -capp`, even if PHPUnit supports it. This PR fixes this.
See https://github.com/symfony/symfony/pull/17272.
Commits
-------
758fc1d [FrameworkBundle] Add case in Kernel directory guess for PHPUnit
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes#17283).
Discussion
----------
[WebProfilerBundle] Remove loading status from AJAX toolbar after error
Q | A
---|---
Bug fix? | no
New feature? | no
BC breaks? | no
Deprecations? | no
Tests pass? | yes
Fixed tickets |
License | MIT
Doc PR |
Commits
-------
079ab73 [WebProfilerBundle] Remove loading status from AJAX toolbar after error
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17293).
Discussion
----------
[HttpFoundation] Add missing apostrophe in setSaveHandler phpdoc
| Q | A
| ------------- | ---
| Fixed tickets |
| License | MIT
I fixed php code in comment to one of functions as it couldn't be used with simple copy and paste.
Commits
-------
e32f5a2 Add missing apostrophe in setSaveHandler phpdoc
* 2.7:
[Process] Fix potential race condition
[PhpUnitBridge] Re-enable the garbage collector
typo
[FrameworkBundle] Set the kernel.name properly after a cache warmup
Removed spaces before semicolon
This PR was merged into the 2.7 branch.
Discussion
----------
[PhpUnitBridge] Re-enable the garbage collector
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17268, #11566
| License | MIT
| Doc PR | -
The bug is fixed in PHP and disabling the gc causes issues elsewhere.
Commits
-------
478710f [PhpUnitBridge] Re-enable the garbage collector
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix potential race condition
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
As seen at https://travis-ci.org/symfony/symfony/jobs/100448880#L2768, ProcessTest::testRunProcessWithTimeout can create an infinite blocking situation.
I found two potential code paths that could be subject to a race condition. This fixes them.
Commits
-------
b114a85 [Process] Fix potential race condition
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17264).
Discussion
----------
Fix typo in Locale class annotations
Commits
-------
eab7e11 typo
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17183).
Discussion
----------
[FrameworkBundle] Set the kernel.name properly after a cache warmup
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16180
| License | MIT
| Doc PR | -
Commits
-------
1438b9a [FrameworkBundle] Set the kernel.name properly after a cache warmup
This PR was merged into the 2.8 branch.
Discussion
----------
[Yaml] cast arrays to objects after parsing has finished
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17190
| License | MIT
| Doc PR |
Casting arrays to objects must happen after the complete YAML string has
been parsed to avoid errors when parsing subsequent lines.
Commits
-------
8251d67 cast arrays to objects after parsing has finished
This PR was merged into the 2.8 branch.
Discussion
----------
Fix toolbar display when nvd3 is loaded on page
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | not applicable
Minor CSS fix for the toolbar, as nvd3 sets `svg { display: block }` so you end up with something like:
Commits
-------
d7010c0 Fix toolbar display when nvd3 is loaded on page
This PR was merged into the 2.8 branch.
Discussion
----------
[WebProfilerBundle] Remove duplicated HTML attributes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
7335dee [WebProfilerBundle] Removed duplicated HTML attributes
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#17248).
Discussion
----------
[Form] fixed DateTimeType tests using "date_widget"="choice".
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | no
| License | MIT
| Doc PR | no
As said in the [documentation](http://symfony.com/doc/current/reference/forms/types/datetime.html#years), the default years available in the ``DateType`` go from five year before to five year after the current year. So now that it's 2016 all around, the tests which use the ``"date_widget"="choice"`` without defining a ``"years"`` option and tries to submit a date in 2010 are failing because 2010 is not in the default choice list.
This PR fixes the issue by setting the ``"years"`` option to ``"2010"`` for each test that need it. It also remove unnecessary (and confusing) dummy data from some tests which were suffering the same issue but silently.
Edit : The PHP 5.6 build on travis seems to fetch and run some old version of the tests. So it still fail on this build but not on the others anymore.
Commits
-------
be20e89 Fix Form's DateTimeType tests.
