Commit Graph

36835 Commits

Author SHA1 Message Date
Bert Hekman
32c7ee35be [FrameworkBundle] Use the correct service id for CachePoolPruneCommand in its compiler pass 2018-05-03 16:57:56 -07:00
Yonel Ceruto
11f3c455d4 Hide short exception trace by default 2018-05-03 19:18:14 -04:00
Ben Johnson
34f136e01b
Suppress warnings when open_basedir is non-empty
If PHP is configured *with a non-empty open_basedir* value that does not permit access to the target location, these calls to is_executable() throw warnings.

While Symfony may not raise exceptions for warnings in production environments, other frameworks (such as Laravel) do, in which case any of these checks causes a show-stopping 500 error.

We fixed a similar issue in the ExecutableFinder class via symfony/symfony#16182 .

This has always been an issue, but 709e15e7a37cb7ed6199548dc70dc33168e6cb2d made it more likely that a warning is triggered.
2018-05-03 12:50:56 -04:00
Christian Flothmann
667924c98a fix deprecation message 2018-05-03 10:46:26 +02:00
David Maicher
b3ac93829a [Doctrine Bridge] fix priority for doctrine event listeners 2018-05-03 09:30:44 +02:00
Fabien Potencier
6cb90daa76 feature #27104 [DX] Redirect to proper Symfony version documentation (noniagriconomie)
This PR was squashed before being merged into the 4.1-dev branch (closes #27104).

Discussion
----------

[DX] Redirect to proper Symfony version documentation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        |

Just a small improvement
I think this can make some dev target the right documentation instead of reading an other version that the one they are developing on

EDIT: I do not know if including the constant directly is the good choice, or it is better to add a global symfony version collector?

Commits
-------

d611160ec6 [DX] Redirect to proper Symfony version documentation
2018-05-03 08:29:40 +02:00
Antoine M
d611160ec6 [DX] Redirect to proper Symfony version documentation 2018-05-03 08:29:31 +02:00
Kévin Dunglas
50fd769ea7
feature #27105 [Serializer] Add ->hasCacheableSupportsMethod() to CacheableSupportsMethodInterface (nicolas-grekas)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Serializer] Add ->hasCacheableSupportsMethod() to CacheableSupportsMethodInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Enhances the interface introduced in #27049 to make it possible to dynamically define if "supports" methods are cacheable.

Commits
-------

04b369215c [Serializer] Add ->hasCacheableSupportsMethod() to CacheableSupportsMethodInterface
2018-05-03 08:19:37 +02:00
Nicolas Grekas
e6f99da5ca bug #26955 [DebugBundle][VarDumper] Fix server dumper placeholder command (ogizanagi)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[DebugBundle][VarDumper] Fix server dumper placeholder command

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no, fixes a deprecation warning
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no, fixes ones <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26944 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

This placeholder command was addressed in quite an unorthodox fashion and the following fix isn't really better, but I guess that's fine for an internal class.

_As a reminder: this command aims to favor discoverability of the `ServerDumpCommand` when listing available commands and by exposing its definition so you can read about it by using `--help`. Execution hints about the `debug.dump_destination` config option required to wire the actual command._

That's the only command for which we're doing this, though. So better keep this placeholder or drop it?

Commits
-------

60af39b161 [DebugBundle][VarDumper] Fix server dumper placeholder command
2018-05-01 16:13:51 -07:00
Nicolas Grekas
95ceeab3d7 minor #27115 [Validator] fixes phpdoc reference to an interface that was removed in Symfony 3.0 (hhamon)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] fixes phpdoc reference to an interface that was removed in Symfony 3.0

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

d2c5813239 [Validator] fixes phpdoc reference to an interface that was removed in Symfony 3.0
2018-05-01 16:10:18 -07:00
Nicolas Grekas
ffb07c6a99 minor #27116 [Validator] make phpdoc of ObjectInitializerInterface interface more accurate (hhamon)
This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] make phpdoc of ObjectInitializerInterface interface more accurate

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

30970c7a9b [Validator] make phpdoc of ObjectInitializerInterface interface more accurate
2018-05-01 16:09:27 -07:00
Nicolas Grekas
7183c59c20 Merge branch '4.0'
* 4.0:
  Remove symfony/polyfill-ctype where not needed
  Use symfony/polyfill-ctype
  [Form] fixes instance variable phpdoc in FormRegistry class
  bumped Symfony version to 4.0.10
  updated VERSION for 4.0.9
  updated CHANGELOG for 4.0.9
  bumped Symfony version to 3.4.10
  updated VERSION for 3.4.9
  updated CHANGELOG for 3.4.9
2018-05-01 16:02:13 -07:00
Nicolas Grekas
a488d555ff Merge branch '3.4' into 4.0
* 3.4:
  Remove symfony/polyfill-ctype where not needed
  Use symfony/polyfill-ctype
  [Form] fixes instance variable phpdoc in FormRegistry class
  bumped Symfony version to 3.4.10
  updated VERSION for 3.4.9
  updated CHANGELOG for 3.4.9
  Add CODE_OF_CONDUCT.md
  Added .github/CODEOWNERS
  bumped Symfony version to 2.8.40
  updated VERSION for 2.8.39
  updated CHANGELOG for 2.8.39
2018-05-01 16:00:51 -07:00
Nicolas Grekas
e525248f66 Merge branch '2.8' into 3.4
* 2.8:
  Remove symfony/polyfill-ctype where not needed
  Use symfony/polyfill-ctype
  [Form] fixes instance variable phpdoc in FormRegistry class
2018-05-01 15:53:27 -07:00
Nicolas Grekas
087c667b83 Merge branch '2.7' into 2.8
* 2.7:
  Remove symfony/polyfill-ctype where not needed
  Use symfony/polyfill-ctype
  [Form] fixes instance variable phpdoc in FormRegistry class
2018-05-01 15:52:40 -07:00
Nicolas Grekas
046f0920c0 Remove symfony/polyfill-ctype where not needed 2018-05-01 15:50:35 -07:00
Hugo Hamon
30970c7a9b [Validator] make phpdoc of ObjectInitializerInterface interface more accurate 2018-05-02 00:50:12 +02:00
Hugo Hamon
d2c5813239 [Validator] fixes phpdoc reference to an interface that was removed in Symfony 3.0 2018-05-02 00:36:56 +02:00
Nicolas Grekas
6ca520fd50 minor #27111 Use symfony/polyfill-ctype (BackEndTea)
This PR was merged into the 2.7 branch.

Discussion
----------

Use symfony/polyfill-ctype

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Related to: #24168
Although it does not fix this issue, it does remove the dependency on the `ctype` extension.

Commits
-------

afc09cc8a7 Use symfony/polyfill-ctype
2018-05-01 15:32:56 -07:00
Gert de Pagter
afc09cc8a7 Use symfony/polyfill-ctype
Use the polyfill for every package that uses cytpe functions.
2018-05-01 15:30:49 -07:00
Nicolas Grekas
04b369215c [Serializer] Add ->hasCacheableSupportsMethod() to CacheableSupportsMethodInterface 2018-05-01 14:58:32 -07:00
Samuel ROZE
daf7ac064b minor #27110 [Messenger] Reset traceable buses (ogizanagi)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Messenger] Reset traceable buses

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

So the dispatched messages list is empty on new requests without rebooting the kernel.

Commits
-------

c68887e1e8 [Messenger] Reset traceable buses
2018-05-01 18:38:15 +01:00
Maxime Steinhausser
c68887e1e8 [Messenger] Reset traceable buses 2018-05-01 14:54:27 +02:00
Maxime Steinhausser
222fef4b83 minor #27109 [Form] fixes instance variable phpdoc in FormRegistry class (hhamon)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] fixes instance variable phpdoc in FormRegistry class

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

27fddf5927 [Form] fixes instance variable phpdoc in FormRegistry class
2018-05-01 14:46:48 +02:00
Hugo Hamon
27fddf5927 [Form] fixes instance variable phpdoc in FormRegistry class 2018-05-01 14:10:15 +02:00
Fabien Potencier
7ab4e4b782 bumped Symfony version to 4.0.10 2018-04-30 22:02:13 +02:00
Fabien Potencier
98e4187f3f
Merge pull request #27103 from fabpot/release-4.0.9
released v4.0.9
2018-04-30 21:46:30 +02:00
Fabien Potencier
2e856cda07 updated VERSION for 4.0.9 2018-04-30 21:45:57 +02:00
Fabien Potencier
fb98ef384b updated CHANGELOG for 4.0.9 2018-04-30 21:45:53 +02:00
Fabien Potencier
1f98e31da2 bumped Symfony version to 3.4.10 2018-04-30 21:44:07 +02:00
Fabien Potencier
4babd75194
Merge pull request #27102 from fabpot/release-3.4.9
released v3.4.9
2018-04-30 21:27:18 +02:00
Fabien Potencier
c7d277e64f updated VERSION for 3.4.9 2018-04-30 21:27:02 +02:00
Fabien Potencier
21520b8a4a updated CHANGELOG for 3.4.9 2018-04-30 21:27:00 +02:00
Nicolas Grekas
4fb673677e Merge branch '4.0'
* 4.0:
  Add CODE_OF_CONDUCT.md
  Added .github/CODEOWNERS
  bumped Symfony version to 2.8.40
  updated VERSION for 2.8.39
  updated CHANGELOG for 2.8.39
2018-04-30 12:14:59 -07:00
Nicolas Grekas
2b233b7803 Merge branch '3.4' into 4.0
* 3.4:
  Add CODE_OF_CONDUCT.md
  Added .github/CODEOWNERS
  bumped Symfony version to 2.8.40
  updated VERSION for 2.8.39
  updated CHANGELOG for 2.8.39
2018-04-30 12:14:36 -07:00
Nicolas Grekas
f244942671 Merge branch '2.8' into 3.4
* 2.8:
  Add CODE_OF_CONDUCT.md
  Added .github/CODEOWNERS
  bumped Symfony version to 2.8.40
  updated VERSION for 2.8.39
  updated CHANGELOG for 2.8.39
2018-04-30 12:14:25 -07:00
Nicolas Grekas
6dcdb58daf Merge branch '2.7' into 2.8
* 2.7:
  Add CODE_OF_CONDUCT.md
  Added .github/CODEOWNERS
2018-04-30 12:13:21 -07:00
Nicolas Grekas
c17adc6616 minor #27079 Added .github/CODEOWNERS (lyrixx)
This PR was merged into the 2.7 branch.

Discussion
----------

Added .github/CODEOWNERS

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

refs https://help.github.com/articles/about-codeowners/

Commits
-------

ffe9aaa Added .github/CODEOWNERS
2018-04-30 12:11:06 -07:00
Fabien Potencier
d80a70644f feature #24896 Add CODE_OF_CONDUCT.md (egircys)
This PR was squashed before being merged into the 2.7 branch (closes #24896).

Discussion
----------

Add CODE_OF_CONDUCT.md

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | n/a
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

GitHub allows specifying a code of conduct for an open source project https://help.github.com/articles/adding-a-code-of-conduct-to-your-project/

The rule set seems maybe obvious, but it's good to have it included.

I've adopted the version http://contributor-covenant.org/version/1/4/ with the email coc@sensiolabs.com

Moved initial proposal to https://github.com/symfony/symfony-docs/pull/9394

Commits
-------

bbbafbad5c Add CODE_OF_CONDUCT.md
2018-04-30 19:17:21 +02:00
Egidijus Gircys
bbbafbad5c Add CODE_OF_CONDUCT.md 2018-04-30 19:17:13 +02:00
Nicolas Grekas
e548b28b81 Merge branch '4.0'
* 4.0:
  [Debug][WebProfilerBundle] Fix setting file link format
  [Debug] Fixed the formatPath when a custom fileLinkFormat is defined
2018-04-30 10:00:18 -07:00
Nicolas Grekas
59298a9271 Merge branch '3.4' into 4.0
* 3.4:
  [Debug][WebProfilerBundle] Fix setting file link format
  [Debug] Fixed the formatPath when a custom fileLinkFormat is defined
2018-04-30 09:59:37 -07:00
Nicolas Grekas
0bfd126ad1 bug #27074 [Debug][WebProfilerBundle] Fix setting file link format (lyrixx, nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Debug][WebProfilerBundle] Fix setting file link format

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | ,p
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26917
| License       | MIT
| Doc PR        | -

Commits
-------

a4a1645 [Debug][WebProfilerBundle] Fix setting file link format
620f90d [Debug] Fixed the formatPath when a custom fileLinkFormat is defined
2018-04-30 09:57:12 -07:00
Nicolas Grekas
a4a1645d44 [Debug][WebProfilerBundle] Fix setting file link format 2018-04-30 09:54:07 -07:00
Grégoire Pineau
620f90d200 [Debug] Fixed the formatPath when a custom fileLinkFormat is defined 2018-04-30 09:53:52 -07:00
Samuel ROZE
74aa51507f minor #27100 [Messenger] Late collect & clone messages (ogizanagi)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Messenger] Late collect & clone messages

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

eb943619b1 [Messenger] Late collect & clone messages
2018-04-30 18:35:47 +02:00
Robin Chalas
e224548a0f [SecurityBundle] Fix framework-bundle dev requirement 2018-04-30 18:23:52 +02:00
Grégoire Pineau
ffe9aaa166 Added .github/CODEOWNERS
refs https://help.github.com/articles/about-codeowners/
2018-04-30 18:22:41 +02:00
Robin Chalas
c93c9a5880 [SecurityBundle] Fix test 2018-04-30 18:12:47 +02:00
Nicolas Grekas
feebe39efb Merge branch '4.0'
* 4.0:
  [PhpUnitBridge] Fix
2018-04-30 08:37:07 -07:00