This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11182).
Discussion
----------
Small comment update according to PSR-2
See [PSR-2](http://www.php-fig.org/psr/psr-2/) paragraph 5.2
> There MUST be a comment such as `// no break` when fall-through is intentional in a non-empty case body.
Related to #11181
Commits
-------
31b1dff Small comment update according to PSR-2
See [PSR-2](http://www.php-fig.org/psr/psr-2/) paragraph 5.2
> There MUST be a comment such as `// no break` when fall-through is intentional in a non-empty case body.
Related to #11181
This PR was merged into the 2.5 branch.
Discussion
----------
[YAML] fix merge node (<<)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | yes but according to spec
| Deprecations? | no
| Tests pass? | yes
| Needs merge to | 2.5
| Fixed tickets | #11142 and #11154
| License | MIT
| Doc PR | —
First commit small refactoring.
Second fixes#11154 (causing a BC break for a less common feature)
Third fixes#11142
Commits
-------
dee1562 [Yaml] fix overwriting of keys after merged map
8c621ab [Yaml] fix priority of sequence merges according to spec
02614e0 [Yaml] refactoring of merges for performance
This PR was merged into the 2.5 branch.
Discussion
----------
[Console] Fixed notice in QuestionHelper
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
When pressing escape in a question, a notice is shown because the sequence is only 2 characters long.
Commits
-------
9fe4b88 [Console] Fixed notice in QuestionHelper
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] Fixed notice in DialogHelper
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
When pressing escape in a question, a notice is shown because the sequence is only 2 characters long.
Commits
-------
ff6c65e [Console] Fixed notice in DialogHelper
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Fixed Request::getPort returns incorrect value under IPv6
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
2a0e8e3 [HttpFoundation] Fixed Request::getPort returns incorrect value under IPv6
This PR was merged into the 2.5 branch.
Discussion
----------
[2.5][FrameworkBundle] Redirect server output to /dev/null in case no verbosity is needed
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
This should reduce I/Os
Commits
-------
6d9fd62 [FrameworkBundle] Redirect server output to /dev/null in case no verbosity is needed
This PR was merged into the 2.3 branch.
Discussion
----------
[Filesystem] Fix test suite on OSX
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
Reviewing PR's, I realized the filesystem test suite fails on my setup (OSX, PHP 5.5.13 with posix ext). `posix_getgrgid` returns false, so some tests are failing.
This solves this issue.
Be aware that the patched method has been moved in FilesystemTestCase in recent branches
Commits
-------
e26f08e [Filesystem] Fix test suite on OSX
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11077).
Discussion
----------
[TwigBundle] [Tests] Add framework-bundle
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? |[yes
| Fixed tickets | -
| License | MIT
| Doc PR |
I'm unable to run the test from within TwigBundle
```bash
src/Symfony/Bundle/TwigBundle
composer install
phpunit
```
gives
```
PHP Fatal error: Class 'Symfony\Bundle\FrameworkBundle\Templating\TemplateReference' not found
```
Adding the FrameworkBundle fixes this but is that what is needed?
I believe `require` and `require-dev` should use `dev-master`
- [x] require(-dev) is not up to par with symfony master.
Commits
-------
a12471d Add framework-bundle
* 2.4:
PHP Fatal error when getContainer method of ContainerAwareCommand has be...
[HttpFoundation] Fixed isSecure() check to be compliant with the docs
Update MimeTypeExtensionGuesser.php
fix test src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
Fixed the Travis build on PHP 5.3.3
* 2.3:
PHP Fatal error when getContainer method of ContainerAwareCommand has be...
[HttpFoundation] Fixed isSecure() check to be compliant with the docs
Update MimeTypeExtensionGuesser.php
fix test src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
Fixed the Travis build on PHP 5.3.3
This PR was merged into the 2.5 branch.
Discussion
----------
[2.5][Process] Do not redirect output to file handles when output is disabled, simply discard it
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
Commits
-------
b35250f [Process] Do not redirect output to file handles when output is disabled
This PR was squashed before being merged into the 2.3 branch (closes#10966).
Discussion
----------
PHP Fatal error when getContainer method of ContainerAwareCommand has be...
PHP Fatal error when getContainer method of ContainerAwareCommand has been called within the configure method of a Command (application property is not been set yet at that time)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
8ea5c4c PHP Fatal error when getContainer method of ContainerAwareCommand has be...
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10981).
Discussion
----------
[HttpFoundation] Fixed isSecure() check to be compliant with the docs
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? |no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
According to the [php docs](http://www.php.net/manual/en/reserved.variables.server.php) the `HTTPS` field will be non-empty when the query was issued via HTTPS.
It isn't restricted to only "on" and 1.
Exception: "off" is sent by IIS
BC breaks: no, because old behavior was not conform with the docs.
Commits
-------
7bc37bd [HttpFoundation] Fixed isSecure() check to be compliant with the docs
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11128).
Discussion
----------
Update MimeTypeExtensionGuesser.php
Add ```'text/rtf' => 'rtf'``` type, as it is a valid type specification for rtf documents.
Commits
-------
c986b91 Update MimeTypeExtensionGuesser.php
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11118).
Discussion
----------
fix test src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
| Q | A
| ------------- | ---
| Bug fix? | [no]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | []
| License | MIT
| Doc PR | []
When running the tests in the HTTPFoundation package these failed. I felt like fixen these so I can start working with all tests green in the package.
Commits
-------
9247ef5 fix test src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#11117).
Discussion
----------
[Validator] Fix array notation in the PropertyPath::append()
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | related #11072#11046 (not fixed yet)
| License | MIT
| Doc PR | -
Commits
-------
aa6b08d [Validator] Fix array notation in the PropertyPath::append()
This PR was squashed before being merged into the 2.5 branch (closes#11111).
Discussion
----------
Fixed undefined ImageValidator::$suffices property when uploading an image during functional tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11110
| License | MIT
| Doc PR |
This will make the FileValidator::$suffices attribute protected so ImageValidator or any inherited class can access it. It fixes#11110 in the most simple way possible.
Commits
-------
859f34e Fixed undefined ImageValidator:: property when uploading an image during functional tests
This PR was merged into the 2.3 branch.
Discussion
----------
Fixed the Travis build on PHP 5.3.3
Updating PHPUnit requires OpenSSL which is not available on 5.3.3 on Travis.
Commits
-------
84561d2 Fixed the Travis build on PHP 5.3.3
* 2.4:
Minor doc fix.
Simplified the way to update PHPUnit to the latest version
[Process] Minor README update
[HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM
Fixed a html error "Element ul is not closed" in logger.html.twig
[HttpFoundation] Officialize the 308 redirect RFC
Officialize the 308 redirect RFC
issue #10808 crawler test
Empty select with attribute name="foo[]" bug fix
Fixed contextually wrong translation
* 2.3:
Minor doc fix.
Simplified the way to update PHPUnit to the latest version
[Process] Minor README update
[HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM
Fixed a html error "Element ul is not closed" in logger.html.twig
[HttpFoundation] Officialize the 308 redirect RFC
issue #10808 crawler test
Empty select with attribute name="foo[]" bug fix
Fixed contextually wrong translation
This PR was merged into the 2.5 branch.
Discussion
----------
[Debug] work-around https://bugs.php.net/61272
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8703
| License | MIT
https://bugs.php.net/61272 is the real offender.
Using ob_end_flush() instead of ob_end_clean() is the fix.
Commits
-------
cb8aff3 [Debug] work-around https://bugs.php.net/61272
This PR was merged into the 2.3 branch.
Discussion
----------
Simplified the way to update PHPUnit to the latest version
Commits
-------
ba37394 Simplified the way to update PHPUnit to the latest version
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#11106).
Discussion
----------
Minor doc fix in FormTypeInterface
Commits
-------
bf21d1a Minor doc fix.
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Fix basic authentication in url with PHP-FPM
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | dispute
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
`getUser()` and `getPassword()` from `Request` are broken when using PHP-FPM because of the lack of `$_SERVER['PHP_AUTH_USER']` and `$_SERVER['PHP_AUTH_PW']`. This PR fixes the issue.
However, now an empty password will return an empty string (which is the expected behavior of `ServerBag`) instead of `NULL`. The test is updated accordingly, but should we consider this as a breakage?
This issue was spotted by using basic auth via the Illuminate component of Laravel and is present from v2.1.0 to master.
Commits
-------
7a75adf [HttpFoundation] Basic auth in url is broken when using PHP CGI/FPM
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Minor README update
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
c7d6bbb [Process] Minor README update
