Commit Graph

19202 Commits

Author SHA1 Message Date
Nicolas Grekas
d70ff0abd4 Merge branch '2.7' into 2.8
* 2.7:
  [SecurityBundle] Removing test insulations for a huge perf win
  [Validator] Use the new interface in the README
  [Filesystem] fix tests on 2.3
  [Filesystem] Recursivly widen non-executable directories
  [Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too
  updated validators.bg.xlf
  [Security] Enable bcrypt validation and result length tests on all PHP versions
  [Security] Verify if a password encoded with bcrypt is no longer than 72 characters
  [Console] Avoid extra blank lines when rendering exceptions
  [Console][Table] fixed render row with multiple cells.
  [Yaml] do not remove "comments" in scalar blocks

Conflicts:
	src/Symfony/Component/Console/Application.php
	src/Symfony/Component/Console/Tests/Fixtures/application_renderexception1.txt
	src/Symfony/Component/Console/Tests/Fixtures/application_renderexception2.txt
	src/Symfony/Component/Console/Tests/Fixtures/application_renderexception4.txt
	src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php
	src/Symfony/Component/Form/Tests/Extension/Core/Type/CollectionTypeTest.php
	src/Symfony/Component/Yaml/Tests/ParserTest.php
2015-12-22 11:25:57 +01:00
Nicolas Grekas
b7f998f744 Merge branch '2.3' into 2.7
* 2.3:
  [SecurityBundle] Removing test insulations for a huge perf win
  [Filesystem] fix tests on 2.3
  [Filesystem] Recursivly widen non-executable directories
2015-12-22 11:07:22 +01:00
Fabien Potencier
bbc53dd83f minor #16999 [SecurityBundle] Removing test insulations for a huge perf win (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[SecurityBundle] Removing test insulations for a huge perf win

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

b8fa471 [SecurityBundle] Removing test insulations for a huge perf win
2015-12-21 19:31:12 +01:00
Nicolas Grekas
b8fa471f8a [SecurityBundle] Removing test insulations for a huge perf win 2015-12-21 17:08:45 +01:00
Ener-Getick
1fbbe84007 [Validator] Use the new interface in the README 2015-12-21 13:16:02 +01:00
Fabien Potencier
1bc9aaa6f9 minor #17080 Fix doctrine bridge tests on older PHP versions (jakzal)
This PR was merged into the 2.8 branch.

Discussion
----------

Fix doctrine bridge tests on older PHP versions

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | f176156eb4
| License       | MIT
| Doc PR        | -

`Foo::class` constant was introduced in PHP 5.5.

Commits
-------

6c68946 Fix doctrine bridge tests on older PHP versions
2015-12-21 09:04:51 +01:00
Andreia Bohner
b59ea7da96 [Validator] Add missing pt_BR translation 2015-12-21 09:04:00 +01:00
Jakub Zalas
6c68946a06 Fix doctrine bridge tests on older PHP versions 2015-12-20 14:24:37 +01:00
Christian Flothmann
9050f676af [Filesystem] fix tests on 2.3
The test introduced in #16797 used the `assertFilePermissions()` method
to test for the expected result. This worked quite well for the PR as it
was submitted for the `master` branch. However, the tests now fail on
2.3 as the `FilesystemTestCase` class which contains this method was
introduced with Symfony 2.4.
2015-12-19 12:15:11 +01:00
Filippo Tessarotto
fb75651a81 [Filesystem] Recursivly widen non-executable directories 2015-12-18 18:05:29 +01:00
Fabien Potencier
422430e282 bug #16926 [DependencyInjection] fixed definition loosing property shared when decorated by a parent definition (wahler)
This PR was squashed before being merged into the 2.8 branch (closes #16926).

Discussion
----------

[DependencyInjection] fixed definition loosing property shared when decorated by a parent definition

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

While upgrading my applications from 2.7 and 2.8 I found out that the attribute "shared" gets lost when a parent is configured. I wrote a Test to confirm my assumption and added a bugfix

Commits
-------

d3a4a77 [DependencyInjection] fixed definition loosing property shared when decorated by a parent definition
2015-12-18 18:02:10 +01:00
Christian Wahler
d3a4a770a6 [DependencyInjection] fixed definition loosing property shared when decorated by a parent definition 2015-12-18 18:02:00 +01:00
Fabien Potencier
6a92f4e03f Merge branch '2.3' into 2.7
* 2.3:
  [Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too
  updated validators.bg.xlf
  [Security] Enable bcrypt validation and result length tests on all PHP versions
  [Security] Verify if a password encoded with bcrypt is no longer than 72 characters
  [Console] Avoid extra blank lines when rendering exceptions
  [Yaml] do not remove "comments" in scalar blocks
2015-12-18 17:59:46 +01:00
Nicolas Grekas
f176156eb4 Fix merge 2015-12-18 17:54:49 +01:00
Fabien Potencier
f371445eff bug #17040 [Console] Avoid extra blank lines when rendering exceptions (ogizanagi)
This PR was merged into the 2.3 branch.

Discussion
----------

[Console] Avoid extra blank lines when rendering exceptions

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Don't know if it can be considered as a bug fix as it is the behavior since a while (https://github.com/symfony/symfony/pull/9055), but I let you see by yourself the old vs new rendering:

![Console exception rendering](https://cloud.githubusercontent.com/assets/2211145/11857447/92cebfbe-a458-11e5-9d3d-6147b0338080.PNG)

Commits
-------

2e158df [Console] Avoid extra blank lines when rendering exceptions
2015-12-18 17:54:05 +01:00
Fabien Potencier
4c7c5ff489 bug #17044 [Form] fix BC break introduced with prototype_data option (memphys)
This PR was squashed before being merged into the 2.8 branch (closes #17044).

Discussion
----------

[Form] fix BC break introduced with prototype_data option

| Q             | A
| ------------- | ---
| Bug fix?      | [yes]
| New feature?  | [no]
| BC breaks?    | [no]
| Deprecations? | [no]
| Tests pass?   | [no]
| Fixed tickets | [#15707]
| License       | MIT
| Doc PR        | []

This fixes the BC break introduced with prototype_data option in collection type. At the moment whether option is set or not it overwrites prototype data but it has different behaviour before and prototype data was taken from the mapped form data/entity.

- [x] make the test work (can't figure yet how to test that prototype without prototype_data option has default values)

Commits
-------

d73485a [Form] fix BC break introduced with prototype_data option
2015-12-18 17:52:32 +01:00
Roma Lapin
d73485a821 [Form] fix BC break introduced with prototype_data option 2015-12-18 17:52:31 +01:00
Fabien Potencier
68bd2c19a1 bug #17055 [Security] Verify if a password encoded with bcrypt is no longer than 72 characters (jakzal)
This PR was merged into the 2.3 branch.

Discussion
----------

[Security] Verify if a password encoded with bcrypt is no longer than 72 characters

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17047
| License       | MIT
| Doc PR        | -

From the [password_hash() docs](http://php.net/password_hash):

> Caution Using the PASSWORD_BCRYPT as the algorithm, will result in the password parameter being truncated to a maximum length of 72 characters.

Commits
-------

0a496e7 [Security] Enable bcrypt validation and result length tests on all PHP versions
5c30266 [Security] Verify if a password encoded with bcrypt is no longer than 72 characters
2015-12-18 17:49:25 +01:00
Fabien Potencier
baa5b7db29 bug #16959 [Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too (HeahDude)
This PR was squashed before being merged into the 2.3 branch (closes #16959).

Discussion
----------

[Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15544
| License       | MIT
| Doc PR        | -

Commits
-------

b4b5d63 [Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too
2015-12-18 17:43:49 +01:00
Jules Pietri
b4b5d63660 [Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too 2015-12-18 17:43:43 +01:00
Fabien Potencier
3f8e218431 bug #16806 [Validator] BicValidator - fixed raising violations to a maximum of one (mvhirsch)
This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] BicValidator - fixed raising violations to a maximum of one

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

I just found a bug while using the constraint. For example my value "a" will raise three violations at one time. I just expected to get a maximum number of one.
This PR will fix that behavior.

I do not know how I can easily add Unit-Tests for that, can someone please help me?

Commits
-------

7860bb4 [Validator] fixed raising violations to a maximum of one
2015-12-18 17:33:18 +01:00
Fabien Potencier
d4fff991e0 bug #16842 [Ldap] Escape carriage returns in LDAP DNs. (ChadSikorra)
This PR was squashed before being merged into the 2.8 branch (closes #16842).

Discussion
----------

[Ldap] Escape carriage returns in LDAP DNs.

Depends upon this commit in polyfill: https://github.com/symfony/polyfill/pull/14

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Carriage returns are supposed to be escaped in a LDAP DN. Leading and trailing spaces should be encoded as well. The spaces were taken care of in the polyfill implementation of `ldap_escape`, but the actual PHP function doesn't do the same. So I moved that logic within the component function and removed it from the polyfill function.

Commits
-------

2243db4 [Ldap] Escape carriage returns in LDAP DNs.
2015-12-18 17:29:00 +01:00
Chad Sikorra
2243db49b8 [Ldap] Escape carriage returns in LDAP DNs. 2015-12-18 17:28:57 +01:00
Fabien Potencier
8d010230ef bug #16860 [Yaml] do not remove "comments" in scalar blocks (xabbuh)
This PR was merged into the 2.3 branch.

Discussion
----------

[Yaml] do not remove "comments" in scalar blocks

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12478, #15857
| License       | MIT
| Doc PR        |

Inside scalar blocks, lines starting with a `#` character must be
treated like every other strings and must not be ignored as comments.

Commits
-------

3c72fcc [Yaml] do not remove "comments" in scalar blocks
2015-12-18 17:24:33 +01:00
Fabien Potencier
dae4267216 bug #17002 [Console][Table] fixed render row that contains multiple cells. (aitboudad)
This PR was merged into the 2.7 branch.

Discussion
----------

[Console][Table] fixed render row that contains multiple cells.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |  #16998
| License       | MIT
| Doc PR        | n/a

Commits
-------

3790ac7 [Console][Table] fixed render row with multiple cells.
2015-12-18 17:14:15 +01:00
Fabien Potencier
ff7cd633e9 minor #16892 [2.8] Use correct height for toolbar clearer (WouterJ)
This PR was merged into the 2.8 branch.

Discussion
----------

[2.8] Use correct height for toolbar clearer

The toolbar is 36px heigh, while the clearer is set at 38px. This means that there is 2px between the end of the page and the toolbar. This is especially not nice when the footer has a dark color (it renders a 2px white line between toolbar and footer).

| Q             | A
| ------------- | ---
| Fixed tickets | -
| License       | MIT

Commits
-------

1a9c0bc Use correct height for clearer
2015-12-18 17:11:40 +01:00
Roumen Damianoff
862b8722b3 updated validators.bg.xlf 2015-12-18 17:08:09 +01:00
Nicolas Grekas
6cc5756d8b Merge branch '2.7' into 2.8
* 2.7:
  prefer phpunit 5.x on hhvm
  [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands
  [travis] Auto-conf deps=high matrix line
  Fix the logout path when not using the router
  Fix the logout path when not using the router
  [Form] cast IDs to match deprecated behaviour of EntityChoiceList
  [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile
  [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers

Conflicts:
	.travis.yml
	src/Symfony/Bundle/FrameworkBundle/composer.json
2015-12-18 16:38:35 +01:00
Nicolas Grekas
85814de44c Merge branch '2.3' into 2.7
* 2.3:
  prefer phpunit 5.x on hhvm
  [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands
  [travis] Auto-conf deps=high matrix line
  Fix the logout path when not using the router
  [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile
  [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers

Conflicts:
	.travis.yml
	src/Symfony/Bundle/FrameworkBundle/composer.json
	src/Symfony/Bundle/SecurityBundle/Templating/Helper/LogoutUrlHelper.php
2015-12-18 16:35:58 +01:00
Nicolas Grekas
da767b8e63 bug #16964 CSS min-height and min-width should not be "auto" (aschempp)
This PR was merged into the 2.8 branch.

Discussion
----------

CSS min-height and min-width should not be "auto"

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Setting `min-width` and `min-height` to `auto` does not work in Safari and IE. The `auto` property has been removed from the standard meanwhile (see https://developer.mozilla.org/en-US/docs/Web/CSS/min-height).

Correct is to set a minimum of zero, which is actually "no minimum height".

This is what the web profiler looks like before and after on latest Safari:

![bildschirmfoto 2015-12-11 um 11 02 31](https://cloud.githubusercontent.com/assets/1073273/11741083/f17357fc-9ff6-11e5-8b59-239b38d37b2a.png)

![bildschirmfoto 2015-12-11 um 11 02 25](https://cloud.githubusercontent.com/assets/1073273/11741089/f6fb6656-9ff6-11e5-946f-f6c9f936c17f.png)

Commits
-------

107c44a CSS min-height and min-width should not be "auto"
2015-12-18 12:12:01 +01:00
Nicolas Grekas
6b13708ab6 bug #16971 [HttpFoundation] Added the ability of using BinaryFileResponse with stream wrappers (jakzal, Sander-Toonen)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] Added the ability of using BinaryFileResponse with stream wrappers

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12990 #13187
| License       | MIT
| Doc PR        | ~

Commits
-------

1da3d61 [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile
dd129b7 [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers
2015-12-18 11:44:19 +01:00
Nicolas Grekas
1c2029a518 minor #17015 [FrameworkBundle] minor: fix property_info service name in composer.json (dunglas)
This PR was merged into the 2.8 branch.

Discussion
----------

[FrameworkBundle] minor: fix property_info service name in composer.json

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

2680b5c [FrameworkBundle] minor: fix property_info service name in composer.json
2015-12-18 11:34:10 +01:00
Nicolas Grekas
c2b7ccb36c bug #17048 Fix the logout path when not using the router (stof)
This PR was merged into the 2.3 branch.

Discussion
----------

Fix the logout path when not using the router

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17029
| License       | MIT
| Doc PR        | n/a

This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting.

Commits
-------

1a2567e Fix the logout path when not using the router
2015-12-18 10:38:22 +01:00
Christian Flothmann
17fcef5aff [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands 2015-12-18 10:21:31 +01:00
Christian Flothmann
49296347c8 fix error level for deprecation 2015-12-17 22:45:56 +01:00
Jakub Zalas
0a496e7011 [Security] Enable bcrypt validation and result length tests on all PHP versions 2015-12-17 18:05:04 +00:00
Jakub Zalas
5c302669eb [Security] Verify if a password encoded with bcrypt is no longer than 72 characters 2015-12-17 18:04:54 +00:00
Christophe Coevoet
542b877424 Fix the logout path when not using the router
This needs to use the base url, not the base path, so that it goes
through the front controller when not using url rewriting.
2015-12-17 14:04:43 +01:00
Christophe Coevoet
1a2567e19e Fix the logout path when not using the router
This needs to use the base url, not the base path, so that it goes
through the front controller when not using url rewriting.
2015-12-17 13:54:40 +01:00
Maxime Steinhausser
2e158df2c7 [Console] Avoid extra blank lines when rendering exceptions 2015-12-17 00:47:15 +01:00
Tobias Schultze
2d48af7745 bug #17006 [Form] Fix casting regression in DoctrineChoiceLoader (bendavies)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Fix casting regression in DoctrineChoiceLoader

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

In symfony 2.7, the [DoctrineChoiceLoader](9543b36a34/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php) and [IdReader](9543b36a34/src/Symfony/Bridge/Doctrine/Form/ChoiceList/IdReader.php) were introduce to replace the deprecated [EntityChoiceList](9543b36a34/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php)

There appears to have been a change in behaviour in the refactor, as the old `EntityChoiceList` [casts ID to strings](9543b36a34/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php (L248)), whereas the new `DoctrineChoiceLoader` [does not](https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php#L159). The casting behavior was [maintained elsewhere](https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php#L122), however.

Since the new `DoctrineChoiceLoader` deprecated `EntityChoiceList`, i'm calling this a regression.

Commits
-------

54bbade [Form] cast IDs to match deprecated behaviour of EntityChoiceList
2015-12-15 20:21:59 +01:00
Ben Davies
54bbade3e6 [Form] cast IDs to match deprecated behaviour of EntityChoiceList 2015-12-15 11:02:11 +00:00
Kévin Dunglas
2680b5cd0c [FrameworkBundle] minor: fix property_info service name in composer.json 2015-12-15 08:31:34 +01:00
Tobias Schultze
3a57b77bc7 Merge branch '2.7' into 2.8 2015-12-15 02:39:37 +01:00
Tobias Schultze
92d9ba38fe minor #16934 [PropertyInfo] Fix some namespaces in tests (dunglas)
This PR was merged into the 2.8 branch.

Discussion
----------

[PropertyInfo] Fix some namespaces in tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

0660891 [PropertyInfo] Fix some namespaces in tests
2015-12-15 02:34:22 +01:00
Tobias Schultze
88d586b447 Merge branch '2.3' into 2.7 2015-12-15 02:31:17 +01:00
Ilya Antipenko
457b3f0047 [PropertyAccessor] A little refactor
- Remove obsolete code
 - Remove excessive actions
 - Fix phpdoc & comments
2015-12-15 02:27:13 +01:00
Kévin Dunglas
6c9bb86b47 [PropertyAccess] minor: constants as internal and removed unused var 2015-12-15 02:21:26 +01:00
Kévin Dunglas
f50f92ab08 bug #16911 [PropertyInfo] Update List Information from ReflectionExtractor (zanderbaldwin)
This PR was squashed before being merged into the 2.8 branch (closes #16911).

Discussion
----------

[PropertyInfo] Update List Information from ReflectionExtractor

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16889
| License       | MIT
| Doc PR        | symfony/symfony-docs#5974

Unless a property with the same casing exists, lowercase the first letter of a property name extracted from a method. From what I understand, we don't actually need to support `snake_case` at all in the PropertyInfo component.

I cannot think of any use-case where PropertyAccess would be used to get/set a property value *before* using PropertyInfo to find out information about the property and the values it supports.

Since PropertyInfo supports the discovery of property names, which can then be used as identifiers in PropertyAccess, there should be no need to support a naming strategy to map property identifiers from one naming convention to another.

---

Running `$reflectionExtractor->getProperties($class)` with the following classes:

```php
class X
{
    public $a;
    public $b;
    public function getA() {}
}
// Result: array('a', 'b');
```

```php
class Y
{
    public $A;
    public $b;
    public function setA() {}
}
// Result: array('A', 'b');
```

```php
class Y
{
    public $username;
    protected $emailAddress;
    public $password;
    public function getEmailAddress() {}
    public function isActive() {}
}
// Result: array('username', 'emailAddress', 'password', 'active');
```

Commits
-------

b2da76c [PropertyInfo] Update List Information from ReflectionExtractor
2015-12-14 22:30:57 +01:00
Zander Baldwin
b2da76ce5b [PropertyInfo] Update List Information from ReflectionExtractor 2015-12-14 22:30:54 +01:00