This PR was merged into the 5.3-dev branch.
Discussion
----------
[PhpUnitBridge] bump "php" to 7.1+ and "phpunit" to 7.5+
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Now that we don't maintain any branch with PHP < 7.1, we can drop support for older PHP and phpunit versions from the bridge \o/
Commits
-------
fe24f73ec0 [PhpUnitBridge] bump "php" to 7.1+ and "phpunit" to 7.5+
* 5.2:
Fix enabled key for ratelimiter config
Use more explicit variable name
Fix wrong comment about SES region
[Mailer] [Sendgrid] Use $scheme variable to stay consistent
[Mailer] [Amazon] Fix @param annotation
[Mailer] Rename testsuites
Remove void return type from test methods
Remove void return type from test methods
[Notifier] Remove void return type from test methods
[Notifier][Telegram] Remove void return type from test methods
[Notifier][Esendex] Remove void return type from test methods
[Notifier][Sendinblue] Remove void return type from test methods
[Notifier][GoogleChat] Remove void return type from test methods
[Notifier] Move ext-json below php requirement to stay consistent
* 5.1:
Use more explicit variable name
Fix wrong comment about SES region
[Mailer] [Sendgrid] Use $scheme variable to stay consistent
[Mailer] [Amazon] Fix @param annotation
[Mailer] Rename testsuites
Remove void return type from test methods
Remove void return type from test methods
[Notifier] Remove void return type from test methods
* 4.4:
Use more explicit variable name
Fix wrong comment about SES region
[Mailer] [Sendgrid] Use $scheme variable to stay consistent
[Mailer] [Amazon] Fix @param annotation
[Mailer] Rename testsuites
Remove void return type from test methods
This PR was merged into the 5.3-dev branch.
Discussion
----------
[DomCrawler] Fix null namespace issue in Crawler
| Q | A
| ------------- | ---
| Branch? | 5.x <!-- see below -->
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#39277 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | <!-- required for new features -->
In this case `isset` may cause an issue if null value would be stored in `$this->namespaces` or `$this->cachedNamespaces`, but never fetched, as if condition would return false. This PR is for 5.x, because namespace caching was introduced recently (#39097).
Commits
-------
7b0a183920 [DomCrawler] Fix null namespace issue in Crawler
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[Notifier] [DX] UnsupportedMessageTypeException for notifier transports
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | --
| License | MIT
| Doc PR | --
I want to streamline the experience, creating new notifier transports. Maybe such exceptions fit well, as we are planing to get more and more transports and don't want to "pollute" the transports itself with repeatable code.
Please let me know if you are open to have such exceptions as I would like to introduce more of them for unsupported options for example and if this should be considered a new feature or it should be applied against `5.1`?
I am not sure about the signature and the name of the new `UnsupportedMessageTypeException`.
Cheers
Commits
-------
cf1d352eac [Notifier] [DX] UnsupportedMessageTypeException for notifier transports
This PR was squashed before being merged into the 5.2 branch.
Discussion
----------
Fix enabled key for ratelimiter config
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
The `enabled` key doesn't always exist in the config when using the ratelimiter component, which causes an undefined index error
Commits
-------
d48e2c2431 Fix enabled key for ratelimiter config
This PR was merged into the 4.4 branch.
Discussion
----------
Use more explicit variable name
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> -->
| License | MIT
- This is called `$container` in https://symfony.com/blog/new-in-symfony-5-1-improved-microkernel.
- In the same file, in `registerContainerConfiguration` we're doing `$this->configureContainer($container, $loader);`.
So I think that `$container` is better than `$c`.
Commits
-------
337174fa4b Use more explicit variable name
This PR was merged into the 4.4 branch.
Discussion
----------
Fix wrong comment about SES region
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This list is wrong (or maybe no more exact). And maintain such list does not make sens in code.
https://docs.aws.amazon.com/general/latest/gr/ses.html
Commits
-------
759774750e Fix wrong comment about SES region
This PR was merged into the 4.4 branch.
Discussion
----------
Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
94f823fd4a Remove void return type from test methods
This PR was merged into the 5.1 branch.
Discussion
----------
Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
This PR follows #39459
cc @nicolas-grekas
Commits
-------
6e6c3ba1a0 Remove void return type from test methods
This PR was merged into the 4.4 branch.
Discussion
----------
[Mailer] [Sendgrid] Use $scheme variable to stay consistent
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
Its used like this in all other mailer bridges
Commits
-------
1a40d7c75a [Mailer] [Sendgrid] Use $scheme variable to stay consistent
This PR was merged into the 4.4 branch.
Discussion
----------
[Mailer] Rename testsuites
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
to stay consistent with other bridges.
Commits
-------
9ebfa6034a [Mailer] Rename testsuites
This PR was merged into the 5.1 branch.
Discussion
----------
[Notifier] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.1
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
616df0c6a3 [Notifier] Remove void return type from test methods
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] [Telegram] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
e48fcdcd34 [Notifier][Telegram] Remove void return type from test methods
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] [Esendex] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
6c185d19ad [Notifier][Esendex] Remove void return type from test methods
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] [Sendinblue] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
15f523e6ad [Notifier][Sendinblue] Remove void return type from test methods
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] [GoogleChat] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
de2bf6d98a [Notifier][GoogleChat] Remove void return type from test methods
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] Add PHP 8 support for bridges
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
Is 5.2 the right branch?
Commits
-------
32014199d0 [Notifier] Add PHP 8 support for bridges
This PR was merged into the 5.1 branch.
Discussion
----------
[PropertyInfo][Serializer] Fixed extracting ignored properties for Serializer
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Fixed typo in `SerializerExtractor::getProperties()` introduced in 8526d7c050 which leads to the error after https://github.com/symfony/symfony/pull/37040.
`$serializerClassMetadata` is instance of `Symfony\Component\Serializer\Mapping\ClassMetadata`, which doesn't contain `isIgnored` method, this methods is located in `Symfony\Component\Serializer\Mapping\AttributeMetadata` which is `$serializerAttributeMetadata` here. More over, it doesn't make sense to check the method existence in one class and call it for another.
Commits
-------
594ce465ce [PropertyInfo][Serializer] Fixed extracting ignored properties
This PR was merged into the 5.3-dev branch.
Discussion
----------
Fix CS in changelogs
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
the last one :)
Commits
-------
fb22eece5e Fix CS in changelogs