This PR was merged into the 2.3 branch.
Discussion
----------
[Form] Fixed: Filter non-integers when selecting entities by int ID
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #14950
| License | MIT
| Doc PR | -
This is #14950 cherry-picked on 2.3 with a fix embedded.
Commits
-------
086c58c [DoctrineBridge] Bypass the db when no valid identifier is provided in ORMQueryBuilderLoader
45579fd [Form] Fixed: Filter non-integers when selecting entities by int ID
* 2.3:
[2.3][Debug] Fix fatal-errors handling on HHVM
Standardize the name of the exception variables
[2.3] Static Code Analysis for Components
Remove duplicated paths
Conflicts:
src/Symfony/Component/Debug/ErrorHandler.php
src/Symfony/Component/HttpFoundation/Session/Storage/MockArraySessionStorage.php
src/Symfony/Component/Security/Acl/Dbal/AclProvider.php
src/Symfony/Component/Security/Core/Authentication/Provider/UserAuthenticationProvider.php
This PR was merged into the 2.6 branch.
Discussion
----------
[Debug+VarDumper] Fix handling of PHP7 "Throwable" exceptions
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
PHP7 may introduce the Throwable interface if the corresponding RFC is accepted (see https://wiki.php.net/rfc/throwable-interface)
This PR adds support for it. We should wait for final approval of the RFC before merging it.
Commits
-------
4dc727f [Debug+VarDumper] Fix handling of PHP7 exception/error model
edf793e [VarDumper] Cherry-pick code style fixes from 2.7
This PR was merged into the 2.6 branch.
Discussion
----------
[VarDumper] Fix uninitialized id in HtmlDumper
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #15015
| License | MIT
| Doc PR | -
Commits
-------
00eee72 [VarDumper] Fix uninitialized id in HtmlDumper
This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes#14980).
Discussion
----------
Fixed fluent interface
Small fix for fluent interface break when adding a single `TableSeparator` instance.
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | #14981 14981
| License | MIT
| Doc PR |
Commits
-------
138f4a9 Fixed fluent interface
This PR was merged into the 2.6 branch.
Discussion
----------
[Debug] fix debug class loader case test on windows
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #14978
| License | MIT
| Doc PR | none
https://github.com/symfony/symfony/blob/2.6/src/Symfony/Component/Debug/DebugClassLoader.php#L213 didn't work since $real and $tail had different directory separators.
Commits
-------
31c25d9 [Debug] fix debug class loader case test on windows
This PR was squashed before being merged into the 2.3 branch (closes#14890).
Discussion
----------
[2.3] Static Code Analysis for Components
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Static Code Analysis with Php Inspections (EA Extended):
- not optimal regular expressions usage
- strlen miss-use
- not optimal conditional statements in Process and Filesystem
- unsafe uniquid usage
PS: re-creating to no spam history log with reverts
Commits
-------
4a4fea7 [2.3] Static Code Analysis for Components
This PR was merged into the 2.3 branch.
Discussion
----------
[Config] Remove duplicated paths
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
If someone sets the same path twice, the file locator will search for the the same file twice. We should remove duplicated paths before locate a file.
Commits
-------
97de887 Remove duplicated paths
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#14930).
Discussion
----------
Bug #14836 [HttpFoundation] Moves default JSON encoding assignment fr…
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | #14918, #14836
| License | MIT
| Doc PR | no
Moves the assignment of the encoding flags to a property so the class can be extended without needing to re-write the constructor and perform the encoding of data twice.
For more information please see https://github.com/symfony/symfony/issues/14836
Commits
-------
25e0d63 Bug #14836 [HttpFoundation] Moves default JSON encoding assignment from constructor to property
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#14897).
Discussion
----------
Allow new lines in Messages translated with transchoice() (replacement for #14867)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Hi,
I found that the MessageSelector does not handle new lines in messages very well.
I suggest adding the "s" modifier to the regexp used to identify the parts and ranges.
What do you think?
PS: would be nice to have this change also in Symfony 2.6 & 2.7
Commits
-------
786b8a6 Allow new lines in Messages translated with transchoice() (replacement for #14867)
This PR was squashed before being merged into the 2.3 branch (closes#14926).
Discussion
----------
[2.3] Fix tests on Windows
There were quite a few tests failing when running on my Windows PC. These fixes are the ones I could easily fix.
| Q | A
| --- | ---
| License | MIT
| Fixed tickets | -
Commits
-------
e3e5f3d [2.3] Fix tests on Windows
* 2.3:
[Form] Support DateTimeImmutable in transform()
[Form] Fix call to removed method (BC broken in 2.3)
[HttpFoundation] Get response content as resource several times for PHP >= 5.6
Improved duplicated code in FileLocator
This PR was submitted for the 2.8 branch but it was merged into the 2.6 branch instead (closes#14866).
Discussion
----------
Updated UPGRADE-2.4.md
| Q | A
| ------------- | ---
| Bug fix? | [no]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [yes ?]
| Tests pass? | [yes]
| Fixed tickets |
| License | MIT
| Doc PR |
A missing deprecation in the upgrade guide.
Commits
-------
b631a56 Updated UPGRADE-2.4.md
This PR was merged into the 2.3 branch.
Discussion
----------
[Form] Support DateTimeImmutable in transform()
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
When passing a DateTimeImmutable instance to DateTimeToLocalizedStringTransformer::transform($dateTime), it throws an exception, `TransformationFailedException('Expected a \DateTime.')`.
The method just converts a date-time object into a string, so there is no reason that it should not support all DateTimeInterface implementations.
DateTimeInterface was added in PHP 5.5, so in order to support earlier versions, we need to do instanceof checks for both DateTime and DateTimeInterface. When Symfony requires PHP 5.5 or larger, we can remove the DateTime check and only check for DateTimeInterface.
This was originally submitted as a PR against the 2.7 branch in #14676.
Commits
-------
17346c5 [Form] Support DateTimeImmutable in transform()
This PR was merged into the 2.6 branch.
Discussion
----------
[Form] add test to avoid regression of #14891
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #14891
| License | MIT
| Doc PR |
Commits
-------
12a19c8 [Form] add test to avoid regression of #14891
This PR was merged into the 2.3 branch.
Discussion
----------
[Form] Fix call to removed method (BC broken in 2.3)
ResolvedFormType#getTypeExtensions() was calling method
AbstractType#getExtensions() which has been removed in
commit b3081e85a0
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
fa9da42 [Form] Fix call to removed method (BC broken in 2.3)
This PR was submitted for the 2.8 branch but it was merged into the 2.6 branch instead (closes#14891).
Discussion
----------
without this change allways the legacy code get called
[Form] [Validator] prevent that always the legacy validator logic get called
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | []
| License | MIT
| Doc PR | []
Commits
-------
96a30bf without this change allways the legacy code get called
ResolvedFormType#getTypeExtensions() was calling method
AbstractType#getExtensions() which has been removed in
commit b3081e85a0
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -