This PR was squashed before being merged into the 3.4 branch (closes#31813).
Discussion
----------
fix type hint for salt in PasswordEncoderInterface
See issue #31812
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #31812
| License | MIT
| Doc PR | none
Pretty self-explanatory
Commits
-------
0e741f9600 fix type hint for salt in PasswordEncoderInterface
This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes#31802).
Discussion
----------
update italian validator translation
| Q | A
| ------------- | ---
| Branch? | 4.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
This PR just takes the italian translation for validators up to date with english one.
Commits
-------
2b95fcaa6b update italian validator translation
This PR was merged into the 4.3 branch.
Discussion
----------
[TwigBridge] suggest Translation Component when TranslationExtension is used
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #31754
| License | MIT
| Doc PR | -
Commits
-------
d4a9e7e639 [TwigBridge] suggest Translation Component when TranslationExtension is used
This PR was squashed before being merged into the 4.3 branch (closes#31744).
Discussion
----------
[Validator] Fix TimezoneValidator default option
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/roadmap):
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against branch 4.4.
- Legacy code removals go to the master branch.
-->
Commits
-------
ee71cdbae4 [Validator] Fix TimezoneValidator default option
This PR was merged into the 4.3 branch.
Discussion
----------
[DoctrineBridge][Validator] do not enable validator auto mapping by default
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | part of #31715, #31752
| License | MIT
| Doc PR |
Commits
-------
a3555fc49c do not enable validator auto mapping by default
This PR was merged into the 3.4 branch.
Discussion
----------
Use willReturn() instead of will(returnValue())
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
In a recent PR, fabbot complained about the usage of will(returnValue()) in test cases that I haven't changed. In this PR, I've applied the PHP CS Fixer's `php_unit_mock_short_will_return` fixer on the whole codebase.
Commits
-------
4fb67df612 Use willReturn() instead of will(returnValue()).
This PR was merged into the 3.4 branch.
Discussion
----------
[github] define 4.4 as the feature branch
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
And let's use master for preparing 5.0.
Commits
-------
30b560c4df [github] define 4.4 as the feature branch
This PR was squashed before being merged into the 4.3 branch (closes#31719).
Discussion
----------
Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
In `Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client` property exists phpdoc about property class, but no `use` declaration added.
As `Symfony\Bundle\FrameworkBundle\Client` deprecated, and actually this will be `Symfony\Bundle\FrameworkBundle\KernelBrowser` instance, we can put `KernelBrowser` instead `Client` (not sure about BC)
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/roadmap):
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
-->
Commits
-------
6982025e3a Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
This PR was merged into the 4.3 branch.
Discussion
----------
[HttpClient] Minor fix in an error message
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License | MIT
| Doc PR | -
Fixes this:
Commits
-------
2da9e3f717 [HttpClient] Minor fix in an error message
This PR was merged into the 4.3 branch.
Discussion
----------
[PHPUnitBridge] Use a more appropriate group when deprecating mode
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.
Commits
-------
3a88f11662 Use a more appropriate group when deprecating mode
The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.
Nicolas Grekas
Massimiliano Arione
Grégoire Pineau
Pierre du Plessis
Christian Flothmann
Fabien Potencier
Tobias Schultze
Toni Peric
Robin Chalas
Roland Franssen
SAMUEL NELA
Alexander M. Turek
Andrii Dembitskyi
Javier Eguiluz
Chi-teck
Grégoire Paris
