Commits
-------
970d0b4 [BrowserKit] Check class existence only when required.
Discussion
----------
[BrowserKit] Check class existence only when required.
See PR #4177
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Remove incorrect exception when doing $client->insulate(false)
Commits
-------
9ac8d43 [Security] fixed phpdoc.
a3ecea3 [Security] added some missing phpdoc for AbstractToken::setUser() and UsernamePasswordToken::__construct() methods.
Discussion
----------
Fixes PHPDoc in UsernamePasswordToken and AbstractToken classes
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
Commits
-------
7fe236a [Security] Configure ports in RetryAuthenticationEntryPoint according to router settings
Discussion
----------
[Security] Configure ports in RetryAuthenticationEntryPoint according to...
... router settings
As requested against 2.0 branch ...
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Currently the ports in RetryAuthenticationEntryPoint are fixed in the constructor call, there is no way to set them when you run your application on different ports.
With this fix the ports are taken from the router configuration.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Currently the ports in RetryAuthenticationEntryPoint are fixed in the constructor call, there is no way to set them when you run your application on different ports.
With this fix the ports are taken from the router configuration.
Commits
-------
5b92b9e [Console] Selectively output to STDOUT or OUTPUT stream
Discussion
----------
[Console] Selectively output to STDOUT or OUTPUT stream
Originally opened in this PR targeting master, but asked to target 2.0 instead: https://github.com/symfony/symfony/pull/4148
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #1434
Todo: -
As noted in the ticket discussion and linked discussion threads, IBM i5 Series has issues with writing output to STDOUT when viewed via their QP2TERM console. The output is likely not being converted to the correct character-encoding on the system level.
This PR changes the default output stream from `php://stdout` to `php://output` for OS400 environments, which does not exhibit this issue.
I'm using `php_uname('s')` to check for the presence of "OS400", which is at least one of the IBM OS's exhibiting this issue. This check is only done once when executing a Console task and shouldn't see any adverse affects in speed on the 99% other platforms using Symfony.
I'm not a native to the OS400 platform so I can't really anticipate any other possible regressions that might occur from switching output streams for that platform. On my Mac, this change would strip all color output, but the PR code only changes output for OS400 environment. To my knowledge the QP2TERM console doesn't even support color, so no loss there.
I think this change is best to make the Console component at least usable out of the box for anyone else trying to build CLI applications for use on OS400.
---------------------------------------------------------------------------
by igorw at 2012-04-29T19:41:21Z
#4146 might also need a fix for this.
---------------------------------------------------------------------------
by johnkary at 2012-04-29T20:21:39Z
@igorw Hmm. In this case for #4152 when creating a CLI application, `Symfony\Component\Console\Output\ConsoleOutput` is the [default implementation](5b92b9ed43/src/Symfony/Component/Console/Application.php (L113)) used by `Symfony\Component\Console\Application` when not specifying your own `OutputInterface`. Our hard-coded defaults were causing problems out of the box.
I haven't looked too closely at the PRs surrounding the additions of `StreamingResponse` and your recent `OutputStream` but are we assuming anywhere that `php://stdout` is the default stream used when creating a streaming response? If so it MAY require a check similar to what I implemented for Console. My addition was only necessary because the output was being sent to a CLI console. If output is sent to a browser, I don't believe this would be an issue.
If you have something that needs testing on OS400 just ping me.
Addresses issues with writing console output for IBM i5 Series (OS400).
The normal QP2TERM shell outputs garbage text when attempting to write
directly to STDOUT, likely because of EBCDIC character-encoding used
on IBM platforms. Writing to the OUTPUT mimics using 'echo' or 'print'
and prints properly in the console.
Fixes#1434
Commits
-------
689a40d [MonologBridge] Fixed the WebProcessor
Discussion
----------
[MonologBridge] Fixed the WebProcessor
The WebProcessor can now be registered as a kernel.request listener to
get the request instead of passing it as a constructor argument, which
was broken as the request is not yet available when the logger is
instantiated.
I'm sending it to 2.0 even if the way to use the processor is not BC as this is really a bugfix. The processor was simply unusable with the previous way. Tell me if you think it should only be fixed for 2.1
Fixes#3311
The WebProcessor can now be registered as a kernel.request listener to
get the request instead of passing it as a constructor argument, which
was broken as the request is not yet available when the logger is
instantiated.
Commits
-------
fde94ca [Validator] Fixed example in README file (fixes#4088)
Discussion
----------
[Validator] Fixed example in README file (fixes#4088)
Commits
-------
2e7d3b1 http_build_query fix
de73de0 http_build_query fix
3b7ee9a http_build_query fix
Discussion
----------
[2.0] http_build_query extra parameters
Bug fix: yes
arg_separator.output is not always "&", so it is better ini_set it or put an extra parameters to http_build_query
---------------------------------------------------------------------------
by fabpot at 2012-04-23T10:20:05Z
Can you squash your commits? It will be much easier to get back to this change later on. Thanks.
---------------------------------------------------------------------------
by Ziumin at 2012-04-23T10:46:35Z
I have no idea how to do it using web interface. I'm not familiar with git (prefer hg). Sorry.
Commits
-------
7ddc8cb [FrameworkBundle] Monitor added/removed translations files in dev (fix#3653)
Discussion
----------
[FrameworkBundle] Monitor added/removed translations files in dev
fix#3653
---------------------------------------------------------------------------
by Koc at 2012-04-20T14:09:55Z
maybe you also can fix#971 ?
Commits
-------
45ada32 Add Support for boolean as to string into yaml extension
Discussion
----------
Add Support for boolean as to string into yaml extension
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: 3992
Todo:
- Maybe use only boolean checker instead of YamlDumper->dump
Commits
-------
89a1cdb Fixed grammar error. "tenminste" (instead of) -> "ten minste" (at minimum).
Discussion
----------
[Validator] validators.nl.xlf Fixed grammar error
There is a small grammar error in validators.nl.xlf
tenminste is wrong is this context.
http://www.onzetaal.nl/taaladvies/advies/tenminste
"tenminste" (instead of) -> "ten minste" (at minimum).
---------------------------------------------------------------------------
by Burgov at 2012-04-19T08:49:14Z
The name of the PR refers to the wrong file
---------------------------------------------------------------------------
by sstok at 2012-04-19T08:57:38Z
Oops :) your wright, I had to recover the form and made that mistake before and fixed in then.
The filename in the commit is correct however.
