Commit Graph

39080 Commits

Author SHA1 Message Date
Maxime Steinhausser
fee81f84d3 Complete UPGRADE-4.2.md 2018-11-07 16:48:32 +01:00
Nicolas Grekas
8d277ce3e5 Merge branch '4.1'
* 4.1:
  [VarDumper] fix dump of closures created from callables
  [DI] fix dumping inlined services
  Add framework asset changes to upgrade 3.0 guide
  [Travis] Bump ext-mongodb to 1.5.2 on Travis
  [DI] dont track classes/interfaces used to compute autowiring error messages
  [DI] fix GraphvizDumper ignoring inline definitions
  bumped Symfony version to 4.1.8
  updated VERSION for 4.1.7
  updated CHANGELOG for 4.1.7
  bumped Symfony version to 3.4.19
  updated VERSION for 3.4.18
  updated CHANGELOG for 3.4.18
  bumped Symfony version to 2.8.48
  updated VERSION for 2.8.47
  update CONTRIBUTORS for 2.8.47
  updated CHANGELOG for 2.8.47
  Fix ini_get() for boolean values
2018-11-06 18:10:56 +01:00
Nicolas Grekas
097963fbaf Merge branch '3.4' into 4.1
* 3.4:
  [VarDumper] fix dump of closures created from callables
  [DI] fix dumping inlined services
  Add framework asset changes to upgrade 3.0 guide
  [Travis] Bump ext-mongodb to 1.5.2 on Travis
  [DI] dont track classes/interfaces used to compute autowiring error messages
  [DI] fix GraphvizDumper ignoring inline definitions
  bumped Symfony version to 3.4.19
  updated VERSION for 3.4.18
  updated CHANGELOG for 3.4.18
  bumped Symfony version to 2.8.48
  updated VERSION for 2.8.47
  update CONTRIBUTORS for 2.8.47
  updated CHANGELOG for 2.8.47
  Fix ini_get() for boolean values
2018-11-06 17:43:48 +01:00
Nicolas Grekas
6006448997 bug #29104 [DI] fix dumping inlined services (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] fix dumping inlined services

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28824 #29078
| License       | MIT
| Doc PR        | -

Same as #29103 but for 3.4.

This PR dump inline services using the call-stack to sort the code for instantiating them.
This makes easier to follow and matches the behavior one would expect (and has when using `ContainerBuiler` directly to create services.)

Commits
-------

a97606d58a [DI] fix dumping inlined services
2018-11-06 17:31:32 +01:00
Nicolas Grekas
41eaba5af5 bug #29054 [VarDumper] fix dump of closures created from callables (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] fix dump of closures created from callables

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

We are missing displaying full information about closures created using `ReflectionMethod::getClosure()` or `Closure::fromCallable()`.

This PR fixes it. For VarDumper but also other places where we have logic to display them.

Commits
-------

1c1818b876 [VarDumper] fix dump of closures created from callables
2018-11-06 17:26:47 +01:00
Nicolas Grekas
1c1818b876 [VarDumper] fix dump of closures created from callables 2018-11-06 17:20:05 +01:00
Nicolas Grekas
a97606d58a [DI] fix dumping inlined services 2018-11-06 17:06:23 +01:00
Nicolas Grekas
85df96a41d Merge branch '2.8' into 3.4
* 2.8:
  Add framework asset changes to upgrade 3.0 guide
  [Travis] Bump ext-mongodb to 1.5.2 on Travis
  bumped Symfony version to 2.8.48
  updated VERSION for 2.8.47
  update CONTRIBUTORS for 2.8.47
  updated CHANGELOG for 2.8.47
2018-11-06 17:04:36 +01:00
Nicolas Grekas
69ae468351 bug #29102 [DI] fix GraphvizDumper ignoring inline definitions (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] fix GraphvizDumper ignoring inline definitions

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Since SF3, inline definitions are first class citizen. I noticed that the GraphvizDumper does not inspect them. Here is the fix.

Commits
-------

ebe6265504 [DI] fix GraphvizDumper ignoring inline definitions
2018-11-06 17:03:43 +01:00
Nicolas Grekas
6cfd3de7bf minor #29041 Fix ini_get() for boolean values (deguif)
This PR was merged into the 3.4 branch.

Discussion
----------

Fix ini_get() for boolean values

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This follows #29020 for branch 3.4

Commits
-------

65b34cb53c Fix ini_get() for boolean values
2018-11-06 17:00:34 +01:00
Nicolas Grekas
613ace6874 minor #29077 Add framework asset changes to upgrade 3.0 guide (KatharinaSt)
This PR was squashed before being merged into the 2.8 branch (closes #29077).

Discussion
----------

Add framework asset changes to upgrade 3.0 guide

| Q             | A
| ------------- | ---
| Branch?       | 2.8 up to 4.1 <!-- see below -->
| Bug fix?      | no (upgrade guide improvement)
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29050   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

further reading:
https://symfony.com/blog/new-in-symfony-2-7-the-new-asset-component
<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

7de10880a4 Add framework asset changes to upgrade 3.0 guide
2018-11-06 16:58:21 +01:00
KatharinaSt
7de10880a4 Add framework asset changes to upgrade 3.0 guide 2018-11-06 16:58:15 +01:00
Nicolas Grekas
ef3be0b244 bug #29090 LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface (desmax)
This PR was merged into the 4.2-dev branch.

Discussion
----------

LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29089
| License       | MIT

While autowiring Translator using `Symfony\Contracts\Translation\TranslatorInterface` symfony complains that wrong service was injected, because LoggingTranslator does not implement new interface.

Commits
-------

65f321f6c9 LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface
2018-11-06 16:56:30 +01:00
Nicolas Grekas
f9198c2aa7 bug #29095 [TwigBridge] require the needed symfony/contracts package (xabbuh)
This PR was merged into the 4.2-dev branch.

Discussion
----------

[TwigBridge] require the needed symfony/contracts package

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29086
| License       | MIT
| Doc PR        |

Commits
-------

4400776140 require the needed symfony/contracts package
2018-11-06 16:55:41 +01:00
Nicolas Grekas
f898332fb5 bug #29107 [DI] dont track classes/interfaces used to compute autowiring error messages (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] dont track classes/interfaces used to compute autowiring error messages

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29019
| License       | MIT
| Doc PR        | -

This will also improve DX since tracking these files is not needed at all.

Commits
-------

09a0c23668 [DI] dont track classes/interfaces used to compute autowiring error messages
2018-11-06 16:54:19 +01:00
Nicolas Grekas
2b7985d5e6 minor #29068 Remove unused variable (jschaedl)
This PR was merged into the 4.2-dev branch.

Discussion
----------

Remove unused variable

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

246b3bf757 Remove unused variable
2018-11-06 16:44:47 +01:00
Nicolas Grekas
8cd0538a7f bug #29094 Add samesite attribute to session cookie after session migration (rpkamp)
This PR was merged into the 4.2-dev branch.

Discussion
----------

Add samesite attribute to session cookie after session migration

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29092
| License       | MIT
| Doc PR        | N/A

Commits
-------

df903005c1 Add samesite attribute to session cookie after session migration
2018-11-06 16:33:07 +01:00
Nicolas Grekas
96894947cd minor #29099 [Travis] Bump ext-mongodb to 1.5.2 on Travis (ogizanagi)
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #29099).

Discussion
----------

[Travis] Bump ext-mongodb to 1.5.2 on Travis

| Q             | A
| ------------- | ---
| Branch?       | 2.7 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/451058906#L2679   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Should fix Travis builds after ba0b611acb being merged (but not released yet).

And/or use `composer require --dev --no-update mongodb/mongodb:@stable`?

Commits
-------

6e4af32284 [Travis] Bump ext-mongodb to 1.5.2 on Travis
2018-11-06 16:30:29 +01:00
Maxime Steinhausser
6e4af32284 [Travis] Bump ext-mongodb to 1.5.2 on Travis 2018-11-06 16:30:18 +01:00
Nicolas Grekas
23a0b2dcda minor #29100 [Messenger] Cleaning after new changes (yceruto)
This PR was squashed before being merged into the 4.2-dev branch (closes #29100).

Discussion
----------

[Messenger] Cleaning after new changes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See topic per commit

Commits
-------

3d31772949 [Messenger] Cleaning after new changes
2018-11-06 16:29:10 +01:00
Yonel Ceruto
3d31772949 [Messenger] Cleaning after new changes 2018-11-06 16:29:01 +01:00
Nicolas Grekas
09a0c23668 [DI] dont track classes/interfaces used to compute autowiring error messages 2018-11-06 14:23:35 +01:00
Nicolas Grekas
ebe6265504 [DI] fix GraphvizDumper ignoring inline definitions 2018-11-06 10:26:47 +01:00
Fabien Potencier
5e0d3f0b8d minor #29093 Clarify deprecation of Email constraint without egulias/email-validator (rpkamp)
This PR was merged into the 4.2-dev branch.

Discussion
----------

Clarify deprecation of Email constraint without egulias/email-validator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

f77970b950 Clarify deprecation of Email constraint without egulias/email-validator
2018-11-06 09:13:06 +01:00
Remon van de Kamp
f77970b950
Clarify deprecation of Email constraint without egulias/email-validator 2018-11-05 21:30:49 +01:00
Christian Flothmann
4400776140 require the needed symfony/contracts package 2018-11-05 11:24:20 +01:00
Remon van de Kamp
df903005c1
Add samesite attribute to session cookie after session migration 2018-11-05 10:25:33 +01:00
Maxim Pustynnikov
65f321f6c9 LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface 2018-11-05 14:48:19 +08:00
Fabien Potencier
4bc1cc7e43 bug #29080 [FrameworkBundle][4.2] fix deps (ro0NL)
This PR was merged into the 4.2-dev branch.

Discussion
----------

[FrameworkBundle][4.2] fix deps

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

The bundle requires the `MetadataAwareNameConverter` added in 4.2

1fc577f2c7/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.xml (L122-L124)

This PR fixes

```
Attempted to load interface "AdvancedNameConverterInterface" from namespace "Symfony\Component\Serializer\NameConverter".
Did you forget a "use" statement for another namespace?
```

Commits
-------

71fe97a7ab [FrameworkBundle][4.2] fix deps
2018-11-04 20:05:04 +01:00
Fabien Potencier
95b975d0d2 minor #29083 [Messenger] The component is still experimental (ogizanagi)
This PR was merged into the 4.2-dev branch.

Discussion
----------

[Messenger] The component is still experimental

| Q             | A
| ------------- | ---
| Branch?       | 4.2 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

3136611d1e [Messenger] The component is still experimental
2018-11-04 20:04:20 +01:00
Maxime Steinhausser
3136611d1e
[Messenger] The component is still experimental 2018-11-04 20:00:43 +01:00
Roland Franssen
71fe97a7ab
[FrameworkBundle][4.2] fix deps 2018-11-04 14:52:16 +01:00
Fabien Potencier
1fc577f2c7 bumped Symfony version to 4.2.0 2018-11-03 14:17:14 +01:00
Fabien Potencier
736f710805
Merge pull request #29073 from fabpot/release-4.2.0-BETA1
released v4.2.0-BETA1
2018-11-03 13:49:05 +01:00
Fabien Potencier
91957aa4cc updated VERSION for 4.2.0-BETA1 2018-11-03 13:37:30 +01:00
Fabien Potencier
d782263056 updated CHANGELOG for 4.2.0-BETA1 2018-11-03 13:37:19 +01:00
Fabien Potencier
0615759e7c bumped Symfony version to 4.1.8 2018-11-03 12:15:06 +01:00
Fabien Potencier
b5c6892911
Merge pull request #29071 from fabpot/release-4.1.7
released v4.1.7
2018-11-03 12:11:34 +01:00
Fabien Potencier
78e1def253 updated VERSION for 4.1.7 2018-11-03 12:11:23 +01:00
Fabien Potencier
32c731b5db updated CHANGELOG for 4.1.7 2018-11-03 12:11:16 +01:00
Fabien Potencier
3ed98de837 bumped Symfony version to 3.4.19 2018-11-03 12:10:01 +01:00
Fabien Potencier
ee054aa62e
Merge pull request #29070 from fabpot/release-3.4.18
released v3.4.18
2018-11-03 11:03:29 +01:00
Fabien Potencier
b22cad3743 updated VERSION for 3.4.18 2018-11-03 11:03:02 +01:00
Fabien Potencier
188481df60 updated CHANGELOG for 3.4.18 2018-11-03 11:02:53 +01:00
Fabien Potencier
d1ca2ac4af bumped Symfony version to 2.8.48 2018-11-03 11:02:24 +01:00
Fabien Potencier
0a7bd0db86
Merge pull request #29069 from fabpot/release-2.8.47
released v2.8.47
2018-11-03 10:54:14 +01:00
Fabien Potencier
6f9c358e5d updated VERSION for 2.8.47 2018-11-03 10:53:57 +01:00
Fabien Potencier
cefedf9da1 update CONTRIBUTORS for 2.8.47 2018-11-03 10:53:55 +01:00
Fabien Potencier
75558bf219 updated CHANGELOG for 2.8.47 2018-11-03 10:53:41 +01:00
Jan Schädlich
246b3bf757
Remove unused variable 2018-11-03 08:39:20 +01:00