Archived

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier 0cfc00e717 feature #25456 [Console] Make pretty the box style table (maidmaid)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Console] Make pretty the `box` style table

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

The console component is the 2nd most popular Symfony component with 70M of downloads. I think such composant has to provide faultless tables, with perfect management of borders, especially since the new `box` style table has been merged (cf https://github.com/symfony/symfony/pull/25301).

![screenshot from 2017-12-12 18-47-34](https://user-images.githubusercontent.com/4578773/33876488-6e1dc81c-df71-11e7-924f-d5e8078d957f.png)

Commits
-------

41f52b3a09 Make pretty the `box` style table

2018-03-17 08:08:46 -07:00

3.0 KiB

Raw Blame History

UPGRADE FROM 4.x to 5.0

Config

Added the getChildNodeDefinitions() method to ParentNodeDefinitionInterface.

Console

Removed the setCrossingChar() method in favor of the setDefaultCrossingChar() method in TableStyle.

EventDispatcher

The TraceableEventDispatcherInterface has been removed.

FrameworkBundle

Removed support for bundle:controller:action and service:action syntaxes to reference controllers. Use serviceOrFqcn::method instead where serviceOrFqcn is either the service ID when using controllers as services or the FQCN of the controller.

Before:

bundle_controller:
    path: /
    defaults:
        _controller: FrameworkBundle:Redirect:redirect

service_controller:
    path: /
    defaults:
        _controller: app.my_controller:myAction

After:

bundle_controller:
    path: /
    defaults:
        _controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController::redirectAction

service_controller:
    path: /
    defaults:
        _controller: app.my_controller::myAction

Removed Symfony\Bundle\FrameworkBundle\Controller\ControllerNameParser.
Warming up a router in RouterCacheWarmer that does not implement the WarmableInterface is not supported anymore.
The RequestDataCollector class has been removed. Use the Symfony\Component\HttpKernel\DataCollector\RequestDataCollector class instead.

HttpFoundation

The $size argument of the UploadedFile constructor has been removed.
The getClientSize() method of the UploadedFile class has been removed.

Security

The ContextListener::setLogoutOnUserChange() method has been removed.
The Symfony\Component\Security\Core\User\AdvancedUserInterface has been removed.

SecurityBundle

The logout_on_user_change firewall option has been removed.
The switch_user.stateless firewall option has been removed.
The SecurityUserValueResolver class has been removed.

Translation

The FileDumper::setBackup() method has been removed.
The TranslationWriter::disableBackup() method has been removed.

TwigBundle

The default value (false) of the twig.strict_variables configuration option has been changed to %kernel.debug%.

Validator

The Email::__construct() 'strict' property has been removed. Use 'mode'=>"strict" instead.
Calling EmailValidator::__construct() method with a boolean parameter has been removed, use EmailValidator("strict") instead.
Removed the checkDNS and dnsMessage options from the Url constraint.

Workflow

add method has been removed use addWorkflow method in Workflow\Registry instead.
SupportStrategyInterface has been removed, use WorkflowSupportStrategyInterface instead.
ClassInstanceSupportStrategy has been removed, use InstanceOfSupportStrategy instead.

3.0 KiB Raw Blame History