This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
Go to file
Fabien Potencier 4e25a619dc bug #23618 [Routing] allow HEAD method to be defined first (DavidBadura)
This PR was merged into the 3.3 branch.

Discussion
----------

[Routing] allow HEAD method to be defined first

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Since 3.3 it's no longer possible to set the allowed methods to HEAD followed by GET. If you try this you get an `Notice: Undefined offset: 0` error.

```
index:
  path: '/'
  defaults:
    _controller: AppBundle:Default:index
  methods: [HEAD, GET]
```

It works perfectly if you change the ordering of the allowed methods:

```
index:
  path: '/'
  defaults:
    _controller: AppBundle:Default:index
  methods: [GET, HEAD]
```

The problem has been added in this commit: dd647ffc8a (diff-3b72491a9ba1cff58442b845ae837eb3R297)

After an `array_filter` the keys will not be reset. So the key `0` does not exist anymore and this check `if ('$methods[0]' !== \$$methodVariable) {` fails. A simple `array_values` ​​fix this issue.

Commits
-------

52e2821597 Router: allow HEAD method to be defined first
2017-07-22 09:57:14 +02:00
.composer Drop hirak/prestissimo 2016-05-12 07:44:15 -05:00
.github Using FQ name for PHP_VERSION_ID 2017-06-01 13:44:56 -07:00
src/Symfony Router: allow HEAD method to be defined first 2017-07-21 19:43:13 +02:00
.editorconfig Add EditorConfig File 2012-06-16 14:08:15 +02:00
.gitignore Add appveyor.yml for C.I. on Windows 2015-08-25 23:41:37 +02:00
.php_cs.dist [Asset] Adding a new version strategy that reads from a manifest JSON file 2017-03-25 09:22:50 -07:00
.travis.yml Merge branch '3.2' into 3.3 2017-07-21 13:04:46 +02:00
appveyor.yml Merge branch '2.8' into 3.2 2017-05-19 14:10:04 +02:00
CHANGELOG-3.0.md Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
CHANGELOG-3.1.md updated CHANGELOG for 3.1.9 2017-01-12 12:43:31 -08:00
CHANGELOG-3.2.md updated CHANGELOG for 3.2.12 2017-07-17 20:14:55 +02:00
CHANGELOG-3.3.md updated CHANGELOG for 3.3.5 2017-07-17 21:08:20 +02:00
composer.json Merge branch '3.2' into 3.3 2017-07-17 18:39:25 +02:00
CONTRIBUTING.md Mention the community review guide 2016-12-18 22:02:35 +01:00
CONTRIBUTORS.md Merge branch '2.8' into 3.2 2017-07-18 09:52:56 +02:00
LICENSE updated LICENSE year 2017-01-02 12:30:00 -08:00
phpunit Using FQ name for PHP_VERSION_ID 2017-06-01 13:44:56 -07:00
phpunit.xml.dist Merge branch '3.2' 2017-04-12 07:14:56 -07:00
README.md Fix minor typo in the main README.md 2017-04-27 20:23:38 +02:00
UPGRADE-3.0.md Fixed formatting in Security section 2017-04-14 11:38:02 +02:00
UPGRADE-3.1.md [Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize 2016-12-08 16:02:32 +01:00
UPGRADE-3.2.md [DI] Check for privates before shared services 2017-05-23 19:58:02 +02:00
UPGRADE-3.3.md [Di] Remove closure-proxy arguments 2017-06-01 22:59:07 +02:00
UPGRADE-4.0.md [SecurityBundle] Clarify deprecation in UserPasswordEncoderCommand::getContainer 2017-07-15 19:48:19 +02:00

Symfony is a PHP framework for web applications and a set of reusable PHP components. Symfony is used by thousands of web applications (including BlaBlaCar.com and Spotify.com) and most of the popular PHP projects (including Drupal and Magento).

Installation

Documentation

Community

Contributing

Symfony is an Open Source, community-driven project with thousands of contributors. Join them contributing code or contributing documentation.

Security Issues

If you discover a security vulnerability within Symfony, please follow our disclosure procedure.

About Us

Symfony development is sponsored by SensioLabs, led by the Symfony Core Team and supported by Symfony contributors.