This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
Go to file
Nicolas Grekas 98bfdf751d bug #39889 [HttpClient] Add check for constant in Curl client (pierredup)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Add check for constant in Curl client

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

After updating Curl on a server, I started receiving the following warning:

```
Warning: Use of undefined constant CURLHEADER_SEPARATE - assumed 'CURLHEADER_SEPARATE'
```

This is a bit of a strange issue, so I'm not 100% sure if this fix is correct (or even if it needs fixing here or in PHP).

The `CURLOPT_HEADEROPT` and `CURLHEADER_SEPARATE` have been added in [Curl 7.37.0](https://curl.se/libcurl/c/CURLHEADER_SEPARATE.html). The update on the server installed Curl `7.29.0`.
So technically these constants should not exist, but in fact the `CURLOPT_HEADEROPT` constant is defined but not the `CURLHEADER_SEPARATE` constant.

This seems a bit weird since both constants have been introduced in the same version.

**PHP Version**: 7.4.14
**Curl Version**: 7.29.0
**CentOs Version**: CentOS Linux release 7.9.2009
**symfony/http-client Version**: 5.0.3

```bash
Psy Shell v0.10.6 (PHP 7.4.14 — cli) by Justin Hileman
>>> defined('CURLOPT_HEADEROPT')
=> true
>>> defined('CURLHEADER_SEPARATE')
=> false
>>> curl_version()
=> [
     "version_number" => 466176,
     "age" => 3,
     "features" => 558781,
     "ssl_version_number" => 0,
     "version" => "7.29.0",
     "host" => "x86_64-redhat-linux-gnu",
     "ssl_version" => "NSS/3.53.1",
     "libz_version" => "1.2.7",
     "protocols" => [
       "dict",
       "file",
       "ftp",
       "ftps",
       "gopher",
       "http",
       "https",
       "imap",
       "imaps",
       "ldap",
       "ldaps",
       "pop3",
       "pop3s",
       "rtsp",
       "scp",
       "sftp",
       "smtp",
       "smtps",
       "telnet",
       "tftp",
     ],
     "ares" => "",
     "ares_num" => 0,
     "libidn" => "1.28",
     "iconv_ver_num" => 0,
     "libssh_version" => "libssh2/1.8.0",
   ]
>>>
```

```bash
$ yum info libcurl

Installed Packages
Name        : curl
Arch        : x86_64
Version     : 7.29.0
Release     : 59.el7_9.1
Size        : 528 k
Repo        : installed
From repo   : updates
```

Curl PHP info:

```
cURL support => enabled
cURL Information => 7.29.0
Age => 3
Features
AsynchDNS => Yes
CharConv => No
Debug => No
GSS-Negotiate => Yes
IDN => Yes
IPv6 => Yes
krb4 => No
Largefile => Yes
libz => Yes
NTLM => Yes
NTLMWB => Yes
SPNEGO => No
SSL => Yes
SSPI => No
TLS-SRP => No
Protocols => dict, file, ftp, ftps, gopher, http, https, imap, imaps, ldap, ldaps, pop3, pop3s, rtsp, scp, sftp, smtp, smtps, telnet, tftp
Host => x86_64-redhat-linux-gnu
SSL Version => NSS/3.53.1
ZLib Version => 1.2.7
libSSH Version => libssh2/1.8.0
```

Commits
-------

c888797313 Add check for constant in Curl client
2021-01-19 11:12:50 +01:00
.github [travis] use PHP 8.0 to patch return types and run deps=low 2021-01-14 15:31:07 +01:00
src/Symfony Add check for constant in Curl client 2021-01-19 12:01:54 +02:00
.appveyor.yml Cleanup CI scripts 2021-01-04 17:51:14 +01:00
.editorconfig Update .editorconfig 2018-09-06 16:22:56 +02:00
.gitignore Run the phpunit-bridge from a PR 2019-08-02 17:46:19 +02:00
.php_cs.dist CS fix 2021-01-14 16:08:15 +01:00
.travis.yml [travis] always install ext-mongodb 2021-01-14 20:57:15 +01:00
CHANGELOG-4.0.md Merge branch '3.4' into 4.1 2018-08-01 18:22:14 +02:00
CHANGELOG-4.1.md updated CHANGELOG for 4.1.10 2019-01-06 17:16:07 +01:00
CHANGELOG-4.2.md updated CHANGELOG for 4.2.10 2019-06-26 16:19:37 +02:00
CHANGELOG-4.3.md updated CHANGELOG for 4.3.10 2020-01-21 14:13:32 +01:00
CHANGELOG-4.4.md Update CHANGELOG for 4.4.18 2020-12-18 14:31:35 +01:00
CODE_OF_CONDUCT.md Added the Code of Conduct file 2018-10-10 03:13:30 -07:00
composer.json [travis] use PHP 8.0 to patch return types and run deps=low 2021-01-14 15:31:07 +01:00
CONTRIBUTING.md Mention the community review guide 2016-12-18 22:02:35 +01:00
CONTRIBUTORS.md Update CONTRIBUTORS for 4.4.18 2020-12-18 14:32:28 +01:00
LICENSE Bump license year 2021-01-01 10:24:35 +01:00
link Fix CS in link binary 2020-12-10 19:02:00 +01:00
phpunit Added compatibility with PHPunit 9.5 2020-12-05 16:15:30 +01:00
phpunit.xml.dist Adds LDAP Adapter test in integration group 2020-11-16 15:17:13 +01:00
README.md Update README.md 2020-12-29 01:17:49 +01:00
UPGRADE-4.0.md Fix CS in changelogs 2020-12-10 17:34:26 +01:00
UPGRADE-4.1.md Merge branch '4.0' into 4.1 2018-05-31 12:17:53 +02:00
UPGRADE-4.2.md Merge branch '3.4' into 4.3 2020-01-08 18:19:22 +01:00
UPGRADE-4.3.md Merge branch '4.3' into 4.4 2019-11-19 13:20:06 +01:00
UPGRADE-4.4.md Fix CS in changelogs 2020-12-10 17:34:26 +01:00
UPGRADE-5.0.md Fix CS in changelogs 2020-12-10 17:34:26 +01:00

Symfony is a PHP framework for web and console applications and a set of reusable PHP components. Symfony is used by thousands of web applications (including BlaBlaCar.com and Spotify.com) and most of the popular PHP projects (including Drupal and Magento).

Installation

Documentation

Community

Contributing

Symfony is an Open Source, community-driven project with thousands of contributors. Join them contributing code or contributing documentation.

Security Issues

If you discover a security vulnerability within Symfony, please follow our disclosure procedure.

About Us

Symfony development is sponsored by SensioLabs, led by the Symfony Core Team and supported by Symfony contributors.