symfony

Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier d178a9b2c5 bug #24243 HttpCache does not consider ESI resources in HEAD requests (mpdude) This PR was squashed before being merged into the 2.7 branch (closes #24243). Discussion ---------- HttpCache does not consider ESI resources in HEAD requests \| Q \| A \| ------------- \| --- \| Branch? \| 2.7 \| Bug fix? \| yes \| New feature? \| no \| BC breaks? \| no \| Deprecations? \| no \| Tests pass? \| yes \| Fixed tickets \| \| License \| MIT \| Doc PR \| Due to this shortcut: `3b42d8859e/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php (L634-L642)` ... the `HttpCache` never looks at the response body for `HEAD` requests. This makes it completely miss ESI-related tweaks like computing the correct TTL, removing validation headers or updating the `Content-Length`. From RFC2616 (https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.4): > The HEAD method is identical to GET except that the server MUST NOT return a message-body in the response. The metainformation contained in the HTTP headers in response to a HEAD request SHOULD be identical to the information sent in response to a GET request. Although it says "SHOULD", I think it can be misleading at best when HEAD requests do, for example, return different (greater) `s-maxage` values than a corresponding GET request. Commits ------- `4dd0e53171` HttpCache does not consider ESI resources in HEAD requests		2017-09-28 05:20:58 -07:00
.composer	Drop hirak/prestissimo	2016-05-12 07:44:15 -05:00
.github	Use correct verb form in the pull request template	2017-09-26 11:35:56 +02:00
src/Symfony	bug #24243 HttpCache does not consider ESI resources in HEAD requests (mpdude)	2017-09-28 05:20:58 -07:00
.editorconfig	Add EditorConfig File	2012-06-16 14:08:15 +02:00
.gitignore	Add appveyor.yml for C.I. on Windows	2015-08-25 23:41:37 +02:00
.php_cs.dist	CS: recover no_break_comment	2017-09-15 12:36:22 +02:00
.travis.yml	[travis] update to trusty	2017-09-06 17:42:52 +02:00
appveyor.yml	[travis] update to trusty	2017-09-06 17:42:52 +02:00
CHANGELOG-2.2.md	Merge branch '2.2' into 2.3	2013-12-03 15:51:26 +01:00
CHANGELOG-2.3.md	updated CHANGELOG for 2.3.42	2016-05-30 10:40:50 +02:00
CHANGELOG-2.4.md	updated CHANGELOG for 2.4.9	2014-09-03 11:50:09 +02:00
CHANGELOG-2.5.md	updated CHANGELOG for 2.5.10	2015-02-02 10:26:02 +01:00
CHANGELOG-2.6.md	updated CHANGELOG for 2.6.10	2015-07-13 11:34:21 +02:00
CHANGELOG-2.7.md	updated CHANGELOG for 2.7.34	2017-08-28 11:40:29 -07:00
composer.json	require the XML PHP extension	2017-07-06 10:51:23 +02:00
CONTRIBUTING.md	Mention the community review guide	2016-12-18 22:02:35 +01:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.7.34	2017-08-28 11:40:34 -07:00
LICENSE	updated LICENSE year	2017-01-02 12:30:00 -08:00
phpunit	Using FQ name for PHP_VERSION_ID	2017-06-01 13:44:56 -07:00
phpunit.xml.dist	fail when detecting risky tests	2017-04-12 09:39:27 +02:00
README.md	Fix minor typo in the main README.md	2017-04-27 20:23:38 +02:00
UPGRADE-2.1.md	Remove aligned '=>' and '='	2014-10-26 08:30:58 +01:00
UPGRADE-2.2.md	Merge branch '2.3' into 2.5	2014-10-01 07:50:18 +02:00
UPGRADE-2.3.md	[Doc] Use Markdown syntax highlighting	2014-10-01 07:38:33 +02:00
UPGRADE-2.4.md	Updated UPGRADE-2.4.md	2015-06-08 16:44:57 +02:00
UPGRADE-2.5.md	Merge branch '2.5' into 2.6	2015-01-05 21:59:13 +01:00
UPGRADE-2.6.md	Fix grammar	2014-12-30 09:24:50 +01:00
UPGRADE-2.7.md	Update UPGRADE-2.7.md	2016-11-07 10:23:54 +03:00
UPGRADE-3.0.md	Add missing pieces in the upgrade guide to 3.0	2017-01-27 15:42:16 +01:00

README.md

Symfony is a PHP framework for web applications and a set of reusable PHP components. Symfony is used by thousands of web applications (including BlaBlaCar.com and Spotify.com) and most of the popular PHP projects (including Drupal and Magento).

Installation

Install Symfony with Composer or with our own installer (see requirements details).
Symfony follows the semantic versioning strictly, publishes "Long Term Support" (LTS) versions and has a release process that is predictable and business-friendly.

Documentation

Read the Getting Started guide if you are new to Symfony.
Try the Symfony Demo application to learn Symfony in practice.
Master Symfony with the Guides and Tutorials, the Components docs and the Best Practices reference.

Community

Join the Symfony Community and meet other members at the Symfony events.
Get Symfony support on Stack Overflow, Slack, IRC, etc.
Follow us on GitHub, Twitter and Facebook.

Contributing

Symfony is an Open Source, community-driven project with thousands of contributors. Join them contributing code or contributing documentation.

Security Issues

If you discover a security vulnerability within Symfony, please follow our disclosure procedure.

About Us

Symfony development is sponsored by SensioLabs, led by the Symfony Core Team and supported by Symfony contributors.