This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
Go to file
Robin Chalas e627989089 feature #33412 [Console] Do not leak hidden console commands (m-vo)
This PR was merged into the 4.4 branch.

Discussion
----------

[Console] Do not leak hidden console commands

| Q             | A
| ------------- | ---
| Branch?       | 4.4 (updated)
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33398
| License       | MIT

This PR attempts to fix hidden console commands to be leaked when interacting with the console.

These are the changes:
* Hidden commands won't be shown anymore in the list of commands in a namespace as well as the list of  suggestions ("Did you mean...") for invalid or ambiguous commands.
* Hidden commands therefore now need to be always entered with their full name.
* If an abbreviated command is entered that was previously ambiguous with (only) hidden commands, it's now executed directly (not ambiguous anymore).

Side note: When implementing the tests & changes I realized that `Application->get()` isn't side effect free (when redirecting to the help command) and behaves differently when called multiple times. It therefore must not be used from inside `find()`. Maybe we should change this? Here are the relevant bits:
f71f74b36a/src/Symfony/Component/Console/Application.php (L495-L502)

Commits
-------

f3406338e6 [Console] Deprecate abbreviating hidden command names using  Application->find()
2019-09-28 17:03:31 +02:00
.github [ErrorHandler] don't throw deprecations for return-types by default 2019-09-25 19:39:21 +02:00
src/Symfony [Console] Deprecate abbreviating hidden command names using Application->find() 2019-09-28 17:00:54 +02:00
.appveyor.yml Merge branch '3.4' into 4.3 2019-09-20 23:36:54 +02:00
.editorconfig Update .editorconfig 2018-09-06 16:22:56 +02:00
.gitignore Run the phpunit-bridge from a PR 2019-08-02 17:46:19 +02:00
.php_cs.dist Merge branch '4.3' into 4.4 2019-09-10 13:27:29 +02:00
.travis.yml [ErrorHandler] fix return-type patching logic 2019-09-25 22:29:01 +02:00
CHANGELOG-4.0.md Merge branch '3.4' into 4.1 2018-08-01 18:22:14 +02:00
CHANGELOG-4.1.md updated CHANGELOG for 4.1.10 2019-01-06 17:16:07 +01:00
CHANGELOG-4.2.md updated CHANGELOG for 4.2.10 2019-06-26 16:19:37 +02:00
CHANGELOG-4.3.md updated CHANGELOG for 4.3.4 2019-08-26 18:47:28 +02:00
CODE_OF_CONDUCT.md Added the Code of Conduct file 2018-10-10 03:13:30 -07:00
composer.json Allow Twig 3 2019-09-23 16:04:59 +02:00
CONTRIBUTING.md Mention the community review guide 2016-12-18 22:02:35 +01:00
CONTRIBUTORS.md update CONTRIBUTORS for 3.4.31 2019-08-26 18:36:24 +02:00
LICENSE update year in license files 2019-01-01 14:45:19 +01:00
link fixed "link" to Contracts packages 2019-09-13 12:50:50 -04:00
phpunit [ErrorHandler] fix return-type patching logic 2019-09-25 22:29:01 +02:00
phpunit.xml.dist [Cache] Add optimized FileSystem & Redis TagAware Adapters 2019-04-24 07:47:35 +02:00
README.md Merge branch '2.8' into 3.4 2018-05-25 16:50:57 +02:00
UPGRADE-4.0.md Merge branch '3.4' into 4.2 2019-06-06 12:03:46 +02:00
UPGRADE-4.1.md Merge branch '4.0' into 4.1 2018-05-31 12:17:53 +02:00
UPGRADE-4.2.md Add BC break note to UPGRADE-4.2.md 2019-09-06 11:27:22 +02:00
UPGRADE-4.3.md bug #32335 [Form] Names for buttons should start with lowercase (mcfedr) 2019-09-25 21:19:30 +02:00
UPGRADE-4.4.md [Console] Deprecate abbreviating hidden command names using Application->find() 2019-09-28 17:00:54 +02:00
UPGRADE-5.0.md [Console] Deprecate abbreviating hidden command names using Application->find() 2019-09-28 17:00:54 +02:00

Symfony is a PHP framework for web applications and a set of reusable PHP components. Symfony is used by thousands of web applications (including BlaBlaCar.com and Spotify.com) and most of the popular PHP projects (including Drupal and Magento).

Installation

Documentation

Community

Contributing

Symfony is an Open Source, community-driven project with thousands of contributors. Join them contributing code or contributing documentation.

Security Issues

If you discover a security vulnerability within Symfony, please follow our disclosure procedure.

About Us

Symfony development is sponsored by SensioLabs, led by the Symfony Core Team and supported by Symfony contributors.