diogo/xmpphp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix XMLObj::sub argument order

Browse Source 
XMLStream::endXML assumes $ns to be second.
This commit is contained in:
Alexei Sorokin 2020-09-13 18:47:26 +03:00
parent a5346a47dc
commit eb648db476
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
XMPPHP/XMLObj.php
View File

@ -158,15 +158,15 @@ class XMLObj
* Return a sub * Return a sub
* *
* @param string $name * @param string $name
* @param array|null $attrs (optional)
* @param string|null $ns (optional) * @param string|null $ns (optional)
* @param array|null $attrs (optional)
* @return mixed * @return mixed
*/ */
public function sub(string $name, ?array $attrs = null, ?string $ns = null) public function sub(string $name, ?string $ns = null, ?array $attrs = null)
{ {
#TODO attrs is ignored // @todo attrs is ignored
foreach ($this->subs as $sub) { foreach ($this->subs as $sub) {
if ($sub->name == $name and ($ns == null or $sub->ns == $ns)) { if ($sub->name === $name && (is_null($ns) || $sub->ns === $ns)) {
return $sub; return $sub;
} }
} }