Commit Graph

7019 Commits

Author SHA1 Message Date
Evan Prodromou 15b9f61842 Better error notification for Geonames plugin 2009-12-23 09:26:59 -08:00
Evan Prodromou 725b2d0475 save location at notice post time 2009-12-22 21:58:23 -08:00
Brion Vibber fa0fbd0118 Fix for massively slow friends timeline query due to indexing bug introduced with repeats.
Sorting on notice.id when our primary selector was notice_inbox.user_id caused a filesort and table scan of the notice table.
Switchng to notice_inbox's notice_id means we can use our index, and everything comes right up.

Before:
mysql> explain SELECT notice.id AS id FROM notice JOIN notice_inbox ON notice.id = notice_inbox.notice_id WHERE notice_inbox.user_id = 18574 AND notice.repeat_of IS NULL ORDER BY notice.id DESC LIMIT 61 OFFSET 0;
+----+-------------+--------------+--------+------------------------------------+---------+---------+-------------------------------+--------+----------------------------------------------+
| id | select_type | table        | type   | possible_keys                      | key     | key_len | ref                           | rows   | Extra                                        |
+----+-------------+--------------+--------+------------------------------------+---------+---------+-------------------------------+--------+----------------------------------------------+
|  1 | SIMPLE      | notice_inbox | ref    | PRIMARY,notice_inbox_notice_id_idx | PRIMARY | 4       | const                         | 102600 | Using index; Using temporary; Using filesort |
|  1 | SIMPLE      | notice       | eq_ref | PRIMARY                            | PRIMARY | 4       | stoica.notice_inbox.notice_id |      1 | Using index                                  |
+----+-------------+--------------+--------+------------------------------------+---------+---------+-------------------------------+--------+----------------------------------------------+

After:
mysql> explain SELECT notice.id AS id FROM notice JOIN notice_inbox ON notice.id = notice_inbox.notice_id WHERE notice_inbox.user_id = 18574 AND notice.repeat_of IS NULL ORDER BY notice_id DESC LIMIT 61 OFFSET 0;
+----+-------------+--------------+--------+------------------------------------+---------+---------+-------------------------------+--------+--------------------------+
| id | select_type | table        | type   | possible_keys                      | key     | key_len | ref                           | rows   | Extra                    |
+----+-------------+--------------+--------+------------------------------------+---------+---------+-------------------------------+--------+--------------------------+
|  1 | SIMPLE      | notice_inbox | ref    | PRIMARY,notice_inbox_notice_id_idx | PRIMARY | 4       | const                         | 102816 | Using where; Using index |
|  1 | SIMPLE      | notice       | eq_ref | PRIMARY,notice_repeatof_idx        | PRIMARY | 4       | stoica.notice_inbox.notice_id |      1 | Using where              |
+----+-------------+--------------+--------+------------------------------------+---------+---------+-------------------------------+--------+--------------------------+
2009-12-22 20:30:41 -08:00
Evan Prodromou f6bf952980 Merge branch 'testing' 2009-12-22 16:44:19 -08:00
Evan Prodromou 30c2e2ce83 update to rc2 2009-12-22 16:41:39 -08:00
Evan Prodromou d708e40be2 update README for 0.9.0rc2 2009-12-22 16:41:07 -08:00
Brion Vibber f987273f11 Ignore user language settings that aren't listed in language config; we'll then fall back to current autodetection. This prevents the surprises where your profile suddenly switches to Arabic because it was selected by default due to lack of a match in the drop-down box. 2009-12-21 06:57:10 -08:00
Brion Vibber 2fb76eec62 Followup fix for ticket 1672: Twitter bridge !group->#hash conversion will now happen regardless of whether account was configured with oauth or basic auth (previously applied only on the oauth path) 2009-12-18 09:38:25 -05:00
Brion Vibber dd96558b66 Make useremail.php executable 2009-12-17 16:41:45 -05:00
Christopher Vollick cc2b2a82da Added UserEmail script.
Used to query user's emails.

Mostly used for administration, to see if a user requesting something is who they say.

Also, some people assume that the admin knows this data, and says things like:
"If you could do _____ with the account connected to this email".

It'd be nice if we could do that without raw SQL.
2009-12-17 16:41:38 -05:00
Evan Prodromou 51838a969b Merge branch 'testing' of git@gitorious.org:statusnet/mainline into testing 2009-12-16 22:22:29 -05:00
Evan Prodromou 530673b3cd Merge branch '0.9.x' into testing 2009-12-16 22:14:41 -05:00
Siebrand Mazeland 7ee875b10f Localisation updates for !StatusNet from !translatewiki.net !sntrans 2009-12-16 23:57:10 +01:00
Brion Vibber dc4bedd25a Add some doc comments and fixmes in util.php 2009-12-16 09:27:48 -05:00
Brion Vibber 0ca80f78fb Add doc comments listing the array parameters for User::register() and Notice::saveNew() 2009-12-16 09:27:48 -05:00
Brion Vibber a998bda4a5 Fix UserRightsTest unit tests 2009-12-16 09:27:48 -05:00
Brion Vibber 0158f4f73d PHP 5.3 closure-based implementation of curry(); old implementation used as fallback for older PHP versions. Added unit tests to confirm they both work! 2009-12-16 09:27:48 -05:00
Brion Vibber 00fb5feff8 Cleanup undefined variable notice: set a couple more null defaults for new params in Notice::saveNew().
Fixes this notice seen while using AJAX repeat button:
Notice: Undefined variable: uri in classes/Notice.php on line 243
2009-12-16 09:27:48 -05:00
Brion Vibber e2e1843639 slight cleanup for a bit in Notice.php where a var was reused for different types, confusing tracking down a bug 2009-12-16 09:27:47 -05:00
Evan Prodromou 2a1468ec8b Merge branch '0.9.x' into testing 2009-12-15 16:24:52 -05:00
Evan Prodromou f3d27cc3ae can't repeat your own notice posted through realtime 2009-12-15 16:19:11 -05:00
Evan Prodromou 608d1b206a Don't show repeater avatar in notice lists 2009-12-15 16:08:44 -05:00
Evan Prodromou d6873beb9b make realtime plugin grok repeats 2009-12-15 15:47:37 -05:00
Sarven Capadisli 80b5a7fe60 Added .form_repeat notice option to received notices in Realtime plugin 2009-12-15 19:44:20 +00:00
Evan Prodromou 22f02b35ad call DB_DataObject::__destruct() if it exists 2009-12-15 12:38:15 -05:00
Evan Prodromou 945661d942 take out DB_DataObject destructor 2009-12-15 12:33:17 -05:00
Evan Prodromou 90c378a81f broadcast for repeats 2009-12-15 12:29:37 -05:00
Evan Prodromou 797a0d79fb create a method for notification for new messages, and use it 2009-12-15 10:31:25 -05:00
Evan Prodromou 19bb9a04d1 add mail notification for dm command results 2009-12-15 10:18:27 -05:00
Evan Prodromou d40f0931aa remove dead code for handling direct messages, now done with commands 2009-12-15 10:12:36 -05:00
Evan Prodromou e99e66eff0 give some trouble-shooting info for fancy URLs 2009-12-15 06:11:37 -05:00
Brion Vibber b9040a7cc4 Add destructor on Memcached_DataObject to free DB_DataObject's global storage for an object when that object itself is destroyed.
Reduces some, but not all, memory leakage for long-running processes.
2009-12-14 16:36:01 -08:00
Sarven Capadisli 27d0e8f0a4 Merge branch '0.9.x' of git@gitorious.org:statusnet/mainline into 0.9.x 2009-12-14 18:34:16 -05:00
Evan Prodromou 1aae7f382f document logincommand/disabled in README 2009-12-14 18:09:45 -05:00
Evan Prodromou 43ee2ec42f default for login command is disabled 2009-12-14 18:09:30 -05:00
Sarven Capadisli f8b187d5a4 Initial representation for repeated notice 2009-12-14 18:09:08 -05:00
Evan Prodromou 607e98ee11 make sure id of <li> in notice list is unique 2009-12-14 17:48:14 -05:00
Evan Prodromou d22364b35e had the order of <status> and <retweeted_status> wrong in api output 2009-12-14 17:11:34 -05:00
Evan Prodromou df7fc2710c Merge branch '0.9.x' of git@gitorious.org:statusnet/mainline into 0.9.x 2009-12-14 16:41:42 -05:00
Evan Prodromou 2a8eee0e0b add friends_timeline with no repeats in it 2009-12-14 16:41:25 -05:00
Evan Prodromou 9384a6e242 fix error with cached repeat of deleted original in api output 2009-12-14 16:40:56 -05:00
Siebrand Mazeland 5c13f855ef Merge branch '0.9.x' of git://gitorious.org/statusnet/mainline into 0.9.x 2009-12-14 22:29:35 +01:00
Evan Prodromou 6ff13d6828 move full-featured timeline to apitimelinehome.php 2009-12-14 16:10:16 -05:00
Evan Prodromou 1ace5c400e parse error in retweet method 2009-12-14 15:49:19 -05:00
Evan Prodromou 9d2a605d0e correct link for repeat attribution in noticelist 2009-12-14 15:42:53 -05:00
Siebrand Mazeland 8ab21542d2 Localisation updates for !StatusNet from !translatewiki.net !sntrans 2009-12-14 21:42:30 +01:00
Brion Vibber b93068083e Clean up console output for non-interactive mode (handy for batch setup scripts) 2009-12-14 11:51:38 -08:00
Zach Copley 918b662568 Fix issue with favorited/following always being set to false 2009-12-14 11:25:51 -08:00
Zach Copley 364038ce2a Fix Twitter bridge so it responds reasonably to authorization errors. 2009-12-14 11:25:01 -08:00
Zach Copley a199bd808a Fix issue with favorited/following always being set to false 2009-12-14 18:16:45 +00:00