This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] fix ErrorHandlerTest when context is not an array
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Commits
-------
988a5dc [Debug] fix ErrorHandlerTest when context is not an array
* 2.4:
[Debug] ErrorHandler: remove $GLOBALS from context in PHP5.3 fix#10292
Allow File instance to be passed to BinaryFileResponse
Add upgrade instructions for the LoggerInterface
fixed CS
Removed strict check when found variables inside a translation
[ExpressionLanguage] Test for the non-strict in_array check in parsePrimaryExpression in Parser.php
Strict in_array check in Parser.php
Updated Serbian latin validation translation
Conflicts:
src/Symfony/Component/Debug/ErrorHandler.php
* 2.3:
[Debug] ErrorHandler: remove $GLOBALS from context in PHP5.3 fix#10292
Allow File instance to be passed to BinaryFileResponse
Add upgrade instructions for the LoggerInterface
fixed CS
Removed strict check when found variables inside a translation
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Debug] less intrusive work around for https://bugs.php.net/54275
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10787, #10292
| License | MIT
| Doc PR | none
- This PR supersedes the behavior introduced in https://github.com/symfony/symfony/pull/10725 :
Instead of building some complicated code to work around https://bugs.php.net/54275, the code is now as
straightforward as possible, with a conditional fallback work around.
- The handling of fatal errors is also made more robust/fail-safe.
- Last but not least, ErrorsLoggerListener and FatalErrorExceptionsListener are now registered earlier and
are now cleaning up their handler/logger once set to prevent setting again and again for sub-requests
(+remove one refcount for these handler and logger).
Commits
-------
d7a186f [Debug] less intrusive work around for https://bugs.php.net/54275
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Allow File instance to be passed to BinaryFileResponse
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10608
| License | MIT
| Doc PR |
See https://github.com/symfony/symfony/issues/10608 for discussion and reasoning.
The docblocks get rather long with this change. The File class does extend SplFileObject so technically it could be left out of the docblock if that is more desirable.
Commits
-------
fc04ad2 Allow File instance to be passed to BinaryFileResponse
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Console] Fix#10795: Allow instancing Console Application when STDIN is not declared
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10795
| License | MIT
Commits
-------
3a5a525 [Console] Fix#10795: Allow instancing Console Application when STDIN is not declared
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#10644).
Discussion
----------
Add upgrade instructions for the LoggerInterface that changed in Symfony 2.2
Commits
-------
6daa295 Add upgrade instructions for the LoggerInterface
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10643).
Discussion
----------
[TwigBridge] Removed strict check when found variables inside a translation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no?
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10638
| License | MIT
Commits
-------
074191e Removed strict check when found variables inside a translation
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes#10605).
Discussion
----------
[ExpressionLanguage] Strict in_array check in Parser.php
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Otherwise it doesn't throw an exception for the cases when passed parameters array includes zero key (and that will result in the PHP Notice down the road).
Commits
-------
154c4a5 [ExpressionLanguage] Test for the non-strict in_array check in parsePrimaryExpression in Parser.php
e465135 Strict in_array check in Parser.php
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes#10796).
Discussion
----------
Updated Serbian latin validation translation
Commits
-------
43e65de Updated Serbian latin validation translation
* 2.4:
bumped Symfony version to 2.4.5
updated VERSION for 2.4.4
updated CHANGELOG for 2.4.4
bumped Symfony version to 2.3.14
updated VERSION for 2.3.13
update CONTRIBUTORS for 2.3.13
updated CHANGELOG for 2.3.13
Updated Serbian validation translation
[Console] Fixed the rendering of exceptions on HHVM with a terminal width
[WebProfilerBundle ] Fixed an edge case on WDT loading
[Security] removed $csrfTokenManager type hint from SimpleFormAuthenticationListener constructor argument
fixed typo
[Process] Disable TTY mode on Windows platform
[Validator] added missing ANNOTATION config to @Target annotation
[Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator.
Conflicts:
src/Symfony/Component/HttpKernel/Kernel.php
* 2.3:
bumped Symfony version to 2.3.14
updated VERSION for 2.3.13
update CONTRIBUTORS for 2.3.13
updated CHANGELOG for 2.3.13
[Console] Fixed the rendering of exceptions on HHVM with a terminal width
[WebProfilerBundle ] Fixed an edge case on WDT loading
fixed typo
[Process] Disable TTY mode on Windows platform
[Validator] added missing ANNOTATION config to @Target annotation
[Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator.
Conflicts:
src/Symfony/Component/HttpKernel/Kernel.php
src/Symfony/Component/Validator/Constraints/Callback.php
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] Fixed the rendering of exceptions on HHVM with a terminal width
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
If ``getTerminalWidth`` returns a big integer (which is the case in Behat 2.5 which overwrites the method to return ``PHP_INT_MAX`` to avoid limiting the width), the fix done in #10000 for HHVM would be needed as well. So this moves it after the condition rather than having it only for the default.
Commits
-------
6e57380 [Console] Fixed the rendering of exceptions on HHVM with a terminal width
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes#10791).
Discussion
----------
Updated Serbian validation translation
Commits
-------
c9bb6c3 Updated Serbian validation translation
This PR was squashed before being merged into the 2.3 branch (closes#10773).
Discussion
----------
[WebProfilerBundle ] Fixed an edge case on WDT loading
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6824 ?
| License | MIT
| Doc PR | none
In some case you can notice the WDT just disappears.
By tracking it down, I noticed that the XHR call returns an empty response with 200 as status code, but if you go directly on the _wdt/my_token URL it works correctly.
What's happening is that when you have a slow listener on `kernel.terminate` (for example the SwiftMailer one with a slow connection), you response (and therefore the WDT javascript) is sent and processed by the browser, the XHR call is done, but the Profiler storage didn't happened yet so no profiling data is available and the `ProfilerController` just sends an empty response with 200 as status code.
Here we change to instead send a specific status code, and treat it in javascript by retrying several times before failing.
The question are:
* Is 204 the most appropriate response code?
* Are 500 ms and 5 max retries good values?
Commits
-------
9d885ed [WebProfilerBundle ] Fixed an edge case on WDT loading
This PR was merged into the 2.5-dev branch.
Discussion
----------
[FrameworkBundle] removed support for HHVM built-in web server as it is deprecated now
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10774
| License | MIT
| Doc PR | n/a
Commits
-------
7f7e2d8 [FrameworkBundle] removed support for HHVM built-in web server as it is deprecated now
This PR was merged into the 2.4 branch.
Discussion
----------
[Security] removed $csrfTokenManager type hint from SimpleFormAuthenticationListener constructor argument
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | [#10452]
| License | MIT
| Doc PR | n/a
Commits
-------
b020207 [Security] removed $csrfTokenManager type hint from SimpleFormAuthenticationListener constructor argument
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10782).
Discussion
----------
fixed typo
[Validator] [FrameworkBundle] fixed a typo in farsi translation of length validator when input must be of exact size.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
dc3f350 fixed typo
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Disable TTY mode on Windows platform
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
7942c2a [Process] Disable TTY mode on Windows platform
Fabien Potencier
Nicolas Grekas
Andreas Lutro
Romain Neutron
Charles-Eric Gorron
Asmir Mustafic
Dmitry Parnas
umpirsky
Christophe Coevoet
Tugdual Saunier
Choong Wei Tjeng
Arash Tabriziyan