Commit Graph

42174 Commits

Author SHA1 Message Date
Robin Chalas
1768c9365c feature #31594 [Security] add PasswordEncoderInterface::needsRehash() (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[Security] add PasswordEncoderInterface::needsRehash()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Split from #31153, with tests.

Commits
-------

50590dce81 [Security] add PasswordEncoderInterface::needsRehash()
2019-06-04 05:02:33 +02:00
Nicolas Grekas
0119d217ca Merge branch '4.3' into 4.4
* 4.3:
  [Translation] Fixed case sensitivity of lint:xliff command
  fix type hint for salt in PasswordEncoderInterface
  Simplify code - catch \Throwable capture all exceptions
  Collect locale details earlier in the process in TranslationDataCollector
  fix typo in PR #31802
  update italian validator translation
  Add missing translations
  [TwigBridge] suggest Translation Component when TranslationExtension is used
2019-06-03 22:28:03 +02:00
Nicolas Grekas
0a9d724d2a Merge branch '4.2' into 4.3
* 4.2:
  [Translation] Fixed case sensitivity of lint:xliff command
  fix type hint for salt in PasswordEncoderInterface
  Simplify code - catch \Throwable capture all exceptions
  fix typo in PR #31802
  update italian validator translation
  Add missing translations
2019-06-03 22:27:40 +02:00
Nicolas Grekas
9fbfc4cf06 Merge branch '3.4' into 4.2
* 3.4:
  fix type hint for salt in PasswordEncoderInterface
  fix typo in PR #31802
  update italian validator translation
  Add missing translations
2019-06-03 22:27:17 +02:00
Nicolas Grekas
54ba63a57e bug #31786 [Translation] Fixed case sensitivity of lint:xliff command (javiereguiluz)
This PR was squashed before being merged into the 4.2 branch (closes #31786).

Discussion
----------

[Translation] Fixed case sensitivity of lint:xliff command

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | (not needed)

I was checking some errors of `lint:xliff` (https://travis-ci.org/EasyCorp/EasyAdminBundle/jobs/540053551#L657) and saw this:

```
ERROR  in src/Resources/translations/EasyAdminBundle.sr_RS.xlf
 * There is a mismatch between the language included in the file name ("EasyAdminBundle.sr_RS.xlf") and the "sr-rs" value used in the "target-language" attribute of the file.

ERROR  in src/Resources/translations/EasyAdminBundle.zh_CN.xlf
 * There is a mismatch between the language included in the file name ("EasyAdminBundle.zh_CN.xlf") and the "zh-cn" value used in the "target-language" attribute of the file.
```

This was suspicious, so I checked the XLIFF standard and it says (http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#target-language):

```
target-language:
  Unlike the other XLIFF attributes, the values are not case-sensitive.
```

So, it's valid that `zh-cn` is the target language and `zh-CN` is the file extension. This PR fixes that.

Commits
-------

ec690b2145 [Translation] Fixed case sensitivity of lint:xliff command
2019-06-03 22:10:17 +02:00
Javier Eguiluz
ec690b2145 [Translation] Fixed case sensitivity of lint:xliff command 2019-06-03 22:09:57 +02:00
Nicolas Grekas
0bf50cff96 bug #31815 [Translator] Collect locale details earlier in the process (pierredup)
This PR was merged into the 4.3 branch.

Discussion
----------

[Translator] Collect locale details earlier in the process

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31600
| License       | MIT
| Doc PR        | N/A

The [LocaleAwareListener](https://github.com/symfony/symfony/blob/4.3/src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php) class reverts the locale back to the default locale when the request has finished. But the `TranslationDataCollector` only collects the locale in `lateCollect`, which only happens when the kernel terminates. This means the locale is reverted back to the default by the time the collector runs.

The PR moves the `locale` and `fallback_locales` from `lateCollect` to `collect`, so that the information can be captured earlier, before the `LocaleAwareListener` is run.

Commits
-------

5c394eeb79 Collect locale details earlier in the process in TranslationDataCollector
2019-06-03 21:51:47 +02:00
Nicolas Grekas
dfae7e9f9d minor #31822 Simplify code - catch \Throwable capture all exceptions (lyrixx)
This PR was merged into the 4.2 branch.

Discussion
----------

Simplify code - catch \Throwable capture all exceptions

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        |

---

This is a legacy when we did support PHP 5.X

Commits
-------

648c6949fc Simplify code - catch \Throwable capture all exceptions
2019-06-03 21:45:55 +02:00
Nicolas Grekas
0797ef28ed minor #31813 fix type hint for salt in PasswordEncoderInterface (garak)
This PR was squashed before being merged into the 3.4 branch (closes #31813).

Discussion
----------

fix type hint for salt in PasswordEncoderInterface

See issue #31812

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31812
| License       | MIT
| Doc PR        | none

Pretty self-explanatory

Commits
-------

0e741f9600 fix type hint for salt in PasswordEncoderInterface
2019-06-03 21:38:32 +02:00
Massimiliano Arione
0e741f9600 fix type hint for salt in PasswordEncoderInterface 2019-06-03 21:38:25 +02:00
Nicolas Grekas
50590dce81 [Security] add PasswordEncoderInterface::needsRehash() 2019-06-03 20:14:30 +02:00
Fabien Potencier
061f622a61 feature #31821 [FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer (yceruto)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As part of https://github.com/symfony/symfony/pull/21035 and 7169f4d3e2

Commits
-------

61613d0bf0 Add missing deprecations for PHP templating layer
2019-06-03 19:16:59 +02:00
Yonel Ceruto
61613d0bf0 Add missing deprecations for PHP templating layer 2019-06-03 12:49:37 -04:00
Grégoire Pineau
693cbff647 feature #31509 [Monolog] Setup the LoggerProcessor after all other processor (lyrixx)
This PR was merged into the 4.4 branch.

Discussion
----------

[Monolog] Setup the LoggerProcessor after all other processor

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27426
| License       | MIT
| Doc PR        |

---

This is a bit strange but [`Monolog\Processor::pushProcessor()`](ebb804e432/src/Monolog/Logger.php (L224-L229))  **prepend** the processor to the stack.

Since the Compiler Pass has a low priority, the `DebugProcessor` is always
the last one to be added to the stack, so the first one in it.

Commits
-------

429307d7cf [Monolog] Setup the LoggerProcessor after all other processor
2019-06-03 17:33:39 +02:00
Grégoire Pineau
648c6949fc Simplify code - catch \Throwable capture all exceptions
This is a legacy when we did support PHP 5.X
2019-06-03 17:30:31 +02:00
Pierre du Plessis
5c394eeb79
Collect locale details earlier in the process in TranslationDataCollector 2019-06-03 16:21:58 +02:00
Fabien Potencier
1bb0aeb97f minor #31805 fix typo in PR #31802 (garak)
This PR was merged into the 3.4 branch.

Discussion
----------

fix typo in PR #31802

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

Fix typo done in PR #31802

Commits
-------

b37c1a818f fix typo in PR #31802
2019-06-03 12:07:11 +02:00
Massimiliano Arione
b37c1a818f
fix typo in PR #31802 2019-06-03 11:50:31 +02:00
Fabien Potencier
8214896edd minor #31802 update italian validator translation (garak)
This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #31802).

Discussion
----------

update italian validator translation

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

This PR just takes the italian translation for validators up to date with english one.

Commits
-------

2b95fcaa6b update italian validator translation
2019-06-03 11:16:27 +02:00
Massimiliano Arione
2b95fcaa6b update italian validator translation 2019-06-03 11:16:20 +02:00
Fabien Potencier
c8f3cef35c feature #31785 [Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand's constructor (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand's constructor

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Continuation of #31748

Commits
-------

14093386e6 [Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand constructor
2019-06-01 16:38:00 +03:00
Fabien Potencier
1583b4f46a minor #31787 Add missing Croatian translations (toniperic)
This PR was merged into the 3.4 branch.

Discussion
----------

Add missing Croatian translations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT

Commits
-------

e83886c811 Add missing translations
2019-06-01 16:36:07 +03:00
Toni Peric
e83886c811
Add missing translations 2019-06-01 15:18:31 +02:00
Robin Chalas
14093386e6 [Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand constructor 2019-06-01 15:06:38 +02:00
Robin Chalas
d7753035f8 [SecurityBundled] Forbid security-http >= 5.0 2019-06-01 14:48:35 +02:00
Robin Chalas
435a2c74ef minor #31783 [Security][Guard] Forbid security-http >= 5.0 (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[Security][Guard] Forbid security-http >= 5.0

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Unlocks #31782. To be discarded on master

Commits
-------

e2c9701e22 [Security][Guard] Forbid security-http >= 5.0
2019-06-01 14:31:14 +02:00
Robin Chalas
e2c9701e22 [Security][Guard] Forbid security-http >= 5.0 2019-06-01 14:17:19 +02:00
Fabien Potencier
d8224b87c8 bug #31761 [TwigBridge] suggest Translation Component when TranslationExtension is used (nicolas-grekas)
This PR was merged into the 4.3 branch.

Discussion
----------

[TwigBridge] suggest Translation Component when TranslationExtension is used

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31754
| License       | MIT
| Doc PR        | -

Commits
-------

d4a9e7e639 [TwigBridge] suggest Translation Component when TranslationExtension is used
2019-06-01 11:33:08 +03:00
Nicolas Grekas
d4a9e7e639 [TwigBridge] suggest Translation Component when TranslationExtension is used 2019-06-01 09:11:44 +02:00
Robin Chalas
8e5b6573ea Merge branch '4.3' into 4.4
* 4.3:
  [Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords
  [Validator] Fix TimezoneValidator default option
  [Messenger] Inject RoutableMessageBus instead of bus locator
  [DomCrawler] Fix type error with null Form::$currentUri
  [Contracts] Fixed typos
  do not enable validator auto mapping by default
  [HttpClient] remove unused argument
2019-05-31 20:55:48 +02:00
Robin Chalas
2a93351bea Merge branch '4.2' into 4.3
* 4.2:
  [DomCrawler] Fix type error with null Form::$currentUri
2019-05-31 20:55:30 +02:00
Robin Chalas
d2c3169496 minor #31768 [SecurityBundle][Workflow] Forbid security-core 5.x (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[SecurityBundle][Workflow] Forbid security-core 5.x

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Required for #31723. To be discarded on master

Commits
-------

fbdb7f68e5 [SecurityBundle][Workflow] Forbid security-core 5.x
2019-05-31 20:48:20 +02:00
Fabien Potencier
6c930029b3 bug #31748 [Messenger] Inject RoutableMessageBus instead of bus locator (chalasr)
This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Inject RoutableMessageBus instead of bus locator

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31741
| License       | MIT
| Doc PR        | n/a

Commits
-------

91817e4de0 [Messenger] Inject RoutableMessageBus instead of bus locator
2019-05-31 16:02:42 +03:00
Robin Chalas
fbdb7f68e5 [SecurityBundle][Workflow] Forbid security-core 5.x 2019-05-31 12:59:29 +02:00
Robin Chalas
1318d3bf51 bug #31763 [Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords (nicolas-grekas)
This PR was merged into the 4.3 branch.

Discussion
----------

[Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31758
| License       | MIT
| Doc PR        | -

Otherwise, the promise of the "auto" mode doesn't work.

Commits
-------

c0fc45682a [Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords
2019-05-31 11:33:06 +02:00
Nicolas Grekas
c0fc45682a [Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords 2019-05-31 11:10:50 +02:00
Nicolas Grekas
9934252f2f feature #31700 [MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event (Simperfit)
This PR was merged into the 4.4 branch.

Discussion
----------

[MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none  <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

To ease the removal of deprecated events this class has been made final as said in https://github.com/symfony/symfony/pull/31672#discussion_r288479232

Commits
-------

9646364476 [MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event
2019-05-31 11:01:15 +02:00
Amrouche Hamza
9646364476
[MonologBridge] RouteProcessor class is now final to ease the the removal of deprecated event 2019-05-31 10:47:09 +02:00
Nicolas Grekas
89f423fc35 bug #31744 [Validator] Fix TimezoneValidator default option (ro0NL)
This PR was squashed before being merged into the 4.3 branch (closes #31744).

Discussion
----------

[Validator] Fix TimezoneValidator default option

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

ee71cdbae4 [Validator] Fix TimezoneValidator default option
2019-05-31 09:43:12 +02:00
Roland Franssen
ee71cdbae4 [Validator] Fix TimezoneValidator default option 2019-05-31 09:42:02 +02:00
Nicolas Grekas
d38c19a3b4 bug #31749 [DoctrineBridge][Validator] do not enable validator auto mapping by default (xabbuh)
This PR was merged into the 4.3 branch.

Discussion
----------

[DoctrineBridge][Validator] do not enable validator auto mapping by default

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #31715, #31752
| License       | MIT
| Doc PR        |

Commits
-------

a3555fc49c do not enable validator auto mapping by default
2019-05-31 09:34:40 +02:00
Nicolas Grekas
da01afacfc bug #31757 [DomCrawler] Fix type error with null Form::$currentUri (chalasr)
This PR was merged into the 4.2 branch.

Discussion
----------

[DomCrawler] Fix type error with null Form::$currentUri

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31644
| License       | MIT
| Doc PR        | n/a

Commits
-------

e48d5d07e3 [DomCrawler] Fix type error with null Form::$currentUri
2019-05-31 09:33:33 +02:00
Robin Chalas
91817e4de0 [Messenger] Inject RoutableMessageBus instead of bus locator 2019-05-31 02:51:53 +02:00
Robin Chalas
e48d5d07e3 [DomCrawler] Fix type error with null Form::$currentUri 2019-05-31 01:40:59 +02:00
Robin Chalas
0b6a9f9058 minor #31755 [Contracts] Fixed typos (samnela)
This PR was merged into the 4.3 branch.

Discussion
----------

[Contracts] Fixed typos

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

0bb8ba4ea4 [Contracts] Fixed typos
2019-05-31 01:00:21 +02:00
SAMUEL NELA
0bb8ba4ea4
[Contracts] Fixed typos 2019-05-31 00:41:44 +02:00
Robin Chalas
8fc75e30a6 minor #31753 [Security][Http] Forbid security-core 5.x (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[Security][Http] Forbid security-core 5.x

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Required for #31725

Commits
-------

7481db6570 [Security][Http] Forbid security-core 5.x
2019-05-30 23:52:10 +02:00
Robin Chalas
7481db6570 [Security][Http] Forbid security-core 5.x 2019-05-30 23:24:03 +02:00
Christian Flothmann
a3555fc49c do not enable validator auto mapping by default 2019-05-30 21:25:18 +02:00
Nicolas Grekas
9c76aae7dd minor #31742 [HttpClient] remove unused argument (nicolas-grekas)
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] remove unused argument

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

da85b48c32 [HttpClient] remove unused argument
2019-05-30 18:42:29 +02:00